Re: [FFmpeg-devel] [PATCH] Issue#6001:Fix for incorrect refs frame count in ffprobe

2019-07-18 Thread Hendrik Leppkes
On Thu, Jul 18, 2019 at 5:33 AM Mukund Manikarnike wrote: > > Hi, > > Please find the patch for issue#6001 attached. The patch is not correct. As you may have noticed, ff_h264_decode_seq_parameter_set does not set *any* parameters in avctx, that is because decoding a SPS and actually activating a

Re: [FFmpeg-devel] [PATCH] matroskadec: Add sizes to forward declarations

2019-07-18 Thread Hendrik Leppkes
On Wed, Jul 17, 2019 at 5:35 AM Andreas Rheinhardt wrote: > > Unknown-length elements end when an element not allowed in them, but > allowed at a higher level is encountered. In order to check for this, > c1abd95a added a pointer to every syntax level's parent to each > EbmlSyntax. Given that the

Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG

2019-07-18 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > Sent: Tuesday, July 16, 2019 5:00 PM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG >

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-18 Thread Fu, Linjie
> -Original Message- > From: Eoff, Ullysses A > Sent: Wednesday, July 17, 2019 21:48 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs > for autoscale/autorotate > > > -Origin

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-18 Thread Fu, Linjie
> -Original Message- > From: Nicolas George [mailto:geo...@nsup.org] > Sent: Thursday, July 18, 2019 03:07 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs > for autoscale/autorot

Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG

2019-07-18 Thread Jean-Baptiste Kempf
On Tue, Jul 16, 2019, at 11:00, Michael Niedermayer wrote: > One alternative is to use github or to ask jb about creating one on > videolan It is trivial to create one either on the git.videolan.org or, better, to use the gitlab code.videolan.org/ffmpeg/ group, where you can create repos without

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-18 Thread Nicolas George
Fu, Linjie (12019-07-18): > Yes, will update as Artie had suggested if no more comments: > > When autoscale is disabled, all output frames might not be in the > same resolution and may require some additional explicit processing > according to your final rendering/output destination. That is not

Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG

2019-07-18 Thread Nicolas George
Guo, Yejun (12019-07-18): > I personally prefer github to host the repo, the repo name might be > ffmpeg_dnn_material or ffmpeg_dnn_data, or something others. I'm open > to the name, just up to you. > > My plan is to first ask authors of filter vf_sr and vf_derain to move > their dnn material to t

Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG

2019-07-18 Thread Jean-Baptiste Kempf
On Thu, Jul 18, 2019, at 11:05, Nicolas George wrote: > Guo, Yejun (12019-07-18): > > I personally prefer github to host the repo, the repo name might be > > ffmpeg_dnn_material or ffmpeg_dnn_data, or something others. I'm open > > to the name, just up to you. > > > > My plan is to first ask autho

[FFmpeg-devel] [PATCH] lavc/phtread_frame: update hwaccel_priv_data in time for multithread

2019-07-18 Thread Linjie Fu
When resolution/format changes, hwaccel_uninit/hwaccel_init will be called to destroy and re-create the hwaccel_priv_data. When output frame number meets the constraints for vframes, the hwaccel_priv_data modified in decoding thread won't be update to user-thread due to the delay mechanism. It will

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/fitsdec: Prevent division by 0 with huge data_max

2019-07-18 Thread Michael Niedermayer
On Thu, Jul 18, 2019 at 08:21:21AM +0200, Reimar Döffinger wrote: > > > On 16.07.2019, at 20:31, Michael Niedermayer wrote: > > > On Tue, Jul 16, 2019 at 08:34:14AM +0200, Reimar Döffinger wrote: > >> On 16.07.2019, at 00:50, Michael Niedermayer > >> wrote: > >> > >>> Fixes: division by 0 >

Re: [FFmpeg-devel] FFmpeg classification

2019-07-18 Thread Thomas Volkert
On 17.07.2019 03:10, Maaya Murakami (JP) wrote: > Hello > > Hope all is well. > Currently I am researching about the trends of FFmpeg and its supporting > codecs, ... It seems that you are not the only one. During the last 24 hours I have received 3 requests regarding only this topic, all coming f

Re: [FFmpeg-devel] [PATCH] Issue#6001:Fix for incorrect refs frame count in ffprobe

2019-07-18 Thread Mukund Manikarnike
Hi Hendrik, Thank you for pointing that out. I'll look into that piece of code. It does appear to be getting set. However, it doesn't reflect in what ffprobe shows in it's output. Regards, Mukund Manikarnike On Thu, Jul 18, 2019 at 12:16 AM Hendrik Leppkes wrote: > On Thu, Jul 18, 2019 at 5:3

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-18 Thread Eoff, Ullysses A
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Nicolas George > Sent: Thursday, July 18, 2019 2:01 AM > To: FFmpeg development discussions and patches > Subject: Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for > autos

Re: [FFmpeg-devel] [PATCH] avformat/ifv: Check for EOF in read_index()

2019-07-18 Thread Peter Ross
On Thu, Jul 18, 2019 at 01:42:23AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 15567/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5758451487080448 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by:

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-18 Thread Eoff, Ullysses A
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Michael Niedermayer > On Mon, Jul 15, 2019 at 06:38:35PM +0800, Linjie Fu wrote: > > +{ "autoscale",HAS_ARG | OPT_BOOL | OPT_SPEC | > > + OPT_EXPERT | OPT_INPUT,

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-18 Thread Moritz Barsnick
On Wed, Jul 17, 2019 at 16:18:11 -0700, Juan De León wrote: > --- > libavfilter/vf_extractqp.c | 116 > libavutil/Makefile | 2 + > libavutil/quantization_params.c | 28 > libavutil/quantization_params.h | 98 +

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-18 Thread Lynne
Jul 18, 2019, 12:25 AM by juandl-at-google@ffmpeg.org : > For context > https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing > >

[FFmpeg-devel] [PATCH] avformat/mxfenc: fix index byte count in partition header

2019-07-18 Thread Baptiste Coudurier
--- libavformat/mxfenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index b677f6af8e..2e54320cf0 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -1944,8 +1944,7 @@ static int mxf_write_partition(AVFormatContext

[FFmpeg-devel] [PATCH] matroskadec: Remove redundant const

2019-07-18 Thread Andreas Rheinhardt
The typedef used to define EbmlSyntax already includes a const qualifier so that it is unnecessary to include another const qualifier in future definitions and declarations. Given that MSVC warns about this, this commit removes these redundant const qualifiers. Suggested-by: Hendrik Leppkes Signe

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-18 Thread Ulf Zibis
Am 17.07.19 um 10:12 schrieb Hendrik Leppkes: > ..., the macro was defined the way it is, and changing it now has a > chance of breaking > random places that rely on the current behavior. OK, that would be risky. Maybe we could add another macro FFSGN. Then maintainers of individual code parts c

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-18 Thread Nicolas George
Ulf Zibis (12019-07-18): > Maybe we could add another macro FFSGN. Then maintainers of individual > code parts could check the usage over the time. Or maybe write robust code that does not need that kind of hair splitting. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] avformat/ifv: Check for EOF in read_index()

2019-07-18 Thread Michael Niedermayer
On Fri, Jul 19, 2019 at 12:32:06AM +1000, Peter Ross wrote: > On Thu, Jul 18, 2019 at 01:42:23AM +0200, Michael Niedermayer wrote: > > Fixes: Timeout > > Fixes: > > 15567/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5758451487080448 > > > > Found-by: continuous fuzzing process > > https:

Re: [FFmpeg-devel] [PATCH] libavformat/subfile: Fix SEEK_CUR and SEEK_END seeking

2019-07-18 Thread Michael Niedermayer
On Wed, Jul 17, 2019 at 07:45:00PM +, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Mon, Jul 15, 2019 at 07:48:35PM +0200, Andreas Rheinhardt wrote: > >> Up until now, when performing a SEEK_END seek, the subfile protocol > >> ignored the desired position (relative to EOF) and used th

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: add -autoscale to disable/enable the default scale

2019-07-18 Thread Michael Niedermayer
On Thu, Jul 18, 2019 at 02:44:46PM +, Eoff, Ullysses A wrote: > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > > Michael Niedermayer > > On Mon, Jul 15, 2019 at 06:38:35PM +0800, Linjie Fu wrote: > > > +{ "autoscale",HAS_ARG | OPT_BOOL | OPT_SPEC | > >

Re: [FFmpeg-devel] [PATCH] matroskadec: Remove redundant const

2019-07-18 Thread Carl Eugen Hoyos
Am Do., 18. Juli 2019 um 21:15 Uhr schrieb Andreas Rheinhardt : > The typedef used to define EbmlSyntax already includes a const qualifier > so that it is unnecessary to include another const qualifier in future > definitions and declarations. Given that MSVC warns about this, this > commit remove

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/fitsdec: Prevent division by 0 with huge data_max

2019-07-18 Thread Reimar Döffinger
On 18.07.2019, at 12:54, Michael Niedermayer wrote: > On Thu, Jul 18, 2019 at 08:21:21AM +0200, Reimar Döffinger wrote: >> >> >> On 16.07.2019, at 20:31, Michael Niedermayer wrote: >> >>> On Tue, Jul 16, 2019 at 08:34:14AM +0200, Reimar Döffinger wrote: On 16.07.2019, at 00:50, Michael N

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-18 Thread Hendrik Leppkes
On Thu, Jul 18, 2019 at 9:17 PM Ulf Zibis wrote: > > > Am 17.07.19 um 10:12 schrieb Hendrik Leppkes: > > ..., the macro was defined the way it is, and changing it now has a > > chance of breaking > > random places that rely on the current behavior. > > OK, that would be risky. > > Maybe we could a

[FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-18 Thread Juan De León
Thanks for the feedback, appreciate it. I added the AV_FRAME_DATA_QUANTIZATION_PARAMS type to AVFrameSideData and I removed the filter since it is not complete yet. I will send the filter and the modification to the encoders when those are done. --- libavutil/Makefile | 2 + libav

Re: [FFmpeg-devel] [PATCH] avcodec/tak_parser: don't return error values

2019-07-18 Thread Michael Niedermayer
On Wed, Jul 17, 2019 at 07:38:50PM -0300, James Almer wrote: > The API does not allow it. > > Also set poutbuf and poutbuf_size to NULL/0 on error to avoid leaving > them uninitialized. > > Signed-off-by: James Almer > --- > libavcodec/tak_parser.c | 16 ++-- > 1 file changed, 10 in

[FFmpeg-devel] [PATCH v2] avcodec/tak_parser: don't return error values

2019-07-18 Thread James Almer
The API does not allow it. Also set poutbuf and poutbuf_size to NULL/0 on error to avoid leaving them uninitialized. Signed-off-by: James Almer --- libavcodec/tak_parser.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/libavcodec/tak_parser.c b/libavco

[FFmpeg-devel] [PATCH] fftools/ffprobe: process show_frame/show_packets last

2019-07-18 Thread Aman Gupta
From: Aman Gupta When using `ffprobe -show_format -show_streams -show_packets`, it makes more sense to omit static data about the file format and streams before the long list of packets instead of at the end. Signed-off-by: Aman Gupta --- fftools/ffprobe.c | 38

Re: [FFmpeg-devel] dash: add descriptor which is useful to the scheme defined by ISO/IEC 23009-1:2014/Amd.2:2015.

2019-07-18 Thread Jeyapal, Karthick
On 7/19/19 8:38 AM, leozhang wrote: > change history: > 1. Use normal descriptor string instead of base64 encoded > 2. Add example to muxers.texi > 3. Change descriptor char * and allocate it dynamically > > Please review, thanks Thanks for sending the revised patch. LGTM. I will wait for 3 days a