Hi Hendrik, Thank you for pointing that out. I'll look into that piece of code. It does appear to be getting set. However, it doesn't reflect in what ffprobe shows in it's output.
Regards, Mukund Manikarnike On Thu, Jul 18, 2019 at 12:16 AM Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Thu, Jul 18, 2019 at 5:33 AM Mukund Manikarnike <muk...@gmail.com> > wrote: > > > > Hi, > > > > Please find the patch for issue#6001 attached. > > The patch is not correct. As you may have noticed, > ff_h264_decode_seq_parameter_set does not set *any* parameters in > avctx, that is because decoding a SPS and actually activating and > using the SPS are seperate actions. As such, this is the wrong spot to > do this. > The SPS values should be set in the avctx in the place where the SPS > is activated for decoding image data, not when the SPS itself is being > decoded. > > This would probably be something like h264_init_ps, which does appear > to already set avctx->refs. > > - Hendrik > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
