Re: [FFmpeg-devel] [PATCH] avformat/segment: populate empty outer stream extradata from packet

2019-05-28 Thread Gyan
On 27-05-2019 10:06 AM, Gyan wrote: On 25-05-2019 07:22 PM, Gyan wrote: On 23-05-2019 06:40 PM, Gyan wrote: On 21-05-2019 06:59 PM, Gyan wrote: Fixes playback in QT for me. Gyan Ping. Pong. Plan to push tomorrow. Pushed as eae251ead9e380c722dce7ac3f4e97017bff9a7b Gyan __

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: Fix VP9 dynamic resolution changing decoding on VAAPI.

2019-05-28 Thread Hendrik Leppkes
On Tue, May 28, 2019 at 8:57 AM Yan Wang wrote: > > When the format change, the VAAPI context cannot be destroyed. > Otherwise, the reference frame surface will lost. > > Signed-off-by: Yan Wang > --- > libavcodec/decode.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: Fix VP9 dynamic resolution changing decoding on VAAPI.

2019-05-28 Thread Yan Wang
On 5/28/2019 3:16 PM, Hendrik Leppkes wrote: On Tue, May 28, 2019 at 8:57 AM Yan Wang wrote: When the format change, the VAAPI context cannot be destroyed. Otherwise, the reference frame surface will lost. Signed-off-by: Yan Wang --- libavcodec/decode.c | 6 ++ 1 file changed, 6 inser

Re: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: disable ICQ mode when enabling low power

2019-05-28 Thread Fu, Linjie
> -Original Message- > From: Li, Zhong > Sent: Wednesday, May 22, 2019 09:49 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: Fu, Linjie > Subject: RE: [FFmpeg-devel] [PATCH] lavc/vaapi_encode: disable ICQ mode > when enabling low power > > > From: ffmpeg-devel [m

[FFmpeg-devel] [PATCH 2/2] doc/filters: update how to generate native model for sr filter

2019-05-28 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- doc/filters.texi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 4fdcfe9..75d2a38 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -16538,9 +16538,10 @@ Efficient Sub-Pixel Convolutional Neural

[FFmpeg-devel] [PATCH 1/2] libavfilter/dnn: add script to convert TensorFlow model (.pb) to native model (.model)

2019-05-28 Thread Guo, Yejun
For example, given TensorFlow model file espcn.pb, to generate native model file espcn.model, just run: python convert.py espcn.pb In current implementation, the native model file is generated for specific dnn network with hard-code python scripts maintained out of ffmpeg. For example, srcnn netwo

Re: [FFmpeg-devel] [PATCH 2/2] doc/filters: update how to generate native model for sr filter

2019-05-28 Thread Gyan
On 28-05-2019 01:31 PM, Guo, Yejun wrote: Signed-off-by: Guo, Yejun --- doc/filters.texi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 4fdcfe9..75d2a38 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -16538,9 +1653

Re: [FFmpeg-devel] [PATCH 2/2] doc/filters: update how to generate native model for sr filter

2019-05-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Gyan > Sent: Tuesday, May 28, 2019 4:14 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH 2/2] doc/filters: update how to generate > native model for sr filter > > > >

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: Fix VP9 dynamic resolution changing decoding on VAAPI.

2019-05-28 Thread Hendrik Leppkes
On Tue, May 28, 2019 at 9:46 AM Yan Wang wrote: > > > On 5/28/2019 3:16 PM, Hendrik Leppkes wrote: > > On Tue, May 28, 2019 at 8:57 AM Yan Wang wrote: > >> When the format change, the VAAPI context cannot be destroyed. > >> Otherwise, the reference frame surface will lost. > >> > >> Signed-off-by

Re: [FFmpeg-devel] [PATCH] libavcodec/vp9: Fix VP9 dynamic resolution changing decoding on VAAPI.

2019-05-28 Thread Yan Wang
On 5/28/2019 4:43 PM, Hendrik Leppkes wrote: On Tue, May 28, 2019 at 9:46 AM Yan Wang wrote: On 5/28/2019 3:16 PM, Hendrik Leppkes wrote: On Tue, May 28, 2019 at 8:57 AM Yan Wang wrote: When the format change, the VAAPI context cannot be destroyed. Otherwise, the reference frame surface wi

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/dnn: add script to convert TensorFlow model (.pb) to native model (.model)

2019-05-28 Thread Liu Steven
> 在 2019年5月28日,下午4:01,Guo, Yejun 写道: > > For example, given TensorFlow model file espcn.pb, > to generate native model file espcn.model, just run: > python convert.py espcn.pb > > In current implementation, the native model file is generated for > specific dnn network with hard-code python scr

[FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-28 Thread Andreas Håkon
Hi, This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) A new (simpler and more robust) implementationof of the reinsertion of the missing headers in the MPEG-2 bitstream from the HW QSV encoder. The problem is quite simple: The bitstream generated by the MPEG-2 QSV encoder

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

2019-05-28 Thread Andreas Håkon
Hi Andreas (Rheinhardt) and Reimar, Thank you for your comments. You're right and the code needs refactoring. I prepared a new implementation, please review it: https://patchwork.ffmpeg.org/patch/13316/ In any case, please note that the software encoder "mpeg2video" every time writes the SEQ_STAR

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Håkon
Hi, ‐‐‐ Original Message ‐‐‐ On Wednesday, 22 de May de 2019 17:04, Andreas Håkon wrote: > Patch to generate aligned Teletext PES packets using the MPEG-TS muxer > when the TS header contains data. Can someone please tell me who is the official maintainer of the MPEG-TS muxer? I'm stil

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Rheinhardt
Andreas Håkon: > Hi, > > ‐‐‐ Original Message ‐‐‐ > On Wednesday, 22 de May de 2019 17:04, Andreas Håkon > wrote: > >> Patch to generate aligned Teletext PES packets using the MPEG-TS muxer >> when the TS header contains data. > > Can someone please tell me who is the official maintain

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/dnn: add script to convert TensorFlow model (.pb) to native model (.model)

2019-05-28 Thread Guo, Yejun
> -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > Liu Steven > Sent: Tuesday, May 28, 2019 6:00 PM > To: FFmpeg development discussions and patches > Cc: Liu Steven ; Guo, Yejun > Subject: Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/dnn: ad

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Håkon
Hi A. Rheinhardt, ‐‐‐ Original Message ‐‐‐ On Tuesday, 28 de May de 2019 13:24, Andreas Rheinhardt wrote: > > Can someone please tell me who is the official maintainer of the MPEG-TS > > muxer? > > I'm still waiting for comments regarding this patch. > > We've been using it for a long

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Rheinhardt
Andreas Håkon: > Hi A. Rheinhardt, > > > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 28 de May de 2019 13:24, Andreas Rheinhardt > wrote: > >>> Can someone please tell me who is the official maintainer of the MPEG-TS >>> muxer? >>> I'm still waiting for comments regarding this patch. >>> W

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/vf_transpose: add exif orientation support

2019-05-28 Thread Paul B Mahol
On 5/28/19, Jun Li wrote: > Add exif orientation support and expose an option. > --- > libavfilter/hflip.h| 3 + > libavfilter/vf_hflip.c | 43 ++--- > libavfilter/vf_transpose.c | 173 + > 3 files changed, 171 insertions(+), 48 deletions(-)

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-28 Thread Paul B Mahol
On 5/28/19, Jun Li wrote: > Fix #6945 > Rotate or/and flip frame according to frame's metadata orientation > --- > fftools/ffmpeg.c| 16 +++- > fftools/ffmpeg.h| 3 ++- > fftools/ffmpeg_filter.c | 28 +++- > 3 files changed, 40 insertions(+), 7

Re: [FFmpeg-devel] [PATCH 1/2] avfilter: add audio soft clip filter

2019-05-28 Thread Werner Robitza
On Fri, Apr 19, 2019 at 3:21 PM Paul B Mahol wrote: > +@item param > +Set additional parameter which controls sigmoid function. Could you perhaps add some more info about the range of possible values and their meaning? Thanks, Werner ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Michael Niedermayer
On Tue, May 28, 2019 at 12:08:55PM +, Andreas Håkon wrote: > Hi A. Rheinhardt, > > > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 28 de May de 2019 13:24, Andreas Rheinhardt > wrote: > > > > Can someone please tell me who is the official maintainer of the MPEG-TS > > > muxer? > > > I'm

[FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread Derek Buitenhuis
Uses the crav1e C bindings for rav1e. Missing version bump and changelog entry. Signed-off-by: Derek Buitenhuis --- Hoping to get some eyes on this, and maybe help some people who want to test out rav1e without having to use Y4Ms or pipes. Some points: * The C bindings for rav1e currently l

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Håkon
Hi Michael, > with which software has the generated mpeg-ts been tested ? > do you have any testecases ? Our test cases are mainly DVB-C broadcasts and mobile streaming. All clients play well. And internal testing is done using the well-known DVB Inspector. Regards. A.H. --- __

[FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-05-28 Thread velocityra
From: Nick Renieris In DNG images with the .tiff extension, it solves the issue where the TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). Embedded thumbnails for DNG images can still be decoded with the added "-dng_thumb" option. Additionally: - Renamed TIFF_WHITE_LEVEL

[FFmpeg-devel] Is this a regression or not?

2019-05-28 Thread Nomis101 🐝
I regularly build HandBrake against the latest FFmpeg master to check if all works as expected or something is broken and I need to open a bug. With the latest master I found some issues, but I'm unsure if this is a regression or not. After commit f9271d0158122c9e043b7d83f691884b65ec1ba5 HB doesn

Re: [FFmpeg-devel] Is this a regression or not?

2019-05-28 Thread Marton Balint
On Tue, 28 May 2019, Nomis101 🐝 wrote: I regularly build HandBrake against the latest FFmpeg master to check if all works as expected or something is broken and I need to open a bug. With the latest master I found some issues, but I'm unsure if this is a regression or not. After commit f9271

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread James Almer
On 5/28/2019 2:29 PM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Missing version bump and changelog entry. > > Signed-off-by: Derek Buitenhuis > --- > Hoping to get some eyes on this, and maybe help some people who want to > test out rav1e without having to use Y4Ms or p

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread Derek Buitenhuis
On 28/05/2019 20:32, James Almer wrote: >> +default: >> +// This should be impossible >> +return (RaChromaSampling) -1; > > If it's not meant to happen, then it should probably be an av_assert0. Yeah, that makes more sense. Will change. >> +int rret; >> +int ret = 0;

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread James Almer
On 5/28/2019 4:49 PM, Derek Buitenhuis wrote: > On 28/05/2019 20:32, James Almer wrote: >>> +default: >>> +// This should be impossible >>> +return (RaChromaSampling) -1; >> >> If it's not meant to happen, then it should probably be an av_assert0. > > Yeah, that makes more sens

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread Derek Buitenhuis
On 28/05/2019 20:49, Derek Buitenhuis wrote: >>> +static const AVOption options[] = { >>> +{ "quantizer", "use constant quantizer mode", OFFSET(quantizer), >>> AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 255, VE }, >>> +{ "max-quantizer", "max quantizer when using bitrate mode", >>> OFFSET(max_qu

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread Derek Buitenhuis
On 28/05/2019 20:58, James Almer wrote: > I think x26* and vpx/aom call it crf? It's not in option_tables.h in any > case. They do not. This is a constant quantizer mode, not constant rate factor. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpe

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Add support for recognizing DNG files

2019-05-28 Thread Paul B Mahol
On 5/28/19, velocit...@gmail.com wrote: > From: Nick Renieris > > In DNG images with the .tiff extension, it solves the issue where the > TIFF thumbnail in IFD 0 was incorrectly parsed (related confusion: [1]). > Embedded thumbnails for DNG images can still be decoded with the added > "-dng_thumb

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-28 Thread Michael Niedermayer
On Mon, May 27, 2019 at 11:18:26PM -0700, Jun Li wrote: > Fix #6945 > Rotate or/and flip frame according to frame's metadata orientation > --- > fftools/ffmpeg.c| 16 +++- > fftools/ffmpeg.h| 3 ++- > fftools/ffmpeg_filter.c | 28 +++- > 3 files

Re: [FFmpeg-devel] [PATCH 06/11] cbs, cbs_mpeg2, cbs_jpeg: Don't av_freep local variables

2019-05-28 Thread Mark Thompson
On 22/05/2019 02:04, Andreas Rheinhardt wrote: > There is no danger of leaving dangling pointers behind, as the lifespan > of local variables (including pointers passed (by value) as function > arguments) ends anyway as soon as we exit their scope. > > Signed-off-by: Andreas Rheinhardt > --- > l

Re: [FFmpeg-devel] [PATCH 03/11] mpeg2_metadata, cbs_mpeg2: Fix handling of colour_description

2019-05-28 Thread Mark Thompson
On 22/05/2019 02:04, Andreas Rheinhardt wrote: > If a sequence display extension is read with colour_description equal to > zero, but a user wants to add one or more of the colour_description > elements, then the colour_description elements the user did not explicitly > request to be set are set to

Re: [FFmpeg-devel] [PATCH 07/11] cbs: Remove useless initializations

2019-05-28 Thread Mark Thompson
On 22/05/2019 02:04, Andreas Rheinhardt wrote: > Up until now, a temporary variable was used and initialized every time a > value was read in CBS; if reading turned out to be successfull, this > value was overwritten (without having ever been looked at) with the > value read if reading was successf

Re: [FFmpeg-devel] [PATCH 10/11] cbs_mpeg2: Fix parsing of picture headers

2019-05-28 Thread Mark Thompson
On 22/05/2019 02:04, Andreas Rheinhardt wrote: > MPEG-2 picture and slice headers can contain optional extra information; > both use the same syntax for their extra information. And cbs_mpeg2's > implementations of both were buggy until recently; the one for the > picture headers still is and this

Re: [FFmpeg-devel] [PATCH 00/11 v3] cbs (mostly MPEG-2) patches

2019-05-28 Thread Mark Thompson
On 22/05/2019 02:04, Andreas Rheinhardt wrote: > > Andreas Rheinhardt (10): > cbs_mpeg2: Correct and use enum values > cbs_mpeg2: Improve checks for invalid values > cbs_mpeg2: Fix storage type for frame_centre_*_offset > cbs_mpeg2: Correct error codes > > James Almer (1): > avcodec/cbs

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread James Darnley
On 2019-05-28 22:00, Derek Buitenhuis wrote: > On 28/05/2019 20:58, James Almer wrote: >> I think x26* and vpx/aom call it crf? It's not in option_tables.h in any >> case. > > They do not. This is a constant quantizer mode, not constant rate factor. IIRC either qp or cqp signature.asc Descrip

Re: [FFmpeg-devel] [PATCH 03/11] mpeg2_metadata, cbs_mpeg2: Fix handling of colour_description

2019-05-28 Thread Andreas Rheinhardt
Mark Thompson: > On 22/05/2019 02:04, Andreas Rheinhardt wrote: >> If a sequence display extension is read with colour_description equal to >> zero, but a user wants to add one or more of the colour_description >> elements, then the colour_description elements the user did not explicitly >> request

[FFmpeg-devel] [PATCH v4 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-28 Thread Jun Li
Fix #6945 Rotate or/and flip frame according to frame's metadata orientation --- fftools/ffmpeg.c| 16 +++- fftools/ffmpeg.h| 3 ++- fftools/ffmpeg_filter.c | 28 +++- 3 files changed, 40 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpe

Re: [FFmpeg-devel] [PATCH 10/11] cbs_mpeg2: Fix parsing of picture headers

2019-05-28 Thread Andreas Rheinhardt
Mark Thompson: > On 22/05/2019 02:04, Andreas Rheinhardt wrote: >> MPEG-2 picture and slice headers can contain optional extra information; >> both use the same syntax for their extra information. And cbs_mpeg2's >> implementations of both were buggy until recently; the one for the >> picture heade

[FFmpeg-devel] [PATCH v4 1/2] lavf/vf_transpose: add exif orientation support

2019-05-28 Thread Jun Li
Add exif orientation support and expose an option. --- libavfilter/hflip.h| 2 + libavfilter/transpose.h| 14 libavfilter/vf_hflip.c | 41 ++--- libavfilter/vf_transpose.c | 166 - 4 files changed, 189 insertions(+), 34 deletions(-)

[FFmpeg-devel] [PATCH v5 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-28 Thread Jun Li
Fix #6945 Rotate or/and flip frame according to frame's metadata orientation --- fftools/ffmpeg.c| 16 +++- fftools/ffmpeg.h| 3 ++- fftools/ffmpeg_filter.c | 28 +++- 3 files changed, 40 insertions(+), 7 deletions(-) diff --git a/fftools/ffmpe

[FFmpeg-devel] [PATCH v5 1/2] lavf/vf_transpose: add exif orientation support

2019-05-28 Thread Jun Li
Add exif orientation support and expose an option. --- libavfilter/hflip.h| 2 + libavfilter/transpose.h| 14 libavfilter/vf_hflip.c | 41 ++--- libavfilter/vf_transpose.c | 166 - 4 files changed, 189 insertions(+), 34 deletions(-)

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/vf_transpose: add exif orientation support

2019-05-28 Thread Jun Li
On Tue, May 28, 2019 at 7:21 AM Paul B Mahol wrote: > On 5/28/19, Jun Li wrote: > > Add exif orientation support and expose an option. > > --- > > libavfilter/hflip.h| 3 + > > libavfilter/vf_hflip.c | 43 ++--- > > libavfilter/vf_transpose.c | 173 +++

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-28 Thread Jun Li
On Tue, May 28, 2019 at 1:50 PM Michael Niedermayer wrote: > On Mon, May 27, 2019 at 11:18:26PM -0700, Jun Li wrote: > > Fix #6945 > > Rotate or/and flip frame according to frame's metadata orientation > > --- > > fftools/ffmpeg.c| 16 +++- > > fftools/ffmpeg.h| 3 ++