[FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-22 Thread Charles Liu
1. organize fragmented information according to the tracks. 2. do NOT skip the last boxes of fragmented info. ticket #7572 Signed-off-by: Charles Liu --- libavformat/isom.h | 10 +- libavformat/mov.c | 374 + 2 files changed, 181 insertions(+), 203

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-22 Thread C.H.Liu
I have updated a new patch that has passed valgrind as follows: *$ ./configure --samples=fate-suite/ --disable-doc --fatal-warnings --valgrind=VALGRIND* *$ make -j4 && make fate-mov* But I never encountered a ‘stream 0, timescale not set’ log in here. Please let me know if you have any questions. S

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Gyan
On 22-02-2019 06:12 AM, Lou Logan wrote: For consistency. Fixes #7740. Signed-off-by: Lou Logan --- Does this need to be checked for errant added hypens, like before entries in a value table? If not, LGTM. Gyan ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Nicolas George
Lou Logan (12019-02-21): > For consistency. Fixes #7740. > > Signed-off-by: Lou Logan I do not think this is correct: the dash is not part of the option name, it is part of the Unix command-line tradition. For consistency, it should be removed when it is there, possibly replaced by the word "opt

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Hendrik Leppkes
On Fri, Feb 22, 2019 at 12:29 PM Nicolas George wrote: > > Lou Logan (12019-02-21): > > For consistency. Fixes #7740. > > > > Signed-off-by: Lou Logan > > I do not think this is correct: the dash is not part of the option name, > it is part of the Unix command-line tradition. For consistency, it

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Tomas Härdin
tor 2019-02-21 klockan 15:26 +0100 skrev Carl Eugen Hoyos: > > 2019-02-21 11:26 GMT+01:00, Tomas Härdin : > > ons 2019-02-20 klockan 23:33 +0100 skrev Carl Eugen Hoyos: > > > > > > > > 2019-02-10 16:42 GMT+01:00, Tomas Härdin : > > > > lör 2019-02-09 klockan 13:10 + skrev Matthew Fearnley: > >

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Tomas Härdin
fre 2019-02-22 klockan 00:11 +0100 skrev Michael Niedermayer: > On Thu, Feb 21, 2019 at 09:26:44PM +, Matthew Fearnley wrote: > > - To clear up the effects: the change from 'i=1' to 'i=0' was the only > > change that should make any difference in the output. > > The rest of the changes were to

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/zmbv: obtain frame later

2019-02-22 Thread Tomas Härdin
tor 2019-02-21 klockan 20:34 +0100 skrev Michael Niedermayer: > The frame is not needed that early so obtaining it later avoids > the costly operation in case other checks fail. > > Fixes: Timeout (14sec -> 4sec) > Fixes: > 13140/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ZMBV_fuzzer-57383

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: initialize sub2video.end_pts together with last_pts

2019-02-22 Thread Michael Niedermayer
On Thu, Feb 21, 2019 at 01:16:00PM +0200, Jan Ekström wrote: > This fixes buffering of samples which causes sudden ballooning of > memory usage in case of no subtitle samples coming in for a while if > the filter chain had been re-initialized. > > You can also see messages a la: > "Error while add

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Tobias Rapp
On 22.02.2019 12:43, Hendrik Leppkes wrote: On Fri, Feb 22, 2019 at 12:29 PM Nicolas George wrote: Lou Logan (12019-02-21): For consistency. Fixes #7740. Signed-off-by: Lou Logan I do not think this is correct: the dash is not part of the option name, it is part of the Unix command-line t

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Nicolas George
Tobias Rapp (12019-02-22): > In my understanding the main source of documentation for API users are the > Doxygen HTML output files while the Texinfo output is for both, command-line > and API users -- with a slight bias towards command-line, at least from > looking at all the ffmpeg/ffplay example

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Gyan
On 22-02-2019 06:50 PM, Nicolas George wrote: Tobias Rapp (12019-02-22): In my understanding the main source of documentation for API users are the Doxygen HTML output files while the Texinfo output is for both, command-line and API users -- with a slight bias towards command-line, at least fr

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Nicolas George
Gyan (12019-02-22): >     '-key'  will be easier to search for these users as well. It's also a > low-cost arrangement. I trust adept API users will quickly suss out that the > hyphen represents CLI. GUI users won't be entering the key string, only the > values*, and casual CLI users will immediate

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Tobias Rapp
On 22.02.2019 14:57, Nicolas George wrote: Gyan (12019-02-22):     '-key'  will be easier to search for these users as well. It's also a low-cost arrangement. I trust adept API users will quickly suss out that the hyphen represents CLI. GUI users won't be entering the key string, only the value

Re: [FFmpeg-devel] [PATCH] http: Do not try to make a new request when seeking past the end of the file

2019-02-22 Thread Vittorio Giovara
On Wed, Feb 20, 2019 at 9:54 AM Vittorio Giovara wrote: > From: Justin Ruggles > > This avoids making invalid HTTP Range requests for a byte range past the > known end of the file during a seek. Those requests generally return a HTTP > response of 416 Range Not Satisfiable, which causes an error

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Tomas Härdin
fre 2019-02-22 klockan 13:09 +0100 skrev Tomas Härdin: > fre 2019-02-22 klockan 00:11 +0100 skrev Michael Niedermayer: > > On Thu, Feb 21, 2019 at 09:26:44PM +, Matthew Fearnley wrote: > > > - To clear up the effects: the change from 'i=1' to 'i=0' was the only > > > change that should make any

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Lou Logan
On Fri, Feb 22, 2019, at 2:29 AM, Nicolas George wrote: > > I do not think this is correct: the dash is not part of the option name, > it is part of the Unix command-line tradition. For consistency, it > should be removed when it is there, possibly replaced by the word > "option" if necessary. I d

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Lou Logan
On Fri, Feb 22, 2019, at 4:21 AM, Nicolas George wrote: > > There are other users than API and command-line. Think of a GUI that > presents all options as editable fields. That seems like an empty argument. Which GUI? Do you have an example? I don't see how some unnamed third-party GUI should hav

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: initialize sub2video.end_pts together with last_pts

2019-02-22 Thread Jan Ekström
On Fri, Feb 22, 2019 at 3:11 PM Michael Niedermayer wrote: > > On Thu, Feb 21, 2019 at 01:16:00PM +0200, Jan Ekström wrote: > > This fixes buffering of samples which causes sudden ballooning of > > memory usage in case of no subtitle samples coming in for a while if > > the filter chain had been r

Re: [FFmpeg-devel] [PATCH] doc: add missing hyphen prefix

2019-02-22 Thread Lou Logan
On Fri, Feb 22, 2019, at 4:57 AM, Nicolas George wrote: > > That would be an argument for using something way more specific than a > dash. Like what? Do you have an example? > Anyway, that kind of marking would belong in the definition of the macro > @option, not in the body of the documentation.

[FFmpeg-devel] [PATCH] ffmpeg_filter: switch sub2video.end_pts initialization value to 0

2019-02-22 Thread Jan Ekström
This seems to fix use cases where the sub2video output is the only input to a filter chain. Additionally, this is the value to which the structure's values would implicitly get initialized to. The ballooning buffering case would not get hit by this as the value of end_pts after (re-)initialization

Re: [FFmpeg-devel] [PATCH] ffmpeg_filter: switch sub2video.end_pts initialization value to 0

2019-02-22 Thread Jan Ekström
On Fri, Feb 22, 2019 at 9:56 PM Jan Ekström wrote: > > This seems to fix use cases where the sub2video output is the only > input to a filter chain. > > Additionally, this is the value to which the structure's values > would implicitly get initialized to. The ballooning buffering case > would not

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Check parents remaining length

2019-02-22 Thread Dale Curtis
+steve who submitted the original patch. - dale On Thu, Feb 21, 2019 at 2:30 PM Dale Curtis wrote: > One of our test clips is behaving differently after this patch: > https://cs.chromium.org/chromium/src/media/test/data/bear-320x240-live.webm > > The printed log message is: > [matroska,webm @

[FFmpeg-devel] [PATCH] rtpenc_chain: forward strict_std_compliance flags to rtp muxer

2019-02-22 Thread Tristan Matthews
fixes: https://trac.ffmpeg.org/ticket/6713 --- libavformat/rtpenc_chain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtpenc_chain.c b/libavformat/rtpenc_chain.c index d3c1bc96dc..e7a4dffaba 100644 --- a/libavformat/rtpenc_chain.c +++ b/libavformat/rtpenc_chain.c @@ -59,6 +59,7

Re: [FFmpeg-devel] Reimbursement request for LDP

2019-02-22 Thread Michael Niedermayer
On Sun, Feb 10, 2019 at 07:53:50PM +0100, Thilo Borgmann wrote: > Hi, > > I'd like to request reimbursement for my travel to the LDP [1]. > > Accomodation was sponsored by the LDP team, so travel costs are rather low: > 21.90€ LGTM thx > > Will send the paperwork to Stefano. > > Thanks, > T

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/zmbv: obtain frame later

2019-02-22 Thread Michael Niedermayer
On Fri, Feb 22, 2019 at 01:45:25PM +0100, Tomas Härdin wrote: > tor 2019-02-21 klockan 20:34 +0100 skrev Michael Niedermayer: > > The frame is not needed that early so obtaining it later avoids > > the costly operation in case other checks fail. > > > > Fixes: Timeout (14sec -> 4sec) > > Fixes: >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pnm: Avoid structure pointer dereferences in inner loop in pnm_get()

2019-02-22 Thread Michael Niedermayer
On Fri, Feb 22, 2019 at 09:10:55AM +0200, Lauri Kasanen wrote: > On Thu, 21 Feb 2019 20:34:29 +0100 > Michael Niedermayer wrote: > > > Improves speed from 5.4 to 4.2 seconds > > Fixes: > > 13149/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PGM_fuzzer-5760833622114304 > > LGTM will apply

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec/zmbvenc: block scoring improvements/bug fixes

2019-02-22 Thread Michael Niedermayer
On Fri, Feb 22, 2019 at 01:09:12PM +0100, Tomas Härdin wrote: > fre 2019-02-22 klockan 00:11 +0100 skrev Michael Niedermayer: > > On Thu, Feb 21, 2019 at 09:26:44PM +, Matthew Fearnley wrote: > > > - To clear up the effects: the change from 'i=1' to 'i=0' was the only > > > change that should m

[FFmpeg-devel] [PATCH] Fix handling of unknown length case for matroska files.

2019-02-22 Thread Dale Curtis
Unknown length has a special encoding which is not uint64_t(-1). Signed-off-by: Dale Curtis --- libavformat/matroskadec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) From 2bf28a1edb54297f44021771b4c3d847c1f923f4 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 22 Fe

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Check parents remaining length

2019-02-22 Thread Dale Curtis
Sent http://ffmpeg.org/pipermail/ffmpeg-devel/2019-February/240418.html - which passes fate and fixes the issue with our test clip. - dale On Fri, Feb 22, 2019 at 12:31 PM Dale Curtis wrote: > +steve who submitted the original patch. > > - dale > > > On Thu, Feb 21, 2019 at 2:30 PM Dale Curtis

[FFmpeg-devel] [RFC PATCH] ffmpeg: explicitly handle timestamp re-initialization

2019-02-22 Thread Jan Ekström
Now each time as the sub2video structure is initialized, the current time is updated to the first received heartbeat's PTS. --- Sending this out as an alternative to the other patch, showing how the sub2video time can be synchronized to the heartbeat explicitly when the structure is (re-)initializ

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-22 Thread Michael Niedermayer
On Fri, Feb 22, 2019 at 06:20:40PM +0800, Charles Liu wrote: > 1. organize fragmented information according to the tracks. > 2. do NOT skip the last boxes of fragmented info. > > ticket #7572 > > Signed-off-by: Charles Liu > --- > libavformat/isom.h | 10 +- > libavformat/mov.c | 374

[FFmpeg-devel] [PATCH] lavc/libx265: signal CPB properties through side data

2019-02-22 Thread Jan Ekström
This way values such as maxrate/bufsize can be utilized further down the chain. --- libavcodec/libx265.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index 98415366da..fe39f45241 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/vf_thumbnail_cuda: Switch to using ffnvcodec

2019-02-22 Thread Philip Langdale
On Fri, 22 Feb 2019 05:46:12 + Soft Works wrote: > > Subject: [FFmpeg-devel] [PATCH 4/5] avfilter/vf_thumbnail_cuda: > > Switch to using ffnvcodec > > > > This change switches the vf_thumbnail_cuda filter from using the > > full cuda sdk to using the ffnvcodec headers and loader. > > > > Most

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix hang while seek on a kind of fragmented mp4.

2019-02-22 Thread C.H.Liu
I can’t reproduce the OOM. Is it possible the problem relate to a specific clip? Here is my test steps: 1. To ensure that it’s not affected by caches, delete all except the .git dir in my code dir. Then checkout again. 2. To ensure that the latest test clips are used. make fate-rsync SAMPLES=fate-