Re: [FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-18 Thread Jeyapal, Karthick
Thanks for sending these excellent patches. The entire patchset looks good to me. Also, many thanks for your patience and taking the earlier review comments in the right spirit. Regards, Karthick On 11/17/18 11:10 PM, Andrey Semashev wrote: > --- > libavformat/dashenc.c | 13 +++-- > 1

[FFmpeg-devel] [PATCH] avfilter: add rgbashift filter

2018-11-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 25 libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_chromashift.c | 226 +-- 4 files changed, 244 insertions(+), 9 deletions(-) diff --git a/doc/filters

[FFmpeg-devel] [PATCH] avutil/mem: Correct documentation of av_fast_*alloc(z)

2018-11-18 Thread Andreas Rheinhardt
The current wording regarding size and min_size is completely wrong and ignores that min_size is indeed only a desired minimal size, not the actually allocated size. Signed-off-by: Andreas Rheinhardt --- libavutil/mem.h | 24 1 file changed, 12 insertions(+), 12 deletion

[FFmpeg-devel] [PATCH 3/5] fftools/ffprobe: Indent the code.

2018-11-18 Thread Jun Zhao
commit 196765a7cc4 missed the reindet. Signed-off-by: Jun Zhao --- fftools/ffprobe.c | 28 ++-- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 280db78..d589893 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffp

[FFmpeg-devel] [PATCH 0/5] Misc change

2018-11-18 Thread Jun Zhao
V1: - indet ffmpeg/buffersrc - add auto threads flag for kvazaar - delete the unused code from ffmpeg - fix max_bit_rate dump warning for ffprobe Jun Zhao (5): lavfi/buffersrc: Indent the code. fftools/ffprobe: fix max_bit_rate dump. fftools/ffprobe: Indent the code. fftools/ff

[FFmpeg-devel] [PATCH 2/5] fftools/ffprobe: fix max_bit_rate dump.

2018-11-18 Thread Jun Zhao
‘codec’ is deprecated in AVStream, so used the dec_ctx to dump max_bit_rate in ffprobe. Clean the warning like: "warning: ‘codec’ is deprecated [-Wdeprecated-declarations]" Signed-off-by: Jun Zhao --- fftools/ffprobe.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 1/5] lavfi/buffersrc: Indent the code.

2018-11-18 Thread Jun Zhao
commit b0012de420f missed reindent. Signed-off-by: Jun Zhao --- libavfilter/buffersrc.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) diff --git a/libavfilter/buffersrc.c b/libavfilter/buffersrc.c index cd56f8c..0c12650 100644 --- a/libavfilter/buffer

[FFmpeg-devel] [PATCH 4/5] fftools/ffmpeg: delete the unused code.

2018-11-18 Thread Jun Zhao
There are come from 2012 ago and have never been used from this time. Signed-off-by: Jun Zhao --- fftools/ffmpeg.c |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index a12208c..085d6d2 100644 --- a/fftools/ffmpeg.c +++ b/fftoo

[FFmpeg-devel] [PATCH 5/5] lavc/kvazaar: fix auto thread flag in kvazaar wrapper.

2018-11-18 Thread Jun Zhao
Now the kvazaar warpper didn't setting the threads for kvazaar API, and kavzaar will auto select the thread number. Signed-off-by: Jun Zhao --- libavcodec/libkvazaar.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c inde

Re: [FFmpeg-devel] [PATCH] mjpegdec: Fill raw huffman tables with default values too

2018-11-18 Thread Mark Thompson
On 13/11/18 00:24, myp...@gmail.com wrote: > On Mon, Nov 12, 2018 at 12:26 AM Mark Thompson wrote: >> >> These may be used by hwaccel decoders when the standard tables are not >> otherwise available. At the same time, clean up that code into an array >> so it's a little less repetitive. >> --- >>

Re: [FFmpeg-devel] [PATCH 2/3] doc/encoders: Add libaom-av1

2018-11-18 Thread Mark Thompson
On 05/11/18 15:49, Gyan wrote: > On Mon, Nov 5, 2018 at 9:04 PM Mark Thompson wrote: > >> On 05/11/18 15:20, Gyan wrote: >>> On Mon, Nov 5, 2018 at 8:23 PM Mark Thompson wrote: >>> --- Updated to add some more explanation of the rate control mode selection. doc/encoders

Re: [FFmpeg-devel] [PATCH 3/3] libaomenc: Drop unused noise-sensitivity option

2018-11-18 Thread Mark Thompson
On 05/11/18 14:52, Mark Thompson wrote: > --- > On 28/10/18 21:02, Carl Eugen Hoyos wrote: >> 2018-10-28 21:08 GMT+01:00, Mark Thompson : >>> --- >>> This was in the 4.0 release, unfortunately (and did nothing there as well). >> >> If it has never worked, it can be removed imo. > > Sure, here is a

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg_er: fix clearing chroma blocks for 422 and 444

2018-11-18 Thread Michael Niedermayer
On Sat, Nov 17, 2018 at 11:39:08PM +0100, Marton Balint wrote: > Fixes ticket #7494. > > Signed-off-by: Marton Balint > --- > libavcodec/mpeg_er.c | 2 ++ > 1 file changed, 2 insertions(+) probably ok a fate test covering this case if its stable should be added too. thx [...] -- Michael

Re: [FFmpeg-devel] invalid PCM-DVD detection

2018-11-18 Thread Michael Niedermayer
On Fri, Nov 16, 2018 at 07:41:27PM +0300, Евгений wrote: > > mpeg.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 10489d03a741445401f3f6bfb49e536680db6cc9 0003-invalid-PCM-DVD-detection.patch > From 8dffee21a78c17bf1e74f459869babe77041dfd2 Mon Sep 17 00:00:00 2001 > From: Evgeny

Re: [FFmpeg-devel] [PATCH 3/3] libaomenc: Drop unused noise-sensitivity option

2018-11-18 Thread Jan Ekström
On Mon, Nov 5, 2018 at 4:53 PM Mark Thompson wrote: > > --- > On 28/10/18 21:02, Carl Eugen Hoyos wrote: > > 2018-10-28 21:08 GMT+01:00, Mark Thompson : > >> --- > >> This was in the 4.0 release, unfortunately (and did nothing there as well). > > > > If it has never worked, it can be removed imo.

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: don't abort when splitting Temporal Units containing OBUs with no obu_size field

2018-11-18 Thread Mark Thompson
On 15/11/18 04:27, James Almer wrote: > The ISOBMFF and Matroska specs allow the last OBU in a Sample/Block to have > obu_has_size_field equal to 0. > > Signed-off-by: James Almer > --- > See https://0x0.st/sUsU.mp4 > > It apparently can't be decoded with either aom or dav1d atm, but the latter

Re: [FFmpeg-devel] [PATCH v5 1/4] lavc/libdavs2: fix sequence incomplete output error

2018-11-18 Thread Mark Thompson
On 02/11/18 13:30, hwren wrote: > Signed-off-by: hwren > --- > libavcodec/libdavs2.c | 12 +++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c > index cadf995..e36bfed 100644 > --- a/libavcodec/libdavs2.c > +++ b/libavcode

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: don't abort when splitting Temporal Units containing OBUs with no obu_size field

2018-11-18 Thread James Almer
On 11/18/2018 3:41 PM, Mark Thompson wrote: > On 15/11/18 04:27, James Almer wrote: >> The ISOBMFF and Matroska specs allow the last OBU in a Sample/Block to have >> obu_has_size_field equal to 0. >> >> Signed-off-by: James Almer >> --- >> See https://0x0.st/sUsU.mp4 >> >> It apparently can't be d

Re: [FFmpeg-devel] [PATCH 1/6] cbs_h2645: Unify the free-functions via macro

2018-11-18 Thread Mark Thompson
On 09/11/18 05:31, Andreas Rheinhardt wrote: > The similarity between several free-functions is exploited to create > them via a common macro. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_h2645.c | 55 -- > 1 file changed, 15 insertions(+),

Re: [FFmpeg-devel] [PATCH 2/6] cbs_h2645: Do a deep copy for parameter sets

2018-11-18 Thread Mark Thompson
On 09/11/18 05:31, Andreas Rheinhardt wrote: > This commit solves dangling pointers problems when the content of a > parameter set isn't refcounted in the beginning: Now a deep copy of the > parameter sets is performed. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_h2645.c | 59 ++

Re: [FFmpeg-devel] [PATCH 3/6] cbs_h2645: Create functions to make parameter sets writeable

2018-11-18 Thread Mark Thompson
On 09/11/18 05:31, Andreas Rheinhardt wrote: > av_buffer_make_writable can't be used here, because a shallow copy isn't > enough for parameter sets. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cbs_h264.h | 8 > libavcodec/cbs_h2645.c | 16 > libavcodec/cb

Re: [FFmpeg-devel] [PATCH 4/6] h264_redundant_pps: Fix memleak in case of errors

2018-11-18 Thread Mark Thompson
On 09/11/18 05:31, Andreas Rheinhardt wrote: > Now the fragment is uninitialized and the input packet freed in case of > errors. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/h264_redundant_pps_bsf.c | 46 ++--- > 1 file changed, 29 insertions(+), 17 deletions(

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Martin Vignali
> > Are all 444(4?) Encodings 12-bit? Also is there a way to verify if your > file should be decoded as 10 or 12-bit? Or does this code automate this > detection? > > The auto mode of the patch, only use codec_tag to switch between 10b and 12b, no other value. I don't think, prores have metadata fo

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Martin Vignali
Le dim. 18 nov. 2018 à 01:57, Carl Eugen Hoyos a écrit : > 2018-11-18 0:28 GMT+01:00, Martin Vignali : > > > 012 : Add 12b support for 444 by default, > > Is it slower? > I believe that once 12 bit decoding is not slower, it should > be the default for 422. > Yes 12b is much slower On a 422 HQ

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffprobe: fix max_bit_rate dump.

2018-11-18 Thread Moritz Barsnick
> +if (dec_ctx->rc_max_rate > 0) print_val ("max_bit_rate", > dec_ctx->rc_max_rate, unit_bit_per_second_str); > +else print_str_opt("max_bit_rate", "N/A"); > if (dec_ctx && dec_ctx->bits_per_raw_sample > 0) > print_fmt("bits_per_raw_sample", "%d", dec_ctx->bi

Re: [FFmpeg-devel] [PATCH 3/3] libaomenc: Drop unused noise-sensitivity option

2018-11-18 Thread Mark Thompson
On 18/11/18 18:34, Jan Ekström wrote: > On Mon, Nov 5, 2018 at 4:53 PM Mark Thompson wrote: >> >> --- >> On 28/10/18 21:02, Carl Eugen Hoyos wrote: >>> 2018-10-28 21:08 GMT+01:00, Mark Thompson : --- This was in the 4.0 release, unfortunately (and did nothing there as well). >>> >>> If i

Re: [FFmpeg-devel] [PATCH] avutil/mem: Correct documentation of av_fast_*alloc(z)

2018-11-18 Thread Michael Niedermayer
On Sun, Nov 18, 2018 at 03:08:45PM +0100, Andreas Rheinhardt wrote: > The current wording regarding size and min_size is completely wrong and > ignores that min_size is indeed only a desired minimal size, not the > actually allocated size. > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-char-subscripts

2018-11-18 Thread Tomas Härdin
sön 2018-11-18 klockan 04:40 +0100 skrev Carl Eugen Hoyos: > Hi! > > On systems with signed char, the compiler cannot distinguish between > (intended) int8_t used as subscript and unintended char, therefore the > warning doesn't help. Is this done anywhere in the codebase currently? Either way, p

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/truemotion2: Check huffman code max bits

2018-11-18 Thread Tomas Härdin
lör 2018-11-17 klockan 03:01 +0100 skrev Michael Niedermayer: > Fixes: Timeout > Fixes: > 10984/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-6643310750859264 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Sign

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/truemotion2: fix integer overflows in tm2_low_chroma()

2018-11-18 Thread Tomas Härdin
lör 2018-11-17 klockan 03:01 +0100 skrev Michael Niedermayer: > Fixes: > 11295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-4888953459572736 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michae

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Kieran O Leary
On Sun, 18 Nov 2018, 21:58 Martin Vignali > I don't know, how to get the "wanted" pix_fmt output using ffmpeg cli, and > I don't know, what the general "rules" of this project for multiple pix_fmt > output for the same input file. > > If user option for decoding precision need to be remove, > i th

Re: [FFmpeg-devel] [PATCH 2/5] fftools/ffprobe: fix max_bit_rate dump.

2018-11-18 Thread myp...@gmail.com
On Mon, Nov 19, 2018 at 6:03 AM Moritz Barsnick wrote: > > > +if (dec_ctx->rc_max_rate > 0) print_val ("max_bit_rate", > > dec_ctx->rc_max_rate, unit_bit_per_second_str); > > +else print_str_opt("max_bit_rate", "N/A"); > > if (dec_ctx && dec_ctx->bits_per_raw

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Carl Eugen Hoyos
2018-11-18 22:58 GMT+01:00, Martin Vignali : > Le dim. 18 nov. 2018 à 01:57, Carl Eugen Hoyos a > écrit : > >> 2018-11-18 0:28 GMT+01:00, Martin Vignali : >> >> > 012 : Add 12b support for 444 by default, >> >> Is it slower? >> I believe that once 12 bit decoding is not slower, it should >> be the

Re: [FFmpeg-devel] avcodec/proresdec : add 12b decoding support

2018-11-18 Thread Carl Eugen Hoyos
2018-11-18 23:50 GMT+01:00, Kieran O Leary : > On Sun, 18 Nov 2018, 21:58 Martin Vignali >> I don't know, how to get the "wanted" pix_fmt output using ffmpeg cli, >> and I don't know, what the general "rules" of this project for multiple >> pix_fmt output for the same input file. >> >> If user opt

Re: [FFmpeg-devel] [PATCH]configure: Add -Wno-char-subscripts

2018-11-18 Thread Carl Eugen Hoyos
2018-11-18 23:25 GMT+01:00, Tomas Härdin : > sön 2018-11-18 klockan 04:40 +0100 skrev Carl Eugen Hoyos: >> Hi! >> >> On systems with signed char, the compiler cannot distinguish between >> (intended) int8_t used as subscript and unintended char, therefore the >> warning doesn't help. > > Is this do

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/truemotion2: fix integer overflows in tm2_low_chroma()

2018-11-18 Thread Michael Niedermayer
On Sun, Nov 18, 2018 at 11:32:21PM +0100, Tomas Härdin wrote: > lör 2018-11-17 klockan 03:01 +0100 skrev Michael Niedermayer: > > Fixes: > > 11295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-4888953459572736 > > > > Found-by: continuous fuzzing process > > https://github

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/truemotion2: Check huffman code max bits

2018-11-18 Thread Michael Niedermayer
On Sun, Nov 18, 2018 at 11:29:10PM +0100, Tomas Härdin wrote: > lör 2018-11-17 klockan 03:01 +0100 skrev Michael Niedermayer: > > Fixes: Timeout > > Fixes: > > 10984/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-6643310750859264 > > > > Found-by: continuous fuzzing process