lör 2018-11-17 klockan 03:01 +0100 skrev Michael Niedermayer: > Fixes: > 11295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-4888953459572736 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavcodec/truemotion2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/truemotion2.c b/libavcodec/truemotion2.c > index 58a577f53c..c583ff4032 100644 > --- a/libavcodec/truemotion2.c > +++ b/libavcodec/truemotion2.c > @@ -484,7 +484,7 @@ static inline void tm2_high_chroma(int *data, int stride, > int *last, unsigned *C > } > } > > -static inline void tm2_low_chroma(int *data, int stride, int *clast, int > *CD, int *deltas, int bx) > +static inline void tm2_low_chroma(int *data, int stride, int *clast, > unsigned *CD, int *deltas, int bx) > { > int t; > int l; > @@ -494,8 +494,8 @@ static inline void tm2_low_chroma(int *data, int stride, > int *clast, int *CD, in > prev = clast[-3]; > else > prev = 0; > - t = (CD[0] + CD[1]) >> 1; > - l = (prev - CD[0] - CD[1] + clast[1]) >> 1; > + t = (int)(CD[0] + CD[1]) >> 1;
I presume the old code would overflow for sums exceeding INT_MAX. Why then is there a cast to int before the shift and not after? /Tomas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
