[FFmpeg-devel] [PATCH] avformat/dashenc: Disable writing CODECS tag for HEVC streams

2018-10-21 Thread Karthick J
For HEVC streams, only the FourCC tag is written without profile, level etc., This is breaking playout support in native Safari. Native Safari playout expects the full info in CODECS tag or None at all. --- libavformat/dashenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --gi

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Disable writing CODECS tag for HEVC streams

2018-10-21 Thread Hendrik Leppkes
On Sun, Oct 21, 2018 at 10:41 AM Karthick J wrote: > > For HEVC streams, only the FourCC tag is written without profile, level etc., > This is breaking playout support in native Safari. > Native Safari playout expects the full info in CODECS tag or None at all. Generating the full string shouldn'

Re: [FFmpeg-devel] [PATCH v2] avformat/dashenc: Support HTTP Persistent for master.m3u8 as well

2018-10-21 Thread Jeyapal, Karthick
On 10/18/18 11:49 AM, Karthick J wrote: > --- > libavformat/dashenc.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c > index 3f5f290e25..15b84a0f3b 100644 > --- a/libavformat/dashenc.c > +++ b/libavformat/dashenc.c

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: URL close unconditionally after DELETE segments

2018-10-21 Thread Jeyapal, Karthick
On 10/18/18 2:56 PM, Karthick J wrote: > Fixes bug with HTTP DELETE when HTTP Persistent is ON. > Right now, HTTP Persistent connections is supported only for POSTs and PUTs. > HTTP DELETE will still open a new connection every time. > --- > libavformat/dashenc.c | 2 +- > 1 file changed, 1 inser

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: Disable writing CODECS tag for HEVC streams

2018-10-21 Thread Jeyapal, Karthick
On 10/21/18 2:28 PM, Hendrik Leppkes wrote: > On Sun, Oct 21, 2018 at 10:41 AM Karthick J wrote: >> >> For HEVC streams, only the FourCC tag is written without profile, level etc., >> This is breaking playout support in native Safari. >> Native Safari playout expects the full info in CODECS tag o

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-21 Thread Moritz Barsnick
On Sat, Oct 20, 2018 at 22:42:55 -0400, Leo Izen wrote: > On 10/20/18 6:47 PM, Michael Niedermayer wrote: > > This will not apply as it has too many newlines > What do you mean by "this will not apply"? Do you mean attempting to > apply the patch fails? What do newline characters have anything to

Re: [FFmpeg-devel] avcodec/proresenc_aw improvements

2018-10-21 Thread Martin Vignali
> > >if avtc->profile < 0 or > 4, return an error. > > Should 5 not become ProRes XQ (ap4x) as in prores_ks? > > Yes, plan to add it later. Need some test before. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] aacenc: remove unsupported PCE mappings

2018-10-21 Thread pkv.stream
Le 29/08/2018 à 1:01 AM, Rostislav Pehlivanov a écrit : On 28 August 2018 at 22:29, Rostislav Pehlivanov > wrote: Turns out those ones make the decoder unable to accurately determine the layout, hence making some API users' guess, and sometimes those

[FFmpeg-devel] [PATCH 2/3] avcodec/aacenc: Add PCE support for 11 to 15 channels

2018-10-21 Thread pkv.stream
For context , search for the discussion: aacenc: remove unsupported PCE mappings From 69bb2a21b873eb0bd49bba965acb98b09b115331 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 16 Sep 2018 01:46:05 +0200 Subject: [PATCH 2/3] avcodec/aacenc: Add PCE support for 11 to 15 channels This adds suppor

[FFmpeg-devel] [PATCH 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

2018-10-21 Thread pkv.stream
For context , search for the discussion: aacenc: remove unsupported PCE mappings Additional details: the aac decoder decodes PCE correctly but since avutil channel layouts are obviously not part of the spec there is no pre-defined one to one correspondance between ffmpeg channel layouts and a

[FFmpeg-devel] [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table

2018-10-21 Thread pkv.stream
For context , search for the discussion: aacenc: remove unsupported PCE mappings From fb2b44216caa7b52d1a69ce4f03119c3473ebf45 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 16 Sep 2018 01:41:52 +0200 Subject: [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table The LFE layouts were prev

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove FF_CODEC_CAP_INIT_THREADSAFE flag

2018-10-21 Thread Henrik Gramner
Fixed in x264-sandbox. All uses of plain strtok() will be removed from x264 in the next push. I though all of the strtok() uses in x264 had already been converted to strtok_r() but apparently that wasn't the case. Sorry about that. ___ ffmpeg-devel maili

[FFmpeg-devel] avcodec/prores_aw : add support for alpha encoding

2018-10-21 Thread Martin Vignali
Hello, Patch in attach add support for YUVA444P10 input and alpha 16b encoding 001 : Add frame header description for alpha value (use value close to the official encoder) 002 : indent and add comment, about the header value (based on multimedia wiki doc) 003 : Add support for Prores 444 with a

Re: [FFmpeg-devel] swscale/unscaled : add grayf32 bswap and rename packed_16bpc_bswap

2018-10-21 Thread Michael Niedermayer
On Sat, Oct 20, 2018 at 10:26:43PM +0200, Martin Vignali wrote: > Hello, > > 001 : add unscaled grayf32 bswap func > similar to packed_16bpc_bswap processing > > 002 : rename packed_16bpc_bswap func to bswap_16bpc > this func is used for planar and packed bswap16 > > Martin [...] > swscale_uns

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg.c: allow forcing input framerate on streamcopy

2018-10-21 Thread Leo Izen
On 10/21/18 7:23 AM, Moritz Barsnick wrote: On Sat, Oct 20, 2018 at 22:42:55 -0400, Leo Izen wrote: On 10/20/18 6:47 PM, Michael Niedermayer wrote: This will not apply as it has too many newlines What do you mean by "this will not apply"? Do you mean attempting to apply the patch fails? What d

Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-21 Thread Michael Niedermayer
On Sat, Oct 20, 2018 at 09:12:21PM +0200, Martin Vignali wrote: [...] > @section showinfo > diff --git a/libavfilter/vf_setparams.c b/libavfilter/vf_setparams.c > index 5426d88777..05ccc38c0d 100644 > --- a/libavfilter/vf_setparams.c > +++ b/libavfilter/vf_setparams.c > @@ -35,6 +35,9 @@ typedef s

Re: [FFmpeg-devel] avfilter/show_info : print color information

2018-10-21 Thread Michael Niedermayer
On Sat, Oct 20, 2018 at 04:59:05PM +0200, Martin Vignali wrote: > Hello, > > Patch in attach add to show_info filter > print of the color property (range, primaries, trc, space) > > Martin > vf_showinfo.c | 35 +++ > 1 file changed, 35 insertions(+) > 035ae11e5

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/ilbcdec: Check startindex

2018-10-21 Thread Paul B Mahol
On 10/21/18, Michael Niedermayer wrote: > Fixes: Out of array read > Fixes: > 10789/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-5153255445757952 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Nied

Re: [FFmpeg-devel] avcodec/prores_aw : add support for alpha encoding

2018-10-21 Thread Reto Kromer
Martin Vignali wrote: >prores_ks take care about alpha data size, for yuv encoding (in >other word reduce quality of yuv data if there is alpha), but >it's seems that this is not the case of the official encoder No, it isn't. >So for prores_aw, i choose to separate yuv encoding and alpha >encodi

Re: [FFmpeg-devel] swscale/unscaled : add grayf32 bswap and rename packed_16bpc_bswap

2018-10-21 Thread Martin Vignali
New patch in attach 001 : change unscaled test condition for float (only use isFloat(src) || isFloat(dst)). 002 : add grayf32 le <-> be i disable float (in/out) in the latest part of the patch, because it's currently doesn't work for floating data (and replace bswap_32 for grayf32 swap, in unscale

Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-21 Thread Martin Vignali
> > please align these vertically, it makes them easier to read > > New patch in attach. Also add changelog entry, and libavfilter version change Martin 0005-avfilter-setparam-add-options-to-set-color-primaries.patch Description: Binary data 0004-avfilter-setparams-merge-setfield-and-setrange-

Re: [FFmpeg-devel] [LDP] FFmpeg at LinuxDays 2018 in Prague

2018-10-21 Thread Thilo Borgmann
Am 20.10.18 um 17:49 schrieb Thomas Volkert: > > On 20.10.2018 17:15, Thilo Borgmann wrote: >> Hi again, >> >>> FFmpeg been accepted for a booth at the LinuxDays 2018 in Prague, Czech >>> Republic during October 6th to 7th! >>> >>> [...] Find detailed information here: >>> >>> https://www.linuxda

Re: [FFmpeg-devel] [LDP] FFmpeg at LinuxDays 2018 in Prague

2018-10-21 Thread Thilo Borgmann
Am 21.10.18 um 19:59 schrieb Thilo Borgmann: > Am 20.10.18 um 17:49 schrieb Thomas Volkert: >> >> On 20.10.2018 17:15, Thilo Borgmann wrote: >>> Hi again, >>> FFmpeg been accepted for a booth at the LinuxDays 2018 in Prague, Czech Republic during October 6th to 7th! [...] Find

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table

2018-10-21 Thread Carl Eugen Hoyos
2018-10-21 14:22 GMT+02:00, pkv.stream : > For context , search for the discussion: aacenc: remove > unsupported PCE mappings Do your patches fix any of the current AAC regressions? https://trac.ffmpeg.org/ticket/7266 https://trac.ffmpeg.org/ticket/7271 https://trac.ffmpeg.org/ticket/7273 Carl Eu

Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-21 Thread Paul B Mahol
On 10/21/18, Martin Vignali wrote: >> >> please align these vertically, it makes them easier to read >> >> > New patch in attach. > Also add changelog entry, and libavfilter version change LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http:

Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-21 Thread Martin Vignali
> > New patch in attach. > > Also add changelog entry, and libavfilter version change > > LGTM > > Pushed, thanks. Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-21 Thread Paul B Mahol
On 10/21/18, Martin Vignali wrote: >> > New patch in attach. >> > Also add changelog entry, and libavfilter version change >> >> LGTM >> >> > Pushed, thanks. You forgot to update setparams filter long description. ___ ffmpeg-devel mailing list ffmpeg-de

[FFmpeg-devel] [PATCH 3.4] configure: add LIBDRM to Libs.private instead of Libs

2018-10-21 Thread Giulio Benetti
Currently LIBDRM is appended to Libs: in libavutil.pc. This causes every program linking with avutil to link with -ldrm in both shared and static linking cases. In shared linking case it makes no sense, since -ldrm is a dependency of libavutil and is transparent while linking with libavutil - Add

Re: [FFmpeg-devel] avfilter : merge setfield and setrange and add set color property option

2018-10-21 Thread Martin Vignali
> > You forgot to update setparams filter long description. > > Patch in attach fix description, and two mistakes (not setting color primaries, trc, space to auto for setfield and setrange, and colorspace option for setparams Sorry. Martin 0002-avfilter-setparams-update-filter-description.patch

Re: [FFmpeg-devel] avcodec/prores_aw : add support for alpha encoding

2018-10-21 Thread Martin Vignali
Le dim. 21 oct. 2018 à 18:59, Reto Kromer a écrit : > Martin Vignali wrote: > > >prores_ks take care about alpha data size, for yuv encoding (in > >other word reduce quality of yuv data if there is alpha), but > >it's seems that this is not the case of the official encoder > > No, it isn't. > > >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table

2018-10-21 Thread pkv.stream
Le 21/10/2018 à 9:08 PM, Carl Eugen Hoyos a écrit : 2018-10-21 14:22 GMT+02:00, pkv.stream : For context , search for the discussion: aacenc: remove unsupported PCE mappings Do your patches fix any of the current AAC regressions? https://trac.ffmpeg.org/ticket/7266 no; the problem is because

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/aacenc: Fix LFE layouts in PCE table

2018-10-21 Thread Carl Eugen Hoyos
2018-10-21 23:09 GMT+02:00, pkv.stream : > Le 21/10/2018 à 9:08 PM, Carl Eugen Hoyos a écrit : >> https://trac.ffmpeg.org/ticket/7273 > > yes the issue is fixed by patches 1 and 3 Please mention the ticket in the commit message of 3. Thank you, Carl Eugen

[FFmpeg-devel] [PATCH v2 3/3] avcodec/aacdec: Translate PCE to avutil channel layouts

2018-10-21 Thread pkv.stream
(commit message changed to include number of trac tricket solved) For context , search for the discussion: aacenc: remove unsupported PCE mappings Additional details: the aac decoder decodes PCE correctly but since avutil channel layouts are obviously not part of the spec there is no pre-def

[FFmpeg-devel] [PATCH] avcodec/aacenc: Treat single channel as mono and bypass PCE

2018-10-21 Thread pkv.stream
A single channel is normally interpreted as mono. However if channelsplit filter is used, the individual channels are given their channel mask (ex: FL) as channel layout. This can cause issue with the native encoder since PCE was added because only channel layouts in spec will be encoded without P

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: remove FF_CODEC_CAP_INIT_THREADSAFE flag

2018-10-21 Thread Marton Balint
On Sun, 21 Oct 2018, Henrik Gramner wrote: Fixed in x264-sandbox. All uses of plain strtok() will be removed from x264 in the next push. Great, thanks! Can you give us an X264_BUILD number from which this will be fixed? Thanks, Marton ___ ffmpeg

Re: [FFmpeg-devel] [PATCH V5 0/2] fix vc1test can't probe some RCV file

2018-10-21 Thread myp...@gmail.com
On Wed, Oct 17, 2018 at 8:19 AM Jun Zhao wrote: > > v5: - fix potential integer overflow > - fix size check agagin, sadly. :( > v4: - add size check to avoid overread > v3: - add size check when probe as Michael's comments. > - update commit msg > - for Jerome's comments, I don't find

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: add several options supported in srt 1.3.0

2018-10-21 Thread Marton Balint
On Fri, 19 Oct 2018, Matsuzawa Tomohiro wrote: Several SRT options are missing. Since pkg_config requires libsrt v1.3.0 and above, it should be able to support options added in libsrt v1.3.0 and below. This commit adds 8 SRT options. sndbuf, rcvbuf, lossmaxttl, minversion, streamid, smoother,

Re: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR image reconstruction from a single exposure using deep CNNs

2018-10-21 Thread Guo, Yejun
From: Vittorio Giovara [mailto:vittorio.giov...@gmail.com] Sent: Friday, October 19, 2018 11:33 PM To: FFmpeg development discussions and patches Cc: Guo, Yejun ; g...@ffbox0-bg.ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR image reconstruction from a single ex

Re: [FFmpeg-devel] [PATCH V3] Add a filter implementing HDR image reconstruction from a single exposure using deep CNNs

2018-10-21 Thread Vittorio Giovara
On Mon, Oct 22, 2018 at 4:19 AM Guo, Yejun wrote: > +.description = NULL_IF_CONFIG_SMALL("HDR image reconstruction from > a single exposure using deep CNNs."), > > > > > why "reconstruction"? there is nothing to construct back if the source > wasn't hdr to begin with > > > "tonemap" is prob

[FFmpeg-devel] [PATCH] avformat/libsrt: add several options supported in srt 1.3.0 v2

2018-10-21 Thread Matsuzawa Tomohiro
Several SRT options are missing. Since pkg_config requires libsrt v1.3.0 and above, it should be able to support options added in libsrt v1.3.0 and below. This commit adds 8 SRT options. sndbuf, rcvbuf, lossmaxttl, minversion, streamid, smoother, messageapi and transtype The keys of option are eq