Re: [FFmpeg-devel] [PATCH v2] fate: add more vc2 encoder tests

2018-07-18 Thread James Darnley
On 2018-07-18 02:24, Michael Niedermayer wrote: > On Mon, Jul 16, 2018 at 01:03:53PM +0200, James Darnley wrote: >> From: James Darnley >> >> --- >> Michael, can you test this for the same failure you saw last time? > > seems to work in all cases i tested Good, I didn't confuse make this time.

Re: [FFmpeg-devel] [PATCH 1/2] svq1dec: Ensure that pixel format constraints are respected

2018-07-18 Thread Michael Niedermayer
On Tue, Jul 17, 2018 at 09:39:18PM +0200, Vittorio Giovara wrote: > YUV410P requires that sizes are divisible by 4. There seem to be > some encoders that ignore that and encode a different value in > the bitstream itself. Handle that case by exporting the relative > cropping information. > --- > Al

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior when start_time_text is -1<<63

2018-07-18 Thread Michael Niedermayer
On Tue, Jul 17, 2018 at 02:37:55PM -0700, Fredrik Hubinette wrote: > > utils.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > e69f1a3a447e331cad7ea85e28c0ed13e48ce33c > 0001-Avoid-undefined-behavior-when-start_time_text-is-1-6.patch > From d7bd55c3d280c10b990577003a985296f10a2b59

Re: [FFmpeg-devel] Patch: to add missing padding to nearest WORD boundary AVI

2018-07-18 Thread Michael Niedermayer
On Tue, Jul 10, 2018 at 08:06:40PM +0200, stefan.becker...@gmx.de wrote: > avidec.c |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > 5f20b4d86b6f21342654d925f4834aa199f99cca > 0001-add-missing-padding-to-nearest-WORD-boundary-AVI.patch > From 82bce9859429ab76261ef2ab852a03c9e0f03

Re: [FFmpeg-devel] [PATCH] Avoid undefined behavior by limiting PTS to 62 bits in ogg decoder

2018-07-18 Thread Michael Niedermayer
On Mon, Jul 16, 2018 at 04:32:14PM -0700, Fredrik Hubinette wrote: > With some (garbled) OGG data, PTS can overflow causing undefined behavior. > This patch avoids that by zeroing out PTS values greater than 2^62. > oggdec.h |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > ff003b788

Re: [FFmpeg-devel] [RFC] Make the user help mailing lists subscription only

2018-07-18 Thread Gyan Doshi
On 18-07-2018 04:13 AM, Lou Logan wrote: I'm considering changing the ffmpeg-user and libav-user mailing lists to only accept messages from subscribed users. ffmpeg-devel would be excluded from this due to the higher familiarity of mailing lists with that audience. What's the volume of messa

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: drop invalid index table segments when sorting them

2018-07-18 Thread Tomas Härdin
fre 2018-07-13 klockan 23:43 +0200 skrev Marton Balint: > This way we can guess a proper index instead of using an invalid one. > > Fixes seeking in the sample of ticket #5671. > > > Signed-off-by: Marton Balint > --- >  libavformat/mxfdec.c | 25 + >  1 file changed, 17 i

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: Use bytestream2 for peaks

2018-07-18 Thread Michael Niedermayer
On Sun, Jul 15, 2018 at 08:51:36PM +0100, Kieran Kunhya wrote: > On Sat, 14 Jul 2018 at 00:14 Michael Niedermayer > wrote: > > > This fixes out of array accesses > > No testcase known > > > > Signed-off-by: Michael Niedermayer > > > > Looks ok if Gagandeep is ok noone seems to have objected so

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/dvbsub_parser: Do not discard data

2018-07-18 Thread Michael Niedermayer
On Fri, Jul 06, 2018 at 05:24:29PM +0200, Michael Niedermayer wrote: > May fix: oss fuzz issue 9220 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/dvbsub_parser.c | 16 +--- > 1 file changed, 9 insertions(+), 7 deletions(-) will apply [...] -- Michael GnuPG fingerpr

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/tscc: Move reget buffer to after decoding

2018-07-18 Thread Michael Niedermayer
On Sun, Jul 15, 2018 at 03:13:38PM +0200, Michael Niedermayer wrote: > reget buffer can be time consuming, theres no need to do it if failures > occur > > Testcase: > 9010/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TSCC_fuzzer-6042614817095680 > > Found-by: continuous fuzzing process > h

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/lagarith: Remove redundant varianble init

2018-07-18 Thread Michael Niedermayer
On Sun, Jul 15, 2018 at 03:13:37PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/lagarith.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Take away

Re: [FFmpeg-devel] avformat/lrcdec: fix losing opening bracket

2018-07-18 Thread Umair Khan
On Sat, Jul 14, 2018 at 8:37 PM Michael Niedermayer wrote: > > On Fri, Jul 13, 2018 at 01:34:47PM +0530, Umair Khan wrote: > > On Wed, Jul 11, 2018 at 11:07 PM Michael Niedermayer > > wrote: > > > > > > On Tue, Jul 10, 2018 at 08:10:00PM +0530, Umair Khan wrote: > > > > Hi, > > > > > > > > Patch

[FFmpeg-devel] [PATCH] svq1dec: Ensure that pixel format constraints are respected

2018-07-18 Thread Vittorio Giovara
2018-07-17 21:39 GMT+02:00, Carl Eugen Hoyos : > 2018-07-17 21:39 GMT+02:00, Vittorio Giovara : > > YUV410P requires that sizes are divisible by 4. There seem to be > > some encoders that ignore that and encode a different value in > > the bitstream itself. Handle that case by exporting the relati

[FFmpeg-devel] [PATCH] ffv1dec: Ensure that pixel format constraints are respected

2018-07-18 Thread Vittorio Giovara
On Tue, Jul 17, 2018 at 11:58:06PM +0200,Michael Niedermayer wrote: > > Its a consequence of the subsampling factor. > > this does not follow from what you write below. But more so this is not > how pixel formats were implemented in FFmpeg. > Where does this idea come from ? I found the following

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-18 Thread Tobias Rapp
On 13.07.2018 13:43, Marcin Gorzel wrote: Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is obtained from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the rematrixing fai

Re: [FFmpeg-devel] [PATCH] ffv1dec: Ensure that pixel format constraints are respected

2018-07-18 Thread Derek Buitenhuis
On Wed, Jul 18, 2018 at 10:01 AM, Vittorio Giovara wrote: >> this does not follow from what you write below. But more so this is not >> how pixel formats were implemented in FFmpeg. >> Where does this idea come from ? > > I found the following description of this pixel format pretty accurate: > ht

Re: [FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-18 Thread Marcin Gorzel
Thanks for your input Tobias! On Wed, Jul 18, 2018 at 3:23 PM Tobias Rapp wrote: > On 13.07.2018 13:43, Marcin Gorzel wrote: > > Rematrixing supports up to 64 channels. However, there is only a limited > number of channel layouts defined. Since the in/out channel count is > obtained from the cha

[FFmpeg-devel] [PATCH] libswresample: Use channel count if channel layout is undefined

2018-07-18 Thread Marcin Gorzel
Rematrixing supports up to 64 channels. However, there is only a limited number of channel layouts defined. Since the in/out channel count is obtained from the channel layout, for undefined layouts (e.g. for 9, 10, 11 channels etc.) the rematrixing fails. In ticket #6790 the problem has been pa

Re: [FFmpeg-devel] [PATCH 0/5] AV1 support in mp4

2018-07-18 Thread James Almer
On 7/9/2018 3:26 PM, James Almer wrote: > What the subject says. > > There are a few comments in some of the patches as well. > > James Almer (5): > avcodec: add AV1 packet split API > avcodec/extract_extradata: add support for AV1 > avcodec/libaomenc: export Sequence Header and Metadata OB

[FFmpeg-devel] [PATCH] avcodec/decode: fix bsfs string parsing when more than one filter is requested

2018-07-18 Thread James Almer
av_get_token() leaves bsfs_str pointing to the delimiter character, so any iteration past the first would be off by one character and start parsing from the delimiter in question. No test case as no decoder currently requests more than one bsfs. Signed-off-by: James Almer --- libavcodec/decode.

[FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-18 Thread Aman Gupta
From: Aman Gupta Fixes a bug that would prevent using multiple comma-separated filters, and allows options to be passed to each filter. Based on similar loop in ffmpeg_opt.c's new_output_stream(). Signed-off-by: Aman Gupta --- libavcodec/decode.c | 47 -

[FFmpeg-devel] [PATCH] avutil/pixfmt: Document chroma plane size for odd resolutions

2018-07-18 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavutil/pixfmt.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index aea008bbdc..2b3307845e 100644 --- a/libavutil/pixfmt.h +++ b/libavutil/pixfmt.h @@ -42,6 +42,10 @@ * This is stored as BGRA on little-e

Re: [FFmpeg-devel] [PATCH] ffv1dec: Ensure that pixel format constraints are respected

2018-07-18 Thread Michael Niedermayer
On Wed, Jul 18, 2018 at 11:03:47AM -0400, Derek Buitenhuis wrote: > On Wed, Jul 18, 2018 at 10:01 AM, Vittorio Giovara > wrote: > >> this does not follow from what you write below. But more so this is not > >> how pixel formats were implemented in FFmpeg. > >> Where does this idea come from ? > >

Re: [FFmpeg-devel] avformat/lrcdec: fix losing opening bracket

2018-07-18 Thread Michael Niedermayer
On Wed, Jul 18, 2018 at 06:04:29PM +0530, Umair Khan wrote: > On Sat, Jul 14, 2018 at 8:37 PM Michael Niedermayer > wrote: > > > > On Fri, Jul 13, 2018 at 01:34:47PM +0530, Umair Khan wrote: > > > On Wed, Jul 11, 2018 at 11:07 PM Michael Niedermayer > > > wrote: > > > > > > > > On Tue, Jul 10, 20

Re: [FFmpeg-devel] [PATCH] avutil/pixfmt: Document chroma plane size for odd resolutions

2018-07-18 Thread Carl Eugen Hoyos
2018-07-18 22:23 GMT+02:00, Michael Niedermayer : > Signed-off-by: Michael Niedermayer > --- > libavutil/pixfmt.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h > index aea008bbdc..2b3307845e 100644 > --- a/libavutil/pixfmt.h > +++ b/libavutil

[FFmpeg-devel] [PATCH]lavfi/af_aiir, af_afir: Remove a variable that is always -1

2018-07-18 Thread Carl Eugen Hoyos
Hi! Two very similar conditions in af_aiir.c and af_afir.c can never be true afaict. Please review, Carl Eugen From 6c83ac40c1c83987fe4bc408e5408166815b88d8 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 19 Jul 2018 02:28:25 +0200 Subject: [PATCH] lavfi/af_afir,af_aiir: Remove a vari

Re: [FFmpeg-devel] [PATCH] avcodec: parse options from AVCodec.bsfs

2018-07-18 Thread James Almer
On 7/18/2018 3:57 PM, Aman Gupta wrote: > From: Aman Gupta > avcodec/decode: parse options from AVCodec.bsfs > Fixes a bug that would prevent using multiple comma-separated filters, > and allows options to be passed to each filter. > > Based on similar loop in ffmpeg_opt.c's new_output_stream(

Re: [FFmpeg-devel] [PATCH v9 0/3] Re-commit for davs2 api change.

2018-07-18 Thread hwren
Ping, any comments for following patches? At 2018-07-16 15:24:54, "hwren" wrote: >hwren (3): > lavc: add avs2 parser > lavf: add avs2 fourcc > lavc,doc,configure: add avs2 video decoder wrapper > > Changelog| 1 + > configure| 4 ++ > doc/decoders.texi

Re: [FFmpeg-devel] Reimbursement request

2018-07-18 Thread Thilo Borgmann
> Am 01.07.2018 um 23:27 schrieb Thomas Volkert : > > >> On 23.03.2018 22:12, Thilo Borgmann wrote: >>> Am 18.03.18 um 20:57 schrieb Thilo Borgmann: >>> Hi, >>> As already discussed, FFmpeg was present on Chemnitzer Linux Tage, in addition, Thilo and I went to Brussels for FOSDEM whe

Re: [FFmpeg-devel] [PATCH v4][GSOC] avfilter: added colorconstancy

2018-07-18 Thread Thilo Borgmann
> Am 16.07.2018 um 13:41 schrieb Mina : > > Hi, > > This patch introduces Grey-Edge algorithm as part of the Color Constancy > Filter project in GSOC. > > V4 changes: > - Fixed error in filter.texi that resulted in breaking "make > doc/ffprobe-all.html" If there are no more comments comin

[FFmpeg-devel] [PATCH] libavcodec/escape130: fixes and improvements

2018-07-18 Thread Michael Chaban
Hi! Recently I completely decompiled original Eidos Escape codecs, and I wanted to fix and improve Escape130 code of ffmpeg. Here are three sequential commits and very short (few frames) RPL-video file sample. Please review, Michael Chaban - - - Image links to compare - - - Original Eidos dec