[FFmpeg-devel] [PATCH] avformat/avienc: add check bitstream method

2018-01-05 Thread Steven Liu
rename mpegts_check_bitstream to ff_check_bitstream fix problem: remux from mp4(AVC Codec) to avi(AVC Codec) error message: [avi @ 0x7fac97003c00] H.264 bitstream malformed, no startcode found, use the video bitstream filter 'h264_mp4toannexb' to fix it ('-bsf:v h264_mp4toannexb' option with ffmpeg

Re: [FFmpeg-devel] [PATCH] avformat/avienc: add check bitstream method

2018-01-05 Thread Hendrik Leppkes
On Fri, Jan 5, 2018 at 9:13 AM, Steven Liu wrote: > rename mpegts_check_bitstream to ff_check_bitstream > fix problem: remux from mp4(AVC Codec) to avi(AVC Codec) > error message: > [avi @ 0x7fac97003c00] H.264 bitstream malformed, no startcode found, > use the video bitstream filter 'h264_mp4toan

[FFmpeg-devel] [PATCH 1/2] adpcm: consume remainder after consuming XA chunks

2018-01-05 Thread misty
From: Misty De Meo --- libavcodec/adpcm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index be206c55ba..cd3bbd33c2 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1115,6 +1115,7 @@ static int adpcm_decode_frame(AVCodecContext *a

[FFmpeg-devel] [PATCH 0/2] adpcm: consume remainder after consuming XA chunks

2018-01-05 Thread misty
From: Misty De Meo > the initialization to 0 is unneeded OK - updated in the included patch. I've also included a second patch which adds an explicit goto and break in aiffdec, on top of the patch you already applied, and the Changelog entry that I forgot to include in that patch. I realize it

[FFmpeg-devel] [PATCH 2/2] aiff: add explicit goto got_sound

2018-01-05 Thread misty
From: Misty De Meo --- Changelog | 1 + libavformat/aiffdec.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/Changelog b/Changelog index 3d966c202b..63007a259d 100644 --- a/Changelog +++ b/Changelog @@ -33,6 +33,7 @@ version : - deconvolve video filter - entropy video filt

[FFmpeg-devel] [PATCH] FFV1: make RGB48 support as non-experimental

2018-01-05 Thread Jerome Martinez
1 year without RGB48 related patches, tested by a couple of users, tested with a FFV1 conformance checker, I suggest that FFV1 RGB48 support in FFmpeg does not mandate anymore the user to add " -strict experimental" on the command line during encoding. From cd1bfe68a1a809700f25e593ac21ca3876d2

Re: [FFmpeg-devel] [PATCH 1/1] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread Misty De Meo
> so this is unfinished code that work in progress ? > if so, what is missing ? > if not, then please write a better commit message Sorry about that - that was the placeholder title of a commit I squashed into the mpeg commit, and forgot to remove when rebasing. I'll remove it from the commit mess

[FFmpeg-devel] [PATCH 0/6] Fix detecting ATRAC3 audio from MPS files

2018-01-05 Thread misty
From: Misty De Meo > this looks a bit odd > shouldnt this test more than 4 bits of startcode ? Yeah, that was a misreading on my part of the original patch. I need a different approach. I think I've found something that should work, though. I was talking to Jan about this in IRC, and vgmtoolbox

[FFmpeg-devel] [PATCH 1/6] fate: add atrac3p conversion test

2018-01-05 Thread misty
From: Misty De Meo --- tests/fate/atrac.mak | 4 1 file changed, 4 insertions(+) diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak index acf79a539c..1707373890 100644 --- a/tests/fate/atrac.mak +++ b/tests/fate/atrac.mak @@ -31,6 +31,10 @@ FATE_ATRAC3P += fate-atrac3p-2 fate-atrac3

[FFmpeg-devel] [PATCH 4/6] Fix detecting ATRAC3 audio from MPS files

2018-01-05 Thread misty
From: Misty De Meo MPS files are MPEG files used on PSP Video discs. They lack the PSMF header used by .pms files, and so the special casing in the original patch fails to support their audio. This patch fixes this by unconditionally reading a new byte for the startcode for PRIVATE_STREAM_1 secti

[FFmpeg-devel] [PATCH 3/6] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread misty
From: Maxim Poliakovski Changes by Misty De Meo : atrac3plus_parser: remove return statements for invalid data atrac3plus_parser: use libavcodec's oma atrac3plus_parser: pass along unexpected data unaltered atrac3plus_parser: adjust bytes_remain type Change by Michael "Bazz" Bazzinotti : at

[FFmpeg-devel] [PATCH 2/6] oma: move some constants into libavcodec

2018-01-05 Thread misty
From: Misty De Meo Most of the constants in libavcodec/oma aren't specific to libavformat; moving them into libavcodec makes them available to libavcodec as well as keeping them compatible with libavformat. ff_oma_codec_tags uses a libavformat-specific type, so it has been left in libavformat. -

[FFmpeg-devel] [PATCH 6/6] psmf: add FATE tests

2018-01-05 Thread misty
From: Misty De Meo --- tests/Makefile | 1 + tests/fate/psmf.mak | 23 +++ 2 files changed, 24 insertions(+) create mode 100644 tests/fate/psmf.mak diff --git a/tests/Makefile b/tests/Makefile index fd3713fe81..c569091fcb 100644 --- a/tests/Makefile +++ b/tests/Makefi

[FFmpeg-devel] [PATCH 5/6] mpeg: fix use of deprecated struct

2018-01-05 Thread misty
From: Misty De Meo --- libavformat/mpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c index afde768199..ca848cacbb 100644 --- a/libavformat/mpeg.c +++ b/libavformat/mpeg.c @@ -561,8 +561,8 @@ redo: len--; for (

Re: [FFmpeg-devel] [PATCH 5/5] mpeg: fix use of deprecated struct

2018-01-05 Thread James Almer
On 12/22/2017 11:35 AM, mi...@brew.sh wrote: > From: Misty De Meo > > --- > libavformat/mpeg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mpeg.c b/libavformat/mpeg.c > index a366ece0ed..210424faf3 100644 > --- a/libavformat/mpeg.c > +++ b/libavforma

Re: [FFmpeg-devel] [PATCH] FFV1: make RGB48 support as non-experimental

2018-01-05 Thread Tobias Rapp
On 05.01.2018 11:18, Jerome Martinez wrote: 0001-FFV1-make-RGB48-support-as-non-experimental.patch From cd1bfe68a1a809700f25e593ac21ca3876d265ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= Date: Fri, 5 Jan 2018 11:09:01 +0100 Subject: [PATCH] FFV1: make RGB48 support

Re: [FFmpeg-devel] [PATCH 1/3 v2] avcodec/util: use a mutex instead of atomics in avcodec_register()

2018-01-05 Thread wm4
On Thu, 4 Jan 2018 22:40:44 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/utils.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index dfbfe98d63..4d736d2e7d 100644 > --- a/libavcodec/u

Re: [FFmpeg-devel] [PATCH 2/3 v2] avformat: use mutexes instead of atomics in av_register_{input, output}_format()

2018-01-05 Thread wm4
On Thu, 4 Jan 2018 22:41:38 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/format.c | 34 +++--- > 1 file changed, 23 insertions(+), 11 deletions(-) > > diff --git a/libavformat/format.c b/libavformat/format.c > index 38ca2a3465..759b5b1a

Re: [FFmpeg-devel] [PATCH 3/3 v2] avfilter: use a mutex instead of atomics in avfilter_register()

2018-01-05 Thread wm4
On Thu, 4 Jan 2018 22:42:52 -0300 James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/avfilter.c | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c > index b98b32bacb..ff7df672fd 100644 > --

Re: [FFmpeg-devel] [PATCH 1/3 v2] avcodec/util: use a mutex instead of atomics in avcodec_register()

2018-01-05 Thread James Almer
On 1/5/2018 1:02 PM, wm4 wrote: > On Thu, 4 Jan 2018 22:40:44 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavcodec/utils.c | 12 +--- >> 1 file changed, 9 insertions(+), 3 deletions(-) >> >> diff --git a/libavcodec/utils.c b/libavcodec/utils.c >> index dfbfe9

Re: [FFmpeg-devel] [PATCH 2/3 v2] avformat: use mutexes instead of atomics in av_register_{input, output}_format()

2018-01-05 Thread James Almer
On 1/5/2018 1:03 PM, wm4 wrote: > On Thu, 4 Jan 2018 22:41:38 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavformat/format.c | 34 +++--- >> 1 file changed, 23 insertions(+), 11 deletions(-) >> >> diff --git a/libavformat/format.c b/libavf

Re: [FFmpeg-devel] [PATCH 3/3 v2] avfilter: use a mutex instead of atomics in avfilter_register()

2018-01-05 Thread James Almer
On 1/5/2018 1:04 PM, wm4 wrote: > On Thu, 4 Jan 2018 22:42:52 -0300 > James Almer wrote: > >> Signed-off-by: James Almer >> --- >> libavfilter/avfilter.c | 15 +++ >> 1 file changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c

Re: [FFmpeg-devel] Chinese DTMB streams playback issue

2018-01-05 Thread Compn
On Thu, 4 Jan 2018 20:42:33 -0500, Abylay Ospan wrote: > Hello All, > > I have made dump of DTMB streams (digital TV standard in China, like > DVB-T in Europe, etc). thanks for samples. > Should I create ticket in https://trac.ffmpeg.org ? yes, please create tickets. one ticket per file. -co

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-01-05 Thread Jacob Trimble
On Tue, Jan 2, 2018 at 9:57 AM, Jacob Trimble wrote: > On Wed, Dec 20, 2017 at 4:31 PM, wm4 wrote: >> On Wed, 20 Dec 2017 15:10:43 -0800 >> Jacob Trimble wrote: >> >>> From 1508d19e9f7acf43d76010ce54d59ff204613601 Mon Sep 17 00:00:00 2001 >>> From: Jacob Trimble >>> Date: Tue, 5 Dec 2017 14:52:

[FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread LongChair .
Hi, Here are two patches that should : - fix https://trac.ffmpeg.org/ticket/6834. - remove code that looked a bit hackish and which is not necessary anymore. The first patch is required as mpp removed some control operation from the API, breaking the build. The second one is related to mpp fi

Re: [FFmpeg-devel] Chinese DTMB streams playback issue

2018-01-05 Thread Moritz Barsnick
On Thu, Jan 04, 2018 at 20:42:33 -0500, Abylay Ospan wrote: > I have made dump of DTMB streams (digital TV standard in China, like > DVB-T in Europe, etc). [...] > Should I create ticket in https://trac.ffmpeg.org ? Yes, please. Moritz ___ ffmpeg-devel

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread wm4
On Fri, 5 Jan 2018 19:02:25 + "LongChair ." wrote: > Hi, > > Here are two patches that should : > > - fix https://trac.ffmpeg.org/ticket/6834. > > - remove code that looked a bit hackish and which is not necessary anymore. > > The first patch is required as mpp removed some control operat

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread LongChair .
Yes the newly used  control operation seems to have always been there anyways, so there shouldn't be much compatibility issues. On 05/01/2018 20:19, wm4 wrote: > On Fri, 5 Jan 2018 19:02:25 + > "LongChair ." wrote: > >> Hi, >> >> Here are two patches that should : >> >> - fix https://trac.f

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2018-01-05 Thread Devin Heitmueller
Hello Aaron, Thanks for the feedback. Comments inline. On Sat, Dec 30, 2017 at 12:34 AM, Aaron Levinson wrote: > Technically, there are a number of 2K and 4K video modes supported by some > DeckLink cards that have a 16x9 aspect ratio as well. This code would treat > such video modes at 4:3.

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-01-05 Thread wm4
On Fri, 5 Jan 2018 10:22:31 -0800 Jacob Trimble wrote: > Just noticed the new files were in libavcodec, moved to libavutil. > Can someone please review this so it can be pushed. I have the MP4 > implementation ready and I would like to get that reviewed and pushed > as soon as possible. I'd ass

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-01-05 Thread Devin Heitmueller
Hi Aaron, Comments inline: > > Most of the changes in this set of patches appear to only be relevant in the > case that libklvanc is enabled. Nevertheless, a number of the changes are > not wrapped in #if CONFIG_LIBKLVANC, which means that they will be exercised > even if libklvanc is not ava

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread wm4
On Fri, 5 Jan 2018 19:22:00 + "LongChair ." wrote: > Yes the newly used  control operation seems to have always been there > anyways, so there shouldn't be much compatibility issues. I mean the second patch removes a workaround for some old misbehavior, right? So it should probably be made

Re: [FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

2018-01-05 Thread Devin Heitmueller
Hi Aaron, >> +ret = ff_alloc_afd_sei(frame, 0, &sei_data, &sei_size); >> +if (ret < 0) { >> +for (i = 0; i < num_payloads; i++) >> +av_free(x4->pic.extra_sei.payloads[i].payload); >> +av_free(x4->pic.extra_sei.payloads); >

Re: [FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

2018-01-05 Thread Devin Heitmueller
Hi Aaron, > On Dec 30, 2017, at 2:34 AM, Aaron Levinson wrote: > > Patch title: "suppoort" -> "support", also "decklink" -> “DeckLink" Ok. >>ff_decklink_cleanup(avctx); >> avpacket_queue_end(&ctx->queue); >> +klvanc_context_destroy(ctx->vanc_ctx); > > Shouldn't this last lin

Re: [FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

2018-01-05 Thread Devin Heitmueller
> On Dec 30, 2017, at 3:11 AM, Aaron Levinson wrote: > > On 12/29/2017 10:12 AM, Devin Heitmueller wrote: >> Make use of libklvanc to parse SCTE-104 packets and announce them >> as a new stream. Right now we just pass the payload straight >> through, but once this is hoooked into libklscte35 we

Re: [FFmpeg-devel] [PATCH] fate: add PERSIST_RPARAM_A_RExt_Sony_3 hevc conformance test

2018-01-05 Thread James Almer
On 10/10/2017 7:32 AM, Michael Niedermayer wrote: > On Mon, Oct 09, 2017 at 09:34:17PM -0300, James Almer wrote: >> The PERSIST_RPARAM_A_RExt_Sony_1 bitstream has an out-of-range value >> and has therefore been superseded. >> It is otherwise identical, and decodes the same. >> >> Signed-off-by: Jam

[FFmpeg-devel] [PATCH 3/3] avformat/mov: Expose encryption info to the app.

2018-01-05 Thread Jacob Trimble
This exposes encryption info from the container to the app. This includes key ID, IV, and subsample byte ranges. The info is passed using the new side-data AV_PKT_DATA_ENCRYPTION_INIT_DATA. Signed-off-by: Jacob Trimble --- libavformat/mov.c | 29 + 1 file changed, 2

[FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-01-05 Thread Jacob Trimble
- Parse schm atom to get different encryption schemes. - Allow senc atom to appear in track fragments. - Allow 16-byte IVs. - Allow constant IVs (specified in tenc). - Allow only tenc to specify encryption (i.e. no senc/saiz/saio). - Use sample descriptor to detect clear fragments. This doesn't su

[FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

2018-01-05 Thread Jacob Trimble
This doesn't support saio atoms with more than one offset. Signed-off-by: Jacob Trimble --- libavformat/isom.h | 6 ++ libavformat/mov.c | 174 + 2 files changed, 180 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

Re: [FFmpeg-devel] avcodec/rkmpp : Fix broken build and remove some useless code

2018-01-05 Thread LongChair .
Yes this was bound to very old versions afaik. Mpp repo was squashed and we didn't have any version requirement Current version is 1.3.7, if i trust my repo fork, previous version was 1.0.0, so we could add that as a requirement. On 05/01/2018 20:30, wm4 wrote: > On Fri, 5 Jan 2018 19:22:00 +0

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-01-05 Thread Jacob Trimble
On Fri, Jan 5, 2018 at 11:49 AM, Jacob Trimble wrote: >> [...] This adds two new fate tests that need to be uploaded by someone: https://storage.googleapis.com/shaka-demo-assets/_bugs/ffmpeg-fate-files/mov-frag-encrypted.mp4 https://storage.googleapis.com/shaka-demo-assets/_bugs/ffmpeg-fate-file

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mov: Increase support for common encryption.

2018-01-05 Thread James Almer
On 1/5/2018 4:49 PM, Jacob Trimble wrote: > diff --git a/libavutil/aes_ctr.c b/libavutil/aes_ctr.c > index e9c568fe0d..6ed69c8e10 100644 > --- a/libavutil/aes_ctr.c > +++ b/libavutil/aes_ctr.c > @@ -38,10 +38,9 @@ struct AVAESCTR *av_aes_ctr_alloc(void) > return av_mallocz(sizeof(struct AVAESC

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2018-01-05 Thread Devin Heitmueller
>> +if (ctx->max_audio_channels > DECKLINK_MAX_AUDIO_CHANNELS) { >> +av_log(avctx, AV_LOG_WARNING, "Decklink card reported support for >> more channels than ffmpeg supports\n"); > > "Decklink" -> "DeckLink", "ffmpeg" -> "FFmpeg". Also, I think it is > preferable to not state "FFmpe

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2018-01-05 Thread Devin Heitmueller
Hello Matthias, Thanks for the feedback. Comments inline: > On Jan 2, 2018, at 4:52 AM, Matthias Hunstock wrote: > > Am 29.12.2017 um 19:12 schrieb Devin Heitmueller: >> To support the existing use case where multi-channel audio can be >> captured (i.e. 7.1) > > Just to be clear, the current

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2018-01-05 Thread Devin Heitmueller
Hi Aaron, >> +static int create_s337_payload(AVPacket *pkt, enum AVCodecID codec_id, >> uint8_t **outbuf, int *outsize) >> +{ >> +uint8_t *s337_payload; >> +uint8_t *s337_payload_start; >> +int i; >> + >> +/* Encapsulate AC3 syncframe into SMPTE 337 packet */ >> +*outsize = (

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Expose encryption info to the app.

2018-01-05 Thread Carl Eugen Hoyos
2018-01-05 20:49 GMT+01:00 Jacob Trimble : > +AV_WB32(side_data, size); > +AV_WL32(side_data + 4, MKTAG('p','s','s','h')); I didn't check: Is this what applications on both big- and little-endian expect? Carl Eugen ___ ffmpeg-devel mailing list

[FFmpeg-devel] DAV files sample

2018-01-05 Thread Haaroon M. Yousaf
I’ve got a camera system that outputs DAV files. When converted to MP4 through ffmpeg, the output mp4 video is fine. However there are many errors in regards to “data partitioning is not being implemented” or “A non-intra slice in IDR NAL unit”. Would you like a sample/copy of this DAV file? I

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

2018-01-05 Thread Carl Eugen Hoyos
2018-01-05 20:49 GMT+01:00 Jacob Trimble : > +entry_count = avio_rb32(pb); > +encryption_index->auxiliary_offsets = av_malloc_array(sizeof(size_t), > entry_count); (sizeof(variable) instead of sizeof(type), please.) But since this could be used for a dos attack, please change this to so

[FFmpeg-devel] [PATCH 1/2] avfilter: deprecate avfilter_link_get_channels()

2018-01-05 Thread James Almer
And move the channels field to the public section of the struct. Signed-off-by: James Almer --- doc/APIchanges | 4 libavfilter/avfilter.c | 2 ++ libavfilter/avfilter.h | 15 ++- libavfilter/version.h | 5 - 4 files changed, 20 insertions(+), 6 deletions(-) dif

Re: [FFmpeg-devel] [PATCH 1/1] mpeg: add experimental support for PSMF audio.

2018-01-05 Thread Misty De Meo
Sorry about that - that was the placeholder title of a commit I squashed into the mpeg commit, and forgot to remove when rebasing. I'll remove it from the commit message. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/list

[FFmpeg-devel] [PATCH 2/2] tools/uncoded_frame: remove usage of avfilter_link_get_channels()

2018-01-05 Thread James Almer
Signed-off-by: James Almer --- tools/uncoded_frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/uncoded_frame.c b/tools/uncoded_frame.c index 3ca2ba4bbe..c044741701 100644 --- a/tools/uncoded_frame.c +++ b/tools/uncoded_frame.c @@ -178,7 +178,7 @@ int main(int argc,

Re: [FFmpeg-devel] [PATCH 3/3] avformat/mov: Expose encryption info to the app.

2018-01-05 Thread Jacob Trimble
On Fri, Jan 5, 2018 at 12:43 PM, Carl Eugen Hoyos wrote: > 2018-01-05 20:49 GMT+01:00 Jacob Trimble : > >> +AV_WB32(side_data, size); >> +AV_WL32(side_data + 4, MKTAG('p','s','s','h')); > > I didn't check: > Is this what applications on both big- and little-endian expect? Yes. This shoul

Re: [FFmpeg-devel] DAV files sample

2018-01-05 Thread Carl Eugen Hoyos
2018-01-05 15:33 GMT+01:00 Haaroon M. Yousaf : > I’ve got a camera system that outputs DAV files. Am I correct that the camera also records audio? > When converted to MP4 through ffmpeg, the output mp4 video is fine. > However there are many errors in regards to “data partitioning is not > being

Re: [FFmpeg-devel] [PATCH] FFV1: make RGB48 support as non-experimental

2018-01-05 Thread Jerome Martinez
On 05/01/2018 16:14, Tobias Rapp wrote: On 05.01.2018 11:18, Jerome Martinez wrote: 0001-FFV1-make-RGB48-support-as-non-experimental.patch From cd1bfe68a1a809700f25e593ac21ca3876d265ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= Date: Fri, 5 Jan 2018 11:09:01 +0100 S

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

2018-01-05 Thread Jacob Trimble
On Fri, Jan 5, 2018 at 12:41 PM, Carl Eugen Hoyos wrote: > 2018-01-05 20:49 GMT+01:00 Jacob Trimble : > >> +entry_count = avio_rb32(pb); >> +encryption_index->auxiliary_offsets = av_malloc_array(sizeof(size_t), >> entry_count); > > (sizeof(variable) instead of sizeof(type), please.) > > B

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

2018-01-05 Thread James Almer
On 1/5/2018 6:29 PM, Jacob Trimble wrote: > diff --git a/libavformat/mov.c b/libavformat/mov.c > index eb3fb71e2a..9ff4a809b7 100644 > --- a/libavformat/mov.c > +++ b/libavformat/mov.c > @@ -5835,6 +5835,177 @@ static int mov_read_senc(MOVContext *c, AVIOContext > *pb, MOVAtom atom) > return

Re: [FFmpeg-devel] [PATCH] doc/fate: Document how to upload samples to the fate suite

2018-01-05 Thread Michael Niedermayer
On Mon, Jan 01, 2018 at 01:17:18PM +0100, Michael Niedermayer wrote: > Suggested-by: Compn > > Signed-off-by: Michael Niedermayer > --- > doc/fate.texi | 20 > 1 file changed, 20 insertions(+) will apply [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

2018-01-05 Thread Carl Eugen Hoyos
2018-01-05 22:29 GMT+01:00 Jacob Trimble : > On Fri, Jan 5, 2018 at 12:41 PM, Carl Eugen Hoyos wrote: >> 2018-01-05 20:49 GMT+01:00 Jacob Trimble : >> >>> +entry_count = avio_rb32(pb); >>> +encryption_index->auxiliary_offsets = av_malloc_array(sizeof(size_t), >>> entry_count); >> >> (size

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-01-05 Thread Michael Niedermayer
On Mon, Dec 18, 2017 at 11:17:48AM -0800, Jacob Trimble wrote: > >> @@ -1327,6 +1384,19 @@ enum AVPacketSideDataType { > >> */ > >> AV_PKT_DATA_A53_CC, > >> > >> +/** > >> + * This side data is encryption "initialization data". > >> + * For MP4 this is the entire 'pssh' box.

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-01-05 Thread Michael Niedermayer
On Fri, Jan 05, 2018 at 10:22:31AM -0800, Jacob Trimble wrote: > On Tue, Jan 2, 2018 at 9:57 AM, Jacob Trimble wrote: > > On Wed, Dec 20, 2017 at 4:31 PM, wm4 wrote: > >> On Wed, 20 Dec 2017 15:10:43 -0800 > >> Jacob Trimble wrote: > >> > >>> From 1508d19e9f7acf43d76010ce54d59ff204613601 Mon Sep

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-01-05 Thread Michael Niedermayer
On Fri, Jan 05, 2018 at 08:27:41PM +0100, wm4 wrote: > On Fri, 5 Jan 2018 10:22:31 -0800 > Jacob Trimble wrote: > > > Just noticed the new files were in libavcodec, moved to libavutil. > > Can someone please review this so it can be pushed. I have the MP4 > > implementation ready and I would lik

Re: [FFmpeg-devel] [RFC] avcodec/avcodec.h: Add encryption info side data

2018-01-05 Thread James Almer
On 1/5/2018 7:32 PM, Michael Niedermayer wrote: > On Fri, Jan 05, 2018 at 08:27:41PM +0100, wm4 wrote: >> On Fri, 5 Jan 2018 10:22:31 -0800 >> Jacob Trimble wrote: >> >>> Just noticed the new files were in libavcodec, moved to libavutil. >>> Can someone please review this so it can be pushed. I h

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

2018-01-05 Thread Jacob Trimble
On Fri, Jan 5, 2018 at 2:01 PM, Carl Eugen Hoyos wrote: > 2018-01-05 22:29 GMT+01:00 Jacob Trimble : >> On Fri, Jan 5, 2018 at 12:41 PM, Carl Eugen Hoyos wrote: >>> 2018-01-05 20:49 GMT+01:00 Jacob Trimble >>> : >>> +entry_count = avio_rb32(pb); +encryption_index->auxiliary_off

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mov: Fix parsing of saio/siaz atoms in encrypted content.

2018-01-05 Thread Carl Eugen Hoyos
2018-01-05 23:58 GMT+01:00 Jacob Trimble : > On Fri, Jan 5, 2018 at 2:01 PM, Carl Eugen Hoyos wrote: >> 2018-01-05 22:29 GMT+01:00 Jacob Trimble : >>> On Fri, Jan 5, 2018 at 12:41 PM, Carl Eugen Hoyos >>> wrote: 2018-01-05 20:49 GMT+01:00 Jacob Trimble : > +entry_count =

Re: [FFmpeg-devel] [PATCH 2/6] oma: move some constants into libavcodec

2018-01-05 Thread Michael Niedermayer
On Fri, Jan 05, 2018 at 10:34:44PM +1100, mi...@brew.sh wrote: > From: Misty De Meo > > Most of the constants in libavcodec/oma aren't specific to > libavformat; moving them into libavcodec makes them available to > libavcodec as well as keeping them compatible with libavformat. > > ff_oma_codec

Re: [FFmpeg-devel] [PATCH] FFV1: make RGB48 support as non-experimental

2018-01-05 Thread Michael Niedermayer
On Fri, Jan 05, 2018 at 10:26:42PM +0100, Jerome Martinez wrote: > On 05/01/2018 16:14, Tobias Rapp wrote: > >On 05.01.2018 11:18, Jerome Martinez wrote: > >>0001-FFV1-make-RGB48-support-as-non-experimental.patch > >> > >>From cd1bfe68a1a809700f25e593ac21ca3876d265ad Mon Sep 17 00:00:00 2001 > >>Fr

Re: [FFmpeg-devel] [PATCH 2/2] aiff: add explicit goto got_sound

2018-01-05 Thread Michael Niedermayer
On Fri, Jan 05, 2018 at 08:06:49PM +1100, mi...@brew.sh wrote: > From: Misty De Meo > > --- > Changelog | 1 + > libavformat/aiffdec.c | 3 +++ > 2 files changed, 4 insertions(+) will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I

Re: [FFmpeg-devel] [PATCH 1/2] adpcm: consume remainder after consuming XA chunks

2018-01-05 Thread Michael Niedermayer
On Fri, Jan 05, 2018 at 08:06:48PM +1100, mi...@brew.sh wrote: > From: Misty De Meo > > --- > libavcodec/adpcm.c | 7 +++ > 1 file changed, 7 insertions(+) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to

Re: [FFmpeg-devel] [PATCH]lavf/rtpdec_jpeg: Treat stream type 64 like 0.

2018-01-05 Thread Michael Niedermayer
On Fri, Jan 05, 2018 at 05:43:01AM +0100, Carl Eugen Hoyos wrote: > Hi! > > Attached patch intends to fix ticket #5975, rfc 2435 says stream type > 64 should be treated like 0. > > Please review, Carl Eugen > rtpdec_jpeg.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 6c39ed6cee6

Re: [FFmpeg-devel] [PATCH 1/6] fate: add atrac3p conversion test

2018-01-05 Thread Bang He
On Wed, Jan 3, 2018 at 5:24 AM, Michael Niedermayer wrote: > On Sun, Dec 31, 2017 at 05:46:02PM +0800, mi...@brew.sh wrote: > > From: Misty De Meo > > > > --- > > tests/fate/atrac.mak | 4 > > 1 file changed, 4 insertions(+) > > > > diff --git a/tests/fate/atrac.mak b/tests/fate/atrac.mak