On 1/5/2018 7:32 PM, Michael Niedermayer wrote: > On Fri, Jan 05, 2018 at 08:27:41PM +0100, wm4 wrote: >> On Fri, 5 Jan 2018 10:22:31 -0800 >> Jacob Trimble <modmaker-at-google....@ffmpeg.org> wrote: >> >>> Just noticed the new files were in libavcodec, moved to libavutil. >>> Can someone please review this so it can be pushed. I have the MP4 >>> implementation ready and I would like to get that reviewed and pushed >>> as soon as possible. >> >> I'd assume we'd wait with applying this until the mp4 patch that uses >> it is reviewed. I'm fine with this patch and I think it can be pushed >> as it is, although I just noticed an APIchanges entry and minor version >> bump is actually missing. You could add them when sending the final >> patch set. >> > >> Maybe getting confirmation from Michael Niedermayer that it's safe to >> proceed would be good (i.e. that the patch will be accepted without >> major changes). > > if everyone is ok with the design and no regressions are found than iam ok > with it as well
This being in libavutil, the two functions using AVPacket should be changed to take and return a byte array instead, that the caller manually either got from side data, or will afterwards adds as side data. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
