Re: [FFmpeg-devel] [PATCH] ffmpeg: always init output stream before reaping filters

2017-10-08 Thread Marton Balint
On Sat, 7 Oct 2017, Hendrik Leppkes wrote: On Wed, Oct 4, 2017 at 12:48 AM, Marton Balint wrote: Otherwise the frame size of the codec is not set in the buffersink. Fixes ticket #6603 and the following simpler case: ffmpeg -c aac -filter_complex "sine=d=0.1,asetnsamples=1025" out.aac Sign

[FFmpeg-devel] [PATCH] Add support for libopenjpeg 2.3

2017-10-08 Thread Gyan Doshi
OpenJPEG 2.3 was released a few days ago. Changelog reports "No API/ABI break compared to v2.2.0 but additional symbols for subset of components decoding" This patch is adapted from an earlier patch which added support for 2.2. Applied and tested locally. From c42f0c4290170cb49dc00f7898bee31d2

Re: [FFmpeg-devel] [PATCH] Add support for libopenjpeg 2.3

2017-10-08 Thread Clément Bœsch
On Sun, Oct 08, 2017 at 04:51:49PM +0530, Gyan Doshi wrote: > OpenJPEG 2.3 was released a few days ago. Changelog reports "No API/ABI > break compared to v2.2.0 but additional symbols for subset of components > decoding" > > This patch is adapted from an earlier patch which added support for 2.2.

Re: [FFmpeg-devel] FFmpeg 3.4

2017-10-08 Thread Michael Niedermayer
On Sat, Oct 07, 2017 at 12:06:23AM +0200, wm4 wrote: > On Fri, 6 Oct 2017 16:53:17 +0200 > Michael Niedermayer wrote: > > > Hi all > > > > if there are no objections i will branch release/3.4 in the next days > > and make the 3.4 release a few days after that > > > > If people prefer a specific

Re: [FFmpeg-devel] FFmpeg 3.4

2017-10-08 Thread Reto Kromer
Michael Niedermayer wrote: >Of course if the majority wants me to wait with the release, >its easy to wait for as long as people want me to wait ... Form an user's perspective, I would be delighted to have a new release. Thank you very much indeed! Reto __

Re: [FFmpeg-devel] [PATCH 0/1] lavc: add support for OpenJPEG 2.3.0

2017-10-08 Thread Gyan Doshi
On 10/5/2017 7:15 PM, Michael Bradshaw wrote: > This adds support for OpenJPEG 2.3.0, which was just released and contains many security-related fixes. I missed this, and just submitted a patch for the same thing. So, ping for merge. Thanks, Gyan

Re: [FFmpeg-devel] [PATCH] Add support for libopenjpeg 2.3

2017-10-08 Thread Alexis Ballier
On Sun, 8 Oct 2017 13:43:45 +0200 Clément Bœsch wrote: > On Sun, Oct 08, 2017 at 04:51:49PM +0530, Gyan Doshi wrote: > > OpenJPEG 2.3 was released a few days ago. Changelog reports "No > > API/ABI break compared to v2.2.0 but additional symbols for subset > > of components decoding" > > > > This

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Nicolas George
Le sextidi 16 vendémiaire, an CCXXVI, Hendrik Leppkes a écrit : > If there is a command line to write a stats file with similar > information from this metadata - I don't think anyone would then > object to that. It was sarcastic: storing the stats in metadata is also a quick-and-dirty solution th

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Nicolas George
Le sextidi 16 vendémiaire, an CCXXVI, Ronald S. Bultje a écrit : > Calm down guys, I said in the next sentence I'm open to alternatives. The frustration in my message, if any, was not directed at you. But I think you should not only be "open" to alternatives but more "actively searching for" them

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Ronald S. Bultje
Hi, On Sun, Oct 8, 2017 at 9:06 AM, Nicolas George wrote: > I think that we should refuse any new stats-gathering or similar filter > until a clean and working solution has been designed. > I don't think that is fair. I don't agree with this approach. Ronald ___

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Nicolas George
Le septidi 17 vendémiaire, an CCXXVI, Ronald S. Bultje a écrit : > > I think that we should refuse any new stats-gathering or similar filter > > until a clean and working solution has been designed. > I don't think that is fair. I don't agree with this approach. Your lack of alternative proposal h

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Paul B Mahol
On 10/8/17, Nicolas George wrote: > Le septidi 17 vendemiaire, an CCXXVI, Ronald S. Bultje a ecrit : >> > I think that we should refuse any new stats-gathering or similar filter >> > until a clean and working solution has been designed. >> I don't think that is fair. I don't agree with this approa

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Nicolas George
Le septidi 17 vendémiaire, an CCXXVI, Paul B Mahol a écrit : > Your lack of common sense have been noted. I want a clean solution. A solution that works for most uses. A solution that works the same way for all filters. And, if possible, a solution that is easy to secure. Is that lack of common s

[FFmpeg-devel] [PATCH 5/6] hwcontext: Perform usual initialisation on derived device contexts

2017-10-08 Thread Mark Thompson
The initialisation should be common. For libmfx, it was previously happening in the derivation function and this moves it out. For VAAPI, it fixes some failures when deriving from a DRM device because this initialisation did not run. --- libavutil/hwcontext.c | 4 libavutil/hwcontext_q

[FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

2017-10-08 Thread Mark Thompson
This has been deprecated in libva2 because hardware does not and will not support it. Therefore never consider it for decode, and for encode assume the user meant constrained baseline profile instead. --- libavcodec/vaapi_decode.c | 1 - libavcodec/vaapi_encode_h264.c | 12 2 f

[FFmpeg-devel] [PATCH 6/6] hwcontext_vaapi: Add support for mapping to DRM objects

2017-10-08 Thread Mark Thompson
Uses vaExportSurfaceHandle() from libva2. --- libavutil/hwcontext_vaapi.c | 106 +++- 1 file changed, 104 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index b2f2e376d8..3b4ca57d6f 100644 --- a/libavuti

[FFmpeg-devel] [PATCH 4/6] hwcontext_vaapi: Set message callbacks on internally-created devices

2017-10-08 Thread Mark Thompson
The message callbacks are library-safe in libva2, so we can now use them. Also factorise out the common connection code to avoid duplicating this change. --- libavutil/hwcontext_vaapi.c | 74 +++-- 1 file changed, 45 insertions(+), 29 deletions(-) diff --g

[FFmpeg-devel] [PATCH 1/6] configure: Add config option for libva2 (VAAPI 1)

2017-10-08 Thread Mark Thompson
--- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 391c141e7a..87722de226 100755 --- a/configure +++ b/configure @@ -2204,6 +2204,7 @@ CONFIG_EXTRA=" texturedsp texturedspenc tpeldsp +vaapi_1 vaapi_encode vc1dsp vide

[FFmpeg-devel] [PATCH 3/6] vaapi: Always free parameter buffers after vaEndPicture() with libva2

2017-10-08 Thread Mark Thompson
This is an ABI change in libva2: previously the Intel driver had this behaviour and it was implemented as a driver quirk, but now it is part of the specification so all drivers must do it. --- libavcodec/vaapi_decode.c | 4 ++-- libavcodec/vaapi_encode.c | 4 ++-- libavfilter/vf_

Re: [FFmpeg-devel] [PATCH] Add support for libopenjpeg 2.3

2017-10-08 Thread Michael Bradshaw
I can clean these up as part of the patch that drops OpenJPEG 1.x support, which I plan on making after the next release (though of course someone else is welcome to beat me to it; it seems there's a race for OpenJPEG patches!). ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [PATCH]lavc/utvideo: Use "&" instead of "&&" in expressions with "~"

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 12:58 AM, Ronald S. Bultje wrote: > I personally think the warning is dumb... But I guess that's just me. I agree; I don't even count it as a valid warning. Maybe disable it? That's only my opinion, of course. - Derek ___ ffmpeg-devel mail

Re: [FFmpeg-devel] [PATCH] Add support for libopenjpeg 2.3

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:18 PM, Michael Bradshaw wrote: > I can clean these up as part of the patch that drops OpenJPEG 1.x support, > which I plan on making after the next release (though of course someone > else is welcome to beat me to it; it seems there's a race for OpenJPEG > patches!). Is there anythi

Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:11 PM, Mark Thompson wrote: > +case FF_PROFILE_H264_BASELINE: > +// Baseline profile is not supported, assume the user meant > +// constrained baseline instead. > +avctx->profile = FF_PROFILE_H264_CONSTRAINED_BASELINE; Trying to automatically (and silentl

Re: [FFmpeg-devel] [PATCH 3/6] vaapi: Always free parameter buffers after vaEndPicture() with libva2

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:11 PM, Mark Thompson wrote: > This is an ABI change in libva2: previously the Intel driver had this > behaviour and it was implemented as a driver quirk, but now it is part > of the specification so all drivers must do it. > --- > libavcodec/vaapi_decode.c | 4 ++-- > libav

[FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

2017-10-08 Thread Mark Thompson
This has been deprecated in libva2 because hardware does not and will not support it. Therefore never consider it for decode, and for encode assume the user meant constrained baseline profile instead. --- On 08/10/17 16:44, Derek Buitenhuis wrote: > On 10/8/2017 4:11 PM, Mark Thompson wrote: >> +

Re: [FFmpeg-devel] [PATCH 5/6] hwcontext: Perform usual initialisation on derived device contexts

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:11 PM, Mark Thompson wrote: > -ret = qsv_device_init(ctx); > -if (ret < 0) > -goto fail; From the patch context alone, this looks kinda iffy. I assume qsv_device_init is now called via av_hwdevice_ctx_init? - Derek ___ ffm

Re: [FFmpeg-devel] [PATCH 4/6] hwcontext_vaapi: Set message callbacks on internally-created devices

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:11 PM, Mark Thompson wrote: > The message callbacks are library-safe in libva2, so we can now use > them. Also factorise out the common connection code to avoid > duplicating this change. > --- > libavutil/hwcontext_vaapi.c | 74 > +++-- > 1

Re: [FFmpeg-devel] [PATCH 2/6] vaapi: Remove H.264 baseline profile

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:49 PM, Mark Thompson wrote: > Yeah, ok, I agree. Patch changed as enclosing. > > > libavcodec/vaapi_decode.c | 1 - > libavcodec/vaapi_encode_h264.c | 12 > 2 files changed, 4 insertions(+), 9 deletions(-) Looks OK to me. I assume we don't care about the old l

Re: [FFmpeg-devel] [PATCH 5/6] hwcontext: Perform usual initialisation on derived device contexts

2017-10-08 Thread Mark Thompson
On 08/10/17 16:49, Derek Buitenhuis wrote: > On 10/8/2017 4:11 PM, Mark Thompson wrote: >> -ret = qsv_device_init(ctx); >> -if (ret < 0) >> -goto fail; > > From the patch context alone, this looks kinda iffy. I assume > qsv_device_init is now called via av_hwdevice_ctx_init? Yes.

Re: [FFmpeg-devel] [PATCH 5/6] hwcontext: Perform usual initialisation on derived device contexts

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:52 PM, Mark Thompson wrote: > Yes. It always was for the non-derived case, resulting in it being called > twice (for qsv it doesn't actually do anything beyond some checks, so this > was harmless). Looks OK, then. - Derek ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH 4/6] hwcontext_vaapi: Set message callbacks on internally-created devices

2017-10-08 Thread Mark Thompson
On 08/10/17 16:51, Derek Buitenhuis wrote: > On 10/8/2017 4:11 PM, Mark Thompson wrote: >> The message callbacks are library-safe in libva2, so we can now use >> them. Also factorise out the common connection code to avoid >> duplicating this change. >> --- >> libavutil/hwcontext_vaapi.c | 74 >>

Re: [FFmpeg-devel] [PATCH 6/6] hwcontext_vaapi: Add support for mapping to DRM objects

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 4:11 PM, Mark Thompson wrote: > Uses vaExportSurfaceHandle() from libva2. > --- > libavutil/hwcontext_vaapi.c | 106 > +++- > 1 file changed, 104 insertions(+), 2 deletions(-) [...] > +for (i = 0; i < drm_desc->nb_objects; i++) > +

Re: [FFmpeg-devel] [PATCH 4/6] hwcontext_vaapi: Set message callbacks on internally-created devices

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 5:00 PM, Mark Thompson wrote: > Easy enough to do. > > Split as: > > """ > hwcontext_vaapi: Factorise out common connection code > > This was duplicated between normal device creation and creation by > derivation from a DRM device. > """ > > and > > """ > hwcontext_vaapi: Set mess

Re: [FFmpeg-devel] [PATCH 6/6] hwcontext_vaapi: Add support for mapping to DRM objects

2017-10-08 Thread Mark Thompson
On 08/10/17 17:03, Derek Buitenhuis wrote: > On 10/8/2017 4:11 PM, Mark Thompson wrote: >> Uses vaExportSurfaceHandle() from libva2. >> --- >> libavutil/hwcontext_vaapi.c | 106 >> +++- >> 1 file changed, 104 insertions(+), 2 deletions(-) > > [...] > >> +

Re: [FFmpeg-devel] [PATCH 6/6] hwcontext_vaapi: Add support for mapping to DRM objects

2017-10-08 Thread Derek Buitenhuis
On 10/8/2017 5:11 PM, Mark Thompson wrote: > This is just how hardware surfaces are stored in AVFrames - they have their > own API-specific handles in the data[] pointers because that's the only place > to put them. > > See >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Hendrik Leppkes
On Sun, Oct 8, 2017 at 5:05 PM, Nicolas George wrote: > Le septidi 17 vendémiaire, an CCXXVI, Paul B Mahol a écrit : >> Your lack of common sense have been noted. > > I want a clean solution. A solution that works for most uses. A solution > that works the same way for all filters. And, if possibl

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Ronald S. Bultje
Hi Nicolas, On Sun, Oct 8, 2017 at 9:38 AM, Nicolas George wrote: > Le septidi 17 vendémiaire, an CCXXVI, Ronald S. Bultje a écrit : > > > I think that we should refuse any new stats-gathering or similar filter > > > until a clean and working solution has been designed. > > I don't think that is

Re: [FFmpeg-devel] [PATCH] Add support for libopenjpeg 2.3

2017-10-08 Thread Michael Bradshaw
On Sun, Oct 8, 2017 at 8:34 AM, Derek Buitenhuis wrote: > > Is there anything that precludes switching 2.X to pkg-config and leaving > 1.X as is? No, switching 2.x to pkg-config isn't dependent on dropping 1.x. But since I plan to do both, I figure I might as well do them together since they're

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Nicolas George
Le septidi 17 vendémiaire, an CCXXVI, Hendrik Leppkes a écrit : > Usually those not happy with an existing solution should also offer up > a replacement, even if only in concept (actual implementable concept, > not just a slogan) That is the policy for enhancements, but not for flaws. When a flaw

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Nicolas George
Le septidi 17 vendémiaire, an CCXXVI, Ronald S. Bultje a écrit : > Hm... Michael has proposed 3 solutions and I commented on each of them. I saw, but basically it amounts to agreeing with the solutions that remove the file output. I am very fine with that, but other people have disagreed. Regards

Re: [FFmpeg-devel] [PATCH] lavf: add more beep options to sine asrc

2017-10-08 Thread Nicolas George
Thanks for the patch. Le quintidi 15 vendémiaire, an CCXXVI, Michael Bradshaw a écrit : > From: Michael Bradshaw > > Signed-off-by: Michael Bradshaw > --- > doc/filters.texi| 13 - > libavfilter/asrc_sine.c | 17 + > 2 files changed, 25 insertions(+), 5 dele

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Ronald S. Bultje
Hi, On Sun, Oct 8, 2017 at 2:04 PM, Nicolas George wrote: > Le septidi 17 vendémiaire, an CCXXVI, Hendrik Leppkes a écrit : > > Usually those not happy with an existing solution should also offer up > > a replacement, even if only in concept (actual implementable concept, > > not just a slogan)

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Nicolas George
Le septidi 17 vendémiaire, an CCXXVI, Ronald S. Bultje a écrit : > I think you're stretching the definition of "flaw" here. I addressed that in the paragraph you snipped: I agree that the usability considerations can be considered an enhancement, but the security considerations must be considered

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Paul B Mahol
On 10/8/17, Nicolas George wrote: > Le septidi 17 vendemiaire, an CCXXVI, Ronald S. Bultje a ecrit : >> I think you're stretching the definition of "flaw" here. > > I addressed that in the paragraph you snipped: I agree that the > usability considerations can be considered an enhancement, but the

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add vmafmotion filter

2017-10-08 Thread Ronald S. Bultje
Hi, On Sun, Oct 8, 2017 at 3:26 PM, Nicolas George wrote: > Le septidi 17 vendémiaire, an CCXXVI, Ronald S. Bultje a écrit : > > I think you're stretching the definition of "flaw" here. > > I addressed that in the paragraph you snipped: I agree that the > usability considerations can be consider

[FFmpeg-devel] [PATCH 00/20] Coded bitstream editing (v3)

2017-10-08 Thread Mark Thompson
Incorporating all review comments from last time: * Change all CBS users to hold a pointer rather than the whole structure. * Rearrange the MPEG-2 framerate stuff so that it doesn't add code and then remove it in the series. * Add a type for the coded bitstream unit type. * Miscellaneous fixups.

[FFmpeg-devel] [PATCH 03/20] lavc: Add coded bitstream read/write API

2017-10-08 Thread Mark Thompson
(cherry picked from commit 18f1706f331bf5dd565774eae680508c8d3a97ad) (cherry picked from commit 44cde38c8acbef7d5250e6d1b52b1020871e093b) --- configure | 1 + libavcodec/Makefile | 1 + libavcodec/cbs.c | 479 ++ libavc

[FFmpeg-devel] [PATCH 02/20] hevc: Improve stream constraint values in common header

2017-10-08 Thread Mark Thompson
Add comments to describe the sources of the constraint values expressed here, and add some more related values which will be used in following patches. Fix the incorrect values for SPS and PPS count (they are not the same as those used for H.264), and remove HEVC_MAX_CU_SIZE because it is not used

[FFmpeg-devel] [PATCH 09/20] lavc: Add h264_redundant_pps bitstream filter

2017-10-08 Thread Mark Thompson
This applies a specific fixup to some Bluray streams which contain redundant PPSs modifying irrelevant parameters of the stream which confuse other transformations which require correct extradata. A new single global PPS is created, and all of the redundant PPSs within the stream are removed. (ch

[FFmpeg-devel] [PATCH 01/20] h264: Add stream constraint values to the common header

2017-10-08 Thread Mark Thompson
With comments describing the derivation of each value. (cherry picked from commit aaf441465080b9bc57f5ca8dea656f9b2c5dc821) --- libavcodec/h264.h | 45 + 1 file changed, 45 insertions(+) diff --git a/libavcodec/h264.h b/libavcodec/h264.h index 86df5eb9

[FFmpeg-devel] [PATCH 08/20] lavc: Add h264_metadata bitstream filter

2017-10-08 Thread Mark Thompson
This is able to modify some header metadata found in the SPS/VUI, and can also add/remove AUDs and insert user data in SEI NAL units. (cherry picked from commit 9e93001b6135a23fe4e200196c08fb4fbffed6fc) (cherry picked from commit c42b62d1f9641f10ffc23cad9abbe47d8a4a165b) --- configure

[FFmpeg-devel] [PATCH 04/20] lavc: Add coded bitstream read/write support for H.264

2017-10-08 Thread Mark Thompson
(cherry picked from commit acf06f45441be24c5cbae0920579cd69427326a1) (cherry picked from commit 768eb9182e94a94bc2ef46f565a0dac7afef3b57) (cherry picked from commit e7f64191b27bcf37cbf7006606f0f439c6cdc24f) --- configure |2 + libavcodec/Makefile |

[FFmpeg-devel] [PATCH 10/20] lavc: Add hevc_metadata bitstream filter

2017-10-08 Thread Mark Thompson
This is able to modify some header metadata found in the VPS/SPS/VUI, and can also add/remove AUDs. (cherry picked from commit b31a9eae0233325c4b382c657f4b687d5d8b0812) --- configure | 1 + doc/bitstream_filters.texi | 54 + libavcodec/Makefile| 1 +

[FFmpeg-devel] [PATCH 11/20] mpeg12: Add a common function to find the best frame rate

2017-10-08 Thread Mark Thompson
This will be used later in both the mpeg2_metadata filter and the VAAPI MPEG-2 encoder. Also adds a unit test. (cherry picked from commit b5859e0b04bdbe12c97cb12ac10a45d51d2d73c9) --- libavcodec/Makefile| 1 + libavcodec/mpeg12.h| 4 ++ libavcodec/mpeg12framerat

[FFmpeg-devel] [PATCH 06/20] lavc: Add coded bitstream read/write support for MPEG-2

2017-10-08 Thread Mark Thompson
(cherry picked from commit 2bc9ba8d3c41f3a8e56484bd67b05040c7909a01) (cherry picked from commit a41b69b5eb950c10d8ede472bcc4e88ce4246db9) --- configure | 2 + libavcodec/Makefile| 1 + libavcodec/cbs.c | 3 + libavcodec/c

[FFmpeg-devel] [PATCH 05/20] lavc: Add coded bitstream read/write support for H.265

2017-10-08 Thread Mark Thompson
(cherry picked from commit 867381b8b51fa21fa2b8f071f508f3d39cc9c1f0) (cherry picked from commit f763489364416bb6866adc4f4a96012dd2ca1bd0) (cherry picked from commit 067a9ddeb8feff1f724856f0054930c55219f76b) --- configure |2 + libavcodec/Makefile |

[FFmpeg-devel] [PATCH 07/20] lavc: Add trace_headers bitstream filter

2017-10-08 Thread Mark Thompson
Supports all streams that the coded bitstream infrastructure does (currently H.264, H.265 and MPEG-2). (cherry picked from commit f11d8a5e8b185340cc50fcbc8a1437b0fbe7e931) --- configure | 1 + doc/bitstream_filters.texi | 8 +++ libavcodec/Makefile| 1 +

[FFmpeg-devel] [PATCH 12/20] lavc: Add mpeg2_metadata bitstream filter

2017-10-08 Thread Mark Thompson
(cherry picked from commit b78c30d7ec26af67c00ce2002709a189f6a87a7e) --- configure | 1 + doc/bitstream_filters.texi | 36 + libavcodec/Makefile | 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/mpeg2_metadata_bsf.c | 312 +++

[FFmpeg-devel] [PATCH 13/20] vaapi_h264: Convert to use coded bitstream infrastructure

2017-10-08 Thread Mark Thompson
(cherry picked from commit 7a4fac5e91789b73e07bd4ad20493cfde028df76) --- configure |2 +- libavcodec/Makefile|2 +- libavcodec/vaapi_encode_h264.c | 1425 3 files changed, 551 insertions(+), 878 deletions(-) diff --

[FFmpeg-devel] [PATCH 16/20] vaapi_h264: Fix CPB/DPB delays

2017-10-08 Thread Mark Thompson
This should be ticks, not time_scale steps - it was wrong for all framerates not a multiple of 1/2. (cherry picked from commit 30645174e333c7db1946ab09be769db9be9d7481) --- libavcodec/vaapi_encode_h264.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/vaapi_en

[FFmpeg-devel] [PATCH 14/20] vaapi_h264: Add support for AUD NAL units

2017-10-08 Thread Mark Thompson
Adds a new private option to enable them (off by default). (cherry picked from commit 820a4483af13cf6fd51f13638e57bcd1c3f629d4) --- libavcodec/vaapi_encode_h264.c | 33 + 1 file changed, 33 insertions(+) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaa

[FFmpeg-devel] [PATCH 15/20] vaapi_h264: Add support for SEI recovery points

2017-10-08 Thread Mark Thompson
Included by default with non-IDR intra frames. (cherry picked from commit a49ee60d5fdbdae1706a44cfbb814abb9793815f) --- libavcodec/vaapi_encode_h264.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_

[FFmpeg-devel] [PATCH 17/20] vaapi_h265: Convert to use coded bitstream infrastructure

2017-10-08 Thread Mark Thompson
Also improves the metadata and generally makes the configuration a bit cleaner. (cherry picked from commit ac12486714b48f9bd5d9167f90b77c936751d6ef) --- configure |2 +- libavcodec/Makefile|2 +- libavcodec/vaapi_encode_h265.c | 1536 +++---

[FFmpeg-devel] [PATCH 18/20] vaapi_h265: Add support for AUD NAL units

2017-10-08 Thread Mark Thompson
Matching the H.264 encoder. (cherry picked from commit e3e8eab359238486dc233f7aa89b7bb3cb19ec38) --- libavcodec/vaapi_encode_h265.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index 4e

[FFmpeg-devel] [PATCH 19/20] vaapi_mpeg2: Convert to use coded bitstream infrastructure

2017-10-08 Thread Mark Thompson
(cherry picked from commit 10eb496d9ae94df6f792b0e1d8750738eb3a0952) --- configure | 2 +- libavcodec/vaapi_encode_mpeg2.c | 638 ++-- 2 files changed, 424 insertions(+), 216 deletions(-) diff --git a/configure b/configure index 2810741f

[FFmpeg-devel] [PATCH 20/20] cbs: Add some read/write tests

2017-10-08 Thread Mark Thompson
Use the appropriate metadata filter for each codec - in the absence of any options to modify the stream, the output bitstream should be identical to the input (though the output file may differ in padding). All tests use conformance bitstreams, the MPEG-2 streams are newly added from the conforman

[FFmpeg-devel] [PATCH] build: prevent SDL2 from polluting global cflags and extralibs

2017-10-08 Thread James Almer
Remove the SDL_main define from the global cflags but not from the ffplay cflags, and the -mwindows linker option from extralibs instead of overriding it with the addition of -mconsole. Signed-off-by: James Almer --- configure | 4 ++-- ffbuild/library.mak | 1 - 2 files changed, 2 ins

[FFmpeg-devel] [PATCH 08/20] lavc: Add h264_metadata bitstream filter

2017-10-08 Thread Mark Thompson
This is able to modify some header metadata found in the SPS/VUI, and can also add/remove AUDs and insert user data in SEI NAL units. (cherry picked from commit 9e93001b6135a23fe4e200196c08fb4fbffed6fc) (cherry picked from commit c42b62d1f9641f10ffc23cad9abbe47d8a4a165b) --- Updated to always add

Re: [FFmpeg-devel] [PATCH] ffmpeg: always use single threaded decoding for attached pictures

2017-10-08 Thread Marton Balint
On Fri, 6 Oct 2017, Hendrik Leppkes wrote: On Fri, Oct 6, 2017 at 10:14 PM, Marton Balint wrote: Since af1761f7b5b1b72197dc40934953b775c2d951cc ffmpeg waits for a frame in each stream before writing the output header. If we are using threaded decoding for attached pictures, we have to read ti

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Do not claim to output transparency information

2017-10-08 Thread Carl Eugen Hoyos
2017-09-28 23:20 GMT+02:00 Carl Eugen Hoyos : > I don't have decklink hardware but I assume it never outputs actual > transparency. I have applied this patch. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavc/utvideo: Use "&" instead of "&&" in expressions with "~"

2017-10-08 Thread Carl Eugen Hoyos
2017-10-08 1:58 GMT+02:00 Ronald S. Bultje : > Hi, > > On Sat, Oct 7, 2017 at 7:05 PM, Carl Eugen Hoyos wrote: > >> Hi! >> >> Attached patch silences two warnings when compiling with gcc-7: >> libavcodec/utvideodec.c:242:107: warning: ‘~’ on a boolean expression >> [-Wbool-operation] >> const

Re: [FFmpeg-devel] [PATCH] Bump major versions of all libraries

2017-10-08 Thread Ivan Kalvachev
On 9/10/17, James Almer wrote: > On 9/10/2017 2:55 PM, Ivan Kalvachev wrote: >> On 9/2/17, James Almer wrote: >> [...] >>> Notes: >>> I have no way to test what effect the removal of XVMC truly has. >>> The decoders are removed but unlike libav we have hwaccels that are not >>> removed by this. S

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-10-08 Thread Carl Eugen Hoyos
2017-10-08 1:55 GMT+02:00 Ronald S. Bultje : > Hi, > > On Sat, Oct 7, 2017 at 7:14 PM, Carl Eugen Hoyos wrote: > >> 2017-05-05 1:32 GMT+02:00 Carl Eugen Hoyos : >> > Hi! >> > >> > It may be better to disable the warning. >> >> Ping, one of the two patches should be applied, >> we currently have on

[FFmpeg-devel] [PATCH]lavf/adp: Fix probe function on systems with signed char

2017-10-08 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the adp probe function, it currently fires for repeated values. I will probably apply soon, Carl Eugen From 33d39f5199bacbbbafdb9885c72c3c6898dded81 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 8 Oct 2017 23:41:14 +0200 Subject: [PATCH] lavf/adp: Fix the pr

Re: [FFmpeg-devel] [PATCH 1/2 v2] configure: disable libxcb dependent features if libxcb is not enabled

2017-10-08 Thread James Almer
On 10/4/2017 12:29 PM, James Almer wrote: > On 9/28/2017 7:56 PM, James Almer wrote: >> Signed-off-by: James Almer >> --- >> configure | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/configure b/configure >> index c2f5fc2c98..ebcf48de20 100755 >> --- a/configure >> +++ b/configure >

Re: [FFmpeg-devel] [PATCH]lavf/amr: Add amrnb and amrwb demuxers

2017-10-08 Thread Carl Eugen Hoyos
2017-10-07 16:51 GMT+02:00 Carl Eugen Hoyos : > 2017-10-01 18:23 GMT+02:00 Carl Eugen Hoyos : >> 2017-09-27 18:08 GMT+02:00 Carl Eugen Hoyos : >> >>> The existing amr demuxer does not allow reading streams, >>> it requires the 3GPP-conforming file header. >>> Attached patch allows reading amrnb and

[FFmpeg-devel] [PATCH] Fix visual glitch with XvMC, caused by wrong idct permutation.

2017-10-08 Thread Ivan Kalvachev
In the past XvMC forced simple_idct since it was using FF_IDCT_PERM_NONE. However now we have SIMD variants of simple_idct that are using FF_IDCT_PERM_TRANSPOSE and if they are selected XvMC would get coefficients in the wrong order. The patch creates new FF_IDCT_NONE that is used only for this ki

Re: [FFmpeg-devel] [FFmpeg-cvslog] configure: Disable -Wbool-operation.

2017-10-08 Thread Mark Thompson
On 08/10/17 22:08, Carl Eugen Hoyos wrote: > ffmpeg | branch: master | Carl Eugen Hoyos | Sun Oct 8 > 23:08:09 2017 +0200| [c2d155e11ee5ec732d471982f2dee43703bcd5a7] | committer: > Carl Eugen Hoyos > > configure: Disable -Wbool-operation. > > Requested-by: Ronald and Derek > >> http://git.vi

Re: [FFmpeg-devel] [FFmpeg-cvslog] configure: Disable -Wbool-operation.

2017-10-08 Thread Carl Eugen Hoyos
2017-10-09 1:26 GMT+02:00 Mark Thompson : > On 08/10/17 22:08, Carl Eugen Hoyos wrote: >> ffmpeg | branch: master | Carl Eugen Hoyos | Sun Oct 8 >> 23:08:09 2017 +0200| [c2d155e11ee5ec732d471982f2dee43703bcd5a7] | committer: >> Carl Eugen Hoyos >> >> configure: Disable -Wbool-operation. >> >> R

Re: [FFmpeg-devel] [FFmpeg-cvslog] configure: Disable -Wbool-operation.

2017-10-08 Thread Mark Thompson
On 09/10/17 00:34, Carl Eugen Hoyos wrote: > 2017-10-09 1:26 GMT+02:00 Mark Thompson : >> On 08/10/17 22:08, Carl Eugen Hoyos wrote: >>> ffmpeg | branch: master | Carl Eugen Hoyos | Sun Oct >>> 8 23:08:09 2017 +0200| [c2d155e11ee5ec732d471982f2dee43703bcd5a7] | >>> committer: Carl Eugen Hoyos >

[FFmpeg-devel] [PATCH] Fix crash if av_vdpau_bind_context() is not used.

2017-10-08 Thread Ivan Kalvachev
The public functions av_alloc_vdpaucontext() and av_vdpau_alloc_context() are allocating AVVDPAUContext structure that is supposed to be placed in avctx->hwaccel_context. However the rest of libavcodec/vdpau.c uses avctx->hwaccel_context as struct VDPAUHWContext, that is bigger and does contain AV

Re: [FFmpeg-devel] [FFmpeg-cvslog] configure: Disable -Wbool-operation.

2017-10-08 Thread James Almer
On 10/8/2017 9:02 PM, Mark Thompson wrote: > On 09/10/17 00:34, Carl Eugen Hoyos wrote: >> 2017-10-09 1:26 GMT+02:00 Mark Thompson : >>> On 08/10/17 22:08, Carl Eugen Hoyos wrote: ffmpeg | branch: master | Carl Eugen Hoyos | Sun Oct 8 23:08:09 2017 +0200| [c2d155e11ee5ec732d471982f2dee

Re: [FFmpeg-devel] [PATCH] Fix visual glitch with XvMC, caused by wrong idct permutation.

2017-10-08 Thread Ronald S. Bultje
Hi, On Sun, Oct 8, 2017 at 6:52 PM, Ivan Kalvachev wrote: [..] Indentation is off in the second hunk, can you fix that? Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] configure: Disable -Wbool-operation.

2017-10-08 Thread Carl Eugen Hoyos
2017-10-09 2:02 GMT+02:00 James Almer : > On 10/8/2017 9:02 PM, Mark Thompson wrote: >> On 09/10/17 00:34, Carl Eugen Hoyos wrote: >>> 2017-10-09 1:26 GMT+02:00 Mark Thompson : On 08/10/17 22:08, Carl Eugen Hoyos wrote: > ffmpeg | branch: master | Carl Eugen Hoyos | Sun Oct > 8 23:0

[FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4videodec: Use 64 bit intermediates for sprite delta

2017-10-08 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: -104713 * 65536 cannot be represented in type 'int' Fixes: 3453/clusterfuzz-testcase-minimized-554657239040 Fixes: 3528/clusterfuzz-testcase-minimized-6283628420005888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/

[FFmpeg-devel] [PATCH 3/3] avcodec/dirac_dwt: Fix integer overflow in COMPOSE_53iL0()

2017-10-08 Thread Michael Niedermayer
Fixes: runtime error: signed integer overflow: 2147483646 + 2 cannot be represented in type 'int' Fixes: 3485/clusterfuzz-testcase-minimized-4940429332054016 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --

[FFmpeg-devel] [PATCH 2/3] avcodec/mpeg_er: Clear mcsel in mpeg_er_decode_mb()

2017-10-08 Thread Michael Niedermayer
Fixes out of array read Should fix: 3516/clusterfuzz-testcase-minimized-4608518562775040 (not reprodoceable) Found-by: Insu Yun, Georgia Tech. Signed-off-by: Michael Niedermayer --- libavcodec/mpeg_er.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mpeg_er.c b/libavcodec/mpeg_e

Re: [FFmpeg-devel] [PATCH]lavf/adp: Fix probe function on systems with signed char

2017-10-08 Thread Carl Eugen Hoyos
2017-10-08 23:42 GMT+02:00 Carl Eugen Hoyos : > Hi! > > Attached patch fixes the adp probe function, it currently fires for > repeated values. Pushed, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH V2 2/2] lavc/vaapi_decode: fix profile search when disable exact profile match.

2017-10-08 Thread Jun Zhao
On 2017/10/1 23:47, Mark Thompson wrote: > On 29/09/17 02:58, Jun Zhao wrote: >> From 94604d623de1fec6f363dcda4d61712865257a0a Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Thu, 21 Sep 2017 02:44:42 -0400 >> Subject: [PATCH V2 2/2] lavc/vaapi_decode: fix profile search when disable >> exa

Re: [FFmpeg-devel] [PATCH V2 1/2] ffmpeg: re-enable hwaccel_lax_profile_check use hwaccel_flags.

2017-10-08 Thread Jun Zhao
On 2017/10/1 23:20, Mark Thompson wrote: > On 29/09/17 02:58, Jun Zhao wrote: >> From e2a7cce88d2a47c7e598b59d24258fea8d809c22 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Thu, 21 Sep 2017 02:41:29 -0400 >> Subject: [PATCH V2 1/2] ffmpeg: re-enable hwaccel_lax_profile_check use >> hwacce

[FFmpeg-devel] [PATCH] doc/filters: Add note on Flite thread safety and update URL

2017-10-08 Thread Gyan Doshi
Version 2 of Flite, a speech synthesis library, was released towards the end of 2014. Among the notes at the project site: "Thread safe (really this time)". Docs and project URL updated accordingly. From 8f0de211aaa9e100cbec2b12b4a1668541a76217 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: M

[FFmpeg-devel] [PATCH] avcodec/mips: preload data in hevc sao edge 135 degree filter msa functions

2017-10-08 Thread kaustubh.raste
From: Kaustubh Raste Signed-off-by: Kaustubh Raste --- libavcodec/mips/hevc_lpf_sao_msa.c | 194 1 file changed, 132 insertions(+), 62 deletions(-) diff --git a/libavcodec/mips/hevc_lpf_sao_msa.c b/libavcodec/mips/hevc_lpf_sao_msa.c index c192265..5b5537a