On 08/10/17 16:51, Derek Buitenhuis wrote: > On 10/8/2017 4:11 PM, Mark Thompson wrote: >> The message callbacks are library-safe in libva2, so we can now use >> them. Also factorise out the common connection code to avoid >> duplicating this change. >> --- >> libavutil/hwcontext_vaapi.c | 74 >> +++++++++++++++++++++++++++------------------ >> 1 file changed, 45 insertions(+), 29 deletions(-) > > Would have preferred these be two separate patches, but I also don't > have strong feelings about it.
Easy enough to do. Split as: """ hwcontext_vaapi: Factorise out common connection code This was duplicated between normal device creation and creation by derivation from a DRM device. """ and """ hwcontext_vaapi: Set message callbacks on internally-created devices The message callbacks are library-safe in libva2, so we can now use them. """ with the obvious change. Thanks, - Mark _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
