Re: [FFmpeg-devel] [PATCH 1/3] avcodec/takdec: Fix integer overflows in decode_subframe()

2017-09-24 Thread Michael Niedermayer
On Fri, Sep 22, 2017 at 08:45:26PM +0200, Michael Niedermayer wrote: > Fixes: runtime error: signed integer overflow: -1562477869 + -691460395 > cannot be represented in type 'int' > Fixes: 3196/clusterfuzz-testcase-minimized-4528307146063872 > > Found-by: continuous fuzzing process > https://gi

Re: [FFmpeg-devel] [PATCH] fate/fits: add missing png & gif dependencies

2017-09-24 Thread Michael Niedermayer
On Sat, Sep 16, 2017 at 03:24:07AM +0530, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > tests/fate/demux.mak | 2 +- > tests/fate/fits.mak | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) will apply thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF13

Re: [FFmpeg-devel] fate/hapdec : add test for hap alpha only

2017-09-24 Thread Michael Niedermayer
On Sat, Sep 23, 2017 at 09:53:45PM +0200, Martin Vignali wrote: > Hello, > > sample can be found here : > https://we.tl/cP0pW9IfBJ > > and need to be put inside ./fate-suite/hap uploaded [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Rewriting code that is p

Re: [FFmpeg-devel] [PATCH 5/5] lavd: Add KMS frame grabber

2017-09-24 Thread Andy Furniss
Mark Thompson wrote: On 20/09/17 17:10, Andy Furniss wrote: Mark Thompson wrote: On 19/09/17 22:21, Andy Furniss wrote: That point being around 7k frames it will run out of something. [AVHWFramesContext @ 0x31ed880] Failed to create surface from DRM object: 2 (resource allocation failed).

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread pkv.stream
Hi atomnuker and others I am interested in working on this patch by atomnuker who did a great job. This could allow encoding to more channels with aac (e.g. ambisonics order three = 16 audio channels). Here's a report about additions I made to the PCE table for all the basic ffmpeg channel l

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread pkv.stream
link to original thread: http://ffmpeg.org/pipermail/ffmpeg-devel/2016-October/200566.html ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/libopenmpt: Query duration and metadata after selecting subsong

2017-09-24 Thread Jörn Heusipp
On 09/17/2017 03:35 PM, Jörn Heusipp wrote: Duration depends on the selected subsong and thus must be queried after selecting the subsong. There is no compelling reason to query other metadata earlier either. Signed-off-by: Jörn Heusipp --- ping? _

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread Rostislav Pehlivanov
On 24 September 2017 at 15:27, pkv.stream wrote: > Hi atomnuker and others > > I am interested in working on this patch by atomnuker who did a great job. > > This could allow encoding to more channels with aac (e.g. ambisonics order > three = 16 audio channels). > > Here's a report about addition

Re: [FFmpeg-devel] [PATCH] aacenc: WIP support for PCEs

2017-09-24 Thread pkv.stream
Le 24/09/2017 à 5:06 PM, Rostislav Pehlivanov a écrit : On 24 September 2017 at 15:27, pkv.stream wrote: Hi atomnuker and others I am interested in working on this patch by atomnuker who did a great job. This could allow encoding to more channels with aac (e.g. ambisonics order three = 16 a

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-24 Thread Michael Niedermayer
On Sat, Sep 23, 2017 at 09:52:50PM +0200, Martin Vignali wrote: > Sorry, i made a mistake in the previous patchs > > Correct patchs in attach will apply thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purch

Re: [FFmpeg-devel] [PATCH 1/2] movenc: Add an option for enabling negative CTS offsets

2017-09-24 Thread Michael Niedermayer
On Sat, Sep 23, 2017 at 06:44:44PM +0300, Jan Ekström wrote: > From: Martin Storsjö > > This reduces the need for an edit list; streams that start with > e.g. dts=-1, pts=0 can be encoded as dts=0, pts=0 (which is valid > in mov/mp4) by shifting the dts values of all packets forward. > This avoid

[FFmpeg-devel] [PATCH v2] avcodec/hevc_sei: Support HEVC paired fields.

2017-09-24 Thread Brian Matherly
From: Brian Matherly Correctly set the interlaced_frame and top_field_first fields when pic_struct indicates paired fields. --- libavcodec/hevc_sei.c | 4 +- tests/fate/hevc.mak | 3 + tests/ref/fate/hevc-paired-fields | 120 ++ 3

[FFmpeg-devel] [PATCH v2] avcodec/hevc_sei: Support HEVC paired fields.

2017-09-24 Thread Brian Matherly
From: Brian Matherly Correctly set the interlaced_frame and top_field_first fields when pic_struct indicates paired fields. --- libavcodec/hevc_sei.c | 4 +- tests/fate/hevc.mak | 3 + tests/ref/fate/hevc-paired-fields | 120 ++ 3

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_sei: Support HEVC paired fields.

2017-09-24 Thread Brian Matherly
On 9/23/2017 5:22 PM, Michael Niedermayer wrote: On Thu, Sep 14, 2017 at 08:39:19PM -0500, Brian Matherly wrote: Correctly set frame.interlaced and frame.top_field_first when pic_struct indicates paired fields. Do you have a (small) sample that gets fixed by this ? Can you make a fate test for

[FFmpeg-devel] libavcodec/hapdec : add support for hapqa decoding

2017-09-24 Thread Martin Vignali
Hello, In attach two patchs to add support for hapqa alpha decoding More info can be found here https://github.com/Vidvox/hap/blob/master/documentation/HapVideoDRAFT.md Part 1 : 0006-libavodec-texturedsp-add-rgtc1u_alpha-uncompress-fun add a new func into texture dsp, in order to decompress rgtc

[FFmpeg-devel] fate/hapdec : add test for hapqa decoding

2017-09-24 Thread Martin Vignali
Hello, sample can be found here: https://we.tl/g7YFdpri1P and need to be put inside ./fate-suite/hap These files test the 3 main mode of HAPQA - No snappy compression for both texture - Snappy 1 chunk for both texture - Snappy 16 chunks for both texture The CRC is the same, because the source p

Re: [FFmpeg-devel] fate/cineform : add test for yuv 10b

2017-09-24 Thread Martin Vignali
2017-08-28 17:52 GMT+02:00 Martin Vignali : > > > 2017-03-26 1:17 GMT+01:00 Michael Niedermayer : > >> On Sat, Mar 25, 2017 at 02:04:03PM +0100, Martin Vignali wrote: >> > Hello, >> > >> > In attach patch to add fate test for cineform decoder >> > >> > Sample can be found here : >> > https://we.tl

Re: [FFmpeg-devel] libavcodec/hapdec : add support for HapAphaOnly decoding

2017-09-24 Thread Carl Eugen Hoyos
2017-09-23 21:49 GMT+02:00 Martin Vignali : > Following this doc : > https://github.com/Vidvox/hap/blob/master/documentation/HapVideoDRAFT.md > > Hap Alpha Only, is only an rgtc1 texture with or without > snappy compression Sorry if I misunderstand: If the format only contains one layer, why is t

Re: [FFmpeg-devel] fate/cineform : add test for yuv 10b

2017-09-24 Thread Carl Eugen Hoyos
2017-03-25 14:04 GMT+01:00 Martin Vignali : > In attach patch to add fate test for cineform decoder > > Sample can be found here : > https://we.tl/y06cKrKh3a Looking at #6675, the sample may not be ideal. But we can of course have more than one sample for cineform... Carl Eugen

Re: [FFmpeg-devel] fate/cineform : add test for yuv 10b

2017-09-24 Thread Michael Niedermayer
On Mon, Sep 25, 2017 at 12:10:25AM +0200, Carl Eugen Hoyos wrote: > 2017-03-25 14:04 GMT+01:00 Martin Vignali : > > > In attach patch to add fate test for cineform decoder > > > > Sample can be found here : > > https://we.tl/y06cKrKh3a > > Looking at #6675, the sample may not be ideal. if the sa

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-24 Thread Carl Eugen Hoyos
2017-09-23 3:14 GMT+02:00 James Almer : > On 9/22/2017 10:01 PM, Michael Niedermayer wrote: >> +if((ret = ff_rate_control_init(&s->m)) < 0) >> +return ret; > > ret = foo(); > if (ret < 0) > return ret; > > No more combined assignment and comparisons for > new code if possib

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-24 Thread James Almer
On 9/24/2017 8:06 PM, Carl Eugen Hoyos wrote: > 2017-09-23 3:14 GMT+02:00 James Almer : >> On 9/22/2017 10:01 PM, Michael Niedermayer wrote: > >>> +if((ret = ff_rate_control_init(&s->m)) < 0) >>> +return ret; >> >> ret = foo(); >> if (ret < 0) >> return ret; >> >> No more c

Re: [FFmpeg-devel] libavcodec/hapenc : add support for hap alpha only encoding

2017-09-24 Thread Carl Eugen Hoyos
2017-09-23 23:41 GMT+02:00 Martin Vignali : > In attach patch for Hap Alpha encoding Same question as before: How can 24bit input be encoded into alpha? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/snowenc: Replace "return -1" by named constants

2017-09-24 Thread Carl Eugen Hoyos
2017-09-25 1:16 GMT+02:00 James Almer : > On 9/24/2017 8:06 PM, Carl Eugen Hoyos wrote: >> 2017-09-23 3:14 GMT+02:00 James Almer : >>> On 9/22/2017 10:01 PM, Michael Niedermayer wrote: >> +if((ret = ff_rate_control_init(&s->m)) < 0) +return ret; >>> >>> ret = foo(); >>

Re: [FFmpeg-devel] [PATCH] swscale_unscaled: fix DITHER_COPY macro, use it only for dst_depth == 8

2017-09-24 Thread Carl Eugen Hoyos
2017-09-23 19:18 GMT+02:00 Mateusz : > In reality -- current version of DITHER_COPY mess > up the average color tone. You could explain how we can reproduce this. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailma

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevc_sei: Support HEVC paired fields.

2017-09-24 Thread Michael Niedermayer
On Sun, Sep 24, 2017 at 02:36:55PM -0500, Brian Matherly wrote: > From: Brian Matherly > > Correctly set the interlaced_frame and top_field_first fields when pic_struct > indicates paired fields. > --- > libavcodec/hevc_sei.c | 4 +- > tests/fate/hevc.mak | 3 + > t

[FFmpeg-devel] [PATCH 1/4] avcodec/avpacket: add av_packet_copy_side_data()

2017-09-24 Thread James Almer
It's added as a replacemet of av_copy_packet_side_data() using the proper av_packet_* namespace, and differs from it in the following ways: - Side data already allocated and copied is properly freed in case of failure. - The dst packet is unchanged in case of failure instead of being unreffed. Si

[FFmpeg-devel] [PATCH 3/4] avformat/movenc: replace use of av_copy_packet_side_data()

2017-09-24 Thread James Almer
Signed-off-by: James Almer --- libavformat/movenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index aa0b60c345..0e98b93b2c 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -449,7 +449,8 @@ concatenate:

[FFmpeg-devel] [PATCH 2/4] avcodec/avpacket: use av_packet_copy_side_data() in av_packet_copy_props()

2017-09-24 Thread James Almer
The side data array in av_packet_copy_side_data() is not reallocated every time a new element is added, unlike when calling av_packet_new_side_data() in a loop. Signed-off-by: James Almer --- libavcodec/avpacket.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff -

[FFmpeg-devel] [PATCH 4/4] ffmpeg: replace use of av_copy_packet_side_data()

2017-09-24 Thread James Almer
Signed-off-by: James Almer --- ffmpeg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg.c b/ffmpeg.c index 1d248bc269..a3ea4c84a6 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -2077,7 +2077,7 @@ static void do_streamcopy(InputStream *ist, OutputStream *ost, const AVPacket *p

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/scale: More descriptive in/ref/out logging

2017-09-24 Thread Kevin Mark
Hi Ronald, On Sat, Sep 23, 2017 at 11:54 AM, Ronald S. Bultje wrote: > > Yes, -E works on Mac. Thanks! Are there any remaining blockers for a potential merge? Best regards, Kevin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/videotoolbox: fix decoding of some h264 bitstreams

2017-09-24 Thread Aman Gupta
On Thu, Oct 1, 2015 at 9:54 AM, wm4 wrote: > On Thu, 1 Oct 2015 18:45:40 +0200 > Hendrik Leppkes wrote: > > > On Thu, Oct 1, 2015 at 6:39 PM, wm4 wrote: > > > On Thu, 1 Oct 2015 18:29:00 +0200 > > > Hendrik Leppkes wrote: > > > > > >> On Thu, Oct 1, 2015 at 6:13 PM, wm4 wrote: > > >> > This a

[FFmpeg-devel] [PATCH v3] avcodec/hevc_sei: Support HEVC paired fields.

2017-09-24 Thread Brian Matherly
From: Brian Matherly Correctly set the interlaced_frame and top_field_first fields when pic_struct indicates paired fields. --- libavcodec/hevc_sei.c | 4 +- tests/fate/hevc.mak | 6 +- tests/ref/fate/hevc-paired-fields | 120 ++