2017-09-23 3:14 GMT+02:00 James Almer <jamr...@gmail.com>: > On 9/22/2017 10:01 PM, Michael Niedermayer wrote:
>> + if((ret = ff_rate_control_init(&s->m)) < 0) >> + return ret; > > ret = foo(); > if (ret < 0) > return ret; > > No more combined assignment and comparisons for > new code if possible. It's too prone to mistakes. This comment looks strange given today's patches from you. Carl Eugen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
