Re: [FFmpeg-devel] [PATCH 1/6] avcodec/vorbisenc: Add pre-echo detection

2017-08-23 Thread Tomas Härdin
On 2017-08-22 03:23, Tyler Jones wrote: + +/** + * Calculate the variance of a block of samples + * + * @param in Array of input samples + * @param length Number of input samples being analyzed + * @return The variance for the current block + */ +static float variance(const float *in, i

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/vorbisenc: Apply dynamic frame lengths

2017-08-23 Thread Tomas Härdin
On 2017-08-22 03:23, Tyler Jones wrote: +static int create_residues(vorbis_enc_context *venc) +{ +int res, ret; +vorbis_enc_residue *rc; + +venc->nresidues = 2; +venc->residues = av_malloc(sizeof(vorbis_enc_residue) * venc->nresidues); av_malloc_array()? Applies to most av_mall

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-23 Thread wm4
On Mon, 21 Aug 2017 19:51:56 +0200 wm4 wrote: > From: Pedro Pombeiro > > DLL data imports cause problems on Windows. They normally require > each variable to be correctly marked with dllimport/dllexport > declspecs. For MSVC, we define av_export to dllimport declspec. This > is not entirely cor

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-23 Thread Nicolas George
Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : > You completely ignored and removed other aspects of my reply. You still are being vague. > Something special, like one can control both audio and video aspect at > once and provide same info to output. On the usability / convenience questi

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-23 Thread Paul B Mahol
On 8/23/17, Nicolas George wrote: > Le duodi 2 fructidor, an CCXXV, Paul B Mahol a écrit : >> You completely ignored and removed other aspects of my reply. > > You still are being vague. > >> Something special, like one can control both audio and video aspect at >> once and provide same info to ou

Re: [FFmpeg-devel] [PATCH V3 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

2017-08-23 Thread Jun Zhao
On 2017/8/21 1:16, Mark Thompson wrote: > On 18/08/17 03:14, Jun Zhao wrote: >> From 64c53df3134c0b478d212f141e6dbe4c3743b3c6 Mon Sep 17 00:00:00 2001 >> From: Jun Zhao >> Date: Tue, 1 Aug 2017 23:05:44 -0400 >> Subject: [PATCH V3 3/4] lavc/vaapi_encode_h264: respect "slices" option in >> h264

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2017-08-23 Thread Nicolas George
Le sextidi 6 fructidor, an CCXXV, Paul B Mahol a écrit : > I was asked multiple times to implement this filter. I was not referring to the advice of single users with a tunnel vision of their own use case. > What framework? There is only framework for video source filter which > outputs static fr

[FFmpeg-devel] [PATCH V4 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

2017-08-23 Thread Jun Zhao
From 8795c55762da131ae29554290c1c352eab092580 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 1 Aug 2017 23:05:44 -0400 Subject: [PATCH V4 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder Enable multi-slice support in AVC/H.264 vaapi encoder. Signed-off-by: Wang, Y

[FFmpeg-devel] [PATCH V4 1/4] lavc/vaapi_encode: Change the slice/parameter buffers to dynamic alloc.

2017-08-23 Thread Jun Zhao
V4: - Change the array malloc function.     - Clean the pointless condition check when free the memory.       Patch 2/4, 3/4, 4/4 same as V3.  V3: - Making pic->slices be VAAPIEncodeSlice* instead of VAAPIEncodeSlice**. - Fix resource (vaBuffer) lead when realloc pic->param_buffers fail. -

[FFmpeg-devel] [PATCH V4 2/4] lavc/vaapi_encode: Add max slices number query.

2017-08-23 Thread Jun Zhao
From 4cac77cf990e91fececaf3dc5bffe606fcdae17c Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 1 Aug 2017 04:16:30 -0400 Subject: [PATCH V4 2/4] lavc/vaapi_encode: Add max slices number query. Add max slices number query. Signed-off-by: Jun Zhao --- libavcodec/vaapi_encode.c | 4 libav

[FFmpeg-devel] [PATCH V4 4/4] lavc/vaapi_encode_h265: respect "slices" option in h265 vaapi encoder

2017-08-23 Thread Jun Zhao
From dae9051c0828f7c86417308d06f1deb0640534bc Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 1 Aug 2017 23:07:34 -0400 Subject: [PATCH V4 4/4] lavc/vaapi_encode_h265: respect "slices" option in h265 vaapi encoder Enable multi-slice support in AVC/H.265 vaapi encoder. Signed-off-by: Wang, Y

Re: [FFmpeg-devel] [PATCH V4 4/4] lavc/vaapi_encode_h265: respect "slices" option in h265 vaapi encoder

2017-08-23 Thread Steven Liu
2017-08-23 18:34 GMT+08:00 Jun Zhao : > >From dae9051c0828f7c86417308d06f1deb0640534bc Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 1 Aug 2017 23:07:34 -0400 Subject: [PATCH V4 4/4] lavc/vaapi_encode_h265: respect "slices" option in h265 vaapi encoder Enable multi-slice support in AVC/H.26

[FFmpeg-devel] [PATCH]lsws/rgb2rgb: Add unscaled 48 to 64bit conversion

2017-08-23 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #6608. Please comment, Carl Eugen From 4f8a1de3f216bdb2571e43dcb64a9376aa08ceae Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 23 Aug 2017 14:19:14 +0200 Subject: [PATCH] lsws/rgb2rgb: Add unscale 48bit to 64bit rgb conversion. Fixes ticket #6608. ---

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-23 Thread Ronald S. Bultje
Hi, I would also recommend to split out the changes to add the mainfunc-aware slice threading implementation (execute3) into pthread_slice.c into its own patch, that way others can review that without being obstructed by the vp9 bits. On Tue, Aug 22, 2017 at 7:59 PM, Ilia Valiakhmetov wrote: >

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-23 Thread Ronald S. Bultje
Hi, now for review of the vp9-specific bits. On Tue, Aug 22, 2017 at 7:59 PM, Ilia Valiakhmetov wrote: > +lflvl_len*sizeof(*s->lflvl) + 16 * > sizeof(*s->above_mv_ctx))); > lflvl_len * sizeof (space). > -// these will be re-allocated a little later > -

[FFmpeg-devel] [PATCH] mjpeg: Add support for ICC side data

2017-08-23 Thread Derek Buitenhuis
JPEGs store embedded profiles under the APP2 marker, signified with a "ICC_PROFILE" null-terminated string header, and can be split across multiple APP2 markers, out of order. This patch currently assumes one single ICC profile for the whole context, i.e. a single JPEG input file. This likely does

[FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-23 Thread pkv.stream
Hello, the following patch allows one to add a trailing ? to -map_channel as in -map option. E.g: -map_channel 0.0.2? so that if the channel does not exist, the command does not stop. This is similar to what one can do with -map. Thanks for any input. From 07959dfe79816d03c30b8027f45b41d

[FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

2017-08-23 Thread pkv.stream
Hello the following patch extends number of output channel for decklink devices to 16. Previously it was limited to 2 or 8 audio channels. Thanks for any comments. From 681e389e4946e079d7db5892f98a82a5b75ad297 Mon Sep 17 00:00:00 2001 From: pkviet Date: Sun, 2 Jul 2017 23:50:56 +0200 Subjec

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

2017-08-23 Thread wm4
On Wed, 23 Aug 2017 18:51:45 +0200 "pkv.stream" wrote: > Hello > > the following patch extends number of output channel for decklink > devices to 16. Previously it was limited to 2 or 8 audio channels. > > Thanks for any comments. > > What channel layouts do configurations with channels 9 t

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

2017-08-23 Thread pkv.stream
Le 23/08/2017 à 7:28 PM, wm4 a écrit : On Wed, 23 Aug 2017 18:51:45 +0200 "pkv.stream" wrote: Hello the following patch extends number of output channel for decklink devices to 16. Previously it was limited to 2 or 8 audio channels. Thanks for any comments. What channel layouts do configu

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

2017-08-23 Thread Kieran Kunhya
On Wed, 23 Aug 2017, 18:28 wm4 wrote: > On Wed, 23 Aug 2017 18:51:45 +0200 > "pkv.stream" wrote: > > > Hello > > > > the following patch extends number of output channel for decklink > > devices to 16. Previously it was limited to 2 or 8 audio channels. > > > > Thanks for any comments. > > > > >

[FFmpeg-devel] [PATCH] avfilter: Add vmaf filter

2017-08-23 Thread Ashish Pratap Singh
From: Ashish Singh Hi, this is vmaf filter. It fuses the scores of previous metrics adm, motion and vif using svm algorithm. It's different from libvmaf filter because it has a very little external dependency (only one svm model file). Currently it supports only one model which can be extended

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pngdec: Fix () placement

2017-08-23 Thread Alexander Strasser
On 2017-08-22 17:23 +, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Tue > Aug 22 18:36:26 2017 +0200| [a2e444d5bb2e3115d3afcc0cca9d1506c90436a2] | > committer: Michael Niedermayer > > avcodec/pngdec: Fix () placement > > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

2017-08-23 Thread Matthias Hunstock
Am 23.08.2017 um 19:28 schrieb wm4: > What channel layouts do configurations with channels 9 to 16 use? There is no concept like stream or track in SDI. It just has 16 mono channels without any semantics which are arbitrarily mapped to whatever you need to transport. @pkv.stream: HDMI 1.x does o

[FFmpeg-devel] [PATCH] avformat/rtpdec_h264: Fix heap-buffer-overflow

2017-08-23 Thread Michael Niedermayer
Fixes: rtp_sdp/poc.sdp Found-by: Bingchang Signed-off-by: Michael Niedermayer --- libavformat/rtpdec_h264.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index 8dd56a549e..6f8148ab6d 100644 --- a/libavformat/rtpdec_h264

Re: [FFmpeg-devel] [PATCH] libavdevice/decklink: enable 16 output channel

2017-08-23 Thread pkv.stream
Le 23/08/2017 à 10:32 PM, Matthias Hunstock a écrit : Am 23.08.2017 um 19:28 schrieb wm4: What channel layouts do configurations with channels 9 to 16 use? There is no concept like stream or track in SDI. It just has 16 mono channels without any semantics which are arbitrarily mapped to whateve

Re: [FFmpeg-devel] [PATCH] all: avoid data imports across DLL boundaries

2017-08-23 Thread James Almer
On 8/21/2017 2:51 PM, wm4 wrote: > From: Pedro Pombeiro > > DLL data imports cause problems on Windows. They normally require > each variable to be correctly marked with dllimport/dllexport > declspecs. For MSVC, we define av_export to dllimport declspec. This > is not entirely correct - dependin

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-23 Thread Dale Curtis
On Sat, Aug 19, 2017 at 3:50 PM, Michael Niedermayer wrote: > On Sun, Aug 20, 2017 at 12:48:30AM +0200, Michael Niedermayer wrote: > > On Fri, Aug 18, 2017 at 03:57:45PM -0700, Dale Curtis wrote: > > > Anything else here? It'd be nice to get this landed soon if no one has > any > > > other commen

Re: [FFmpeg-devel] [PATCH 2/2] fate: add test vector aac-al04sf_48

2017-08-23 Thread Michael Niedermayer
On Tue, Aug 22, 2017 at 07:25:15PM -0700, Alex Converse wrote: > On Tue, Aug 22, 2017 at 3:23 PM, Michael Niedermayer > wrote: > > On Mon, Aug 21, 2017 at 04:22:15PM -0700, Alex Converse wrote: > >> --- > >> tests/fate/aac.mak | 4 > >> 1 file changed, 4 insertions(+) > > > > where can i fin

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: Add tile threading support

2017-08-23 Thread Ronald S. Bultje
Hi, On Tue, Aug 22, 2017 at 7:59 PM, Ilia Valiakhmetov wrote: > +if (s->td) > +av_free(s->td); > + > +s->td = av_mallocz_array(s->s.h.tiling.tile_cols, > sizeof(VP9TileData)); The free() leaks s->td[*].b/block_base if they were already allocated. Ronald ___

Re: [FFmpeg-devel] [PATCH] avfilter: Add vmaf filter

2017-08-23 Thread Michael Niedermayer
On Thu, Aug 24, 2017 at 12:58:53AM +0530, Ashish Pratap Singh wrote: > From: Ashish Singh > > Hi, this is vmaf filter. It fuses the scores of previous metrics adm, motion > and vif > using svm algorithm. It's different from libvmaf filter because it has a very > little > external dependency (on

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/vorbisenc: Apply dynamic frame lengths

2017-08-23 Thread Tyler Jones
On Wed, Aug 23, 2017 at 10:31:58AM +0200, Tomas Härdin wrote: > On 2017-08-22 03:23, Tyler Jones wrote: > > +static int create_residues(vorbis_enc_context *venc) > > +{ > > +int res, ret; > > +vorbis_enc_residue *rc; > > + > > +venc->nresidues = 2; > > +venc->residues = av_malloc(s

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/vorbisenc: Add pre-echo detection

2017-08-23 Thread Tyler Jones
On Wed, Aug 23, 2017 at 10:11:50AM +0200, Tomas Härdin wrote: > On 2017-08-22 03:23, Tyler Jones wrote: > > + > > +/** > > + * Calculate the variance of a block of samples > > + * > > + * @param in Array of input samples > > + * @param length Number of input samples being analyzed > > + * @retu

Re: [FFmpeg-devel] [PATCH V4 4/4] lavc/vaapi_encode_h265: respect "slices" option in h265 vaapi encoder

2017-08-23 Thread Jun Zhao
On 2017/8/23 19:12, Steven Liu wrote: > 2017-08-23 18:34 GMT+08:00 Jun Zhao : > >From dae9051c0828f7c86417308d06f1deb0640534bc Mon Sep 17 00:00:00 2001 > From: Jun Zhao > Date: Tue, 1 Aug 2017 23:07:34 -0400 > Subject: [PATCH V4 4/4] lavc/vaapi_encode_h265: respect "slices" option in > h265 vaa

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-23 Thread Michael Niedermayer
On Mon, Aug 07, 2017 at 12:32:16PM -0700, Dale Curtis wrote: > On Fri, Aug 4, 2017 at 4:38 PM, Michael Niedermayer > wrote: > > > so theres no easy way to create a smaller file then 64mb ? > > > > Ah no, I didn't realize you had a size limit; I just meant none of the > existing clips were large

Re: [FFmpeg-devel] [PATCH] mjpeg: Add support for ICC side data

2017-08-23 Thread Michael Niedermayer
On Wed, Aug 23, 2017 at 05:12:34PM +0100, Derek Buitenhuis wrote: > JPEGs store embedded profiles under the APP2 marker, signified > with a "ICC_PROFILE" null-terminated string header, and can be > split across multiple APP2 markers, out of order. > > This patch currently assumes one single ICC pr

Re: [FFmpeg-devel] [PATCH]lsws/rgb2rgb: Add unscaled 48 to 64bit conversion

2017-08-23 Thread Michael Niedermayer
On Wed, Aug 23, 2017 at 02:21:40PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #6608. iam not sure thats the correct fix for the ticket but the patch is a good idea none the less thus LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0F

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-23 Thread Michael Niedermayer
On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: > Hello, > > the following patch allows one to add a trailing ? to -map_channel > as in -map option. > > E.g: -map_channel 0.0.2? so that if the channel does not exist, the > command does not stop. > > This is similar to what one can do

[FFmpeg-devel] [V5 1/4] lavc/vaapi_encode: Change the slice/parameter buffers to dynamic alloc.

2017-08-23 Thread Jun Zhao
V5: - In h265_vaapi encoder, when setting slice number > max slice number   supported by driver, report error and return. Same as h264_vaapi.     - Clean the logic when setting first_slice_segment_in_pic_flags   V4: - Change the array malloc function.     - Clean the pointless condition check w

[FFmpeg-devel] [V5 4/4] lavc/vaapi_encode_h265: respect "slices" option in h265 vaapi encoder

2017-08-23 Thread Jun Zhao
From 9baf5d8b4b2a6119a8406bb52a05d4a1b67f9a3e Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 1 Aug 2017 23:07:34 -0400 Subject: [V5 4/4] lavc/vaapi_encode_h265: respect "slices" option in h265 vaapi encoder Enable multi-slice support in AVC/H.265 vaapi encoder. Signed-off-by: Wang, Yi A S

[FFmpeg-devel] [V5 2/4] lavc/vaapi_encode: Add max slices number query.

2017-08-23 Thread Jun Zhao
From 4cac77cf990e91fececaf3dc5bffe606fcdae17c Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 1 Aug 2017 04:16:30 -0400 Subject: [V5 2/4] lavc/vaapi_encode: Add max slices number query. Add max slices number query. Signed-off-by: Jun Zhao --- libavcodec/vaapi_encode.c | 4 libavcodec/

[FFmpeg-devel] [V5 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

2017-08-23 Thread Jun Zhao
From 8795c55762da131ae29554290c1c352eab092580 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 1 Aug 2017 23:05:44 -0400 Subject: [V5 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder Enable multi-slice support in AVC/H.264 vaapi encoder. Signed-off-by: Wang, Yi A S

Re: [FFmpeg-devel] [PATCH V6] lavfi/scale_vaapi: add denoise/sharpness support.

2017-08-23 Thread Jun Zhao
ping? On 2017/8/4 15:25, Jun Zhao wrote: > V6 : - Re-work with current scale_vaapi and double check i965 have fix the > sharpness issue. >https://bugs.freedesktop.org/show_bug.cgi?id=96988 > v5 : - fix the commit message as review(Mark Thompson and Moritz Barsnick) > - change the mag

Re: [FFmpeg-devel] [PATCH] avfilter: Add vmaf filter

2017-08-23 Thread Ashish Pratap Singh
On Aug 24, 2017 05:13, "Michael Niedermayer" wrote: On Thu, Aug 24, 2017 at 12:58:53AM +0530, Ashish Pratap Singh wrote: > From: Ashish Singh > > Hi, this is vmaf filter. It fuses the scores of previous metrics adm, motion and vif > using svm algorithm. It's different from libvmaf filter because

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-23 Thread Kv Pham
Ah sorry about that. I forgot about the tabs. Will correct and add update to doc. Thanks Le 24 août 2017 2:32 AM, "Michael Niedermayer" a écrit : > On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: > > Hello, > > > > the following patch allows one to add a trailing ? to -map_channel >

Re: [FFmpeg-devel] [PATCH] ffmpeg options: Enable trailing ? for map_channel

2017-08-23 Thread pkv.stream
Le 24/08/2017 à 2:30 AM, Michael Niedermayer a écrit : On Wed, Aug 23, 2017 at 06:48:14PM +0200, pkv.stream wrote: Hello, the following patch allows one to add a trailing ? to -map_channel as in -map option. E.g: -map_channel 0.0.2? so that if the channel does not exist, the command does not s

Re: [FFmpeg-devel] [PATCH] avfilter: Add vmaf filter

2017-08-23 Thread Michael Niedermayer
On Thu, Aug 24, 2017 at 07:35:41AM +0530, Ashish Pratap Singh wrote: > On Aug 24, 2017 05:13, "Michael Niedermayer" wrote: > > On Thu, Aug 24, 2017 at 12:58:53AM +0530, Ashish Pratap Singh wrote: > > From: Ashish Singh > > > > Hi, this is vmaf filter. It fuses the scores of previous metrics adm,