[FFmpeg-devel] [V5 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264 vaapi encoder

[Jun Zhao]

From 8795c55762da131ae29554290c1c352eab092580 Mon Sep 17 00:00:00 2001
From: Jun Zhao <jun.z...@intel.com>
Date: Tue, 1 Aug 2017 23:05:44 -0400
Subject: [V5 3/4] lavc/vaapi_encode_h264: respect "slices" option in h264
 vaapi encoder

Enable multi-slice support in AVC/H.264 vaapi encoder.

Signed-off-by: Wang, Yi A <yi.a.w...@intel.com>
Signed-off-by: Jun Zhao <jun.z...@intel.com>
---
 libavcodec/vaapi_encode_h264.c | 32 +++++++++++++++++++++++++++-----
 1 file changed, 27 insertions(+), 5 deletions(-)

diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c
index 90c7f7e3cc..4a9531bb13 100644
--- a/libavcodec/vaapi_encode_h264.c
+++ b/libavcodec/vaapi_encode_h264.c
@@ -141,6 +141,8 @@ typedef struct VAAPIEncodeH264Context {
     int mb_width;
     int mb_height;
 
+    int last_mb_index;
+
     int fixed_qp_idr;
     int fixed_qp_p;
     int fixed_qp_b;
@@ -953,6 +955,7 @@ static int 
vaapi_encode_h264_init_picture_params(AVCodecContext *avctx,
     VAEncPictureParameterBufferH264  *vpic = pic->codec_picture_params;
     VAAPIEncodeH264Context           *priv = ctx->priv_data;
     int i;
+    int slices;
 
     if (pic->type == PICTURE_TYPE_IDR) {
         av_assert0(pic->display_order == pic->encode_order);
@@ -998,7 +1001,19 @@ static int 
vaapi_encode_h264_init_picture_params(AVCodecContext *avctx,
     vpic->pic_fields.bits.idr_pic_flag = (pic->type == PICTURE_TYPE_IDR);
     vpic->pic_fields.bits.reference_pic_flag = (pic->type != PICTURE_TYPE_B);
 
-    pic->nb_slices = 1;
+    slices = 1;
+    if (ctx->max_slices) {
+        if (avctx->slices <= ctx->max_slices) {
+            slices = avctx->slices;
+        } else {
+            av_log(avctx, AV_LOG_ERROR, "The max slices number per frame "
+                   "cannot more than %d.\n", ctx->max_slices);
+            return AVERROR_INVALIDDATA;
+        }
+    }
+    pic->nb_slices = slices;
+
+    priv->last_mb_index = 0;
 
     return 0;
 }
@@ -1048,14 +1063,17 @@ static int 
vaapi_encode_h264_init_slice_params(AVCodecContext *avctx,
         av_assert0(0 && "invalid picture type");
     }
 
-    // Only one slice per frame.
-    vslice->macroblock_address = 0;
-    vslice->num_macroblocks = priv->mb_width * priv->mb_height;
+    vslice->macroblock_address = priv->last_mb_index;
+    vslice->num_macroblocks =
+        ((slice->index + 1) * priv->mb_width * priv->mb_height) / 
pic->nb_slices - priv->last_mb_index;
+    priv->last_mb_index += vslice->num_macroblocks;
 
     vslice->macroblock_info = VA_INVALID_ID;
 
     vslice->pic_parameter_set_id = vpic->pic_parameter_set_id;
-    vslice->idr_pic_id = priv->idr_pic_count++;
+    vslice->idr_pic_id = priv->idr_pic_count;
+    if (priv->last_mb_index == priv->mb_width * priv->mb_height)
+        priv->idr_pic_count++;
 
     vslice->pic_order_cnt_lsb = (pic->display_order - priv->last_idr_frame) &
         ((1 << (4 + vseq->seq_fields.bits.log2_max_pic_order_cnt_lsb_minus4)) 
- 1);
@@ -1140,6 +1158,10 @@ static av_cold int 
vaapi_encode_h264_configure(AVCodecContext *avctx)
     if (avctx->compression_level == FF_COMPRESSION_DEFAULT)
         avctx->compression_level = opt->quality;
 
+    if (!ctx->max_slices && avctx->slices > 0)
+        av_log(avctx, AV_LOG_WARNING, "The encode slice option is not "
+               "supported with the driver.\n");
+
     return 0;
 }
 
-- 
2.11.0


_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel