[FFmpeg-devel] [PATCH] avcodec/qsvenc_henv: add idr_interval option

From: Steven Liu user need to control the idr_interval for qsv hevc Signed-off-by: Steven Liu --- libavcodec/qsvenc_hevc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c index 7d4d55bb61..c063e27eea 100644 --- a/libavcodec/qsvenc_hevc.c

Re: [FFmpeg-devel] [PATCH v2 1/2] lavu: Add DRM hwcontext

On Thu, 6 Jul 2017 00:02:08 +0100 Mark Thompson wrote: > --- > Updated following discussion: > * Back to using nested arrays. > * Documentation improved. > * Configure option now called libdrm. > * Other minor fixups. > > > configure | 3 + > libavutil/Makefile

Re: [FFmpeg-devel] [PATCH] htmlsubtitles: support tag

On Mon, 3 Jul 2017 17:57:06 +0200 Michael Niedermayer wrote: > On Mon, Jul 03, 2017 at 01:54:50PM +0200, Clément Bœsch wrote: > > On Mon, Jul 03, 2017 at 01:43:43PM +0200, wm4 wrote: > > > Some .srt files use this tag. > > > > > > (An alternative implementation would be correctly ignoring unkn

[FFmpeg-devel] [PATCH v2] avcodec/rdft: remove sintable

It is redundant with costable. The first half of sintable is identical with the second half of costable. The second half of sintable is negative value of the first half of sintable. The computation is changed to handle sign of sin values. Signed-off-by: Muhammad Faiz --- libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH] avcodec/rdft: remove sintable

On Wed, Jul 5, 2017 at 10:22 PM, Rostislav Pehlivanov wrote: > On 5 July 2017 at 11:33, Muhammad Faiz wrote: > >> It is redundant with costable. The first half of sintable is >> identical with the second half of costable. The second half >> of sintable is negative value of the first half of sinta

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

>>In other words, it's just an example in the wiki. It's one way to do it, but >>that doesn't mean it's *the* way to do it. Building against dynamic libs is >>certainly much more common if those are (at least for the most part) provided >>by the "system" (distribution or what have you). >> >>Bot

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

On Wed, Jul 05, 2017 at 04:39:05PM +0200, wm4 wrote: > On Wed, 5 Jul 2017 16:08:38 +0200 > Michael Niedermayer wrote: > > > On Wed, Jul 05, 2017 at 09:56:10AM +0200, wm4 wrote: > > > On Tue, 4 Jul 2017 22:33:52 +0200 > > > Michael Niedermayer wrote: > > > > > > > Fixes: out of array access >

Re: [FFmpeg-devel] [PATCH] avfilter: add limiter filter

On 7/4/17, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 17 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/limiter.h | 33 ++ > libavfilter/vf_limiter.c | 228

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

On Thu, 6 Jul 2017 11:58:47 +0200 Michael Niedermayer wrote: > On Wed, Jul 05, 2017 at 04:39:05PM +0200, wm4 wrote: > > On Wed, 5 Jul 2017 16:08:38 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, Jul 05, 2017 at 09:56:10AM +0200, wm4 wrote: > > > > On Tue, 4 Jul 2017 22:33:52 +0200

Re: [FFmpeg-devel] [PATCH v2 1/2] lavu: Add DRM hwcontext

On 06/07/17 09:00, wm4 wrote: > On Thu, 6 Jul 2017 00:02:08 +0100 > Mark Thompson wrote: > >> --- >> Updated following discussion: >> * Back to using nested arrays. >> * Documentation improved. >> * Configure option now called libdrm. >> * Other minor fixups. >> >> >> configure

[FFmpeg-devel] [PATCH] avcodec/qsvenc_hevc: add idr_interval option

From: Steven Liu user need to control the idr_interval for qsv hevc Signed-off-by: Steven Liu --- libavcodec/qsvenc_hevc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c index 7d4d55bb61..c063e27eea 100644 --- a/libavcodec/qsvenc_hevc.c

[FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

From: Jan Sebechlebsky Pass filename to AVFormatContext of underlying muxer. This commit fixes bug #6308. Signed-off-by: Jan Sebechlebsky --- libavformat/fifo.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index 2cbe5c5..c88

[FFmpeg-devel] [PATCH] h264dec: remove unneeded prototype

--- libavcodec/h264dec.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/h264dec.c b/libavcodec/h264dec.c index c7abd9d45d..49ebeca6d8 100644 --- a/libavcodec/h264dec.c +++ b/libavcodec/h264dec.c @@ -55,8 +55,6 @@ #include "thread.h" #include "vdpau_compat.h" -static int h264_d

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

On Thu, 6 Jul 2017 13:05:14 +0200 sebechlebsky...@gmail.com wrote: > From: Jan Sebechlebsky > > Pass filename to AVFormatContext of underlying muxer. > This commit fixes bug #6308. > > Signed-off-by: Jan Sebechlebsky > --- > libavformat/fifo.c | 7 --- > 1 file changed, 4 insertions(+),

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_hevc: add idr_interval option

On 06/07/17 11:48, Steven Liu wrote: > From: Steven Liu > > user need to control the idr_interval for qsv hevc > > Signed-off-by: Steven Liu > --- > libavcodec/qsvenc_hevc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/qsvenc_hevc.c b/libavcodec/qsvenc_hevc.c > index 7d

Re: [FFmpeg-devel] [PATCH] Fix static linking openssl library

Ping On Fri, Jun 23, 2017 at 10:26 AM, Alexandr Topilski wrote: > Hi, thank you for reply but output of pkg-config --static --libs openssl > is next: > $ -L/usr/local/lib -lssl -ldl -lcrypto -ldl > > Also i built openssl without any flags, simple execute: ./config && make && > make install > >

Re: [FFmpeg-devel] [PATCH] avfilter: add limiter filter

On 7/6/2017 7:12 AM, Paul B Mahol wrote: > On 7/4/17, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 17 +++ >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter/limiter.h | 33 +

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

On Thu, Jul 06, 2017 at 12:35:28PM +0200, wm4 wrote: > On Thu, 6 Jul 2017 11:58:47 +0200 > Michael Niedermayer wrote: > > > On Wed, Jul 05, 2017 at 04:39:05PM +0200, wm4 wrote: > > > On Wed, 5 Jul 2017 16:08:38 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Wed, Jul 05, 2017 at 09:56

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

On Thu, 6 Jul 2017 16:29:21 +0200 Michael Niedermayer wrote: > On Thu, Jul 06, 2017 at 12:35:28PM +0200, wm4 wrote: > > On Thu, 6 Jul 2017 11:58:47 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, Jul 05, 2017 at 04:39:05PM +0200, wm4 wrote: > > > > On Wed, 5 Jul 2017 16:08:38 +0200 >

[FFmpeg-devel] [PATCH] avcodec/hevcdec: Remove hevc_decode_extradata()

This function wrapped around ff_hevc_decode_extradata() and export_stream_params(), but from the 2 callers one needs to skip export_stream_params() so its simpler to directly call the needed code. Moving the 2nd part of the code out was suggested by wm4 Signed-off-by: Michael Niedermayer ---

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: Remove hevc_decode_extradata()

On Thu, 6 Jul 2017 17:08:27 +0200 Michael Niedermayer wrote: > This function wrapped around ff_hevc_decode_extradata() and > export_stream_params(), > but from the 2 callers one needs to skip export_stream_params() so its > simpler to > directly call the needed code. > > Moving the 2nd part o

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: Remove hevc_decode_extradata()

On 7/6/2017 12:54 PM, wm4 wrote: > On Thu, 6 Jul 2017 17:08:27 +0200 > Michael Niedermayer wrote: > >> This function wrapped around ff_hevc_decode_extradata() and >> export_stream_params(), >> but from the 2 callers one needs to skip export_stream_params() so its >> simpler to >> directly call

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add warning message when use fmp4 and byte range mode

On 7/6/2017 3:55 AM, Steven Liu wrote: > +if (hls->segment_type == SEGMENT_TYPE_FMP4 && byterange_mode) { > +av_log(s, AV_LOG_WARNING, "Have not support fmp4 byterange mode yet > now, patch " > + "welcome or wait to support it, change the hls_segment_type > to mpegts now

[FFmpeg-devel] [PATCH] ffmpeg: Fix typos in the comment for decode() ("." vs. "->")

pkt is a pointer, so it should be dereferenced with the -> operator. Signed-off-by: Wan-Teh Chang --- ffmpeg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ffmpeg.c b/ffmpeg.c index 6dae6e9078..888d19a647 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -2253,8 +2253,8 @@ stati

[FFmpeg-devel] [PATCH 0/2] Needlessly (?) Anal C Spec Adherence Fixe

As per the C standard: Where an argument declared as size_t n specifies the length of the array for a function, n can have the value zero on a call to that function. Unless explicitly stated otherwise in the description of a particular function in this subclause, pointer arguments

[FFmpeg-devel] [PATCH 1/2] concatdec: Do not pass NULL to memcmp

Signed-off-by: Derek Buitenhuis --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index e57e5ce0ec..e8b37d6a08 100644 --- a/libavformat/concatdec.c +++ b/libavformat/concatdec.c @@ -120,7 +120,7 @@ sta

[FFmpeg-devel] [PATCH 2/2] mpegtsenc: Don't pass NULL to memcpy

Signed-off-by: Derek Buitenhuis --- libavformat/mpegtsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index acea2e93a6..f62ed55dea 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -277,6 +277,8 @@ static void putst

Re: [FFmpeg-devel] [PATCH 0/2] Needlessly (?) Anal C Spec Adherence Fixe

On Thu, 6 Jul 2017 18:34:19 +0100 Derek Buitenhuis wrote: > As per the C standard: > > Where an argument declared as size_t n specifies the length of the > array for a function, n can have the value zero on a call to that > function. Unless explicitly stated otherwise in the descrip

Re: [FFmpeg-devel] [PATCH 1/2] concatdec: Do not pass NULL to memcmp

L'octidi 18 messidor, an CCXXV, Derek Buitenhuis a écrit : > Signed-off-by: Derek Buitenhuis > --- > libavformat/concatdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ok. Thanks. Regards, -- Nicolas George signature.asc Description: Digital signature

[FFmpeg-devel] [PATCH 00/12] Dead code and missing checks

FATE passes. Derek Buitenhuis (12): bitpacked: Remove dead store hdsenc: Add missing goto statement af_tempo: Add missing error check scpr: Added missing error check opusdec: Remove dead code ffmpeg_opt: Make get_timecode actually return errors cngenc: Add missing error check hlsen

[FFmpeg-devel] [PATCH 01/12] bitpacked: Remove dead store

Signed-off-by: Derek Buitenhuis --- libavcodec/bitpacked.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/bitpacked.c b/libavcodec/bitpacked.c index 12174d6007..f0b417d595 100644 --- a/libavcodec/bitpacked.c +++ b/libavcodec/bitpacked.c @@ -68,10 +68,6 @@ static int bitpacked_d

[FFmpeg-devel] [PATCH 02/12] hdsenc: Add missing goto statement

Signed-off-by: Derek Buitenhuis --- libavformat/hdsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hdsenc.c b/libavformat/hdsenc.c index 347df83a51..c362a75d8b 100644 --- a/libavformat/hdsenc.c +++ b/libavformat/hdsenc.c @@ -421,6 +421,7 @@ static int hds_write_header(AVForm

[FFmpeg-devel] [PATCH 03/12] af_tempo: Add missing error check

Signed-off-by: Derek Buitenhuis --- libavfilter/af_atempo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index 76410221d6..944df1dd32 100644 --- a/libavfilter/af_atempo.c +++ b/libavfilter/af_atempo.c @@ -1148,6 +1148,8 @@ static int requ

[FFmpeg-devel] [PATCH 04/12] scpr: Added missing error check

Signed-off-by: Derek Buitenhuis --- libavcodec/scpr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index f6d1e45692..29ee70d521 100644 --- a/libavcodec/scpr.c +++ b/libavcodec/scpr.c @@ -311,6 +311,8 @@ static int decompress_i(AVCodecContext *avctx,

[FFmpeg-devel] [PATCH 05/12] opusdec: Remove dead code

Signed-off-by: Derek Buitenhuis --- libavcodec/opusdec.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index 1110302f9c..5a7ba9dbb4 100644 --- a/libavcodec/opusdec.c +++ b/libavcodec/opusdec.c @@ -152,14 +152,7 @@ static in

[FFmpeg-devel] [PATCH 09/12] rtmpproto: Fix error return

Mistake was added in 5840473890440dbe0bd2cce530ebb3d93e187ae6. Signed-off-by: Derek Buitenhuis --- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index ae55a33284..7dd9cdddaf 100644 --- a/libavformat/r

[FFmpeg-devel] [PATCH 10/12] rtspdec: Fix return error

Signed-off-by: Derek Buitenhuis --- libavformat/rtspdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 0cb8f53a4c..fdf75a0979 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -498,7 +498,6 @@ int ff_rtsp_parse_streaming_co

[FFmpeg-devel] [PATCH 06/12] ffmpeg_opt: Make get_timecode actually return errors

Signed-off-by: Derek Buitenhuis --- ffmpeg_opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index 9b7e8c74b9..989391bb34 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -3072,7 +3072,7 @@ static int opt_timecode(void *optctx, const char *opt,

[FFmpeg-devel] [PATCH 11/12] af_amix: Add missing error check

Signed-off-by: Derek Buitenhuis --- libavfilter/af_amix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c index f19e6b39a5..809c8bf9ca 100644 --- a/libavfilter/af_amix.c +++ b/libavfilter/af_amix.c @@ -468,6 +468,8 @@ static int filter_frame(AVF

[FFmpeg-devel] [PATCH 08/12] hlsenc: Add missing error check

Signed-off-by: Derek Buitenhuis --- libavformat/hlsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index dd6a62b13c..b3b52da369 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -602,6 +602,8 @@ static int hls_mux_init(AVFormat

[FFmpeg-devel] [PATCH 12/12] bitstream_filter: Add missing error check

Signed-off-by: Derek Buitenhuis --- libavcodec/bitstream_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/bitstream_filter.c b/libavcodec/bitstream_filter.c index e9291aba19..8599b90d4a 100644 --- a/libavcodec/bitstream_filter.c +++ b/libavcodec/bitstream_filter.c @@ -122

[FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

Signed-off-by: Derek Buitenhuis --- libavcodec/cngenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cngenc.c b/libavcodec/cngenc.c index 302c703f72..b7207fd5f6 100644 --- a/libavcodec/cngenc.c +++ b/libavcodec/cngenc.c @@ -92,6 +92,8 @@ static int cng_encode_frame(AVCodecCont

Re: [FFmpeg-devel] [PATCH 04/12] scpr: Added missing error check

On 7/6/17, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/scpr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c > index f6d1e45692..29ee70d521 100644 > --- a/libavcodec/scpr.c > +++ b/libavcodec/scpr.c > @@ -311,6 +3

[FFmpeg-devel] [PATCH 04/12 v2] scpr: Added missing error check

Signed-off-by: Derek Buitenhuis --- libavcodec/scpr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index f6d1e45692..37fbe7a106 100644 --- a/libavcodec/scpr.c +++ b/libavcodec/scpr.c @@ -582,6 +582,8 @@ static int decompress_p(AVCodecContext *avctx,

Re: [FFmpeg-devel] [PATCH 04/12] scpr: Added missing error check

On 7/6/2017 7:33 PM, Paul B Mahol wrote: >> +if (ret < 0) >> +return ret; > > Hmm? Seems I forgot to amend this one properly. v2 sent. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/

[FFmpeg-devel] [PATCH 2/2 v2] mpegtsenc: Don't pass NULL to memcpy

Signed-off-by: Derek Buitenhuis --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index acea2e93a6..fdfa544ee2 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -277,6 +277,10 @@ static void pu

Re: [FFmpeg-devel] [PATCH v3] configure: require pkg-config for libvorbis

On 7/4/2017 8:38 PM, Paul B Mahol wrote: > This one works, so OK from me. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 04/12 v2] scpr: Added missing error check

On 7/6/17, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/scpr.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c > index f6d1e45692..37fbe7a106 100644 > --- a/libavcodec/scpr.c > +++ b/libavcodec/scpr.c > @@ -582,6 +5

Re: [FFmpeg-devel] [PATCH 12/12] bitstream_filter: Add missing error check

On 7/6/2017 3:28 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/bitstream_filter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/bitstream_filter.c b/libavcodec/bitstream_filter.c > index e9291aba19..8599b90d4a 100644 > --- a/libavcodec/b

Re: [FFmpeg-devel] [PATCH 01/12] bitpacked: Remove dead store

On 6 July 2017 at 19:28, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/bitpacked.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavcodec/bitpacked.c b/libavcodec/bitpacked.c > index 12174d6007..f0b417d595 100644 > --- a/libavcodec/bitpacked.c > ++

Re: [FFmpeg-devel] [PATCH 05/12] opusdec: Remove dead code

On 6 July 2017 at 19:28, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/opusdec.c | 9 + > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c > index 1110302f9c..5a7ba9dbb4 100644 > --- a/libavcodec/o

Re: [FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

On 6 July 2017 at 19:28, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/cngenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/cngenc.c b/libavcodec/cngenc.c > index 302c703f72..b7207fd5f6 100644 > --- a/libavcodec/cngenc.c > +++ b/libavcode

Re: [FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

On 7/6/2017 10:07 PM, Rostislav Pehlivanov wrote: > Just remove setting and checking the return value altogether, > ff_lpc_calc_ref_coeffs returns the order which you give it and can't error > out. Would look good to me if you did that, so feel free to push once done. OK. - Derek

Re: [FFmpeg-devel] [PATCH 03/12] af_tempo: Add missing error check

On 6 July 2017 at 19:28, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavfilter/af_atempo.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c > index 76410221d6..944df1dd32 100644 > --- a/libavfilter/af_atempo.c >

Re: [FFmpeg-devel] [PATCH 11/12] af_amix: Add missing error check

On 7/6/17, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavfilter/af_amix.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavfilter/af_amix.c b/libavfilter/af_amix.c > index f19e6b39a5..809c8bf9ca 100644 > --- a/libavfilter/af_amix.c > +++ b/libavfilter/af_a

Re: [FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

On 07/06/2017 04:28 PM, wm4 wrote: On Thu, 6 Jul 2017 16:16:12 +0200 Jan Sebechlebsky wrote: On 07/06/2017 01:15 PM, wm4 wrote: On Thu, 6 Jul 2017 13:05:14 +0200 sebechlebsky...@gmail.com wrote: For what reason? For example RTSP muxer attempts to access filename (url) from AVFormatContex

[FFmpeg-devel] [PATCH 1/2] pixdesc: Improve scoring for opaque/unknown pixel formats

Hardware pixel formats do not tell you anything about their actual contents, but should still score higher than formats with completely unknown properties, which in turn should score higher than invalid formats. Do not return an AVERROR code as a score. Fixes a hang in libavfilter where format ne

[FFmpeg-devel] [PATCH 2/2] pixdesc: Add a test for av_find_best_pix_fmt_of_2()

--- libavutil/Makefile| 1 + libavutil/tests/pixfmt_best.c | 115 ++ tests/fate/libavutil.mak | 4 ++ tests/ref/fate/pixfmt_best| 1 + 4 files changed, 121 insertions(+) create mode 100644 libavutil/tests/pixfmt_best.c create mod

Re: [FFmpeg-devel] [PATCH 2/2] mpegtsenc: Don't pass NULL to memcpy

On Thu, Jul 06, 2017 at 06:34:21PM +0100, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/mpegtsenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c > index acea2e93a6..f62ed55dea 100644 > --- a/libavform

Re: [FFmpeg-devel] [PATCH 2/2] mpegtsenc: Don't pass NULL to memcpy

On Fri, Jul 07, 2017 at 12:13:02AM +0200, Michael Niedermayer wrote: > On Thu, Jul 06, 2017 at 06:34:21PM +0100, Derek Buitenhuis wrote: > > Signed-off-by: Derek Buitenhuis > > --- > > libavformat/mpegtsenc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavformat/mpegtsenc.

Re: [FFmpeg-devel] [PATCH] configure: use pkg-config for libgme, if available

On 23 June 2017 at 17:08, wm4 wrote: > On Fri, 23 Jun 2017 01:53:37 +0100 > Ricardo Constantino wrote: > >> The pkg-config file is relatively new (2013), so some distros might >> not have it yet. And the -lstdc++ being required for the static lib >> is only present since the last release in Decem

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add warning message when use fmp4 and byte range mode

2017-07-06 23:31 GMT+08:00 Derek Buitenhuis : > On 7/6/2017 3:55 AM, Steven Liu wrote: >> +if (hls->segment_type == SEGMENT_TYPE_FMP4 && byterange_mode) { >> +av_log(s, AV_LOG_WARNING, "Have not support fmp4 byterange mode yet >> now, patch " >> + "welcome or wait to supp

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_hevc: add idr_interval option

2017-07-06 19:51 GMT+08:00 Mark Thompson : > On 06/07/17 11:48, Steven Liu wrote: >> From: Steven Liu >> >> user need to control the idr_interval for qsv hevc >> >> Signed-off-by: Steven Liu >> --- >> libavcodec/qsvenc_hevc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH] ffmpeg: Fix typos in the comment for decode() ("." vs. "->")

2017-07-07 0:42 GMT+08:00 Wan-Teh Chang : > pkt is a pointer, so it should be dereferenced with the -> operator. > > Signed-off-by: Wan-Teh Chang > --- > ffmpeg.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index 6dae6e9078..888d19a647 100644

Re: [FFmpeg-devel] [PATCH 08/12] hlsenc: Add missing error check

2017-07-07 2:28 GMT+08:00 Derek Buitenhuis : > Signed-off-by: Derek Buitenhuis > --- > libavformat/hlsenc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index dd6a62b13c..b3b52da369 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 02/12] hdsenc: Add missing goto statement

2017-07-07 2:28 GMT+08:00 Derek Buitenhuis : > Signed-off-by: Derek Buitenhuis > --- > libavformat/hdsenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/hdsenc.c b/libavformat/hdsenc.c > index 347df83a51..c362a75d8b 100644 > --- a/libavformat/hdsenc.c > +++ b/libavformat/h

Re: [FFmpeg-devel] [PATCH 09/12] rtmpproto: Fix error return

2017-07-07 2:28 GMT+08:00 Derek Buitenhuis : > Mistake was added in 5840473890440dbe0bd2cce530ebb3d93e187ae6. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/rtmpproto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpprot

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_hevc: add idr_interval option

On 06/07/17 23:32, Steven Liu wrote: > 2017-07-06 19:51 GMT+08:00 Mark Thompson : >> On 06/07/17 11:48, Steven Liu wrote: >>> From: Steven Liu >>> >>> user need to control the idr_interval for qsv hevc >>> >>> Signed-off-by: Steven Liu >>> --- >>> libavcodec/qsvenc_hevc.c | 1 + >>> 1 file chang

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_hevc: add idr_interval option

2017-07-07 7:12 GMT+08:00 Mark Thompson : > On 06/07/17 23:32, Steven Liu wrote: >> 2017-07-06 19:51 GMT+08:00 Mark Thompson : >>> On 06/07/17 11:48, Steven Liu wrote: From: Steven Liu user need to control the idr_interval for qsv hevc Signed-off-by: Steven Liu --- >

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_hevc: add idr_interval option

On 07/07/17 00:20, Steven Liu wrote: > 2017-07-07 7:12 GMT+08:00 Mark Thompson : >> On 06/07/17 23:32, Steven Liu wrote: >>> 2017-07-06 19:51 GMT+08:00 Mark Thompson : On 06/07/17 11:48, Steven Liu wrote: > From: Steven Liu > > user need to control the idr_interval for qsv hevc

Re: [FFmpeg-devel] [PATCH] avcodec/qsvenc_hevc: add idr_interval option

2017-07-07 7:37 GMT+08:00 Mark Thompson : > > > On 07/07/17 00:20, Steven Liu wrote: >> 2017-07-07 7:12 GMT+08:00 Mark Thompson : >>> On 06/07/17 23:32, Steven Liu wrote: 2017-07-06 19:51 GMT+08:00 Mark Thompson : > On 06/07/17 11:48, Steven Liu wrote: >> From: Steven Liu >> >

[FFmpeg-devel] [PATCH] checkasm: add hybrid_analysis_ileave and hybrid_synthesis_deint tests to aacpsdsp

Signed-off-by: James Almer --- tests/checkasm/aacpsdsp.c | 82 +++ 1 file changed, 82 insertions(+) diff --git a/tests/checkasm/aacpsdsp.c b/tests/checkasm/aacpsdsp.c index 2b051f65da..ea68b39fa9 100644 --- a/tests/checkasm/aacpsdsp.c +++ b/tests/check

Re: [FFmpeg-devel] [PATCH 1/2] pixdesc: Improve scoring for opaque/unknown pixel formats

On Thu, Jul 06, 2017 at 10:59:24PM +0100, Mark Thompson wrote: > Hardware pixel formats do not tell you anything about their actual > contents, but should still score higher than formats with completely > unknown properties, which in turn should score higher than invalid > formats. > > Do not retu

Re: [FFmpeg-devel] [PATCH 06/12] ffmpeg_opt: Make get_timecode actually return errors

On Thu, Jul 06, 2017 at 07:28:36PM +0100, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > ffmpeg_opt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) probably ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Does the universe only

Re: [FFmpeg-devel] [PATCH 2/2] pixdesc: Add a test for av_find_best_pix_fmt_of_2()

On Thu, Jul 06, 2017 at 11:00:31PM +0100, Mark Thompson wrote: > --- > libavutil/Makefile| 1 + > libavutil/tests/pixfmt_best.c | 115 > ++ > tests/fate/libavutil.mak | 4 ++ > tests/ref/fate/pixfmt_best| 1 + > 4 files changed, 1

[FFmpeg-devel] [PATCH 1/1] This change adds an encoder for Camera metadata motion. This is a type of sensor data associated with video, such as GPS, acceleration, gyro, and camera orientation. It does

From: Louis O'Bryan Signed-off-by: Louis O'Bryan --- Changelog | 1 + doc/general.texi| 2 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 3 + libavcodec/avcodec.h| 1 + libavcodec/cammenc.c| 299 +++

[FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

From: Louis O'Bryan I am adding a new encoder for camera sensor metadata. This is an implementation of a not-yet-published open standard for adding camera sensor data to mp4 containers, including the GPS, acceleration, gyro, and camera orientation. After this change is submitted, I will be sendin

Re: [FFmpeg-devel] [PATCH 2/2 v2] mpegtsenc: Don't pass NULL to memcpy

On Thu, Jul 06, 2017 at 07:55:54PM +0100, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/mpegtsenc.c | 4 > 1 file changed, 4 insertions(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If you fake or manipulate

Re: [FFmpeg-devel] [PATCH 1/1] This change adds an encoder for Camera metadata motion. This is a type of sensor data associated with video, such as GPS, acceleration, gyro, and camera orientation. It

FYI - sorry if these emails are duplicates. On Thu, Jul 6, 2017 at 5:36 PM, Louis O'Bryan wrote: > From: Louis O'Bryan > > Signed-off-by: Louis O'Bryan > --- > Changelog | 1 + > doc/general.texi| 2 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c |

Re: [FFmpeg-devel] [PATCH] h264dec: remove unneeded prototype

On Thu, Jul 06, 2017 at 01:04:03PM +0200, Rafaël Carré wrote: > --- > libavcodec/h264dec.c | 2 -- > 1 file changed, 2 deletions(-) applied thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does not speak. He who speaks, does not know. -- Lao

Re: [FFmpeg-devel] [PATCH] ffmpeg: Fix typos in the comment for decode() ("." vs. "->")

On Fri, Jul 07, 2017 at 06:35:30AM +0800, Steven Liu wrote: > 2017-07-07 0:42 GMT+08:00 Wan-Teh Chang : > > pkt is a pointer, so it should be dereferenced with the -> operator. > > > > Signed-off-by: Wan-Teh Chang > > --- > > ffmpeg.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH v2 1/2] lavu: Add DRM hwcontext

On 2017/7/6 7:02, Mark Thompson wrote: > --- > Updated following discussion: > * Back to using nested arrays. > * Documentation improved. > * Configure option now called libdrm. > * Other minor fixups. > > > configure | 3 + > libavutil/Makefile | 2 + > li

[FFmpeg-devel] [RFC][PATCH] movenc: write clap tag

Hi all, I’m looking for some assistance on this patch which is intended to resolve https://trac.ffmpeg.org/ticket/6145 . In https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html

Re: [FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

On 7/7/2017 1:36 AM, Louis O'Bryan wrote: > I am adding a new encoder for camera sensor metadata. This is an > implementation of a not-yet-published open standard for adding camera > sensor data to mp4 containers, including the GPS, acceleration, gyro, > and camera orientation. > After this change

Re: [FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

That is fair. If that is a requirement / everyone else thinks the same, then I will push on the team making the spec to have it public before I submit a patch to FFmpeg. On Thu, Jul 6, 2017 at 6:25 PM, Derek Buitenhuis wrote: > On 7/7/2017 1:36 AM, Louis O'Bryan wrote: > > I am adding a new enco

Re: [FFmpeg-devel] [RFC][PATCH] movenc: write clap tag

On 7/7/2017 2:20 AM, Dave Rice wrote: > Currently this patch writes the clap atom under this condition > "track->par->codec_id == AV_CODEC_ID_RAWVIDEO & track->mode == MODE_MOV”; > however, AV_CODEC_ID_RAWVIDEO isn’t quite what the spec asks for. Any advice > on how to write this condition for “

Re: [FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

On 7/7/2017 2:34 AM, Louis O'Bryan wrote: > That is fair. If that is a requirement / everyone else thinks the same, > then I will push on the team making the spec to have it public before I > submit a patch to FFmpeg. Cool; I'll wait for others' opinions, of course. Perfectly fine if you still wa

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add warning message when use fmp4 and byte range mode

2017-07-07 6:30 GMT+08:00 Steven Liu : > 2017-07-06 23:31 GMT+08:00 Derek Buitenhuis : >> On 7/6/2017 3:55 AM, Steven Liu wrote: >>> +if (hls->segment_type == SEGMENT_TYPE_FMP4 && byterange_mode) { >>> +av_log(s, AV_LOG_WARNING, "Have not support fmp4 byterange mode >>> yet now, patch

Re: [FFmpeg-devel] [RFC][PATCH] movenc: write clap tag

> On Jul 6, 2017, at 9:39 PM, Derek Buitenhuis > wrote: > > On 7/7/2017 2:20 AM, Dave Rice wrote: >> Currently this patch writes the clap atom under this condition >> "track->par->codec_id == AV_CODEC_ID_RAWVIDEO & track->mode == MODE_MOV”; >> however, AV_CODEC_ID_RAWVIDEO isn’t quite what th

Re: [FFmpeg-devel] [PATCH 08/12] hlsenc: Add missing error check

2017-07-07 6:29 GMT+08:00 Steven Liu : > 2017-07-07 2:28 GMT+08:00 Derek Buitenhuis : >> Signed-off-by: Derek Buitenhuis >> --- >> libavformat/hlsenc.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c >> index dd6a62b13c..b3b52da369 100644

[FFmpeg-devel] [PATCH] movenc: write clap tag

Resolves https://trac.ffmpeg.org/ticket/6145 and writes a clap atom that is coincident with the frames width and height. From 23d80d0d47829fed61e817b1e7c3f6d420c9ab5c Mon Sep 17 00:00:00 2001 From: Dave Rice Date: Thu, 6 Jul 2017 21:12:38 -0400 Subject: [PATCH] movenc: write clap tag --- liba

[FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

In url_find_protocol(), proto_str is either "file" or a string consisting of only the characters in URL_SCHEME_CHARS, which does not include ','. Therefore the strchr(proto_str, ',') call always returns NULL. Note: The code was added in commit 6161c41817f6e53abb3021d67ca0f19def682718. Signed-off-

[FFmpeg-devel] [PATCH] avfilter/pthread: rewrite implementation

Avoid pthread_cond_broadcast that wakes up all workers. Make each of them uses distict mutex/cond. Benchmark using afir with threads=4 and 4096 taps fir: channels=1: old: 2128210 decicycles in afir_execute, 2 runs, 0 skips 1382927 decicycles in afir_execute,1024 runs, 0

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: use ff_thread_once on costable initialization

On Wed, Jul 5, 2017 at 10:24 PM, Rostislav Pehlivanov wrote: > On 5 July 2017 at 16:22, wm4 wrote: > >> On Wed, 5 Jul 2017 16:12:07 +0100 >> Rostislav Pehlivanov wrote: >> >> > On 5 July 2017 at 07:15, Muhammad Faiz wrote: >> > >> > > Make it thread-safe and avoid redundant initialization. >> >

Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang wrote: > In url_find_protocol(), proto_str is either "file" or a string > consisting of only the characters in URL_SCHEME_CHARS, which does not > include ','. Therefore the strchr(proto_str, ',') call always returns > NULL. > > Note: The code was added

Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

Hi Muhammad, On Thu, Jul 6, 2017 at 7:56 PM, Muhammad Faiz wrote: > On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang > wrote: >> In url_find_protocol(), proto_str is either "file" or a string >> consisting of only the characters in URL_SCHEME_CHARS, which does not >> include ','. Therefore the strc

Re: [FFmpeg-devel] [PATCH] avformat/avio: Remove no-op code in url_find_protocol().

On Fri, Jul 7, 2017 at 11:27 AM, Wan-Teh Chang wrote: > Hi Muhammad, > > On Thu, Jul 6, 2017 at 7:56 PM, Muhammad Faiz wrote: >> On Fri, Jul 7, 2017 at 9:18 AM, Wan-Teh Chang >> wrote: >>> In url_find_protocol(), proto_str is either "file" or a string >>> consisting of only the characters in URL