Re: [FFmpeg-devel] [PATCH] ffmpeg: Fix typos in the comment for decode() ("." vs. "->")

[Michael Niedermayer]

On Fri, Jul 07, 2017 at 06:35:30AM +0800, Steven Liu wrote:
> 2017-07-07 0:42 GMT+08:00 Wan-Teh Chang <wtc-at-google....@ffmpeg.org>:
> > pkt is a pointer, so it should be dereferenced with the -> operator.
> >
> > Signed-off-by: Wan-Teh Chang <w...@google.com>
> > ---
> >  ffmpeg.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ffmpeg.c b/ffmpeg.c
> > index 6dae6e9078..888d19a647 100644
> > --- a/ffmpeg.c
> > +++ b/ffmpeg.c
> > @@ -2253,8 +2253,8 @@ static int ifilter_send_eof(InputFilter *ifilter)
> >
> >  // This does not quite work like 
> > avcodec_decode_audio4/avcodec_decode_video2.
> >  // There is the following difference: if you got a frame, you must call
> > -// it again with pkt=NULL. pkt==NULL is treated differently from 
> > pkt.size==0
> > -// (pkt==NULL means get more output, pkt.size==0 is a flush/drain packet)
> > +// it again with pkt=NULL. pkt==NULL is treated differently from 
> > pkt->size==0
> > +// (pkt==NULL means get more output, pkt->size==0 is a flush/drain packet)
> >  static int decode(AVCodecContext *avctx, AVFrame *frame, int *got_frame, 
> > AVPacket *pkt)
> >  {
> >      int ret;
> > --
> > 2.13.2.725.g09c95d1e9-goog
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> ok

applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct answer.

signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel