Re: [FFmpeg-devel] [PATCH] decode.c: Handle 0-size packets in compat_decode

2017-07-05 Thread wm4
On Tue, 4 Jul 2017 20:20:38 +0200 Reimar Döffinger wrote: > On 04.07.2017, at 10:42, wm4 wrote: > > Not really comfortable with the current patch. Why does it even touch > > the compat_decode_partial_size handling path? > > Because that is the code that gets utterly confused by 0-size packets

Re: [FFmpeg-devel] [PATCH] avcodec/als: use planar sample formats

2017-07-05 Thread wm4
On Tue, 4 Jul 2017 21:34:26 +0200 Thilo Borgmann wrote: > Am 02.07.17 um 16:17 schrieb Paul B Mahol: > > On 7/2/17, Thilo Borgmann wrote: > >> Am 01.07.17 um 22:23 schrieb Paul B Mahol: > >>> This is native layout of this codec. > >> > >> From where is that definition? > > > > See how s

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

2017-07-05 Thread wm4
On Tue, 4 Jul 2017 22:33:52 +0200 Michael Niedermayer wrote: > Fixes: out of array access > Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] Filter with external image manupilation?

2017-07-05 Thread Evert Vorster
Hi there, developers on this list. Is it possible to pause decoding and encoding of a file with a script? What we are trying to achieve is to extract all the frames from an input file, but pause the process after each frame is extracted. During the pause between the frames, we want to manipulate

Re: [FFmpeg-devel] Filter with external image manupilation?

2017-07-05 Thread Moritz Barsnick
On Wed, Jul 05, 2017 at 10:41:49 +0200, Evert Vorster wrote: > Hi there, developers on this list. This is more of a question for ffmpeg-user, actually. > Is it possible to pause decoding and encoding of a file with a script? You can suspend ffmpeg with a signal. But that won't be very precise in

Re: [FFmpeg-devel] Filter with external image manupilation?

2017-07-05 Thread Evert Vorster
I thank you for the very prompt reply. This is more of a question for ffmpeg-user, actually. > My apologies! > > > Is it possible to pause decoding and encoding of a file with a script? > > You can suspend ffmpeg with a signal. But that won't be very precise in > terms of timing. > Ctrl+z? I'll

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: add sbrdsp tests

2017-07-05 Thread Paul B Mahol
On 7/5/17, James Almer wrote: > On 7/4/2017 10:45 PM, Michael Niedermayer wrote: >> On Tue, Jul 04, 2017 at 03:15:56PM -0300, James Almer wrote: >>> On 7/4/2017 2:31 PM, Michael Niedermayer wrote: On Mon, Jul 03, 2017 at 02:32:28PM +0200, Matthieu Bouron wrote: > On Fri, Jun 30, 2017 at 0

[FFmpeg-devel] [PATCH] avcodec/rdft: remove sintable

2017-07-05 Thread Muhammad Faiz
It is redundant with costable. The first half of sintable is identical with the second half of costable. The second half of sintable is negative value of the first half of sintable. The computation is changed to handle sign of sin values, so disable arm optimization. Signed-off-by: Muhammad Faiz

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: add sbrdsp tests

2017-07-05 Thread Hendrik Leppkes
On Wed, Jul 5, 2017 at 11:40 AM, Paul B Mahol wrote: > On 7/5/17, James Almer wrote: >> On 7/4/2017 10:45 PM, Michael Niedermayer wrote: >>> On Tue, Jul 04, 2017 at 03:15:56PM -0300, James Almer wrote: On 7/4/2017 2:31 PM, Michael Niedermayer wrote: > On Mon, Jul 03, 2017 at 02:32:28PM +

Re: [FFmpeg-devel] Filter with external image manupilation?

2017-07-05 Thread Moritz Barsnick
On Wed, Jul 05, 2017 at 11:40:49 +0200, Evert Vorster wrote: > > You can suspend ffmpeg with a signal. But that won't be very precise in > > terms of timing. > > > Ctrl+z? I'll have to educate myself on that. Does this work for encoding, > too? Yes, basically, from a controlling shell. I was think

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: add sbrdsp tests

2017-07-05 Thread James Almer
On 7/5/2017 7:52 AM, Hendrik Leppkes wrote: > On Wed, Jul 5, 2017 at 11:40 AM, Paul B Mahol wrote: >> >> I get segfauls in sbrdsp code after some recent commit. > > Indeed, fate also shows almost all AAC tests failing on x86_64 systems. > > - Hendrik Yeah, got a bit overzealous in an unrelated

Re: [FFmpeg-devel] [PATCH] decode.c: Handle 0-size packets in compat_decode

2017-07-05 Thread Michael Niedermayer
On Wed, Jul 05, 2017 at 09:52:55AM +0200, wm4 wrote: > On Tue, 4 Jul 2017 20:20:38 +0200 > Reimar Döffinger wrote: > > > On 04.07.2017, at 10:42, wm4 wrote: > > > Not really comfortable with the current patch. Why does it even touch > > > the compat_decode_partial_size handling path? > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

2017-07-05 Thread Michael Niedermayer
On Wed, Jul 05, 2017 at 09:56:10AM +0200, wm4 wrote: > On Tue, 4 Jul 2017 22:33:52 +0200 > Michael Niedermayer wrote: > > > Fixes: out of array access > > Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072 > > > > Found-by: continuous fuzzing process > > https://github.com/google/oss-

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread wm4
On Tue, 4 Jul 2017 14:54:31 + Saverio Blasi wrote: > - This patch contains the changes to interface the Turing codec > (http://turingcodec.org/) with ffmpeg. The patch was modified to address the > comments in the review as follows: > - Added a pkg-config file to list all dependencies re

Re: [FFmpeg-devel] [PATCH] libavformat/gdv: Fix parsing for soundless video

2017-07-05 Thread Michael Niedermayer
On Wed, Jul 05, 2017 at 07:48:18AM +0500, Azamat Hackimov wrote: > Here another file chptr1.gdv, 0,5 Mb long: > https://drive.google.com/file/d/0B8VpSH5prLMrT1pFejhQV2tQWWs/view?usp=sharing uploaded to gdv/ace.gdv gdv/chptr1.gdv thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF1

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

2017-07-05 Thread wm4
On Wed, 5 Jul 2017 16:08:38 +0200 Michael Niedermayer wrote: > On Wed, Jul 05, 2017 at 09:56:10AM +0200, wm4 wrote: > > On Tue, 4 Jul 2017 22:33:52 +0200 > > Michael Niedermayer wrote: > > > > > Fixes: out of array access > > > Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072 > >

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread Saverio Blasi
>>So I did try to build this, but the ffmpeg configure check apparently fails >>at picking it up and dumps 3.5MB of C++ linker errors into the config.log. >>And I have no idea why it does that. configure actually prints "ERROR: >>libturing not found using pkg-config", but the .pc part seems to b

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

2017-07-05 Thread Derek Buitenhuis
On 6/28/2017 4:41 PM, Derek Buitenhuis wrote: > Apple software and devices requrie hvc1. This patchset was originally > sent to Libav for this same purpose. > > John Stebbins (5): > movenc: use correct tag list for AVOutputFormat.codec_tag > movenc: simplify codec_tag lookup > movenc: move t

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread Derek Buitenhuis
On 7/5/2017 3:56 PM, Saverio Blasi wrote: > RUN cmake -DCMAKE_INSTALL_PREFIX="/source/ffmpeg/ffmpeg_build" .. && \ > make && \ > make install > WORKDIR /source/ffmpeg > COPY 0001-Added-Turing-codec-interface-for-ffmpeg.patch /source/ffmpeg > RUN git apply 0001-Added-Turing-codec-interface-f

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread Saverio Blasi
2. Not used --pkg-config-flags--static and thus missed including the (unfortunately non-namespaced) embedded boost libraries. I followed the example instructions in https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu#ffmpeg (at the top of the page it says "Compile FFmpeg on Ubuntu, Debian, or

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: use ff_thread_once on costable initialization

2017-07-05 Thread Rostislav Pehlivanov
On 5 July 2017 at 07:15, Muhammad Faiz wrote: > Make it thread-safe and avoid redundant initialization. > > Signed-off-by: Muhammad Faiz > --- > libavcodec/fft_template.c | 81 ++ > +++-- > 1 file changed, 71 insertions(+), 10 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: use ff_thread_once on costable initialization

2017-07-05 Thread wm4
On Wed, 5 Jul 2017 16:12:07 +0100 Rostislav Pehlivanov wrote: > On 5 July 2017 at 07:15, Muhammad Faiz wrote: > > > Make it thread-safe and avoid redundant initialization. > > > > Signed-off-by: Muhammad Faiz > > --- > > libavcodec/fft_template.c | 81 ++ > > ++

Re: [FFmpeg-devel] [PATCH] avcodec/rdft: remove sintable

2017-07-05 Thread Rostislav Pehlivanov
On 5 July 2017 at 11:33, Muhammad Faiz wrote: > It is redundant with costable. The first half of sintable is > identical with the second half of costable. The second half > of sintable is negative value of the first half of sintable. > > The computation is changed to handle sign of sin values, >

Re: [FFmpeg-devel] [PATCH] avfomat/hlsenc: support fmp4 format in hls

2017-07-05 Thread Derek Buitenhuis
On 7/3/2017 1:22 PM, Steven Liu wrote: > Pushed! Seems this patch has unexpected behavior when 'hls_segment_type=fmp4' and 'hls_flags=single_file'. It should probably create a self indexed file (sidx boxes at the start) and a byte range m3u8, no? At the very least it should fail or warn the use

Re: [FFmpeg-devel] [PATCH] avcodec/fft_template: use ff_thread_once on costable initialization

2017-07-05 Thread Rostislav Pehlivanov
On 5 July 2017 at 16:22, wm4 wrote: > On Wed, 5 Jul 2017 16:12:07 +0100 > Rostislav Pehlivanov wrote: > > > On 5 July 2017 at 07:15, Muhammad Faiz wrote: > > > > > Make it thread-safe and avoid redundant initialization. > > > > > > Signed-off-by: Muhammad Faiz > > > --- > > > libavcodec/fft_t

[FFmpeg-devel] [PATCH] libavformat/gdv: Added FATE test for GDV files (v2)

2017-07-05 Thread Azamat H. Hackimov
Two files to check - with and without audio stream. --- tests/Makefile | 1 + tests/fate/gdv.mak | 8 ++ tests/ref/fate/gdv-nosound | 26 +++ tests/ref/fate/gdv-sound | 181 + 4 files changed, 216 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread Saverio Blasi
>>2. Not used --pkg-config-flags--static and thus missed including the >>(unfortunately non-namespaced) embedded boost libraries. >> >>I followed the example instructions in >>https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu#ffmpeg (at the top of >>the page it says "Compile FFmpeg on Ubuntu,

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread wm4
On Wed, 5 Jul 2017 15:49:53 + Saverio Blasi wrote: > >>2. Not used --pkg-config-flags--static and thus missed including the > >>(unfortunately non-namespaced) embedded boost libraries. > >> > >>I followed the example instructions in > >>https://trac.ffmpeg.org/wiki/CompilationGuide/Ubuntu#f

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread Derek Buitenhuis
On 7/5/2017 5:36 PM, wm4 wrote: > These pkg-config flag additions in the Ubuntu instructions are pretty > unusual. Passing --static to pkg-config is the de-facto way to build FFmpeg with static libraries. - Derek ___ ffmpeg-devel mailing list ffmpeg-dev

[FFmpeg-devel] [PATCH] checkasm: add a g722dsp test

2017-07-05 Thread James Almer
Signed-off-by: James Almer --- tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 +++ tests/checkasm/checkasm.h | 1 + tests/checkasm/g722dsp.c | 66 +++ tests/fate/checkasm.mak | 1 + 5 files changed, 72 insertions(+) create mode 1

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

2017-07-05 Thread Derek Buitenhuis
On 7/5/2017 4:01 PM, Derek Buitenhuis wrote: > Going to push the last four today, unless someone objects. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add A53 Closed Captions to MPEG header if they are available.

2017-07-05 Thread John P Poet
On Fri, Jun 9, 2017 at 11:41 AM Devin Heitmueller < dheitmuel...@kernellabs.com> wrote: > Hello Marton, > > On Tue, Jun 6, 2017 at 5:45 PM, Marton Balint wrote: > > > As far as I remember multiple side data of the same type is not > something we > > wanted to support. Why do you need it? Can't a

Re: [FFmpeg-devel] [PATCH] libavformat/gdv: Fix parsing for soundless video

2017-07-05 Thread Michael Niedermayer
On Mon, Jul 03, 2017 at 01:10:55AM +0500, Azamat H. Hackimov wrote: > Added 2 byte skipping if there no sound present, that fixes playback > files without sound stream. > --- > libavformat/gdv.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavformat/gdv.c b/libavformat/gdv.c > ind

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Wan-Teh Chang
Hi Ronald, A variant of this patch is committed as 2e664b9c1e73c80aab91070c1eb7676f04bdd12d: http://ffmpeg.org/pipermail/ffmpeg-cvslog/2017-April/106577.html I believe it does not fix the tsan warning. On Thu, Apr 6, 2017 at 10:48 AM, Ronald S. Bultje wrote: > ..., but this way the accesses to

Re: [FFmpeg-devel] [PATCH] Add A53 Closed Captions to MPEG header if they are available.

2017-07-05 Thread Marton Balint
On Fri, 9 Jun 2017, Devin Heitmueller wrote: Hello Marton, On Tue, Jun 6, 2017 at 5:45 PM, Marton Balint wrote: As far as I remember multiple side data of the same type is not something we wanted to support. Why do you need it? Can't a single AV_FRAME_DATA_A53_CC side data packet contain ma

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 5, 2017 at 5:30 PM, Wan-Teh Chang wrote: > Hi Ronald, > > A variant of this patch is committed as > 2e664b9c1e73c80aab91070c1eb7676f04bdd12d: > > http://ffmpeg.org/pipermail/ffmpeg-cvslog/2017-April/106577.html > > I believe it does not fix the tsan warning. I had notic

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Wan-Teh Chang
Hi Ronald, Thank you for the quick reply! On Wed, Jul 5, 2017 at 2:49 PM, Ronald S. Bultje wrote: > Hi Wan-Teh, > > On Wed, Jul 5, 2017 at 5:30 PM, Wan-Teh Chang wrote: >> >> Hi Ronald, >> >> A variant of this patch is committed as >> 2e664b9c1e73c80aab91070c1eb7676f04bdd12d: >> >> http://ffmpe

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 5, 2017 at 6:12 PM, Wan-Teh Chang wrote: > Hi Ronald, > > Thank you for the quick reply! > > On Wed, Jul 5, 2017 at 2:49 PM, Ronald S. Bultje > wrote: > > Hi Wan-Teh, > > > > On Wed, Jul 5, 2017 at 5:30 PM, Wan-Teh Chang wrote: > >> > >> Hi Ronald, > >> > >> A variant o

[FFmpeg-devel] [PATCH v2 1/2] lavu: Add DRM hwcontext

2017-07-05 Thread Mark Thompson
--- Updated following discussion: * Back to using nested arrays. * Documentation improved. * Configure option now called libdrm. * Other minor fixups. configure | 3 + libavutil/Makefile | 2 + libavutil/hwcontext.c | 4 + libavutil/hwcontext.h

[FFmpeg-devel] [PATCH v2 2/2] test-only: DRM allocation for Intel, DRM to VAAPI mapping

2017-07-05 Thread Mark Thompson
--- For example: ./ffmpeg_g -y -init_hw_device drm:/dev/dri/card0 -i in.mp4 -an -filter_hw_device drm0 -vf 'format=nv12,hwupload,format=drm_prime,hwmap=derive_device=vaapi,format=vaapi' -c:v h264_vaapi out.mp4 (Note that it needs DRM master directly for the dumb buffer allocation, so this wil

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

2017-07-05 Thread Moritz Barsnick
On Wed, Jul 05, 2017 at 17:42:31 +0100, Derek Buitenhuis wrote: > Passing --static to pkg-config is the de-facto way to build FFmpeg > with static libraries. In other words, it's just an example in the wiki. It's one way to do it, but that doesn't mean it's *the* way to do it. Building against dyn

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Wan-Teh Chang
Hi Ronald, On Wed, Jul 5, 2017 at 3:31 PM, Ronald S. Bultje wrote: > Hi Wan-Teh, > > On Wed, Jul 5, 2017 at 6:12 PM, Wan-Teh Chang wrote: >> >> Thank you for all the tsan warning fixes. In the meantime, it would be >> good to revert 2e664b9c1e73c80aab91070c1eb7676f04bdd12d to avoid >> confusion.

Re: [FFmpeg-devel] [PATCH] avfomat/hlsenc: support fmp4 format in hls

2017-07-05 Thread Steven Liu
2017-07-06 8:02 GMT+08:00 Steven Liu : > 2017-07-05 23:28 GMT+08:00 Derek Buitenhuis : >> On 7/3/2017 1:22 PM, Steven Liu wrote: >>> Pushed! >> >> Seems this patch has unexpected behavior when 'hls_segment_type=fmp4' >> and 'hls_flags=single_file'. >> >> It should probably create a self indexed fil

Re: [FFmpeg-devel] [PATCH] checkasm/aarch64: fix tests returning a float

2017-07-05 Thread James Almer
On 6/22/2017 5:35 AM, Matthieu Bouron wrote: > On Wed, Jun 21, 2017 at 10:19:33PM +0200, Matthieu Bouron wrote: >> On Wed, Jun 21, 2017 at 04:57:53PM -0300, James Almer wrote: >>> On 6/19/2017 6:08 AM, Matthieu Bouron wrote: Avoids overriding v0 (which containins the result of the tested

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

2017-07-05 Thread Ronald S. Bultje
Hi Wan-Teh, On Wed, Jul 5, 2017 at 8:08 PM, Wan-Teh Chang wrote: > Hi Ronald, > > On Wed, Jul 5, 2017 at 3:31 PM, Ronald S. Bultje > wrote: > > Hi Wan-Teh, > > > > On Wed, Jul 5, 2017 at 6:12 PM, Wan-Teh Chang wrote: > >> > >> Thank you for all the tsan warning fixes. In the meantime, it would

[FFmpeg-devel] [PATCH] avformat/hlsenc: add warning message when use fmp4 and byte range mode

2017-07-05 Thread Steven Liu
have not support fmp4 byterange mode now, so give a warn message Suggested-by: Derek Buitenhuis Signed-off-by: Steven Liu --- libavformat/hlsenc.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index dd6a62b..f1157a9 100

Re: [FFmpeg-devel] [PATCH] checkasm/aarch64: fix tests returning a float

2017-07-05 Thread Matthieu Bouron
Le 6 juil. 2017 4:08 AM, "James Almer" a écrit : On 6/22/2017 5:35 AM, Matthieu Bouron wrote: > On Wed, Jun 21, 2017 at 10:19:33PM +0200, Matthieu Bouron wrote: >> On Wed, Jun 21, 2017 at 04:57:53PM -0300, James Almer wrote: >>> On 6/19/2017 6:08 AM, Matthieu Bouron wrote: Avoids overriding