[FFmpeg-devel] [PATCH] FATE: Add test for libavfilter/scale2ref

2017-06-04 Thread Kevin Mark
This new FATE test for the scale2ref filter makes use of the recently added scale2ref-specific variables to maintain the aspect ratio of a test input. Filtergraph explanation: [main] has an AR of 4:3. [ref] has an AR of 16:9. 640 / 4 = 160. So the new width for [main] is 160. 160 / ((320 / 240) *

Re: [FFmpeg-devel] [PATCH] libavfilter/scale2ref: Add constants for the primary input

2017-06-04 Thread Kevin Mark
On Thu, Jun 1, 2017 at 5:37 PM, Michael Niedermayer wrote: > applied > > can you add a fate test that uses the new identifers ? > > Thanks Certainly. Submitted a patch for a scale2ref-specific test. Thanks, Kevin ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH] FATE: Add test for libavfilter/scale2ref

2017-06-04 Thread Gyan
On Sun, Jun 4, 2017 at 1:23 PM, Kevin Mark wrote: > > If we were to use "iw/4:-1" in place of "iw/4:ow/mdar": > 640 / 4 = 160. So the new width for [main] would be 160. > 360 / 4 = 90. So the new height for [main] would be 90. > 160 / 90 = 16 / 9 so [main] now has the same aspect ratio as [ref] >

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-04 Thread Nicolas George
Le sextidi 16 prairial, an CCXXV, Daniel Kucera a écrit : > Signed-off-by: Daniel Kucera > --- > libavformat/avio.c| 2 +- > libavformat/aviobuf.c | 20 > libavformat/cache.c | 4 ++-- > libavformat/file.c| 2 ++ > libavformat/subfile.c | 2 +- > libavformat/wtv

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-04 Thread Nicolas George
Le quintidi 15 prairial, an CCXXV, James Almer a écrit : > On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > I see EINVAL more fit as an error for example if src or dst are NULL, > something that would actually be an invalid argument. > We don't currently check that, for that matter. Maybe we shoul

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-04 Thread Nicolas George
Le quartidi 14 prairial, an CCXXV, Michael Niedermayer a écrit : > > Notice a pattern? > yes > Security issues are found, i post a fix and people complain, No. The pattern is: you rush to produce a bad fix. > If you knew a year and a half ago about a security issue and about a > great solution to

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check file extensions

2017-06-04 Thread Nicolas George
Le quintidi 15 prairial, an CCXXV, Hendrik Leppkes a écrit : > I object to breaking a functioning protocol in the name of some > obscure social-engineering attack. I agree, this issue is negligible. As was the issue about the concat protocol. But we obviously have many similar issues all over the

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/utils: Fix several integer overflows.

2017-06-04 Thread Ronald S. Bultje
Hi, On Sun, Jun 4, 2017 at 6:32 AM, Nicolas George wrote: > Le quintidi 15 prairial, an CCXXV, James Almer a écrit : > > On 6/3/2017 9:25 PM, Michael Niedermayer wrote: > > I see EINVAL more fit as an error for example if src or dst are NULL, > > something that would actually be an invalid argum

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: add a custom read_packet function

2017-06-04 Thread Michael Niedermayer
On Sat, Jun 03, 2017 at 06:14:12PM -0300, James Almer wrote: > On 6/3/2017 5:16 PM, Michael Niedermayer wrote: > > On Sat, Jun 03, 2017 at 12:33:33AM -0300, James Almer wrote: > >> Atempt to read and propagate only full ADTS frames and not other data, > >> like id3v1 or APETags at the end of the fi

Re: [FFmpeg-devel] [PATCH 1/2] avformat/utils: return impaired streams in av_find_best_stream if only those exist

2017-06-04 Thread Marton Balint
On Sat, 3 Jun 2017, Michael Niedermayer wrote: On Fri, Jun 02, 2017 at 11:10:13PM +0200, Marton Balint wrote: Fixes ticket #6397. Signed-off-by: Marton Balint --- libavformat/utils.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) LGTM Thanks, pushed both patche

[FFmpeg-devel] [PATCH 2/3] avformat/options: disable flush_packets as default

2017-06-04 Thread Marton Balint
It is a huge performance improvement for encoding files with small packets (e.g. wav) over SMB/CIFS. Signed-off-by: Marton Balint --- libavformat/mux.c | 4 ++-- libavformat/options_table.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mux.c b/lib

[FFmpeg-devel] [PATCH 1/3] avformat/aviobuf: fix flushing buffers after seeking backwards

2017-06-04 Thread Marton Balint
In the past, aviobuf only flushed buffers until the current buffer position, even if more data was written to it previously, and a backward seek was used to reposition the IO context. From now, aviobuf will keep track of the written data, so no explicit seek will be required till the end of the bu

[FFmpeg-devel] [PATCH 3/3] avformat/aviobuf: increase buffer size to 128k

2017-06-04 Thread Marton Balint
Another huge performance improvement when using SMB/CIFS as output. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 2 +- tests/ref/seek/lavf-alaw | 3 +-- tests/ref/seek/lavf-mulaw | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/libavformat/aviobuf.c b/liba

[FFmpeg-devel] [PATCH] libavcodec/vp9 ipred_dl_32x32_16 avx2 version

2017-06-04 Thread Ilia Valiakhmetov
vp9_diag_downleft_32x32_8bpp_c: 580.2 vp9_diag_downleft_32x32_8bpp_sse2: 75.6 vp9_diag_downleft_32x32_8bpp_ssse3: 73.7 vp9_diag_downleft_32x32_8bpp_avx: 72.7 vp9_diag_downleft_32x32_10bpp_c: 1101.2 vp9_diag_downleft_32x32_10bpp_sse2: 145.4 vp9_diag_downleft_32x32_10bpp_ssse3: 137.5 vp9_diag_downlef

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: add a custom read_packet function

2017-06-04 Thread James Almer
On 6/4/2017 8:44 AM, Michael Niedermayer wrote: > On Sat, Jun 03, 2017 at 06:14:12PM -0300, James Almer wrote: >> On 6/3/2017 5:16 PM, Michael Niedermayer wrote: >>> On Sat, Jun 03, 2017 at 12:33:33AM -0300, James Almer wrote: Atempt to read and propagate only full ADTS frames and not other da

Re: [FFmpeg-devel] [PATCH] libavformat/aviobuf.c: don't treat 0 from read_packet as EOF

2017-06-04 Thread Daniel Kučera
2017-06-04 12:25 GMT+02:00 Nicolas George : > Le sextidi 16 prairial, an CCXXV, Daniel Kucera a écrit : >> Signed-off-by: Daniel Kucera >> --- >> libavformat/avio.c| 2 +- >> libavformat/aviobuf.c | 20 >> libavformat/cache.c | 4 ++-- >> libavformat/file.c| 2 ++

[FFmpeg-devel] [PATCH] fate: add fate-adts-id3v1-demux

2017-06-04 Thread James Almer
This test the demuxer discarding non ADTS frames at the beginning and end of the input. As a side effect, this commit also enables fate-adts-demux, which was accidentally disabled in 324f0fbff1245f9e9e1dda29ecb03138a2de287d. Signed-off-by: James Almer --- Sample is in http://0x0.st/6gI.aac Shou

[FFmpeg-devel] [PATCH] fate: add test for the Dirac low delay profile

2017-06-04 Thread Rostislav Pehlivanov
--- tests/fate/video.mak | 3 +++ tests/ref/fate/dirac-low-delay | 7 +++ 2 files changed, 10 insertions(+) create mode 100644 tests/ref/fate/dirac-low-delay diff --git a/tests/fate/video.mak b/tests/fate/video.mak index 5a64e6f9e4..d1d35335f2 100644 --- a/tests/fate/video.mak +++

[FFmpeg-devel] [PATCH] libavcodec/vp9: ipred_dl_32x32_16 avx2 implementation

2017-06-04 Thread Ilia Valiakhmetov
vp9_diag_downleft_32x32_8bpp_c: 580.2 vp9_diag_downleft_32x32_8bpp_sse2: 75.6 vp9_diag_downleft_32x32_8bpp_ssse3: 73.7 vp9_diag_downleft_32x32_8bpp_avx: 72.7 vp9_diag_downleft_32x32_10bpp_c: 1101.2 vp9_diag_downleft_32x32_10bpp_sse2: 145.4 vp9_diag_downleft_32x32_10bpp_ssse3: 137.5 vp9_diag_downlef

Re: [FFmpeg-devel] [PATCH] fate: add fate-adts-id3v1-demux

2017-06-04 Thread James Almer
On 6/4/2017 1:08 PM, James Almer wrote: > This test the demuxer discarding non ADTS frames at the beginning and > end of the input. > > As a side effect, this commit also enables fate-adts-demux, which was > accidentally disabled in 324f0fbff1245f9e9e1dda29ecb03138a2de287d. > > Signed-off-by: Jam

Re: [FFmpeg-devel] [PATCH 3/3] avformat/aviobuf: increase buffer size to 128k

2017-06-04 Thread Michael Niedermayer
On Sun, Jun 04, 2017 at 03:35:07PM +0200, Marton Balint wrote: > Another huge performance improvement when using SMB/CIFS as output. > > Signed-off-by: Marton Balint > --- > libavformat/aviobuf.c | 2 +- > tests/ref/seek/lavf-alaw | 3 +-- > tests/ref/seek/lavf-mulaw | 3 +-- > 3 files chan

Re: [FFmpeg-devel] [PATCH] fate: add test for the Dirac low delay profile

2017-06-04 Thread Michael Niedermayer
On Sun, Jun 04, 2017 at 06:03:36PM +0100, Rostislav Pehlivanov wrote: > --- > tests/fate/video.mak | 3 +++ > tests/ref/fate/dirac-low-delay | 7 +++ > 2 files changed, 10 insertions(+) > create mode 100644 tests/ref/fate/dirac-low-delay test passes on linux x86 32/64 arm, mips and

Re: [FFmpeg-devel] [PATCH 3/3] avformat/aviobuf: increase buffer size to 128k

2017-06-04 Thread Marton Balint
On Mon, 5 Jun 2017, Michael Niedermayer wrote: On Sun, Jun 04, 2017 at 03:35:07PM +0200, Marton Balint wrote: Another huge performance improvement when using SMB/CIFS as output. Signed-off-by: Marton Balint --- libavformat/aviobuf.c | 2 +- tests/ref/seek/lavf-alaw | 3 +-- tests/ref/

Re: [FFmpeg-devel] [PATCH] fate: add fate-adts-id3v1-demux

2017-06-04 Thread Michael Niedermayer
On Sun, Jun 04, 2017 at 01:08:39PM -0300, James Almer wrote: > This test the demuxer discarding non ADTS frames at the beginning and > end of the input. > > As a side effect, this commit also enables fate-adts-demux, which was > accidentally disabled in 324f0fbff1245f9e9e1dda29ecb03138a2de287d. >

Re: [FFmpeg-devel] [PATCH] FATE: Add test for libavfilter/scale2ref

2017-06-04 Thread Michael Niedermayer
On Sun, Jun 04, 2017 at 03:53:31AM -0400, Kevin Mark wrote: > This new FATE test for the scale2ref filter makes use of the recently > added scale2ref-specific variables to maintain the aspect ratio of a > test input. > > Filtergraph explanation: > [main] has an AR of 4:3. [ref] has an AR of 16:9.

[FFmpeg-devel] [PATCH V2] lavc/golomb: Fix UE golomb overwrite issue.

2017-06-04 Thread Jun Zhao
V2: Add Add set_ue_golomb_long() to support 32bits UE golomb and update the unit test. From 6fe36e4e2a41f70e2a41c5eba90b5143b4eeba7b Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Fri, 2 Jun 2017 15:05:49 +0800 Subject: [PATCH V2] lavc/golomb: Fix UE golomb overwrite issue. put_bits just support

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

2017-06-04 Thread Michael Niedermayer
Hi On Sun, Jun 04, 2017 at 12:46:18PM +0200, Nicolas George wrote: > Le quartidi 14 prairial, an CCXXV, Michael Niedermayer a écrit : > > > Notice a pattern? > > yes > > Security issues are found, i post a fix and people complain, > > No. The pattern is: you rush to produce a bad fix. thats "ad

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check local file extensions

2017-06-04 Thread Michael Niedermayer
On Sat, Jun 03, 2017 at 09:20:04PM +0200, Michael Niedermayer wrote: > This reduces the attack surface of local file-system > information leaking. > > It prevents the existing exploit leading to an information leak. As > well as similar hypothetical attacks. > > Leaks of information from files an

Re: [FFmpeg-devel] [PATCH] FATE: Add test for libavfilter/scale2ref

2017-06-04 Thread Kevin Mark
On Sun, Jun 4, 2017 at 4:19 AM, Gyan wrote: > Now that this feature has been applied, it may be helpful to check if one > of the W/H arguments is of the form '-n' and log a warning that this will > force the ref's display aspect ratio. The warning should also convey the > expression to use: 'oh*m

Re: [FFmpeg-devel] [PATCH] fate: add test for the Dirac low delay profile

2017-06-04 Thread Rostislav Pehlivanov
On 5 June 2017 at 00:44, Michael Niedermayer wrote: > On Sun, Jun 04, 2017 at 06:03:36PM +0100, Rostislav Pehlivanov wrote: > > --- > > tests/fate/video.mak | 3 +++ > > tests/ref/fate/dirac-low-delay | 7 +++ > > 2 files changed, 10 insertions(+) > > create mode 100644 tests/ref/

Re: [FFmpeg-devel] [PATCH] avformat/hls: Check local file extensions

2017-06-04 Thread Nicolas George
Le septidi 17 prairial, an CCXXV, Michael Niedermayer a écrit : > Applied with the author name joke suggested by nicolas Despite Hendrik's objection? The joke name was nit an approval, and I had no authority to give it anyway. (On a phone and bad network, will reply to the other mail later.) --