Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-04 Thread Michael Niedermayer
On Wed, May 03, 2017 at 11:27:53PM -0300, James Almer wrote: > On 5/3/2017 11:00 PM, Michael Niedermayer wrote: > > On Wed, May 03, 2017 at 03:28:53PM +0200, Hendrik Leppkes wrote: > >> On Wed, May 3, 2017 at 3:23 PM, Michael Niedermayer > >> wrote: > >>> On Wed, May 03, 2017 at 12:54:53PM +0200,

[FFmpeg-devel] Multipage tiff

2017-05-04 Thread Olivier Galibert
Hi, Is multipage tiff supported? Information on the web is contradictory. Best, OG. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-04 Thread Michael Niedermayer
On Wed, May 03, 2017 at 05:21:50AM +0200, Michael Niedermayer wrote: > Fixes timeout > Fixes: 1293/clusterfuzz-testcase-minimized-6054752074858496 This patch also fixes 1309/clusterfuzz-testcase-minimized-5754803370065920 [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC7870

[FFmpeg-devel] [PATCH] tests/fate/fifo-muxer: update fifo-muxer dependencies

2017-05-04 Thread Tobias Rapp
Fixes fate when configured with --disable-network. --- tests/fate/fifo-muxer.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/fifo-muxer.mak b/tests/fate/fifo-muxer.mak index ef8b3b3..9c13954 100644 --- a/tests/fate/fifo-muxer.mak +++ b/tests/fate/fifo-muxer.mak @

Re: [FFmpeg-devel] Multipage tiff

2017-05-04 Thread Moritz Barsnick
On Thu, May 04, 2017 at 13:31:16 +0200, Olivier Galibert wrote: > Is multipage tiff supported? Information on the web is contradictory. This is a question for ffmpeg-user, not for ffmpeg-devel. Have you tried? I did, and it seems that ffmpeg sees only the first image. I always considered multi-

Re: [FFmpeg-devel] [PATCH] fixes the issue https://trac.ffmpeg.org/ticket/6338

2017-05-04 Thread Moritz Barsnick
On Thu, May 04, 2017 at 08:04:21 +0530, Vineet Goel wrote: > sorry about that. I am not proficient with git and development. There are a lot of useful hints here: https://ffmpeg.org/developer.html Actually pretty much a must-read before submitting patches. ;-) > And I am attaching the patch file

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-04 Thread James Almer
On 5/4/2017 7:51 AM, Michael Niedermayer wrote: > On Wed, May 03, 2017 at 11:27:53PM -0300, James Almer wrote: >> On 5/3/2017 11:00 PM, Michael Niedermayer wrote: >>> On Wed, May 03, 2017 at 03:28:53PM +0200, Hendrik Leppkes wrote: On Wed, May 3, 2017 at 3:23 PM, Michael Niedermayer wrot

[FFmpeg-devel] [PATCH] avcodec: Avoid splitting side data repeatedly

2017-05-04 Thread Michael Niedermayer
Fixes Timeout Fixes: 508/clusterfuzz-testcase-6245747678773248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/avpacket.c | 24 libavcodec/decode.c | 9 +++-- lib

Re: [FFmpeg-devel] [PATCH] avcodec: Avoid splitting side data repeatedly

2017-05-04 Thread James Almer
On 5/4/2017 12:15 PM, Michael Niedermayer wrote: > Fixes Timeout > Fixes: 508/clusterfuzz-testcase-6245747678773248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/avpacket.c | 24 ++

Re: [FFmpeg-devel] [PATCH] fixes the issue https://trac.ffmpeg.org/ticket/6338

2017-05-04 Thread Vineet Goel
thank for you pointing it out. I'll go through the docs. and for this patch do I have to redo as per norms, or is it accepted? regards, Vineet On Thu, May 4, 2017 at 8:04 PM, Moritz Barsnick wrote: > On Thu, May 04, 2017 at 08:04:21 +0530, Vineet Goel wrote: > > sorry about that. I am not pro

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/mpeg4videodec: Convert sprite_offset to 64bit

2017-05-04 Thread Michael Niedermayer
On Wed, May 03, 2017 at 05:21:51AM +0200, Michael Niedermayer wrote: > This avoids intermediates from overflowing (the final values are checked) > Fixes: runtime error: signed integer overflow: -167712 + -2147352576 cannot > be represented in type 'int' > > Fixes: 1298/clusterfuzz-testcase-minimi

Re: [FFmpeg-devel] [PATCH] avcodec/flicvideo: Check for chunk overread

2017-05-04 Thread Michael Niedermayer
On Tue, May 02, 2017 at 12:54:34AM +0200, Michael Niedermayer wrote: > Fixes integer overflow > Fixes: 1292/clusterfuzz-testcase-minimized-5795512143839232 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/flicvideo.c | 20 +++- > 1 file changed, 19 insertions(+), 1 delet

Re: [FFmpeg-devel] fate/exr : add test for Y, B44A negative, datawindow != display window

2017-05-04 Thread Martin Vignali
2017-05-01 14:31 GMT+02:00 Martin Vignali : > Hello, > > In attach a patch to add fate tests for exr > > samples can be found here > https://we.tl/ItuIX0BMfk > > and need to be put inside fate-suite/exr > > can be test with make fate-exr SAMPLES=fate-suite/ > > Theses tests increase coverage of ex

Re: [FFmpeg-devel] [PATCH] avcodec/wavpack: Fix invalid shift and integer overflow

2017-05-04 Thread Michael Niedermayer
On Fri, Apr 07, 2017 at 03:38:12AM +0200, Michael Niedermayer wrote: > Fixes: 940/clusterfuzz-testcase-5200378381467648 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg > Signed-off-by: Michael Niedermayer > --- > libavcodec/wavpack.c | 2

Re: [FFmpeg-devel] [PATCH] cuvid: support AVCodecContext.hw_device_ctx API

2017-05-04 Thread Philip Langdale
On 2017-05-02 16:56, wm4 wrote: This is a newer API that is intended for decoders like the cuvid wrapper. Until now, the wrapper required to set an awkward "incomplete" hw_frames_ctx to set the device. Now the device can be set directly, and the user can get AV_PIX_FMT_CUDA output for a specific

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Kyle Swanson
Hi, On Tue, May 2, 2017 at 12:18 PM, wm4 wrote: > On Tue, 2 May 2017 16:16:35 +0200 > Nicolas George wrote: > >> Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : >> > This is all one big mess. >> >> It is, but I will not take responsibility when it is not mine. >> >> Libavfilter was in need

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Nicolas George
Le quintidi 15 floréal, an CCXXV, Kyle Swanson a écrit : > I believe this is still broken on git master and is present on release Well, nobody fixed it. > 3.3. If a proper fix is going to take time, There is no reason it should, the issue is rather simple. >

Re: [FFmpeg-devel] [PATCH] cuvid: support AVCodecContext.hw_device_ctx API

2017-05-04 Thread Timo Rothenpieler
--- a/libavcodec/cuvid.c +++ b/libavcodec/cuvid.c @@ -802,9 +802,17 @@ static av_cold int cuvid_decode_init(AVCodecContext *avctx) goto error; } } else { -ret = av_hwdevice_ctx_create(&ctx->hwdevice, AV_HWDEVICE_TYPE_CUDA, ctx->cu_gpu, NULL, 0); -if (

Re: [FFmpeg-devel] [PATCH]compat/strtod: Add missing const qualifiers

2017-05-04 Thread Carl Eugen Hoyos
2017-05-02 22:29 GMT+02:00 Aaron Levinson : > On 5/1/2017 1:51 AM, Carl Eugen Hoyos wrote: >> >> Hi! >> >> Even without the casts, the patch reduces the number of warnings shown >> when compiling compat/strtod from seven to three. >> >> Please comment, Carl Eugen > > LGTM Patch applied. Thank you

Re: [FFmpeg-devel] [PATCH]configure: Fix libopus detection

2017-05-04 Thread Carl Eugen Hoyos
2017-05-04 5:28 GMT+02:00 James Almer : > On 5/3/2017 4:24 AM, Carl Eugen Hoyos wrote: >> 2017-03-30 0:47 GMT+02:00 Carl Eugen Hoyos : >> >>> Attached patch fixes a compilation error here. >> >> If nobody wants to work on this issue, I'll commit >> this patch in a few days. >> >> Carl Eugen > > I h

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread wm4
On Thu, 4 May 2017 22:24:15 +0200 Nicolas George wrote: > Le quintidi 15 floréal, an CCXXV, Kyle Swanson a écrit : > > I believe this is still broken on git master and is present on release > > Well, nobody fixed it. > > > 3.3. If a proper fix is going to take time, > > There is no reason

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-04 Thread wm4
On Thu, 4 May 2017 12:51:14 +0200 Michael Niedermayer wrote: > On Wed, May 03, 2017 at 11:27:53PM -0300, James Almer wrote: > > On 5/3/2017 11:00 PM, Michael Niedermayer wrote: > > > On Wed, May 03, 2017 at 03:28:53PM +0200, Hendrik Leppkes wrote: > > >> On Wed, May 3, 2017 at 3:23 PM, Michae

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Nicolas George
Le quintidi 15 floréal, an CCXXV, Nicolas George a écrit : > Absolutely not, these change were there for a reason, that reason is > still valid. Also, the bug is not in libavfilter, so reverting changes in libavfilter makes no sense. Regards, -- Nicolas George signature.asc Description: Dig

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread wm4
On Fri, 5 May 2017 00:05:35 +0200 Nicolas George wrote: > Le quintidi 15 floréal, an CCXXV, Nicolas George a écrit : > > Absolutely not, these change were there for a reason, that reason is > > still valid. > > Also, the bug is not in libavfilter, so reverting changes in libavfilter > makes no

[FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-04 Thread Carl Eugen Hoyos
Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function ‘av_timecode_make_string’: libavutil/timecode.c:103:60: warning: ‘%02d’ directive output may be truncated writing between 2 and 10 bytes into a region of size between 0 and 7 [-Wforma

[FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-04 Thread Carl Eugen Hoyos
Hi! It may be better to disable the warning. Carl Eugen From ab94367f502ab00f643a78608593eb9522e5c3be Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 5 May 2017 01:30:19 +0200 Subject: [PATCH] lavu/opt: Use "&&" instead of "*" in boolean expression. Fixes the following warning: libav

[FFmpeg-devel] [PATCH] avcodec/wavpack: Fix signed integer overflow: 1285114081 * 2 cannot be represented in type 'int'

2017-05-04 Thread Michael Niedermayer
Fixes: 945/clusterfuzz-testcase-6037937588273152 Fixes: integer overflow Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] ffmpeg: check for unconnected outputs

2017-05-04 Thread Carl Eugen Hoyos
2017-05-03 1:06 GMT+02:00 wm4 : > Fixes e.g.: > > ffmpeg -f lavfi -i testsrc -f lavfi -i testsrc -filter_complex > "[0:v][1:v]psnr[out]" -f null none I believe you forgot to fix the commit message. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

2017-05-04 Thread Aaron Levinson
On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: > Hi! > > It may be better to disable the warning. > > Carl Eugen > > -num = den ? num * intnum / den : (num * intnum ? INFINITY : NAN); > +num = den ? num * intnum / den : (num && intnum ? INFINITY : NAN); In order to preserve the ori

Re: [FFmpeg-devel] [RFC]lavu/timecode: Increase AV_TIMECODE_STR_SIZE.

2017-05-04 Thread Aaron Levinson
On 5/4/2017 4:27 PM, Carl Eugen Hoyos wrote: Hi! Attached patch is one possibility to fix the following warning with gcc 7: libavutil/timecode.c: In function ‘av_timecode_make_string’: libavutil/timecode.c:103:60: warning: ‘%02d’ directive output may be truncated writing between 2 and 10 bytes i

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/avpacket: Use av_copy_packet_side_data() in av_packet_copy_props()

2017-05-04 Thread James Almer
On 5/4/2017 6:59 PM, wm4 wrote: > On Thu, 4 May 2017 12:51:14 +0200 > Michael Niedermayer wrote: > >> On Wed, May 03, 2017 at 11:27:53PM -0300, James Almer wrote: >>> On 5/3/2017 11:00 PM, Michael Niedermayer wrote: On Wed, May 03, 2017 at 03:28:53PM +0200, Hendrik Leppkes wrote: > O

Re: [FFmpeg-devel] [PATCH] libavformat/hls: Observe Set-Cookie headers

2017-05-04 Thread Micah Galizia
On 2017-05-02 09:04 PM, wm4 wrote: On Tue, 2 May 2017 20:47:06 -0400 Micah Galizia wrote: Signed-off-by: Micah Galizia --- libavformat/hls.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index bac53a4350..643d50e1da

Re: [FFmpeg-devel] fate/exr : add test for Y, B44A negative, datawindow != display window

2017-05-04 Thread Michael Niedermayer
On Mon, May 01, 2017 at 02:31:28PM +0200, Martin Vignali wrote: > Hello, > > In attach a patch to add fate tests for exr > > samples can be found here > https://we.tl/ItuIX0BMfk uploaded [..] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Everything should be made

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-04 Thread Steven Liu
2017-05-03 9:49 GMT+08:00 Aaron Levinson : > On 4/27/2017 7:21 PM, Steven Liu wrote: > >> 2017-04-26 7:30 GMT+08:00 Steven Liu : >> >> fix ticket id: #6353 >>> >>> Signed-off-by: Steven Liu >>> --- >>> libavformat/hlsenc.c | 24 >>> 1 file changed, 24 insertions(+) >>> >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-04 Thread Aaron Levinson
On 5/4/2017 9:15 PM, Steven Liu wrote: 2017-05-03 9:49 GMT+08:00 Aaron Levinson : On 4/27/2017 7:21 PM, Steven Liu wrote: 2017-04-26 7:30 GMT+08:00 Steven Liu : fix ticket id: #6353 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 24 1 file changed, 24 inser

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: hold old key info when append list

2017-05-04 Thread Steven Liu
2017-05-05 12:29 GMT+08:00 Aaron Levinson : > On 5/4/2017 9:15 PM, Steven Liu wrote: > >> 2017-05-03 9:49 GMT+08:00 Aaron Levinson : >> >> On 4/27/2017 7:21 PM, Steven Liu wrote: >>> >>> 2017-04-26 7:30 GMT+08:00 Steven Liu : fix ticket id: #6353 > > Signed-off-by: Steven Li

Re: [FFmpeg-devel] [PATCH] This fixes ISO date formatissue when manifest created by this muxer is not playable in most players. This ensures compatibility with dash standard. Tested on many players (d

2017-05-04 Thread Aaron Levinson
On 5/2/2017 2:29 PM, wm4 wrote: On Tue, 2 May 2017 14:17:33 -0700 Aaron Levinson wrote: On 5/1/2017 11:06 PM, MFojtak wrote: Currently this muxer does not work at all. I don't know if 000Z would make it compatible with more player as I don't know any. However, adding Z makes it compatible wit

[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

2017-05-04 Thread Muhammad Faiz
This should fix Ticket6349. Since 383057f8e744efeaaa3648a59bc577b25b055835, framequeue may generate unaligned frame data. Signed-off-by: Muhammad Faiz --- libavfilter/avfilter.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c

Re: [FFmpeg-devel] [PATCH] avcodec/libmp3lame: properly handle unaligned frame data

2017-05-04 Thread Muhammad Faiz
On Fri, May 5, 2017 at 3:15 AM, Kyle Swanson wrote: > Hi, > > On Tue, May 2, 2017 at 12:18 PM, wm4 wrote: >> On Tue, 2 May 2017 16:16:35 +0200 >> Nicolas George wrote: >> >>> Le duodi 12 floréal, an CCXXV, Paul B Mahol a écrit : >>> > This is all one big mess. >>> >>> It is, but I will not take

Re: [FFmpeg-devel] [PATCH] Fixed bug encountered when decoding interlaced video

2017-05-04 Thread Aaron Levinson
On 4/12/2017 6:08 PM, Aaron Levinson wrote: > On 3/26/2017 10:34 AM, Aaron Levinson wrote: >> On 3/26/2017 4:41 AM, Matthias Hunstock wrote: >>> Am 26.03.2017 um 11:50 schrieb Aaron Levinson: When using the following command to play back either file: ffmpeg -i -f decklink -pix_fmt uyvy4