Re: [FFmpeg-devel] [PATCHv2] avfilter/vf_framerate: always request input if no output is provided in request_frame

L'octidi 18 germinal, an CCXXV, Marton Balint a écrit : > Fixes ticket #6285. > > Signed-off-by: Marton Balint > --- > libavfilter/vf_framerate.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Still LGTM, of course. But since the questions of elegance have been raised, here ar

Re: [FFmpeg-devel] Patch: filter af_amix inputs

On Thu, Apr 06, 2017 at 09:49:21AM +0100, John Warburton wrote: > Dear All, > > While needing automatically to mix several hundred audio files, I > noticed that the libavfilter module af_amix.c (audio filter 'amix') is > hard-coded to limit inputs to 32. Of course, I believe this to be > sensible

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

On Fri, Apr 07, 2017 at 08:30:50AM +0200, wm4 wrote: > On Fri, 7 Apr 2017 02:17:37 +0200 > Michael Niedermayer wrote: > > > On Wed, Mar 29, 2017 at 11:47:31AM +0200, wm4 wrote: > > > On Mon, 27 Mar 2017 00:41:05 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Sun, Mar 26, 2017 at 05:3

Re: [FFmpeg-devel] [PATCH] avfilter: implement vf_remap_frac

>> >> Signed-off-by: Daniel Oberhoff >> --- >> libavfilter/Makefile| 1 + >> libavfilter/allfilters.c| 1 + >> libavfilter/vf_remap_frac.c | 491 >> >> 3 files changed, 493 insertions(+) >> create mode 100644 libavfilter/vf_remap_frac.c >>

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/h264: Check weight values to be within the specs limits.

On Thu, Apr 06, 2017 at 10:32:15PM -0400, Ronald S. Bultje wrote: > Hi, > > On Thu, Apr 6, 2017 at 8:10 PM, Michael Niedermayer > wrote: > > > On Wed, Mar 22, 2017 at 07:09:23PM +0100, Michael Niedermayer wrote: > > > On Wed, Mar 22, 2017 at 09:06:09AM -0400, Ronald S. Bultje wrote: > > > > Hi,

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

Hi, On Fri, Apr 7, 2017 at 6:22 AM, Michael Niedermayer wrote: > if you say these are not bugs by definition even though its > quite obvious they are bugs then whatever you use as definition must > be flawed. Or you misunderstood what i wrote. > That's hypocritical. Id like to apply the patch

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

On Fri, 7 Apr 2017 12:22:07 +0200 Michael Niedermayer wrote: > On Fri, Apr 07, 2017 at 08:30:50AM +0200, wm4 wrote: > > On Fri, 7 Apr 2017 02:17:37 +0200 > > Michael Niedermayer wrote: > > > > > On Wed, Mar 29, 2017 at 11:47:31AM +0200, wm4 wrote: > > > > On Mon, 27 Mar 2017 00:41:05 +0200

Re: [FFmpeg-devel] [PATCH] avfilter: implement vf_remap_frac

L'octidi 18 germinal, an CCXXV, Daniel Oberhoff a écrit : > what do you propose? I personally have no objection underscores in filter names. Spaceswereinventedforareason. And we already have a few filters with underscores in them. On the other hand, the patch looks like a big copy-paste of the or

Re: [FFmpeg-devel] [PATCH] avfilter: implement vf_remap_frac

On 4/7/17, Daniel Oberhoff wrote: >>> >>> Signed-off-by: Daniel Oberhoff >>> --- >>> libavfilter/Makefile| 1 + >>> libavfilter/allfilters.c| 1 + >>> libavfilter/vf_remap_frac.c | 491 >>> >>> 3 files changed, 493 insertions(+) >>> create

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

On Fri, Apr 07, 2017 at 06:26:05AM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, Apr 7, 2017 at 6:22 AM, Michael Niedermayer > wrote: > > > if you say these are not bugs by definition even though its > > quite obvious they are bugs then whatever you use as definition must > > be flawed. Or yo

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

On Fri, Apr 07, 2017 at 12:35:37PM +0200, wm4 wrote: > On Fri, 7 Apr 2017 12:22:07 +0200 > Michael Niedermayer wrote: > > > On Fri, Apr 07, 2017 at 08:30:50AM +0200, wm4 wrote: > > > On Fri, 7 Apr 2017 02:17:37 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Wed, Mar 29, 2017 at 11:47

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

On Fri, 7 Apr 2017 13:07:23 +0200 Michael Niedermayer wrote: > On Fri, Apr 07, 2017 at 12:35:37PM +0200, wm4 wrote: > > On Fri, 7 Apr 2017 12:22:07 +0200 > > Michael Niedermayer wrote: > > > > > On Fri, Apr 07, 2017 at 08:30:50AM +0200, wm4 wrote: > > > > On Fri, 7 Apr 2017 02:17:37 +0200 >

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

Hi, On Fri, Apr 7, 2017 at 6:47 AM, Michael Niedermayer wrote: > On Fri, Apr 07, 2017 at 06:26:05AM -0400, Ronald S. Bultje wrote: > > On Fri, Apr 7, 2017 at 6:22 AM, Michael Niedermayer > > > > Id like to apply the patch unless you or someone else objects. > > > > I really don't like this appr

[FFmpeg-devel] [PATCH] avutil/internal: Do not enable CHECKED with DEBUG

This avoids potential undefined behavior in debug mode while still allowing developers which want to check for potential additional overflows to do so by manually enabling this. Signed-off-by: Michael Niedermayer --- libavutil/internal.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)

Re: [FFmpeg-devel] [PATCH] vf_framestep: add blend parameter for motion blur effect

On Thu, Apr 6, 2017 at 5:00 PM, Michael Niedermayer wrote: > On Thu, Apr 06, 2017 at 02:09:46PM +0100, Matthias Troffaes wrote: >> Many thanks for your feedback, Michael and Nicolas. >> >> On Wed, Apr 5, 2017 at 7:02 PM, Michael Niedermayer >> wrote: >> > fails on qemu mips >> >> Thank you for fl

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

Hi, On Fri, Apr 7, 2017 at 2:37 AM, wm4 wrote: > On Thu, 6 Apr 2017 13:48:41 -0400 > "Ronald S. Bultje" wrote: > > > The av_log() is done outside the lock, but this way the accesses to the > > field (reads and writes) are always protected by a mutex. The av_log() > > is not run inside the lock

Re: [FFmpeg-devel] [PATCH] avutil/internal: Do not enable CHECKED with DEBUG

On Fri, 7 Apr 2017 13:49:09 +0200 Michael Niedermayer wrote: > This avoids potential undefined behavior in debug mode while still allowing > developers which want to check for potential additional overflows to do so > by manually enabling this. > > Signed-off-by: Michael Niedermayer > --- > l

Re: [FFmpeg-devel] [PATCH] pthread_frame: make accesses to debug field be protected by owner lock.

On Fri, 7 Apr 2017 08:30:00 -0400 "Ronald S. Bultje" wrote: > Hi, > > On Fri, Apr 7, 2017 at 2:37 AM, wm4 wrote: > > > On Thu, 6 Apr 2017 13:48:41 -0400 > > "Ronald S. Bultje" wrote: > > > > > The av_log() is done outside the lock, but this way the accesses to the > > > field (reads and wr

Re: [FFmpeg-devel] [PATCH] avcodec/mjpegdec: Fixes runtime error: signed integer overflow: -24543 * 2031616 cannot be represented in type 'int'

On Fri, Apr 07, 2017 at 07:46:01AM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, Apr 7, 2017 at 6:47 AM, Michael Niedermayer > wrote: > > > On Fri, Apr 07, 2017 at 06:26:05AM -0400, Ronald S. Bultje wrote: > > > On Fri, Apr 7, 2017 at 6:22 AM, Michael Niedermayer > > > > > > Id like to apply

Re: [FFmpeg-devel] [PATCH] avutil/internal: Do not enable CHECKED with DEBUG

Hi, On Fri, Apr 7, 2017 at 7:49 AM, Michael Niedermayer wrote: > This avoids potential undefined behavior in debug mode while still allowing > developers which want to check for potential additional overflows to do so > by manually enabling this. > > Signed-off-by: Michael Niedermayer > --- >

Re: [FFmpeg-devel] [PATCH] libopus: Add channel mapping 2 support in libopusdec

Hi, Just wanted to follow up and check if there any changes I should add to this patch? Thanks for taking a look. Felicia On Mon, Mar 27, 2017 at 5:35 PM Felicia Lim wrote: > Hi all, > > Here is another patch to decode Opus ambisonics files using channel > mapping 2 [1], this time in libopusd

Re: [FFmpeg-devel] Patch: filter af_amix inputs

On Fri, Apr 7, 2017 at 10:25 AM, Michael Niedermayer wrote: > > this patch is corrupted by linebreaks I'm sorry about that. It's attached to this email, from a file made by git format-patch. J -- John Warburton Tonmeister, Director, Associate Lecturer, University of Surrey Department of Music and

Re: [FFmpeg-devel] [PATCH] ffmpeg: use av_stream_new_side_data()

On 12/26/2016 6:36 PM, James Almer wrote: > Signed-off-by: James Almer > --- > ffmpeg.c | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/ffmpeg.c b/ffmpeg.c > index ec9da3e..a1c02ca 100644 > --- a/ffmpeg.c > +++ b/ffmpeg.c > @@ -2916,26 +2916,17 @@ stat

Re: [FFmpeg-devel] [PATCH v2] lavf: use the new bitstream filter for extracting extradata

On 4/5/2017 6:22 PM, James Almer wrote: > On 4/1/2017 9:03 PM, James Almer wrote: >> This merges commits 8e2ea691351c5079cdab245ff7bfa5c0f3e3bfe4 and >> 096a8effa3f8f3455292c958c3ed07e798def7bd by Anton Khirnov, with the >> following change: >> >> - extract_extradata_check() is added to know if the

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/hevc_parse: ignore all non parameter set NAL units in extradata

On 4/3/2017 7:04 AM, Michael Niedermayer wrote: > On Sun, Apr 02, 2017 at 10:45:43PM -0300, James Almer wrote: >> While they shouldn't be present, they are harmless if they are. >> >> Signed-off-by: James Almer >> --- >> libavcodec/hevc_parse.c | 21 ++--- >> 1 file changed, 2 ins

Re: [FFmpeg-devel] [PATCH] vf_pad: center image on padded area if negative x/y

On 3 April 2017 at 19:34, Ricardo Constantino wrote: > or if x/y go beyond padded area. > > This is mostly useful when paired with the aspect option. > Defaults aren't changed. > > Idea for this was taken from mpv's soon-to-be-removed expand vf. > --- > doc/filters.texi | 3 +++ > libavfilt

[FFmpeg-devel] [PATCH 2/2] doc/examples/decode_video: Fix format string vulnerability

Fixes: CID1404843 Signed-off-by: Michael Niedermayer --- doc/examples/decode_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c index 613bc5cc88..4377fd49e0 100644 --- a/doc/examples/decode_video.c +++ b/doc/examp

[FFmpeg-devel] [PATCH 1/2] avcodec/dcadsp: Fix runtime error: signed integer overflow

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/dcadsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dcadsp.c b/libavcodec/dcadsp.c index 4f1e933cfb..fade1a6c02

Re: [FFmpeg-devel] [PATCH v12] avformat/dashdec: add dash demuxer base version

Steven Liu wrote: ffmpeg need a dash demuxer for demux the dash formats base on https://github.com/samsamsam-iptvplayer/exteplayer3/blob/master/tmp/ffmpeg/patches/3.2.2/01_add_dash_demux.patch Just a user, this will be a good feature. This patch doesn't seem to work with say - http://dash

Re: [FFmpeg-devel] Fix leaked dictionary in mp3dec

In Chromium code, we set s->metadata ahead of time, with a custom entry to avoid id3v1 tag parsing. Some recent changes in mp3dec.c meant that we had to update this code, and in the process, we discovered this reference leak on our end. I am submitting this patch as a general code hardening patch

Re: [FFmpeg-devel] [PATCH] Observe Set-Cookie headers in HLS streams

On 2017-04-07 02:48 AM, wm4 wrote: On Thu, 6 Apr 2017 22:48:59 -0400 Micah Galizia wrote: Signed-off-by: Micah Galizia --- libavformat/hls.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/liba

[FFmpeg-devel] [PATCH 2/2] avcodec/pixlet: Reorder rlen check

This changes nothing but is nicer looking as this checks rlen Maybe this helps coverity remove CID1397743 Signed-off-by: Michael Niedermayer --- libavcodec/pixlet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pixlet.c b/libavcodec/pixlet.c index 4aa59f8f33..c4

[FFmpeg-devel] [PATCH 1/2] avcodec/mjpegenc_huffman: Assert length in ff_mjpegenc_huffman_compute_bits()

This should help coverity see that the issues this leads to cannot occur Signed-off-by: Michael Niedermayer --- libavcodec/mjpegenc_huffman.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/mjpegenc_huffman.c b/libavcodec/mjpegenc_huffman.c index ebf1311466..0e63f8066b 100644 --

[FFmpeg-devel] [PATCH] avfilter/avf_showcqt: add attack option

Signed-off-by: Muhammad Faiz --- doc/filters.texi | 5 + libavfilter/avf_showcqt.c | 39 --- libavfilter/avf_showcqt.h | 3 +++ libavfilter/version.h | 2 +- 4 files changed, 41 insertions(+), 8 deletions(-) diff --git a/doc/filters.texi b/