Hi, On Fri, Apr 7, 2017 at 6:47 AM, Michael Niedermayer <mich...@niedermayer.cc> wrote:
> On Fri, Apr 07, 2017 at 06:26:05AM -0400, Ronald S. Bultje wrote: > > On Fri, Apr 7, 2017 at 6:22 AM, Michael Niedermayer > <mich...@niedermayer.cc> > > > Id like to apply the patch unless you or someone else objects. > > > > I really don't like this approach. I'd like you to try to find something > > more sensible that protects developer machines from bugs also. > > i suggested to decouple SUINT from the #ifdef DEBUG, which fixes > exactly that possibility (and noone seemed to care) You asked - in this email - to apply this patch as-is. The patch does not decouple #ifdef DEBUG from SUINT. Now the question is whether SUINT has any raison d'etre in our main codebase. If it's under #if 0 or otherwise "dead code", any Diego'ification would immediately get rid of it. So answer me this question: if the code is under #if 0, why shouldn't it just exist locally on your hard disk only? (Yes, I have actual (old) debug branches for the vp9 decoder locally.) Ronald _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
