Re: [FFmpeg-devel] [PATCH 3/3] avformat/matroska: use av_stream_add_side_data() for stereo3d side data

2016-11-19 Thread Michael Niedermayer
On Thu, Nov 17, 2016 at 02:41:15AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroska.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/libavformat/matroska.c b/libavformat/matroska.c > index c592fb0..7a3d233 10064

Re: [FFmpeg-devel] [PATCH] options_table: replace INT64_MAX with a sligthly smaller value

2016-11-19 Thread Andreas Cadhalpun
On 19.11.2016 01:39, Michael Niedermayer wrote: > On Fri, Nov 18, 2016 at 11:06:56PM +0100, Andreas Cadhalpun wrote: >> AVOption.max is a double, which has not enough precision for INT64_MAX. >> >> It gets interpreted as INT64_MIN, when converted back to int64_t. >> >> Signed-off-by: Andreas Cadhal

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-19 Thread Andreas Cadhalpun
On 19.11.2016 02:14, Michael Niedermayer wrote: > On Fri, Nov 18, 2016 at 10:35:29PM +0100, Andreas Cadhalpun wrote: >> On 18.11.2016 02:40, Michael Niedermayer wrote: >>> On Thu, Nov 17, 2016 at 07:35:01PM +0100, Andreas Cadhalpun wrote: +if (size < 0 || size >= FF_MAX_EXTRADA

Re: [FFmpeg-devel] [PATCH] swscale/options: Use AV_OPT_TYPE_PIXEL_FMT

2016-11-19 Thread Andreas Cadhalpun
On 19.11.2016 02:41, Michael Niedermayer wrote: > Found-by: Andreas Cadhalpun > Signed-off-by: Michael Niedermayer > --- > libswscale/options.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libswscale/options.c b/libswscale/options.c > index c1ea336..7eb2752 10064

Re: [FFmpeg-devel] [PATCH] Added the interface for the Turing codec

2016-11-19 Thread Moritz Barsnick
On Fri, Nov 18, 2016 at 20:15:30 +0100, wm4 wrote: > This lib has a really weird API... I can't judge the algorithms or the development direction and stuff - I'm sure it's all state of the art. But the API sure gives me goosebumps, and I don't mean the sexy feelgood type. Sure, it has all the fle

[FFmpeg-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

2016-11-19 Thread Andreas Cadhalpun
This fixes segmentation faults due to stack-overflow caused by too deep recursion. Signed-off-by: Andreas Cadhalpun --- libavcodec/smacker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c index b8a0c55..0fec7a3 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

2016-11-19 Thread Michael Niedermayer
On Sat, Nov 19, 2016 at 02:29:35PM +0100, Andreas Cadhalpun wrote: > This fixes segmentation faults due to stack-overflow caused by too deep > recursion. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/smacker.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) breaks fate [s

Re: [FFmpeg-devel] [PATCH 3/3] avformat/matroska: use av_stream_add_side_data() for stereo3d side data

2016-11-19 Thread James Almer
On 11/19/2016 7:35 AM, Michael Niedermayer wrote: > On Thu, Nov 17, 2016 at 02:41:15AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/matroska.c | 22 -- >> 1 file changed, 8 insertions(+), 14 deletions(-) >> >> diff --git a/libavformat/matroska.

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-19 Thread Michael Niedermayer
On Sat, Nov 19, 2016 at 02:04:44PM +0100, Andreas Cadhalpun wrote: > On 19.11.2016 02:14, Michael Niedermayer wrote: > > On Fri, Nov 18, 2016 at 10:35:29PM +0100, Andreas Cadhalpun wrote: > >> On 18.11.2016 02:40, Michael Niedermayer wrote: > >>> On Thu, Nov 17, 2016 at 07:35:01PM +0100, Andreas Ca

[FFmpeg-devel] [PATCH] avcodec/avpacket: fix leak on realloc in av_packet_add_side_data()

2016-11-19 Thread James Almer
If realloc fails, the pointer is overwritten and the previously allocated buffer is leaked, which goes against the expected functionality of keeping the packet unchanged in case of error. Signed-off-by: James Almer --- Should i backport this to affected branches? libavcodec/avpacket.c | 7 -

Re: [FFmpeg-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

2016-11-19 Thread Andreas Cadhalpun
On 19.11.2016 16:13, Michael Niedermayer wrote: > On Sat, Nov 19, 2016 at 02:29:35PM +0100, Andreas Cadhalpun wrote: >> This fixes segmentation faults due to stack-overflow caused by too deep >> recursion. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavcodec/smacker.c | 4 ++-- >> 1 file c

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-19 Thread Andreas Cadhalpun
On 19.11.2016 16:28, Michael Niedermayer wrote: > On Sat, Nov 19, 2016 at 02:04:44PM +0100, Andreas Cadhalpun wrote: >> On 19.11.2016 02:14, Michael Niedermayer wrote: >>> On Fri, Nov 18, 2016 at 10:35:29PM +0100, Andreas Cadhalpun wrote: On 18.11.2016 02:40, Michael Niedermayer wrote: > O

[FFmpeg-devel] [RFC] lavf: add CoreMedia AVCodecTag mappings

2016-11-19 Thread Josh de Kock
I've mapped a fair amount of the CoreMedia FourCCs to their respective AVCodecIDs. The ones I didn't know or thought didn't exist in FFmpeg have been mapped to AV_CODEC_ID_NONE. Signed-off-by: Josh de Kock --- libavformat/Makefile| 1 + libavformat/avformat.h | 32 ++ libavformat

Re: [FFmpeg-devel] [PATCH] swscale/options: Use AV_OPT_TYPE_PIXEL_FMT

2016-11-19 Thread Michael Niedermayer
On Sat, Nov 19, 2016 at 02:09:38PM +0100, Andreas Cadhalpun wrote: > On 19.11.2016 02:41, Michael Niedermayer wrote: > > Found-by: Andreas Cadhalpun > > Signed-off-by: Michael Niedermayer > > --- > > libswscale/options.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff

[FFmpeg-devel] [PATCH] avformat/utils: check for overflow before reallocating side data

2016-11-19 Thread James Almer
This makes av_stream_add_side_data() consistent with av_packet_add_side_data(). Signed-off-by: James Almer --- libavformat/utils.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 19bb8bd..9d01bab 100644 --- a/libavformat/uti

Re: [FFmpeg-devel] libavcodec : add psd image file decoder

2016-11-19 Thread Andreas Cadhalpun
On 18.11.2016 18:27, Martin Vignali wrote: > From c41e6c79ed42478a1658c8922d19c832d3a89424 Mon Sep 17 00:00:00 2001 > From: Martin Vignali > Date: Fri, 18 Nov 2016 18:18:20 +0100 > Subject: [PATCH 1/2] libavcodec : add decoder for Photoshop PSD image file.

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-19 Thread Michael Niedermayer
On Sat, Nov 19, 2016 at 05:30:59PM +0100, Andreas Cadhalpun wrote: > On 19.11.2016 16:28, Michael Niedermayer wrote: > > On Sat, Nov 19, 2016 at 02:04:44PM +0100, Andreas Cadhalpun wrote: > >> On 19.11.2016 02:14, Michael Niedermayer wrote: > >>> On Fri, Nov 18, 2016 at 10:35:29PM +0100, Andreas Ca

[FFmpeg-devel] [PATCH] avcodec/cuvid: Add support for P010 as an output surface format

2016-11-19 Thread Philip Langdale
The nvidia 375.xx driver introduces support for P016 output surfaces, for 10bit and 12bit HEVC content (it's also the first driver to support hardware decoding of 12bit content). Technically, we don't support P016, but in practice I don't think we zero-out the extra bits in P010 so it can be used

Re: [FFmpeg-devel] [PATCH] avformat/utils: check for overflow before reallocating side data

2016-11-19 Thread Michael Niedermayer
On Sat, Nov 19, 2016 at 03:09:15PM -0300, James Almer wrote: > This makes av_stream_add_side_data() consistent with > av_packet_add_side_data(). > > Signed-off-by: James Almer > --- > libavformat/utils.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) LGTM thx [...] -- Michael

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: fix leak on realloc in av_packet_add_side_data()

2016-11-19 Thread Michael Niedermayer
On Sat, Nov 19, 2016 at 01:10:27PM -0300, James Almer wrote: > If realloc fails, the pointer is overwritten and the previously allocated > buffer > is leaked, which goes against the expected functionality of keeping the packet > unchanged in case of error. > > Signed-off-by: James Almer > --- >

Re: [FFmpeg-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

2016-11-19 Thread Michael Niedermayer
On Sat, Nov 19, 2016 at 05:27:19PM +0100, Andreas Cadhalpun wrote: > On 19.11.2016 16:13, Michael Niedermayer wrote: > > On Sat, Nov 19, 2016 at 02:29:35PM +0100, Andreas Cadhalpun wrote: > >> This fixes segmentation faults due to stack-overflow caused by too deep > >> recursion. > >> > >> Signed-o

Re: [FFmpeg-devel] [PATCH] Added the interface for the Turing codec

2016-11-19 Thread Alexander Strasser
On 2016-11-19 14:29 +0100, Moritz Barsnick wrote: > On Fri, Nov 18, 2016 at 20:15:30 +0100, wm4 wrote: > > This lib has a really weird API... > > I can't judge the algorithms or the development direction and stuff - > I'm sure it's all state of the art. But the API sure gives me > goosebumps, and

Re: [FFmpeg-devel] [PATCH] avformat/utils: check for overflow before reallocating side data

2016-11-19 Thread James Almer
On 11/19/2016 7:19 PM, Michael Niedermayer wrote: > On Sat, Nov 19, 2016 at 03:09:15PM -0300, James Almer wrote: >> This makes av_stream_add_side_data() consistent with >> av_packet_add_side_data(). >> >> Signed-off-by: James Almer >> --- >> libavformat/utils.c | 5 - >> 1 file changed, 4 in

Re: [FFmpeg-devel] [PATCH] avcodec/avpacket: fix leak on realloc in av_packet_add_side_data()

2016-11-19 Thread James Almer
On 11/19/2016 7:30 PM, Michael Niedermayer wrote: > On Sat, Nov 19, 2016 at 01:10:27PM -0300, James Almer wrote: >> If realloc fails, the pointer is overwritten and the previously allocated >> buffer >> is leaked, which goes against the expected functionality of keeping the >> packet >> unchanged

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-19 Thread Andreas Cadhalpun
On 19.11.2016 22:36, Michael Niedermayer wrote: > On Sat, Nov 19, 2016 at 05:30:59PM +0100, Andreas Cadhalpun wrote: >> A hard failure is unnecessary and Carl Eugen [1] and Hendrik [2] >> convinced me that it should be avoided. > > I think there are 2 different things here > unavailable data, like

Re: [FFmpeg-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

2016-11-19 Thread Andreas Cadhalpun
On 19.11.2016 23:34, Michael Niedermayer wrote: > On Sat, Nov 19, 2016 at 05:27:19PM +0100, Andreas Cadhalpun wrote: >> diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c >> index b8a0c55..be3914b 100644 >> --- a/libavcodec/smacker.c >> +++ b/libavcodec/smacker.c >> @@ -129,8 +129,12 @@ stati

Re: [FFmpeg-devel] [libav-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

2016-11-19 Thread Andreas Cadhalpun
On 20.11.2016 00:25, Luca Barbato wrote: > On 19/11/2016 17:27, Andreas Cadhalpun wrote: >> This fixes segmentation faults due to stack-overflow caused by too >> deep recursion. > > You shouldn't be able to use hc->current for the same purpose? That's what I tried first, but it doesn't work, sinc

[FFmpeg-devel] [PATCH] configure: reserve a register for gcc before 5 on x86_32 with PIE

2016-11-19 Thread Andreas Cadhalpun
gcc before gcc-5 reserves a register on x86_32 for the GOT, when PIE is enabled. This fixes build failures due to: error: 'asm' operand has impossible constraints Signed-off-by: Andreas Cadhalpun --- A build log of a failed build with gcc 4.9 is available at: https://buildd.debian.org/status/fe

Re: [FFmpeg-devel] [PATCH] configure: reserve a register for gcc before 5 on x86_32 with PIE

2016-11-19 Thread Hendrik Leppkes
On Sun, Nov 20, 2016 at 1:07 AM, Andreas Cadhalpun wrote: > gcc before gcc-5 reserves a register on x86_32 for the GOT, when PIE is > enabled. > > This fixes build failures due to: > error: 'asm' operand has impossible constraints > > Signed-off-by: Andreas Cadhalpun > --- > > A build log of a fa

[FFmpeg-devel] [PATCH] avcodec/cuvid: Add support for P010 as an output surface format

2016-11-19 Thread Philip Langdale
The nvidia 375.xx driver introduces support for P016 output surfaces, for 10bit and 12bit HEVC content (it's also the first driver to support hardware decoding of 12bit content). Technically, we don't support P016, but in practice I don't think we zero-out the extra bits in P010 so it can be used

Re: [FFmpeg-devel] [PATCH] ffmdec: sanitize codec parameters

2016-11-19 Thread Michael Niedermayer
On Sun, Nov 20, 2016 at 12:37:05AM +0100, Andreas Cadhalpun wrote: > On 19.11.2016 22:36, Michael Niedermayer wrote: > > On Sat, Nov 19, 2016 at 05:30:59PM +0100, Andreas Cadhalpun wrote: > >> A hard failure is unnecessary and Carl Eugen [1] and Hendrik [2] > >> convinced me that it should be avoid

Re: [FFmpeg-devel] [PATCH] configure: reserve a register for gcc before 5 on x86_32 with PIE

2016-11-19 Thread Ronald S. Bultje
Hi, On Sat, Nov 19, 2016 at 7:07 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > gcc before gcc-5 reserves a register on x86_32 for the GOT, when PIE is > enabled. > > This fixes build failures due to: > error: 'asm' operand has impossible constraints > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] configure: reserve a register for gcc before 5 on x86_32 with PIE

2016-11-19 Thread James Almer
On 11/20/2016 12:19 AM, Ronald S. Bultje wrote: > Hi, > > On Sat, Nov 19, 2016 at 7:07 PM, Andreas Cadhalpun < > andreas.cadhal...@googlemail.com> wrote: > >> gcc before gcc-5 reserves a register on x86_32 for the GOT, when PIE is >> enabled. >> >> This fixes build failures due to: >> error: 'asm