Re: [FFmpeg-devel] [PATCH] avcodec/vda: define av_vda_default_init2 when CONFIG_H264_VDA_HWACCEL equ 0

2016-10-17 Thread Steven Liu
ping Xidorn Quan 2016-10-15 6:01 GMT+08:00 wm4 : > On Thu, 13 Oct 2016 20:57:07 +0800 > Steven Liu wrote: > > > ping > > > > 2016-10-12 17:36 GMT+08:00 Steven Liu : > > > > > on OSX: > > > ../configure --disable-everything --enable-demuxer=hls make > > > error message: Undefined symbols for arch

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Nicolas George
Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > probably, yes I would have said exactly the opposite. It is nothing but a waste of time and a pollution of the history. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-10-17 Thread Pallavi Kumari
I am not sure how to use fft function of ffmpeg. I tried on a test code https://dpaste.de/es8K. could you point me to an example or something? Also, could you help me with a timeline for this project. On Sat, Oct 15, 2016 at 10:34 PM, Pallavi Kumari wrote: > I will makes the necessary changes.

Re: [FFmpeg-devel] [OPW] OPW Project Proposal

2016-10-17 Thread Pallavi Kumari
Hi Michael, I figured out the use of fft. Help me with the time line setting. Thanks On Mon, Oct 17, 2016 at 1:37 PM, Pallavi Kumari wrote: > I am not sure how to use fft function of ffmpeg. I tried on a test code > https://dpaste.de/es8K. could you point me to an example or something? > > Also

Re: [FFmpeg-devel] FFmpeg 3.2

2016-10-17 Thread wm4
On Mon, 17 Oct 2016 04:24:40 +0200 Michael Niedermayer wrote: > On Sun, Oct 16, 2016 at 06:01:54PM -0400, Helmut K. C. Tessarek wrote: > > On 2016-09-27 09:30, Michael Niedermayer wrote: > > > Its long since FFmpeg 3.1, so its time to make 3.2 > > > ill branch release/3.2 off master and make 3.

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: support rtsps

2016-10-17 Thread wm4
On Sun, 16 Oct 2016 21:20:04 + Jay wrote: > This is the approach present in avformat/rtsp.c, but I can modify. What is > preferred? > > For clarity, this patch does not copy url params from the `rtsps://` input. > It passes tls params provided as cmd line options to the `tls://` protocol > h

Re: [FFmpeg-devel] [PATCH] matroskadec: fix NULL pointer dereference

2016-10-17 Thread wm4
On Sun, 16 Oct 2016 22:11:03 +0200 Andreas Cadhalpun wrote: > The problem was introduced in commit 1273bc6. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/matroskadec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/m

Re: [FFmpeg-devel] [PATCH] mov: move stsd finalization to an appropriate place

2016-10-17 Thread Hendrik Leppkes
On Sat, Oct 15, 2016 at 11:19 AM, Hendrik Leppkes wrote: > On Fri, Oct 14, 2016 at 3:21 PM, Carl Eugen Hoyos wrote: >> 2016-10-14 13:56 GMT+02:00 Hendrik Leppkes : >>> mov_finalize_stsd_codec parses stream information from the ALAC extradata, >>> so run it after the extradata processing is comple

Re: [FFmpeg-devel] [PATCH] matroskadec: fix NULL pointer dereference

2016-10-17 Thread Hendrik Leppkes
On Mon, Oct 17, 2016 at 12:13 PM, wm4 wrote: > On Sun, 16 Oct 2016 22:11:03 +0200 > Andreas Cadhalpun wrote: > >> The problem was introduced in commit 1273bc6. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/matroskadec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: > Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > > probably, yes > > I would have said exactly the opposite. It is nothing but a waste of time > and a pollution of the history. My idea here is to maximize the nu

Re: [FFmpeg-devel] [PATCH] matroskadec: fix NULL pointer dereference

2016-10-17 Thread Benoit Fouet
Hi, On 17/10/2016 06:49, James Almer wrote: On 10/16/2016 9:30 PM, James Almer wrote: On 10/16/2016 5:11 PM, Andreas Cadhalpun wrote: The problem was introduced in commit 1273bc6. Signed-off-by: Andreas Cadhalpun --- libavformat/matroskadec.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Clément Bœsch
On Mon, Oct 17, 2016 at 12:11:08AM +0200, Michael Behrisch wrote: > Am 16.10.2016 um 23:24 schrieb Clément Bœsch: > > On Sun, Oct 16, 2016 at 09:46:20PM +0200, Michael Behrisch wrote: > >> Hi all, > >> first of all thanks for providing this great library. > >> > >> Today my pull request https://git

[FFmpeg-devel] [PATCH v2] libavformat/tee: Add fifo support for tee

2016-10-17 Thread sebechlebskyjan
From: Jan Sebechlebsky Signed-off-by: Jan Sebechlebsky --- Thanks for noticing, I've fixed the patch (also some minor formatting issues I've noticed). doc/muxers.texi | 20 + libavformat/tee.c | 87 ++- 2 files changed, 106 i

Re: [FFmpeg-devel] [PATCH] avformat/tests/gitignore: add fifo_muxer entry

2016-10-17 Thread Jan Sebechlebsky
On 10/15/2016 06:32 PM, Zhao Zhili wrote: From a3ee9afc37331315e4ec57f1ebf881779b62bf60 Mon Sep 17 00:00:00 2001 From: Zhao Zhili Date: Sun, 16 Oct 2016 00:09:25 +0800 Subject: [PATCH] avformat/tests/gitignore: add fifo_muxer entry --- libavformat/tests/.gitignore | 1 + 1 file changed, 1

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread wm4
On Mon, 17 Oct 2016 13:09:36 +0200 Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: > > Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > > > probably, yes > > > > I would have said exactly the opposite. It is nothing but a waste

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-10-17 Thread Benoit Fouet
Hi, On 17/10/2016 02:34, James Almer wrote: > Fixes valgrind warning about "Conditional jump or move depends on > uninitialised value(s)" > > Signed-off-by: James Almer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mov.c b/libavf

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: > On Mon, 17 Oct 2016 13:09:36 +0200 > Michael Niedermayer wrote: > > > On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: > > > Le sextidi 26 vendémiaire, an CCXXV, Michael Niedermayer a écrit : > > > > probably, yes > > > >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-10-17 Thread James Almer
On 10/17/2016 10:05 AM, Benoit Fouet wrote: > Hi, > > > On 17/10/2016 02:34, James Almer wrote: >> Fixes valgrind warning about "Conditional jump or move depends on >> uninitialised value(s)" >> >> Signed-off-by: James Almer >> --- >> libavformat/mov.c | 2 +- >> 1 file changed, 1 insertion(+)

Re: [FFmpeg-devel] [PATCH] matroskadec: fix NULL pointer dereference

2016-10-17 Thread James Almer
On 10/17/2016 4:47 AM, Benoit Fouet wrote: > Hi, > > On 17/10/2016 06:49, James Almer wrote: >> On 10/16/2016 9:30 PM, James Almer wrote: >>> On 10/16/2016 5:11 PM, Andreas Cadhalpun wrote: The problem was introduced in commit 1273bc6. Signed-off-by: Andreas Cadhalpun ---

Re: [FFmpeg-devel] FFmpeg 3.2

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 12:01:56PM +0200, wm4 wrote: > On Mon, 17 Oct 2016 04:24:40 +0200 > Michael Niedermayer wrote: > > > On Sun, Oct 16, 2016 at 06:01:54PM -0400, Helmut K. C. Tessarek wrote: > > > On 2016-09-27 09:30, Michael Niedermayer wrote: > > > > Its long since FFmpeg 3.1, so its tim

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-10-17 Thread Richard Kern
> On Sep 19, 2016, at 10:30 AM, Aman Gupta wrote: > > > > On Monday, September 19, 2016, Richard Kern > wrote: > >> On Sep 10, 2016, at 10:33 PM, Aman Gupta > wrote: >> >> >> >> On Sunday, September 11, 2016, Richard Kern > wrote: >> >> > On Sep 8, 2016, at 4:19

Re: [FFmpeg-devel] [PATCH] matroskadec: fix NULL pointer dereference

2016-10-17 Thread Andreas Cadhalpun
On 17.10.2016 15:44, James Almer wrote: > On 10/17/2016 4:47 AM, Benoit Fouet wrote: >> On 17/10/2016 06:49, James Almer wrote: >>> On 10/16/2016 9:30 PM, James Almer wrote: On 10/16/2016 5:11 PM, Andreas Cadhalpun wrote: > The problem was introduced in commit 1273bc6. > > Signed-o

Re: [FFmpeg-devel] FFmpeg 3.2

2016-10-17 Thread wm4
On Mon, 17 Oct 2016 15:47:06 +0200 Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 12:01:56PM +0200, wm4 wrote: > > On Mon, 17 Oct 2016 04:24:40 +0200 > > Michael Niedermayer wrote: > > > > > On Sun, Oct 16, 2016 at 06:01:54PM -0400, Helmut K. C. Tessarek wrote: > > > > On 2016-09-27 0

Re: [FFmpeg-devel] FFmpeg 3.2

2016-10-17 Thread Hendrik Leppkes
On Mon, Oct 17, 2016 at 3:47 PM, Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 12:01:56PM +0200, wm4 wrote: >> On Mon, 17 Oct 2016 04:24:40 +0200 >> Michael Niedermayer wrote: >> >> > On Sun, Oct 16, 2016 at 06:01:54PM -0400, Helmut K. C. Tessarek wrote: >> > > On 2016-09-27 09:30, Michael

Re: [FFmpeg-devel] [PATCH] aiffdec: fix division by zero

2016-10-17 Thread Andreas Cadhalpun
On 17.10.2016 05:43, Michael Niedermayer wrote: > On Sun, Oct 16, 2016 at 10:38:42PM +0200, Andreas Cadhalpun wrote: >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/aiffdec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/aiffdec.c b/libavformat/

Re: [FFmpeg-devel] FFmpeg 3.2

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 03:56:37PM +0200, wm4 wrote: > On Mon, 17 Oct 2016 15:47:06 +0200 > Michael Niedermayer wrote: > > > On Mon, Oct 17, 2016 at 12:01:56PM +0200, wm4 wrote: > > > On Mon, 17 Oct 2016 04:24:40 +0200 > > > Michael Niedermayer wrote: > > > > > > > On Sun, Oct 16, 2016 at 06:

Re: [FFmpeg-devel] FFmpeg 3.2

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 04:12:26PM +0200, Hendrik Leppkes wrote: > On Mon, Oct 17, 2016 at 3:47 PM, Michael Niedermayer > wrote: > > On Mon, Oct 17, 2016 at 12:01:56PM +0200, wm4 wrote: > >> On Mon, 17 Oct 2016 04:24:40 +0200 > >> Michael Niedermayer wrote: > >> > >> > On Sun, Oct 16, 2016 at 06:

Re: [FFmpeg-devel] [PATCH] add hds demuxer

2016-10-17 Thread Steven Liu
2016-10-15 21:52 GMT+08:00 Nicolas George : > Le tridi 23 vendémiaire, an CCXXV, wm4 a écrit : > > XML is very complex > > This is the usual, and often only, argument raised in this kind of > situation. And unfortunately, I already addressed it in this very thread. > > XML is very complex, y

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-10-17 Thread wm4
On Sun, 16 Oct 2016 21:32:03 +0200 Marton Balint wrote: > Also contains the following changes to the library: > - add ff_ prefix to functions > - remove cplusplus defines. > - add FF_ prefix to contants and some structs > - remove true peak calculation feature, since it uses its own resampler, an

Re: [FFmpeg-devel] [PATCH] aiffdec: fix division by zero

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 04:17:35PM +0200, Andreas Cadhalpun wrote: > On 17.10.2016 05:43, Michael Niedermayer wrote: > > On Sun, Oct 16, 2016 at 10:38:42PM +0200, Andreas Cadhalpun wrote: > >> Signed-off-by: Andreas Cadhalpun > >> --- > >> libavformat/aiffdec.c | 2 +- > >> 1 file changed, 1 inse

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/loudnorm: add an internal libebur128 library

2016-10-17 Thread Moritz Barsnick
On Mon, Oct 17, 2016 at 17:09:15 +0200, wm4 wrote: > Does this copy parts of libebur128 to FFmpeg? > Why? There was a long discussion regarding this patch: http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2016-April/192668.html (in summary: "please don't require yet another small external library,

Re: [FFmpeg-devel] [PATCH] libavcodec: Added Selftest for libavcodec/avpacket.c

2016-10-17 Thread Michael Niedermayer
Hi first, please dont forget to submit an application to outreachy theres a deadline in a few hours On Sun, Oct 16, 2016 at 04:28:23PM -0700, Thomas Turner wrote: > Improved code coverage for libavcodec. > Function(s) Tested: av_packet_clone(). It seems your mails get stuck in the moderation qu

Re: [FFmpeg-devel] [PATCH] aiffdec: fix division by zero

2016-10-17 Thread Andreas Cadhalpun
On 17.10.2016 17:13, Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 04:17:35PM +0200, Andreas Cadhalpun wrote: >> On 17.10.2016 05:43, Michael Niedermayer wrote: >>> On Sun, Oct 16, 2016 at 10:38:42PM +0200, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavf

[FFmpeg-devel] [PATCH/RFC]lavf/avidec: Do not fail for very large idx1 tags

2016-10-17 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the file mentioned in github pull request 197, it can be played with MPlayer, vlc, xine and totem. Please comment, Carl Eugen From 646a765749e08bb48f74488ad9f539cbc736673c Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 17 Oct 2016 18:25:48 +0200 Subject: [PA

Re: [FFmpeg-devel] FFmpeg 3.2

2016-10-17 Thread Carl Eugen Hoyos
2016-10-17 0:01 GMT+02:00 Helmut K. C. Tessarek : > On 2016-09-27 09:30, Michael Niedermayer wrote: >> Its long since FFmpeg 3.1, so its time to make 3.2 >> ill branch release/3.2 off master and make 3.2 in maybe about a week or >> 2 unless something delays it > > What happened to 3.2? I believe d

Re: [FFmpeg-devel] [PATCH] avfilter/firequalizer: optimize gain/gain_entry command

2016-10-17 Thread Muhammad Faiz
On Mon, Oct 17, 2016 at 6:16 AM, Muhammad Faiz wrote: > do not rebuild when gain/gain_entry command are > equal with old gain/gain_entry > > Signed-off-by: Muhammad Faiz > --- > libavfilter/af_firequalizer.c | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > applied

Re: [FFmpeg-devel] [PATCH] avfilter/showcqt: add font option

2016-10-17 Thread Muhammad Faiz
On Mon, Oct 17, 2016 at 6:02 AM, Muhammad Faiz wrote: > this is fontconfig pattern > > Signed-off-by: Muhammad Faiz > --- > doc/filters.texi | 10 ++ > libavfilter/avf_showcqt.c | 85 > +++ > libavfilter/avf_showcqt.h | 1 + > 3 files ch

Re: [FFmpeg-devel] [PATCH] avcodec/vda: define av_vda_default_init2 when CONFIG_H264_VDA_HWACCEL equ 0

2016-10-17 Thread Xidorn Quan
This isn't maintained by me. You should probaby ping Sebastien Zwickert < dilar...@free.fr>. But this change looks trivial, so I think it is fine. - Xidorn On Mon, Oct 17, 2016 at 7:01 PM, Steven Liu wrote: > ping Xidorn Quan > > 2016-10-15 6:01 GMT+08:00 wm4 : > >> On Thu, 13 Oct 2016 20:57:0

[FFmpeg-devel] [PATCH] libavcodec/tests: Added test for libavcodec/avpacket.c

2016-10-17 Thread Thomas Turner
Improved code coverage for libavcodec. Function(s) Tested: av_packet_clone(). Signed-off-by: Thomas Turner --- libavcodec/Makefile | 3 +- libavcodec/tests/avpacket.c | 185 tests/fate/libavcodec.mak | 5 ++ 3 files changed, 192 insertio

Re: [FFmpeg-devel] [PATCH] aiffdec: fix division by zero

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 06:27:29PM +0200, Andreas Cadhalpun wrote: > On 17.10.2016 17:13, Michael Niedermayer wrote: > > On Mon, Oct 17, 2016 at 04:17:35PM +0200, Andreas Cadhalpun wrote: > >> On 17.10.2016 05:43, Michael Niedermayer wrote: > >>> On Sun, Oct 16, 2016 at 10:38:42PM +0200, Andreas Ca

[FFmpeg-devel] [PATCH] avfilter/firequalizer: add dumpfile and dumpscale option

2016-10-17 Thread Muhammad Faiz
Signed-off-by: Muhammad Faiz --- doc/filters.texi | 7 libavfilter/af_firequalizer.c | 97 --- 2 files changed, 90 insertions(+), 14 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 8fda8a1..9fc8c4f 100644 --- a/doc/fi

Re: [FFmpeg-devel] [PATCH] aiffdec: fix division by zero

2016-10-17 Thread Andreas Cadhalpun
On 17.10.2016 20:11, Michael Niedermayer wrote: > On Mon, Oct 17, 2016 at 06:27:29PM +0200, Andreas Cadhalpun wrote: >> On 17.10.2016 17:13, Michael Niedermayer wrote: >>> On Mon, Oct 17, 2016 at 04:17:35PM +0200, Andreas Cadhalpun wrote: On 17.10.2016 05:43, Michael Niedermayer wrote: > O

[FFmpeg-devel] [PATCH] avformat: close parser if codec changed

2016-10-17 Thread Andreas Cadhalpun
The parser depends on the codec and thus must not be used with a different one. If it is, the 'avctx->codec_id == s->parser->codec_ids[0] ...' assert in av_parser_parse2 gets triggered. Signed-off-by: Andreas Cadhalpun --- libavformat/utils.c | 12 1 file changed, 12 insertions(+)

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Behrisch
Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: >> On Mon, 17 Oct 2016 13:09:36 +0200 >> Michael Niedermayer wrote: >> >>> On Mon, Oct 17, 2016 at 10:07:42AM +0200, Nicolas George wrote: Le sextidi 26 vendémiaire, an CCXXV, Michael Ni

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Ronald S. Bultje
Hi Michael, On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch wrote: > Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > > On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: > >> On Mon, 17 Oct 2016 13:09:36 +0200 > >> Michael Niedermayer wrote: > >> > >>> On Mon, Oct 17, 2016 at 10:07:42

Re: [FFmpeg-devel] [PATCH/RFC]lavf/avidec: Do not fail for very large idx1 tags

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 06:29:42PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the file mentioned in github pull request 197, > it can be played with MPlayer, vlc, xine and totem. > > Please comment, Carl Eugen > avidec.c |2 ++ > 1 file changed, 2 insertions(+) > 0b5d5e6

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Behrisch
Hi Ronald, Am 17.10.2016 um 21:37 schrieb Ronald S. Bultje: > Hi Michael, > > On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch > wrote: > >> Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: >>> On Mon, Oct 17, 2016 at 01:34:55PM +0200, wm4 wrote: On Mon, 17 Oct 2016 13:09:36 +0200 Mich

Re: [FFmpeg-devel] [PATCHv3] mov: Evaluate the movie display matrix

2016-10-17 Thread Vittorio Giovara
On Thu, Oct 13, 2016 at 6:50 PM, Vittorio Giovara wrote: > This matrix needs to be applied after all others have (currently only > display matrix from trak), but cannot be handled in movie box, since > streams are not allocated yet. So store it in main context, and apply > it when appropriate, tha

[FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-17 Thread Rostislav Pehlivanov
Should fix segfaults on x86-32 Performance improvements: quant_bands: with: 681 decicycles in quant_bands, 8388453 runs,155 skips without: 1190 decicycles in quant_bands, 8388386 runs,222 skips Around 42% for the function Twoloop coder: abs_pow34: with/without: 7.82s/8.17s Around 4%

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Interpret unspecified color range as limited range

2016-10-17 Thread Vittorio Giovara
On Mon, Sep 19, 2016 at 8:36 AM, Ronald S. Bultje wrote: > Hi, > > On Fri, Sep 16, 2016 at 9:27 AM, Clément Bœsch wrote: >> >> On Fri, Sep 16, 2016 at 03:20:49PM +0200, Vittorio Giovara wrote: >> > This is the assumption that is made in pixel format conversion do >> > throughout the code (in part

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: pass the demuxer's AVFormatContext to avpriv_request_sample()

2016-10-17 Thread Michael Niedermayer
On Sun, Oct 16, 2016 at 09:34:51PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/mov.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB It is dangerous to be r

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Ronald S. Bultje
Hi Michael, On Mon, Oct 17, 2016 at 5:23 PM, Michael Behrisch wrote: > Hi Ronald, > > Am 17.10.2016 um 21:37 schrieb Ronald S. Bultje: > > Hi Michael, > > > > On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch > > wrote: > > > >> Am 17.10.2016 um 15:29 schrieb Michael Niedermayer: > >>> On Mon,

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Interpret unspecified color range as limited range

2016-10-17 Thread Ronald S. Bultje
Hi Vittorio, On Mon, Oct 17, 2016 at 5:28 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Mon, Sep 19, 2016 at 8:36 AM, Ronald S. Bultje > wrote: > > Hi, > > > > On Fri, Sep 16, 2016 at 9:27 AM, Clément Bœsch wrote: > >> > >> On Fri, Sep 16, 2016 at 03:20:49PM +0200, Vittorio Gio

[FFmpeg-devel] [PATCH 2/2] lavf/mp3enc: write encoder delay/padding upon closing

2016-10-17 Thread Jon Toohill
--- libavformat/mp3enc.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index de63401..4c97fa1 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -111,6 +111,8 @@ typedef struct MP3Con

[FFmpeg-devel] [PATCH 1/2] lavc/libmp3lame: send encoder delay/padding in packet side data

2016-10-17 Thread Jon Toohill
--- libavcodec/libmp3lame.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index 5642264..e55aa85 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -50,6 +50,7 @@ typedef struct L

[FFmpeg-devel] [PATCH 0/2] Fix gapless encoding/remuxing for MP3

2016-10-17 Thread Jon Toohill
Round trip wav->mp3->wav now preserves the correct number of samples. Remuxing mp3->mp3 with -c:a copy also preserves any existing gapless metadata in the Info tag. The code in libmp3lame.c to set AV_PKT_DATA_SKIP_SAMPLES was mostly copied from libopusenc.c. Jon Toohill (2): lavc/libmp3lame: se

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Michael Behrisch
Hi Ronald, Am 17.10.2016 um 23:45 schrieb Ronald S. Bultje: > Hi Michael, > > On Mon, Oct 17, 2016 at 5:23 PM, Michael Behrisch wrote: > >> Hi Ronald, >> >> Am 17.10.2016 um 21:37 schrieb Ronald S. Bultje: >>> Hi Michael, >>> >>> On Mon, Oct 17, 2016 at 3:16 PM, Michael Behrisch >>> wrote: >>>

Re: [FFmpeg-devel] comma at the end of enumerator lists

2016-10-17 Thread Carl Eugen Hoyos
2016-10-18 0:17 GMT+02:00 Michael Behrisch : > I am not claiming that -Wpedantic is the only way to achieve this. > I only think it helps or at least I assume that was the intention > when it was invented. ("If gcc does it this way, it must be a good idea.") This is an extremely unconvincing arg

Re: [FFmpeg-devel] [PATCH/RFC]lavf/avidec: Do not fail for very large idx1 tags

2016-10-17 Thread Carl Eugen Hoyos
2016-10-17 22:32 GMT+02:00 Michael Niedermayer : > On Mon, Oct 17, 2016 at 06:29:42PM +0200, Carl Eugen Hoyos wrote: >> Hi! >> >> Attached patch fixes the file mentioned in github pull request 197, >> it can be played with MPlayer, vlc, xine and totem. >> >> Please comment, Carl Eugen > >> avidec.

[FFmpeg-devel] [PATCH]lavf/avidec: Be more verbose when ignoring very large tag size

2016-10-17 Thread Carl Eugen Hoyos
Hi! Attached patch prints the tag and the tag size when ignoring the size. Please comment, Carl Eugen From e99dc274b7b4b4b5ef502ddb0a8245c1f47c2ece Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 18 Oct 2016 00:37:06 +0200 Subject: [PATCH] lavf/avidec: Be more verbose when ignoring ve

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 10:24:48PM +0100, Rostislav Pehlivanov wrote: > Should fix segfaults on x86-32 > > Performance improvements: > > quant_bands: > with: 681 decicycles in quant_bands, 8388453 runs,155 skips > without: 1190 decicycles in quant_bands, 8388386 runs,222 skips > Aroun

Re: [FFmpeg-devel] [PATCH v3] aacenc: add SIMD optimizations for abs_pow34 and quantization

2016-10-17 Thread James Almer
On 10/17/2016 6:24 PM, Rostislav Pehlivanov wrote: > diff --git a/libavcodec/aacenc_utils.h b/libavcodec/aacenc_utils.h > index ff9188a..f5cf77d 100644 > --- a/libavcodec/aacenc_utils.h > +++ b/libavcodec/aacenc_utils.h > @@ -37,7 +37,7 @@ > #define ROUND_TO_ZERO 0.1054f > #define C_QUANT 0.4054f

Re: [FFmpeg-devel] [PATCH] fate: add swr-convertaudio test

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 05:37:41AM +0700, Muhammad Faiz wrote: > test for flt to s16 > should pass on correct rounding to nearest > > Signed-off-by: Muhammad Faiz > --- > tests/fate/libswresample.mak | 8 > 1 file changed, 8 insertions(+) tested on linux32/64, arm and mips qemu LGTM

Re: [FFmpeg-devel] [PATCH 3/3] fate: add loudnorm filter test

2016-10-17 Thread Michael Niedermayer
On Sun, Oct 16, 2016 at 10:12:17PM +0200, Marton Balint wrote: > > On Sun, 16 Oct 2016, Marton Balint wrote: > > >Signed-off-by: Marton Balint > >--- > >tests/fate/filter-audio.mak | 7 +++ > >1 file changed, 7 insertions(+) > > > >diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-

Re: [FFmpeg-devel] [PATCH]lavf/avidec: Be more verbose when ignoring very large tag size

2016-10-17 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 12:42:18AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch prints the tag and the tag size when ignoring the size. > > Please comment, Carl Eugen > avidec.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > 5e698290127169160243ccf1f06fe9c443c41b6c

Re: [FFmpeg-devel] [PATCH 3/3] fate: add loudnorm filter test

2016-10-17 Thread Marton Balint
On Tue, 18 Oct 2016, Michael Niedermayer wrote: On Sun, Oct 16, 2016 at 10:12:17PM +0200, Marton Balint wrote: On Sun, 16 Oct 2016, Marton Balint wrote: Signed-off-by: Marton Balint --- tests/fate/filter-audio.mak | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/fate/filter-

[FFmpeg-devel] [PATCH] lavf/http.c: Add listen_timeout option.

2016-10-17 Thread Stephan Holljes
--- libavformat/http.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index d48958d..3b0d6ab 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -115,6 +115,7 @@ typedef struct HTTPContext { int reconnect_delay; int reconnect_dela

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-10-17 Thread Richard Kern
> On Oct 17, 2016, at 8:47 PM, Aman Gupta wrote: > > > > On Mon, Oct 17, 2016 at 6:35 AM, Richard Kern > wrote: > >> On Sep 19, 2016, at 10:30 AM, Aman Gupta > > wrote: >> >> >> >> On Monday, September 19, 2016, Richard Kern >

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: zero initialize codec_name in mov_parse_stsd_video()

2016-10-17 Thread Michael Niedermayer
On Sun, Oct 16, 2016 at 09:34:50PM -0300, James Almer wrote: > Fixes valgrind warning about "Conditional jump or move depends on > uninitialised value(s)" > > Signed-off-by: James Almer > --- > libavformat/mov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This should be suppressabl

Re: [FFmpeg-devel] [PATCH 2/3] avformat/matroskadec: support parsing Chroma Location elements

2016-10-17 Thread Michael Niedermayer
On Sat, Oct 15, 2016 at 12:40:55PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/matroskadec.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index acf1ccb..cfe4692 100644 > --- a/libavformat/matro

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-10-17 Thread Aman Gupta
On Mon, Oct 17, 2016 at 6:35 AM, Richard Kern wrote: > > On Sep 19, 2016, at 10:30 AM, Aman Gupta wrote: > > > > On Monday, September 19, 2016, Richard Kern wrote: > >> >> On Sep 10, 2016, at 10:33 PM, Aman Gupta wrote: >> >> >> >> On Sunday, September 11, 2016, Richard Kern wrote: >> >>> >>>

Re: [FFmpeg-devel] [PATCH] lavc/videotoolboxenc: implement a53cc

2016-10-17 Thread Aman Gupta
On Mon, Oct 17, 2016 at 5:51 PM, Richard Kern wrote: > > On Oct 17, 2016, at 8:47 PM, Aman Gupta wrote: > > > > On Mon, Oct 17, 2016 at 6:35 AM, Richard Kern wrote: > >> >> On Sep 19, 2016, at 10:30 AM, Aman Gupta wrote: >> >> >> >> On Monday, September 19, 2016, Richard Kern wrote: >> >>> >>

Re: [FFmpeg-devel] [PATCH] avformat/tests/gitignore: add fifo_muxer entry

2016-10-17 Thread Michael Niedermayer
On Mon, Oct 17, 2016 at 01:38:24PM +0200, Jan Sebechlebsky wrote: > On 10/15/2016 06:32 PM, Zhao Zhili wrote: > > > From a3ee9afc37331315e4ec57f1ebf881779b62bf60 Mon Sep 17 00:00:00 2001 > >From: Zhao Zhili > >Date: Sun, 16 Oct 2016 00:09:25 +0800 > >Subject: [PATCH] avformat/tests/gitignore: add

Re: [FFmpeg-devel] [PATCH 1/2] compat/avisynth: minor update for alpha offsets

2016-10-17 Thread Stephen Hutchinson
On 9/27/2016 10:07 PM, Stephen Hutchinson wrote: On 9/27/2016 4:11 PM, Michael Niedermayer wrote: can you update the status for the patch(es) on https://patchwork.ffmpeg.org/project/ffmpeg/list/?submitter=49 ? so developers know what needs a review, needs to be applied and what is on hold/revov

Re: [FFmpeg-devel] [PATCH 3/3] fate: add loudnorm filter test

2016-10-17 Thread Michael Niedermayer
On Tue, Oct 18, 2016 at 02:20:03AM +0200, Marton Balint wrote: > > On Tue, 18 Oct 2016, Michael Niedermayer wrote: > > >On Sun, Oct 16, 2016 at 10:12:17PM +0200, Marton Balint wrote: > >> > >>On Sun, 16 Oct 2016, Marton Balint wrote: > >> > >>>Signed-off-by: Marton Balint > >>>--- > >>>tests/fat

Re: [FFmpeg-devel] [PATCH] lavf/http.c: Add listen_timeout option.

2016-10-17 Thread Stephan Holljes
On Tue, Oct 18, 2016 at 2:09 AM, Stephan Holljes wrote: > --- > libavformat/http.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index d48958d..3b0d6ab 100644 > --- a/libavformat/http.c > +++ b/libavformat/http.c > @@ -115,6 +115,7 @@ type

Re: [FFmpeg-devel] [PATCH 2/3] avformat/matroskadec: support parsing Chroma Location elements

2016-10-17 Thread James Almer
On 10/17/2016 10:00 PM, Michael Niedermayer wrote: > On Sat, Oct 15, 2016 at 12:40:55PM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavformat/matroskadec.c | 4 >> 1 file changed, 4 insertions(+) >> >> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c

[FFmpeg-devel] [PATCH] doc/examples/demuxing_decoding: Drop AVFrame->pts use

2016-10-17 Thread Michael Niedermayer
This code is not correct for git master Signed-off-by: Michael Niedermayer --- doc/examples/demuxing_decoding.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c index 49fb6af..b1a216a 100644 --- a/doc/exa

[FFmpeg-devel] [PATCH 2/3 v2] avformat/matroskadec: support parsing Chroma Location elements

2016-10-17 Thread James Almer
Signed-off-by: James Almer --- libavformat/matroska.h| 14 ++ libavformat/matroskadec.c | 7 +++ 2 files changed, 21 insertions(+) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index 8ad89da..13155e5 100644 --- a/libavformat/matroska.h +++ b/libavformat/matros

Re: [FFmpeg-devel] [PATCH]lavf/avidec: Be more verbose when ignoring very large tag size

2016-10-17 Thread Clément Bœsch
On Tue, Oct 18, 2016 at 12:42:18AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch prints the tag and the tag size when ignoring the size. > > Please comment, Carl Eugen > From e99dc274b7b4b4b5ef502ddb0a8245c1f47c2ece Mon Sep 17 00:00:00 2001 > From: Carl Eugen Hoyos > Date: Tue, 18 Oct

[FFmpeg-devel] [PATCH] libavcodec/tests: Added selftest for libavcodec/avpacket.c

2016-10-17 Thread tdturner
From: Thomas Turner Improved code coverage for libavcodec. Function(s) Tested: av_packet_clone() Signed-off-by: Thomas Turner --- libavcodec/Makefile | 3 +- libavcodec/tests/avpacket.c | 207 tests/fate/libavcodec.mak | 5 ++ 3 files