[FFmpeg-devel] lavf : scale_vaapi : add denoise/sharpless support

2016-08-30 Thread Jun Zhao
From 78421d6b3a4da21dc1e7793777946cf057fc6cfe Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 30 Aug 2016 14:36:00 +0800 Subject: [PATCH] lavf : scale_vaapi : add denoise/sharpless support. add denoise/sharpless support, used scope [-1, 100] as the input scope. Signed-off-by: Jun Zhao --- l

[FFmpeg-devel] [PATCH v2] lavf : scale_vaapi : add denoise/sharpless support

2016-08-30 Thread Jun Zhao
From 1d2d7e0671027948644e08ca79853cc40b0fcf27 Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 30 Aug 2016 14:36:00 +0800 Subject: [PATCH] lavf : scale_vaapi : add denoise/sharpless support. add denoise/sharpless support, used scope [-1, 100] as the input scope. Signed-off-by: Jun Zhao --- l

[FFmpeg-devel] [PATCH] libavutil: let clang-FORTIFY build; NFC.

2016-08-30 Thread George Burgess IV
ChromeOS is adopting a new FORTIFY implementation tailored for clang. As an artifact of how this new FORTIFY is implemented, a handful of implicit conversion warnings get turned into errors. This patch fixes the implicit conversions in ffmpeg that clang-FORTIFY has an issue with. Signed-off-by: Ge

Re: [FFmpeg-devel] [PATCH] cmdutils: fix implicit declaration of SetDllDirectory function

2016-08-30 Thread Tobias Rapp
On 30.08.2016 04:10, James Almer wrote: On 8/29/2016 10:42 AM, Tobias Rapp wrote: Attached patch fixes a build error on my system (Ubuntu 14.04, mingw-w64 3.1.0, gcc-mingw-w64 4.8.2) introduced by commit 3bf142c77337814458ed8e036796934032d9837f. Interesting. windows.h is already included if Co

[FFmpeg-devel] [PATCH v3] lavf : scale_vaapi : add denoise/sharpless support

2016-08-30 Thread Jun Zhao
v3 : fix sharpless mapping issue v2 : fix filter support flag check logic issue From 415b00c6157d8311cc18713e6347400895f7333c Mon Sep 17 00:00:00 2001 From: Jun Zhao Date: Tue, 30 Aug 2016 14:36:00 +0800 Subject: [PATCH v3] lavf : scale_vaapi : add denoise/sharpless support. add denoise/sharpless

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Paul B Mahol
On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje wrote: > Hi, > > On Mon, Aug 29, 2016 at 11:23 AM, Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > > > The filter needs input frames with color properties filled out by > > the decoder. Since this is not always possible, add input option

[FFmpeg-devel] patch libavformat/crypto buffer count

2016-08-30 Thread Simon H
patch split and advice taken :) libavformat-crypto-buffer-count.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Patch libavformat/crypto to add seek when reading

2016-08-30 Thread Simon H
libavformat-crypto-add-seek.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [GSoC] Motion Interpolation

2016-08-30 Thread Robert Krüger
On Tue, Aug 30, 2016 at 3:13 AM, Davinder Singh wrote: > On Sat, Aug 27, 2016 at 6:15 PM Robert Krüger > wrote: > > > [...] > > what is the way to best contribute with test cases? I have two samples > that > > I use for testing, so far the results look very, very promising but there > > are stil

Re: [FFmpeg-devel] [PATCH v4 5/5] avformat/tee: Use BSF list API

2016-08-30 Thread Jan Sebechlebsky
On 08/26/2016 12:53 AM, sebechlebsky...@gmail.com wrote: From: Jan Sebechlebsky Signed-off-by: Jan Sebechlebsky --- I believe I have fixed handling input / output timebase and input parameters to bitstream filters list. libavformat/tee.c | 131 ++

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Ronald S. Bultje
Hi, On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol wrote: > On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje > wrote: > > > Hi, > > > > On Mon, Aug 29, 2016 at 11:23 AM, Vittorio Giovara < > > vittorio.giov...@gmail.com> wrote: > > > > > The filter needs input frames with color properties fille

[FFmpeg-devel] [PATCH] avformat/hlsenc: add warning for append_list and hls_init_time option

2016-08-30 Thread Steven Liu
When use append_list mode, the hls_init_time set nouse, Because the append_list only support append at the old m3u8 end cannot set init segments durations at the middle of the list. That's invalid use append_list and hls_init_time one time. and show a warning message for user. Signed-off-by: LiuQi

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-30 Thread Nicolas George
Le tridi 13 fructidor, an CCXXIV, Brett Harrison a écrit : > Before I fix the patch, can you clarify the intended functionality? > > The docs say that 16 is the default fontsize, however if > CONFIG_LIBFONTCONFIG is configured and ffmpeg if called with: > > -vf drawtext=text=abc:fontcolor=white >

Re: [FFmpeg-devel] Evolution of lavfi's design and API

2016-08-30 Thread Nicolas George
Le duodi 12 fructidor, an CCXXIV, Paul B Mahol a écrit : > Nicolas, what is status of this? > > I'm currently interested in frame multithreading in lavfi. I am currently locked on a patch series to replace the recursive calls to filter_frames() with a FIFO on each link. I think this is an absolu

Re: [FFmpeg-devel] [PATCH] libavutil: let clang-FORTIFY build; NFC.

2016-08-30 Thread Michael Niedermayer
On Tue, Aug 30, 2016 at 12:11:42AM -0700, George Burgess IV wrote: > ChromeOS is adopting a new FORTIFY implementation tailored for clang. As > an artifact of how this new FORTIFY is implemented, a handful of > implicit conversion warnings get turned into errors. This patch fixes > the implicit con

[FFmpeg-devel] [GSoC][PATCH v2 2/2] mlpenc: Working MLP/TrueHD encoder

2016-08-30 Thread Jai Luthra
* Multichannel support for TrueHD is experimental There should be downmix substreams present for 2+ channel bitstreams, but ffmpeg decoder doesn't need it. Will add support for this soon. * There might be lossless check failures on LFE channels * 32-bit sample support has been removed fo

Re: [FFmpeg-devel] [PATCH] lavf: add textdata virtual demuxer and demuxer

2016-08-30 Thread Stefano Sabatini
On date Tuesday 2016-08-23 16:53:28 +0200, Nicolas George encoded: > Le septidi 7 fructidor, an CCXXIV, Stefano Sabatini a écrit : > > Bump. > > > > So, basically, what are the features that you want to add? > > I can list a few: > > > > - have multiple streams (with media type and optionally enc

[FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-30 Thread Timo Rothenpieler
--- configure | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/configure b/configure index 52931c3..bcfc9a8 100755 --- a/configure +++ b/configure @@ -5992,20 +5992,33 @@ enabled vdpau && enabled xlib && check_lib2 "vdpau/vdpau.h vdpa

Re: [FFmpeg-devel] ffmpeg video conversation command is not working

2016-08-30 Thread Madhav G
Hi ffmpeg Team, Good day to you, We are waiting for your reply, kindly let us know your suggestion to resolve the issue. Thanks, On Fri, Aug 26, 2016 at 8:51 PM, Markin Abras wrote: > Hello, did you hear back from ffmpeg? Did they say what we should do? > > Markin > > On Thu, Aug 25, 2016 at

Re: [FFmpeg-devel] [PATCH v4 5/5] avformat/tee: Use BSF list API

2016-08-30 Thread Nicolas George
Le decadi 10 fructidor, an CCXXIV, sebechlebsky...@gmail.com a écrit : > From: Jan Sebechlebsky > > Signed-off-by: Jan Sebechlebsky > --- > I believe I have fixed handling input / output timebase and input parameters > to bitstream filters list. > > libavformat/tee.c | 131 > +++

Re: [FFmpeg-devel] ffmpeg video conversation command is not working

2016-08-30 Thread Nicolas George
Le quartidi 14 fructidor, an CCXXIV, Madhav G a écrit : > We are waiting for your reply, kindly let us know your suggestion to > resolve the issue. You did get a reply, on ffmpeg-user, which is the proper place. As this mail is not about the development of ffmpeg proper, it should not have been s

Re: [FFmpeg-devel] Evolution of lavfi's design and API

2016-08-30 Thread Paul B Mahol
On Tuesday, August 30, 2016, Nicolas George wrote: > Le duodi 12 fructidor, an CCXXIV, Paul B Mahol a écrit : > > Nicolas, what is status of this? > > > > I'm currently interested in frame multithreading in lavfi. > > I am currently locked on a patch series to replace the recursive calls to > fil

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Vittorio Giovara
On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol wrote: > > > On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje > wrote: >> >> Hi, >> >> On Mon, Aug 29, 2016 at 11:23 AM, Vittorio Giovara < >> vittorio.giov...@gmail.com> wrote: >> >> > The filter needs input frames with color properties filled out b

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Paul B Mahol
On Tuesday, August 30, 2016, Vittorio Giovara wrote: > On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol > wrote: > > > > > > On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje > > > wrote: > >> > >> Hi, > >> > >> On Mon, Aug 29, 2016 at 11:23 AM, Vittorio Giovara < > >> vittorio.giov...@gmail.com >

Re: [FFmpeg-devel] patch libavformat/crypto buffer count

2016-08-30 Thread Michael Niedermayer
On Tue, Aug 30, 2016 at 09:45:56AM +0100, Simon H wrote: > patch split and advice taken :) > crypto.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > 31c87f6b089c8e51817dda80327bda83d91bb3c4 > libavformat-crypto-buffer-count.patch > From 14176ca9d6a1d62d10c2e670ccf4f1d2cf16648f M

Re: [FFmpeg-devel] Patch libavformat/crypto to add seek when reading

2016-08-30 Thread Michael Niedermayer
On Tue, Aug 30, 2016 at 09:47:12AM +0100, Simon H wrote: > > crypto.c | 116 > +-- > 1 file changed, 114 insertions(+), 2 deletions(-) > a8d9d6638d0be86896de1cb2fa5f9a9f60d7b3c3 libavformat-crypto-add-seek.patch > From a0c4d274b2b171

Re: [FFmpeg-devel] [PATCH 3/3] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Vittorio Giovara
On Tue, Aug 30, 2016 at 10:54 AM, Paul B Mahol wrote: > > > On Tuesday, August 30, 2016, Vittorio Giovara > wrote: >> >> On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol wrote: >> > >> > >> > On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje >> > wrote: >> >> >> >> Hi, >> >> >> >> On Mon, Aug 29,

Re: [FFmpeg-devel] [PATCH] lavf: add textdata virtual demuxer and demuxer

2016-08-30 Thread Stefano Sabatini
On date Tuesday 2016-08-30 12:31:27 +0200, Stefano Sabatini encoded: [...] > I rebased the patch, and performed two simple changes in ffprobe (see > attachment), and it's almost working. > > I think supporting the show_compact_data mode should simplify the > format in case the format is generated

Re: [FFmpeg-devel] [PATCHv2] vf_colorspace: Allow overriding input color properties

2016-08-30 Thread Ronald S. Bultje
Hi, On Tue, Aug 30, 2016 at 10:00 AM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > On Tue, Aug 30, 2016 at 4:13 AM, Paul B Mahol wrote: > > > > > > On Mon, Aug 29, 2016 at 5:53 PM, Ronald S. Bultje > > wrote: > >> > >> Hi, > >> > >> On Mon, Aug 29, 2016 at 11:23 AM, Vittorio Giovara

Re: [FFmpeg-devel] MAINTAINERS: Add myself for alsdec

2016-08-30 Thread Michael Niedermayer
On Mon, Aug 29, 2016 at 10:58:46PM +0530, Umair Khan wrote: > Hi, > > Patch attached. > > - Umair > MAINTAINERS |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 6d3177b33447c480236a1519270e13ec7ed67b7a > 0001-MAINTAINERS-Add-myself-for-alsdec.patch > From b5bb6b16c313dd84857bf41cd

Re: [FFmpeg-devel] Patch libavformat/crypto to add seek when reading

2016-08-30 Thread Simon H
hmm... not sure i understand fate, even after a quick look. Is there an explanation more complete than on the website? I'm guessing that the ideal test for this would be to exercise the url functions directly from code; e.g.: 1. write some known data through crypto:, compare with pre-prepared ou

Re: [FFmpeg-devel] HLS Segmenter and the "hls_time" option

2016-08-30 Thread Aman Gupta
On Fri, Aug 26, 2016 at 2:06 AM, Steven Liu wrote: > 2016-08-26 16:58 GMT+08:00 Ibrahim Tachijian : > > > Thanks this actually does what I expected it to do. > > For me this option will help a lot, and we would really be interested in > > this eventually reaching git. > > > > Thanks to Steven Liu

Re: [FFmpeg-devel] Patch libavformat/crypto to add seek when reading

2016-08-30 Thread Michael Niedermayer
On Tue, Aug 30, 2016 at 06:04:57PM +0100, Simon H wrote: > hmm... not sure i understand fate, even after a quick look. Is there an > explanation more complete than on the website? the code and git log > > I'm guessing that the ideal test for this would be to exercise the url > functions direc

Re: [FFmpeg-devel] Possible long(er?) term support

2016-08-30 Thread Gerion Entrup
On Samstag, 27. August 2016 23:37:09 CEST Dominik 'Rathann' Mierzejewski wrote: > On Saturday, 27 August 2016 at 12:48, Michael Niedermayer wrote: > > which other distros use 2.8 ? (that is distro releases which will not/ > > cannot upgrade to 3.*) > > I can see 2.8.6 in Gentoo (marked as stable,

Re: [FFmpeg-devel] Evolution of lavfi's design and API

2016-08-30 Thread Nicolas George
Le quartidi 14 fructidor, an CCXXIV, Paul B Mahol a écrit : > the filter frame multithreading would just internally, in filter context > cache frames, once enough frames are in cache - call workers and be done, > repeat. At eof call workers on remaining frames in cache. I have no idea how much tho

Re: [FFmpeg-devel] [PATCH] swscale: add support for P010LE/BE output

2016-08-30 Thread Michael Niedermayer
On Mon, Aug 29, 2016 at 11:23:00PM +0200, Timo Rothenpieler wrote: > --- > libswscale/output.c | 98 > +++- > libswscale/utils.c | 4 +- > libswscale/x86/swscale.c | 4 +- > tests/ref/fate/filter-pixdesc-p010be | 1

[FFmpeg-devel] CNG (consistent noise generation) idea

2016-08-30 Thread Jonathan Campbell
I have some spare time again, I'd like to reimplement the "consistent noise generation" patch I made awhile back. To clarify what that is, some codecs use pseudo-random noise generation in the decoding process (noise bands). The idea is to enable seeding that pseudo-random generator with the b

Re: [FFmpeg-devel] HLS Segmenter and the "hls_time" option

2016-08-30 Thread Steven Liu
Aman Gupta 于2016年8月31日 周三上午1:48写道: > On Fri, Aug 26, 2016 at 2:06 AM, Steven Liu > wrote: > > > 2016-08-26 16:58 GMT+08:00 Ibrahim Tachijian : > > > > > Thanks this actually does what I expected it to do. > > > For me this option will help a lot, and we would really be interested > in > > > this

Re: [FFmpeg-devel] [PATCH] configure: improve logic and checks for nvenc

2016-08-30 Thread James Almer
On 8/30/2016 8:00 AM, Timo Rothenpieler wrote: > --- > configure | 37 + > 1 file changed, 25 insertions(+), 12 deletions(-) > > diff --git a/configure b/configure > index 52931c3..bcfc9a8 100755 > --- a/configure > +++ b/configure > @@ -5992,20 +5992,33 @@ ena

Re: [FFmpeg-devel] HLS Segmenter and the "hls_time" option

2016-08-30 Thread Steven Liu
2016-08-31 1:48 GMT+08:00 Aman Gupta : > On Fri, Aug 26, 2016 at 2:06 AM, Steven Liu > wrote: > > > 2016-08-26 16:58 GMT+08:00 Ibrahim Tachijian : > > > > > Thanks this actually does what I expected it to do. > > > For me this option will help a lot, and we would really be interested > in > > > t

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-30 Thread Brett Harrison
Since there are differing opinions on how the default fontsize should be established this patch adds my changes while preserving the current behavior when fontsize is not specified. On Tue, Aug 30, 2016 at 2:43 AM, Nicolas George wrote: > Le tridi 13 fructidor, an CCXXIV, Brett Harrison a écrit

[FFmpeg-devel] [PATCH] libavcodec/opus: Add channel mapping 2 to extradata parser

2016-08-30 Thread Michael Graczyk
This allows libavcodec/opus to demux ambisonics in an ogg/opus container. Channel mapping family 2 is being added in this standards track IETF draft: tools.ietf.org/html/draft-ietf-codec-ambisonics-00 --- libavcodec/opus.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] added expr evaluation to drawtext - fontsize

2016-08-30 Thread Kieran O Leary
Hi, On Fri, Aug 26, 2016 at 10:37 PM, Brett Harrison wrote: > Allows expr evaluation in the fontsize parameter for drawtext. Thanks for making this. I regularly use drawtext to create watermarked/timecoded access copies in a moving image archive and I have to use workarounds in scripts in order

Re: [FFmpeg-devel] [PATCH] avfilter/vf_dctdnoiz: add YUV444P support

2016-08-30 Thread Clément Bœsch
On Mon, Aug 29, 2016 at 10:00:31PM +0200, Paul B Mahol wrote: > On Mon, Aug 29, 2016 at 8:52 PM, Clément Bœsch wrote: > > > On Mon, Aug 29, 2016 at 07:00:54PM +0200, Paul B Mahol wrote: > > > Hi, > > > > > > patch attached. > > > > The color decorrelation is an important part of the denoising alg

Re: [FFmpeg-devel] [PATCH] libavutil: let clang-FORTIFY build; NFC.

2016-08-30 Thread George Burgess
[Re-sending from the right email address...] Good intuition. :) This is all I saw when compiling Chrome; looks like I misconfigured ffmpeg, though, so `make fate` was using GCC to compile things. With the correct configuration, I see a few more errors. I'll send out v2 shortly. Thanks! On Tue, A

[FFmpeg-devel] [PATCH v2] Let clang-FORTIFY build; NFC.

2016-08-30 Thread George Burgess IV
ChromeOS is adopting a new FORTIFY implementation tailored for clang. As an artifact of how this new FORTIFY is implemented, a handful of implicit conversion warnings get turned into errors. This patch fixes the implicit conversions in ffmpeg that clang-FORTIFY has an issue with. Signed-off-by: Ge

Re: [FFmpeg-devel] [PATCH v3] lavf : scale_vaapi : add denoise/sharpless support

2016-08-30 Thread Mark Thompson
On 30/08/16 09:00, Jun Zhao wrote: > v3 : fix sharpless mapping issue > v2 : fix filter support flag check logic issue Hi, A general remark to start: vf_scale_vaapi is named to be a scaling filter (i.e. it replaces vf_scale/swscale for AV_PIX_FMT_VAAPI) - is this therefore really the right plac

Re: [FFmpeg-devel] Evolution of lavfi's design and API

2016-08-30 Thread Michael Niedermayer
On Tue, Aug 30, 2016 at 09:08:18PM +0200, Nicolas George wrote: > Le quartidi 14 fructidor, an CCXXIV, Paul B Mahol a écrit : > > the filter frame multithreading would just internally, in filter context > > cache frames, once enough frames are in cache - call workers and be done, > > repeat. At eof

Re: [FFmpeg-devel] [PATCH v2] Let clang-FORTIFY build; NFC.

2016-08-30 Thread Ronald S. Bultje
Hi, On Tue, Aug 30, 2016 at 6:49 PM, George Burgess IV wrote: > ChromeOS is adopting a new FORTIFY implementation tailored for clang. As > an artifact of how this new FORTIFY is implemented, a handful of > implicit conversion warnings get turned into errors. This patch fixes > the implicit conve

[FFmpeg-devel] [PATCH 0/2] avisynth: fixes for alpha and planar rgb

2016-08-30 Thread Stephen Hutchinson
When bugtesting AviSynth+ against the patches submitted to libavformat, some issues came up that required changes to avisynth_c.h (which is updated here mostly to match what will be included in upstream avsplus) and the demuxer. Stephen Hutchinson (2): compat/avisynth: minor update for alpha off

[FFmpeg-devel] [PATCH 2/2] avisynth: fix Planar RGB output

2016-08-30 Thread Stephen Hutchinson
--- libavformat/avisynth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 1fe8e08..1acc44f 100644 --- a/libavformat/avisynth.c +++ b/libavformat/avisynth.c @@ -690,8 +690,10 @@ static int avisynth_read_packet_video(AVFor

[FFmpeg-devel] [PATCH 1/2] compat/avisynth: minor update for alpha offsets

2016-08-30 Thread Stephen Hutchinson
--- compat/avisynth/avisynth_c.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/compat/avisynth/avisynth_c.h b/compat/avisynth/avisynth_c.h index 605b92a..2f84dd1 100644 --- a/compat/avisynth/avisynth_c.h +++ b/compat/avisynth/avisynth_c.h @@ -533,7 +533,11 @@ typedef

Re: [FFmpeg-devel] [PATCH v2] Let clang-FORTIFY build; NFC.

2016-08-30 Thread George Burgess
Thanks for the feedback! I agree the casts aren't pretty. :) > Isn't it easier to change your fortify-clang and add a compiler option to disable this specific error for specific targets? The short answer is "in some cases, yes. Sadly, this doesn't seem to be one of those cases." The longer answe

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add warning for append_list and hls_init_time option

2016-08-30 Thread Michael Niedermayer
On Tue, Aug 30, 2016 at 05:30:18PM +0800, Steven Liu wrote: > When use append_list mode, the hls_init_time set nouse, > Because the append_list only support append at the old m3u8 end > cannot set init segments durations at the middle of the list. > That's invalid use append_list and hls_init_time

[FFmpeg-devel] [PATCH] lavf/matroskaenc: improve tag-skipping checks

2016-08-30 Thread Rodger Combs
- Add "duration" to list of skipped attributes (we handle that elsewhere) - Move the list to its own function and make its use consistent This fixes cases where we'd have a string in one list and not another, which could result in us writing an empty tag. --- libavformat/matroskaenc.c | 28 ++