Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

2016-07-03 Thread Carl Eugen Hoyos
Burt P. gmail.com> writes: > +/* For user information/stats, pulled up into HDCDContext > + * by filter_frame() */ > +int _hdcd_detected; No leading underscores please, same below. [...] > +/* update the user info/flags */ > +#define UPDATE_INFO(s,pe,tg,tf) I believe this should b

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

2016-07-03 Thread Moritz Barsnick
On Sat, Jul 02, 2016 at 23:53:20 -0500, Burt P. wrote: > static int integrate(hdcd_state_t *state, int *flag, const int32_t > *samples, int count, int stride) Your mailer is breaking likes in the patch. You may need to attach it as a text file, or actually use git send-email. > +/* update the u

Re: [FFmpeg-devel] [PATCH 1/3] avutil/parseutils: dont assume standard time when parsing a timestamp

2016-07-03 Thread Michael Niedermayer
On Fri, Jul 01, 2016 at 12:58:38AM +0200, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/parseutils.c | 1 + > 1 file changed, 1 insertion(+) probably ok thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Democracy is the form of gover

[FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

2016-07-03 Thread Burt P
The new HDCD filter really does nothing to show that it is working or that HDCD control information was even detected in the stream. This patch collects information about the decode, like which features were used, and reports it to the user at the end. Signed-off-by: Burt P --- libavfilter/af_hd

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

2016-07-03 Thread Burt P.
Thanks. I've sent a new version of the patch in reply to Carl Eugen Hoyos, and using git send-email this time, but I saw this message and included most of the things you mentioned. I'm still getting used to this. Anyway, I am curious why both of you think UPDATE_INFO should not remain a macro? It

Re: [FFmpeg-devel] [PATCH] lavc/h264_slice: use sps directly when checking for invalid 8x8 inference

2016-07-03 Thread Clément Bœsch
On Sat, Jul 02, 2016 at 09:07:42PM +0200, Michael Niedermayer wrote: > On Sat, Jul 02, 2016 at 07:23:35PM +0200, Clément Bœsch wrote: > > --- > > libavcodec/h264_slice.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM > > thx > applied -- Clément B. ___

Re: [FFmpeg-devel] [PATCH] libavcodec/mmaldec.c: add interlaced_frame and format struct to AVFrame for deinterlacing

2016-07-03 Thread Jens Ziller
Am Samstag, den 02.07.2016, 17:54 +0200 schrieb Moritz Barsnick: > On Sun, Jun 26, 2016 at 17:12:14 +0200, Jens Ziller wrote: > > > > +ctx->interlaced_frame = !(interlace_type.eMode == > > MMAL_InterlaceProgressive); > What's wrong with using the "!=" operator instead? "!=" is a comparing

Re: [FFmpeg-devel] [PATCH] libavcodec/mmaldec.c: add interlaced_frame and format struct to AVFrame for deinterlacing

2016-07-03 Thread Moritz Barsnick
On Sun, Jul 03, 2016 at 17:20:41 +0200, Jens Ziller wrote: > Am Samstag, den 02.07.2016, 17:54 +0200 schrieb Moritz Barsnick: > > On Sun, Jun 26, 2016 at 17:12:14 +0200, Jens Ziller wrote: > > > > > > +ctx->interlaced_frame = !(interlace_type.eMode == > > > MMAL_InterlaceProgressive); > >

Re: [FFmpeg-devel] libavdevice/decklink: advanced options for selecting an input connection

2016-07-03 Thread Michael Niedermayer
On Tue, May 10, 2016 at 08:30:11PM +0200, Matthias Hunstock wrote: > Am 10.05.2016 um 07:54 schrieb Felipe Astroza: > > This patch add additional input options: video input connection (vinput), > > audio input connection (ainput). > > > > Usage: > > ffmpeg -f decklink -i 'Card name'@fmt

Re: [FFmpeg-devel] [PATCH] libavcodec/mmaldec.c: add interlaced_frame and format struct to AVFrame for deinterlacing

2016-07-03 Thread Jens Ziller
Am Sonntag, den 03.07.2016, 18:05 +0200 schrieb Moritz Barsnick: > On Sun, Jul 03, 2016 at 17:20:41 +0200, Jens Ziller wrote: > > > > Am Samstag, den 02.07.2016, 17:54 +0200 schrieb Moritz Barsnick: > > > > > > On Sun, Jun 26, 2016 at 17:12:14 +0200, Jens Ziller wrote: > > > > > > > > > > > > +

[FFmpeg-devel] [RFC] beginner difficulty bug trac tag for new open source developers

2016-07-03 Thread compn
hello about once a month (also, around OPW/GSOC time) we get people in #ffmpeg-devel or the ml asking about contributing to ffmpeg. i think we need to try to organize something for new contributors. usually there is only one or two devs alive (including me) to guide newbies. most times these want

[FFmpeg-devel] [PATCH] avcodec: add missing xmm/neon clobber test wrappers for the new decode API

2016-07-03 Thread James Almer
Signed-off-by: James Almer --- Tested on Win64 (xmm), but not arm and aarch64 (neon). configure | 4 libavcodec/aarch64/neontest.c | 10 ++ libavcodec/arm/neontest.c | 10 ++ libavcodec/x86/w64xmmtest.c | 10 ++ 4 files changed, 34 insertio

Re: [FFmpeg-devel] [PATCH] avcodec: add missing xmm/neon clobber test wrappers for the new decode API

2016-07-03 Thread Ronald S. Bultje
Hi, On Sun, Jul 3, 2016 at 3:45 PM, James Almer wrote: > Signed-off-by: James Almer > --- > Tested on Win64 (xmm), but not arm and aarch64 (neon). > > configure | 4 > libavcodec/aarch64/neontest.c | 10 ++ > libavcodec/arm/neontest.c | 10 ++ > li

[FFmpeg-devel] [PATCH] avcodec/vaapi_encode_h264: Use av_clip_uintp2()

2016-07-03 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/vaapi_encode_h264.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index db9071f..d576ede 100644 --- a/libavcodec/vaapi_encode_h264.c +++ b/libavcodec/vaap

Re: [FFmpeg-devel] [PATCH] avcodec: add missing xmm/neon clobber test wrappers for the new decode API

2016-07-03 Thread James Almer
On 7/3/2016 5:24 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jul 3, 2016 at 3:45 PM, James Almer wrote: > >> Signed-off-by: James Almer >> --- >> Tested on Win64 (xmm), but not arm and aarch64 (neon). >> >> configure | 4 >> libavcodec/aarch64/neontest.c | 10 ++

[FFmpeg-devel] [PATCH]Support QT b64a ARGB64 rawvideo

2016-07-03 Thread Carl Eugen Hoyos
Hi! Attached patches fix ticket #5657. Please comment, Carl Eugen From 1bba7103c093951cab1bb9aa7b5eaf07b44d2781 Mon Sep 17 00:00:00 2001 From: v0lt Date: Sun, 3 Jul 2016 23:04:08 +0200 Subject: [PATCH 1/2] lavc/rawdec: Support QuickTime b64a ARGB64 rawvideo. Fixes ticket #5657. --- libavcodec/

Re: [FFmpeg-devel] [PATCH] configure: disable the new optimizer in Visual Studio 2015 Update 3

2016-07-03 Thread Hendrik Leppkes
On Tue, Jun 28, 2016 at 12:01 PM, Hendrik Leppkes wrote: > On Tue, Jun 28, 2016 at 11:48 AM, Hendrik Leppkes wrote: >> Visual Studio 2015 Update 3 introduced a new SSA optimizer, however >> it unfortunately causes miscompilations. Until it is fixed, the new >> optimizations are disabled and shoul

[FFmpeg-devel] [PATCH] x86/dcadsp: optimize lfe_fir0_float_fma3 on x86_32

2016-07-03 Thread James Almer
About 10% faster. Signed-off-by: James Almer --- libavcodec/x86/dcadsp.asm | 43 +++ 1 file changed, 31 insertions(+), 12 deletions(-) diff --git a/libavcodec/x86/dcadsp.asm b/libavcodec/x86/dcadsp.asm index c5bf21a..055361a 100644 --- a/libavcodec/x86/dc

[FFmpeg-devel] [PATCH] PPC64: Add versions of functions in libswscale/input.c optimized for POWER8 VSX SIMD.

2016-07-03 Thread Dan Parrot
Finish providing SIMD versions for POWER8 VSX of functions in libswscale/input.c That should allow trac ticket #5570 to be closed. --- libswscale/ppc/input_vsx.c | 1018 +++- 1 file changed, 1014 insertions(+), 4 deletions(-) diff --git a/libswscale/ppc/inp

Re: [FFmpeg-devel] [PATCH] configure: disable the new optimizer in Visual Studio 2015 Update 3

2016-07-03 Thread Kacper Michajlow
2016-07-03 23:39 GMT+02:00 Hendrik Leppkes : > On Tue, Jun 28, 2016 at 12:01 PM, Hendrik Leppkes wrote: >> On Tue, Jun 28, 2016 at 11:48 AM, Hendrik Leppkes >> wrote: >>> Visual Studio 2015 Update 3 introduced a new SSA optimizer, however >>> it unfortunately causes miscompilations. Until it is

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

2016-07-03 Thread Burt P.
I've attached a third attempt at this patch with all the suggestions by Carl Eugen Hoyos and Moritz Barsnick, including converting the UPDATE_INFO macro into a function, and some more comments and little fixes. Thanks. From 2dbbfc0cea83b769b5b02eecc5ec3dabc477457b Mon Sep 17 00:00:00 2001 From: Bu

Re: [FFmpeg-devel] [PATCH] PPC64: Add versions of functions in libswscale/input.c optimized for POWER8 VSX SIMD.

2016-07-03 Thread Carl Eugen Hoyos
Dan Parrot mail.com> writes: > Finish providing SIMD versions for POWER8 VSX of functions > in libswscale/input.c > That should allow trac ticket #5570 to be closed. Please add some numbers: Either for single functions or for a single ffmpeg command. (for rgb/bgr, mono is irrelevant) Carl Euge