Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: treat quant_cof as a signed value

2016-03-06 Thread Paul B Mahol
On 3/5/16, Umair Khan wrote: > Signed-off-by: Umair Khan > --- > libavcodec/alsdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c > index ebd364e..0043512 100644 > --- a/libavcodec/alsdec.c > +++ b/libavcodec/alsdec.c > @@ -72

[FFmpeg-devel] Original TOON.AVI with xxpc chunks

2016-03-06 Thread Mats Peterson
Speaking of toon.avi, here's the original from Sierra's King's Quest VI which contains xxpc chunks that aren't even detected by FFmpeg's demuxer. Probably some incorrect formatting of that AVI file, I don't know. https://drive.google.com/open?id=0B3_pEBoLs0faaFY0ME92SDA1VEU Mats -- Mats Peter

Re: [FFmpeg-devel] [PATCH 0/2] New versioning (was: version.sh: Always use latest tag for generated version number)

2016-03-06 Thread Reimar Döffinger
On 06.03.2016, at 02:50, Timothy Gu wrote: > To Michael and all release makers: after this patchset when making a > release in a release branch, please do ALL of the following in the > following order. Been absent a while from the list, but this sounds like we do not have documentation on the rel

[FFmpeg-devel] [PATCH] lavf/utils: Add debug messages to ff_get_packet_palette()

2016-03-06 Thread Mats Peterson
Might be useful. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From e959e17d2cd770e1bb6280c07910a085af624bc1 Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Sun, 6 Mar 2016 10:57:24 +0100 Subject: [PATCH] lavf/utils: Add debug messages to ff_get_packet_palette() --- libavformat/u

[FFmpeg-devel] [PATCH] avfilter/avf_showcqt: add performance debugging log

2016-03-06 Thread Muhammad Faiz
for easier development Signed-off-by: Muhammad Faiz --- libavfilter/avf_showcqt.c | 64 +++ libavfilter/avf_showcqt.h | 9 +++ 2 files changed, 68 insertions(+), 5 deletions(-) diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c in

Re: [FFmpeg-devel] [PATCH] version.sh: Always use latest tag for generated version number

2016-03-06 Thread Nicolas George
Le quintidi 15 ventôse, an CCXXIV, Timothy Gu a écrit : > The date is considered to be "good" but perhaps not as necessary. I think the date should be present too, it is the only information that can be parsed without any previous knowledge. > - It should also be gitrevisions(7)-compatible Extra

[FFmpeg-devel] [PATCH] bitstream.c: improve init_vlc error messages.

2016-03-06 Thread Reimar Döffinger
Makes it far easier to spot the issue if e.g. caused by a typo in the code table. Signed-off-by: Reimar Döffinger --- libavcodec/bitstream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/bitstream.c b/libavcodec/bitstream.c index 1acb7a3..9344175 100644 --- a/lib

Re: [FFmpeg-devel] [PATCH] tests/gapless: add gapless aac tests

2016-03-06 Thread Marton Balint
On Fri, 4 Mar 2016, Michael Niedermayer wrote: On Fri, Mar 04, 2016 at 10:46:33PM +0100, Marton Balint wrote: On Thu, 3 Mar 2016, Michael Niedermayer wrote: On Thu, Mar 03, 2016 at 02:27:52AM +0100, Marton Balint wrote: Signed-off-by: Marton Balint --- tests/fate/gapless.mak | 3 +++ t

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Reimar Döffinger
On Sat, Mar 05, 2016 at 06:38:40PM +0100, Michael Niedermayer wrote: > diff --git a/libavformat/avienc.c b/libavformat/avienc.c > index 0cfffb7..357dd34 100644 > --- a/libavformat/avienc.c > +++ b/libavformat/avienc.c > @@ -306,8 +306,7 @@ static int avi_write_header(AVFormatContext *s) >

Re: [FFmpeg-devel] [PATCH] aacenc: avoid double in quantize_bands.

2016-03-06 Thread Reimar Döffinger
On Wed, Mar 02, 2016 at 07:33:31PM +, Rostislav Pehlivanov wrote: > On 1 March 2016 at 21:55, Reimar Döffinger wrote: > > I cannot see any point whatsoever to use > > double here instead of float. > > Using float allows for use of SIMD. > > --- > > libavcodec/aacenc_utils.h | 5 ++--- > > 1 f

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 11:53:27AM +0100, Reimar Döffinger wrote: > On Sat, Mar 05, 2016 at 06:38:40PM +0100, Michael Niedermayer wrote: > > diff --git a/libavformat/avienc.c b/libavformat/avienc.c > > index 0cfffb7..357dd34 100644 > > --- a/libavformat/avienc.c > > +++ b/libavformat/avienc.c > > @

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Mats Peterson
On 03/06/2016 11:53 AM, Reimar Döffinger wrote: On Sat, Mar 05, 2016 at 06:38:40PM +0100, Michael Niedermayer wrote: diff --git a/libavformat/avienc.c b/libavformat/avienc.c index 0cfffb7..357dd34 100644 --- a/libavformat/avienc.c +++ b/libavformat/avienc.c @@ -306,8 +306,7 @@ static int avi_wri

[FFmpeg-devel] [PATCH 1/2] avcodec/aactab: do not use floats for constants

2016-03-06 Thread Marton Balint
This may improve precision for some compilers and architectures. Signed-off-by: Marton Balint --- libavcodec/aactab.h | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/libavcodec/aactab.h b/libavcodec/aactab.h index b48e7da..a0d44a2 100644 --- a/libavco

Re: [FFmpeg-devel] [PATCH] aacenc: optimize cost cache.

2016-03-06 Thread Reimar Döffinger
On Wed, Mar 02, 2016 at 07:19:08PM +, Rostislav Pehlivanov wrote: > > -entry->cb = cb; > > -entry->rtz = rtz; > > + cb, 1.0f, INFINITY, &entry->bits, > > &entry->energy, 0); > > +*cache_state = cb; > > } > > -if (bits) > > -

[FFmpeg-devel] [PATCH 2/2] avcodec/sinewin_tablegen: use sin instead of sinf to improve precision

2016-03-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/sinewin_tablegen.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sinewin_tablegen.h b/libavcodec/sinewin_tablegen.h index 4432135..438cd1a 100644 --- a/libavcodec/sinewin_tablegen.h +++ b/libavcodec/sinewin_tablegen.h @@

Re: [FFmpeg-devel] [PATCH] bitstream.c: improve init_vlc error messages.

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 11:46:23AM +0100, Reimar Döffinger wrote: > Makes it far easier to spot the issue if e.g. > caused by a typo in the code table. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/bitstream.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] --

[FFmpeg-devel] [PATCH v2] lavf/avienc: Store palette at keyframes if it differs from the global one

2016-03-06 Thread Mats Peterson
Michael, I've modified your patch to work with stream copy as well. Also, I've simplified it a bit in one place. It seems to produce identical files, but I might have missed something. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From 02868156345edf572c3c3cdd3fd916e5130c607c Mon Sep

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/aactab: do not use floats for constants

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 12:18:48PM +0100, Marton Balint wrote: > This may improve precision for some compilers and architectures. > > Signed-off-by: Marton Balint > --- > libavcodec/aactab.h | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/libavc

Re: [FFmpeg-devel] [PATCH] bitstream.c: improve init_vlc error messages.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 12:21:30PM +0100, Michael Niedermayer wrote: > On Sun, Mar 06, 2016 at 11:46:23AM +0100, Reimar Döffinger wrote: > > Makes it far easier to spot the issue if e.g. > > caused by a typo in the code table. > > > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/bitstr

[FFmpeg-devel] [PATCH v3] lavf/avienc: Store palette at keyframes if it differs from the global one

2016-03-06 Thread Mats Peterson
Minor fix. -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From 10faea5eccb02a6e971b6733412d3c41a6d46f5f Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Sun, 6 Mar 2016 12:41:07 +0100 Subject: [PATCH v3] lavf/avienc: Store palette at keyframes if it differs from the global one --- libavf

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Mats Peterson
On 03/06/2016 12:09 PM, Michael Niedermayer wrote: Once again, why are these tests unneeded? Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Mats Peterson
On 03/06/2016 12:51 PM, Mats Peterson wrote: On 03/06/2016 12:09 PM, Michael Niedermayer wrote: Once again, why are these tests unneeded? Mats avio_tell() won't work on an unseekable stream, since it uses avio_seek(), as far as I know. Mats -- Mats Peterson http://matsp888.no-ip.org/~mat

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: treat quant_cof as a signed value

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 09:00:47AM +0100, Paul B Mahol wrote: > On 3/5/16, Umair Khan wrote: > > Signed-off-by: Umair Khan > > --- > > libavcodec/alsdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c > > index ebd364e..0

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Eran Kornblau
Ping Thanks Eran 0001-mov-support-seek-in-encrypted-mp4.patch Description: 0001-mov-support-seek-in-encrypted-mp4.patch ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv2 1/2] avcodec/aactab: do not use floats for constants

2016-03-06 Thread Marton Balint
This may improve the precision of the fixed point decoder for some compilers and architectures. Signed-off-by: Marton Balint --- libavcodec/aac_defines.h | 6 +++--- libavcodec/aactab.h | 22 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Mats Peterson
On 03/06/2016 12:55 PM, Mats Peterson wrote: On 03/06/2016 12:51 PM, Mats Peterson wrote: On 03/06/2016 12:09 PM, Michael Niedermayer wrote: Once again, why are these tests unneeded? Mats avio_tell() won't work on an unseekable stream, since it uses avio_seek(), as far as I know. Mats I

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Ronald S. Bultje
Hi Mats, On Sun, Mar 6, 2016 at 6:51 AM, Mats Peterson < matsp888-at-yahoo@ffmpeg.org> wrote: > On 03/06/2016 12:09 PM, Michael Niedermayer wrote: > > Once again, why are these tests unneeded? You shouldn't send the same message 5x within 2 seconds. Please be patient. Why are they unneeded

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 01:15:33PM +0100, Mats Peterson wrote: > On 03/06/2016 12:55 PM, Mats Peterson wrote: > >On 03/06/2016 12:51 PM, Mats Peterson wrote: > >>On 03/06/2016 12:09 PM, Michael Niedermayer wrote: > >> > >>Once again, why are these tests unneeded? > >> > >>Mats > >> > > > >avio_tell

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Mats Peterson
On 03/06/2016 01:29 PM, Ronald S. Bultje wrote: Hi Mats, On Sun, Mar 6, 2016 at 6:51 AM, Mats Peterson < matsp888-at-yahoo@ffmpeg.org> wrote: On 03/06/2016 12:09 PM, Michael Niedermayer wrote: Once again, why are these tests unneeded? You shouldn't send the same message 5x within 2 sec

[FFmpeg-devel] [PATCH v4] lavf/avienc: Store palette at keyframes if it differs from the global one

2016-03-06 Thread Mats Peterson
Another fix for non-seekable streams. Once again, Michael, this is your patch modified to work with stream copy. Mats -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From cdbb72a0ef1f061b32f56dd390584db4122ec84b Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Sun, 6 Mar 2016 14:04:57 +01

Re: [FFmpeg-devel] [PATCH v4] lavf/avienc: Store palette at keyframes if it differs from the global one

2016-03-06 Thread Mats Peterson
On 03/06/2016 02:07 PM, Mats Peterson wrote: Another fix for non-seekable streams. Once again, Michael, this is your patch modified to work with stream copy. Mats Now, *seeking* in AVI files with xxpc chunks (at least with FFplay) still leaves a lot to be desired. It only works so-so. Are

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Ronald S. Bultje
Hi, On Sun, Mar 6, 2016 at 7:37 AM, Mats Peterson < matsp888-at-yahoo@ffmpeg.org> wrote: > On 03/06/2016 01:29 PM, Ronald S. Bultje wrote: > >> Hi Mats, >> >> On Sun, Mar 6, 2016 at 6:51 AM, Mats Peterson < >> matsp888-at-yahoo@ffmpeg.org> wrote: >> >> On 03/06/2016 12:09 PM, Michael Nied

Re: [FFmpeg-devel] [PATCH] avformat/avienc: Remove unneeded seekable tests

2016-03-06 Thread Mats Peterson
"Ronald S. Bultje" skrev: (6 mars 2016 14:37:25 CET) >Hi, > >On Sun, Mar 6, 2016 at 7:37 AM, Mats Peterson < >matsp888-at-yahoo@ffmpeg.org> wrote: > >> On 03/06/2016 01:29 PM, Ronald S. Bultje wrote: >> >>> Hi Mats, >>> >>> On Sun, Mar 6, 2016 at 6:51 AM, Mats Peterson < >>> matsp888-at-yahoo.

Re: [FFmpeg-devel] [PATCH] [RFC] proof-of-concept minimal inflate.

2016-03-06 Thread Ronald S. Bultje
Hi, On Sat, Mar 5, 2016 at 5:34 PM, Reimar Döffinger wrote: > FFmpeg currently lacks a fallback inflate algorithm > when zlib is not available. > This wouldn't be the first time we NIH'ed something, so that by itself isn't a sufficiently good reason to not use it :) We have a lot of infrastruc

[FFmpeg-devel] [PATCH v5] lavf/avienc: Store palette in keyframes if it differs from the global one

2016-03-06 Thread Mats Peterson
Restored your code at the place where I had "simplified it". It's obviously needed. -- Mats Peterson http://matsp888.no-ip.org/~mats/ >From fdc1b9d1c22417993a1295fc10904901d2a1269a Mon Sep 17 00:00:00 2001 From: Mats Peterson Date: Sun, 6 Mar 2016 14:54:30 +0100 Subject: [PATCH v5] lavf/avienc:

Re: [FFmpeg-devel] [PATCH] [RFC] proof-of-concept minimal inflate.

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 08:43:15AM -0500, Ronald S. Bultje wrote: > Hi, > > On Sat, Mar 5, 2016 at 5:34 PM, Reimar Döffinger > wrote: > > > FFmpeg currently lacks a fallback inflate algorithm > > when zlib is not available. > > > > This wouldn't be the first time we NIH'ed something, so that by

Re: [FFmpeg-devel] [PATCH v5] lavf/avienc: Store palette in keyframes if it differs from the global one

2016-03-06 Thread Mats Peterson
Mats Peterson skrev: (6 mars 2016 14:56:04 CET) >Restored your code at the place where I had "simplified it". It's >obviously needed. A question: Do we need to add keyframe xxpc chunks when doing stream copy? It would be semantically wrong in a way. I'm ambivalent about it. If this is not nee

Re: [FFmpeg-devel] [PATCH] [RFC] proof-of-concept minimal inflate.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 08:43:15AM -0500, Ronald S. Bultje wrote: > We have a lot of infrastructure for it already available > > though, like VLC code reading (though only in libavcodec, > > not libavutil). > > This is a hackish quick-and-dirty version. > > It certainly is not optimized, and I woul

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 12:07:37PM +, Eran Kornblau wrote: > Ping > > Thanks > > Eran > isom.h |3 ++ > mov.c | 94 > + > 2 files changed, 97 insertions(+) > 395b2cf334ec76f21376f52709b5a9caeeb39d9d > 0001-mov-support

[FFmpeg-devel] [PATCH] aacenc: use generational cache instead of resetting.

2016-03-06 Thread Reimar Döffinger
Approximately 11% faster transcoding from mp3 with default settings. Signed-off-by: Reimar Döffinger --- libavcodec/aacenc.c | 9 - libavcodec/aacenc.h | 5 +++-- libavcodec/aacenc_quantization_misc.h | 3 ++- 3 files changed, 9 insertions(+), 8 deleti

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/dca: clear X96 channels if nothing was decoded

2016-03-06 Thread Michael Niedermayer
On Wed, Mar 02, 2016 at 10:31:10PM +0300, foo86 wrote: > The first X96 channel set can have more channels than core, causing X96 > decoding to be skipped. Clear the number of decoded X96 channels to zero > in this rudimentary case. > --- > libavcodec/dca_core.c | 1 + > 1 file changed, 1 insertion

[FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
Approximately 10% faster transcode from mp3 to aac with default settings. Signed-off-by: Reimar Döffinger --- libavcodec/aacenc_utils.h | 47 ++- 1 file changed, 38 insertions(+), 9 deletions(-) diff --git a/libavcodec/aacenc_utils.h b/libavcodec/aace

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 07:35:58PM +0100, Reimar Döffinger wrote: > Approximately 10% faster transcode from mp3 to aac > with default settings. Note to anyone wanting to optimize it further: There is almost 25% on the table if you can replace the pow() and cos() function uses by something more eff

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread James Almer
On 3/6/2016 3:35 PM, Reimar Döffinger wrote: > Approximately 10% faster transcode from mp3 to aac > with default settings. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/aacenc_utils.h | 47 > ++- > 1 file changed, 38 insertions(+), 9 deletion

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 03:49:00PM -0300, James Almer wrote: > On 3/6/2016 3:35 PM, Reimar Döffinger wrote: > > Approximately 10% faster transcode from mp3 to aac > > with default settings. > > > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/aacenc_utils.h | 47 > > ++

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
Please review the patch. NagaChaitanya Vellanki (1): Add tests for functions in hash.c libavutil/Makefile | 1 + libavutil/hash.c | 41 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 +++

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
--- libavutil/Makefile | 1 + libavutil/hash.c | 41 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 + 4 files changed, 91 insertions(+) create mode 100644 tests/ref/fate/hash

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread James Almer
On 3/6/2016 4:14 PM, Reimar Döffinger wrote: > On Sun, Mar 06, 2016 at 03:49:00PM -0300, James Almer wrote: >> On 3/6/2016 3:35 PM, Reimar Döffinger wrote: >>> Approximately 10% faster transcode from mp3 to aac >>> with default settings. >>> >>> Signed-off-by: Reimar Döffinger >>> --- >>> libavco

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On Sun, Mar 06, 2016 at 04:46:08PM -0300, James Almer wrote: > On 3/6/2016 4:14 PM, Reimar Döffinger wrote: > > On Sun, Mar 06, 2016 at 03:49:00PM -0300, James Almer wrote: > >> On 3/6/2016 3:35 PM, Reimar Döffinger wrote: > >> Are you sure this wasn't vectorized already? I remember i checked and i

[FFmpeg-devel] [PATCH] aacenc_utils: Use temporary variable.

2016-03-06 Thread Reimar Döffinger
This ensures gcc does not create unnecessary loads or stores and possibly even does not vectorize the negation. Speeds up mp3 to aac transcoding with default settings by 10% when using "gcc (Debian 5.3.1-10) 5.3.1 20160224". Signed-off-by: Reimar Döffinger --- libavcodec/aacenc_utils.h | 5 +++--

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Eran Kornblau
> > can you create a fate test for this ? > maybe seek-test could be simply used? > Sure, can you point me to some existing test that is similar enough for me to use as a reference ? I read the Wiki page about adding a test, but not quite sure how to apply it here > thanks > > [...] > -- > M

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Use jpeg constants in jpeg_probe()

2016-03-06 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > > 1 file changed, 37 insertions(+), 36 deletions(-) > > 82bb95da87139860c2e09731e375420e2733392e patchjpegconstants.diff > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > > LGTM > > thx Patch applied. Thank you, Carl Eugen __

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread James Almer
On 3/6/2016 4:28 PM, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/hash.c | 41 + > tests/fate/libavutil.mak | 4 > tests/ref/fate/hash | 45 + > 4 files chan

Re: [FFmpeg-devel] Support seek in encrypted MP4

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 08:35:41PM +, Eran Kornblau wrote: > > > > can you create a fate test for this ? > > maybe seek-test could be simply used? > > > Sure, can you point me to some existing test that is similar enough for me to > use as a reference ? > I read the Wiki page about adding a

Re: [FFmpeg-devel] [PATCHv2 1/2] avcodec/aactab: do not use floats for constants

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 01:10:48PM +0100, Marton Balint wrote: > This may improve the precision of the fixed point decoder for some compilers > and architectures. > > Signed-off-by: Marton Balint > --- > libavcodec/aac_defines.h | 6 +++--- > libavcodec/aactab.h | 22 +++---

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread Michael Niedermayer
On Sun, Mar 06, 2016 at 11:27:59AM -0800, NagaChaitanya Vellanki wrote: > Please review the patch. > > NagaChaitanya Vellanki (1): > Add tests for functions in hash.c btw, if this is a qualification task for GSoC or Outreachy then please add yourself to https://trac.ffmpeg.org/wiki/SponsoringPr

Re: [FFmpeg-devel] [PATCH] avformat/ftp: Support response code 125 for STOR and RETR commands

2016-03-06 Thread Michael Niedermayer
On Thu, Jan 07, 2016 at 10:38:06AM +0100, Raymond Hilseth wrote: > This fixes a problem where ffmpeg would hang if there is already an open > data connection, and the server sends a 125 response code in reply to a > STOR or RETR command. > > Signed-off-by: Raymond Hilseth > --- > libavformat/ftp

Re: [FFmpeg-devel] [PATCH] rtp: Fix play multiple multicast streams with the same port

2016-03-06 Thread Michael Niedermayer
On Wed, Jan 13, 2016 at 09:11:13AM +0800, Zhao Zhili wrote: > ping? applied sorry for the delay, i had hoped thomas would review thanks > > On Fri, Jan 8, 2016 at 9:15 AM, Zhao Zhili wrote: > > > Sorry, I work hard to cross the Great Fire Wall to send this patch and > > cannot send it as pl

[FFmpeg-devel] [PATCH 1/3] lavf/segment: style nit

2016-03-06 Thread Rodger Combs
--- libavformat/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index dd3b092..818c0c9 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -809,7 +809,7 @@ static int seg_write_packet(AVFormatContext *s, AVPa

[FFmpeg-devel] [PATCH 2/3] lavf/segment: slight refactor to seg_write_packet

2016-03-06 Thread Rodger Combs
This reduces some code duplication, and ensures that cur_entry.last_duration is always set. --- libavformat/segment.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 818c0c9..6ad991f 100644 --- a/libavformat/segme

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Ganesh Ajjanagadde
On Sun, Mar 6, 2016 at 1:43 PM, Reimar Döffinger wrote: > On Sun, Mar 06, 2016 at 07:35:58PM +0100, Reimar Döffinger wrote: >> Approximately 10% faster transcode from mp3 to aac >> with default settings. > > Note to anyone wanting to optimize it further: > There is almost 25% on the table if you c

[FFmpeg-devel] [PATCH 3/3] lavf/segment: add option to write empty filler segments as needed

2016-03-06 Thread Rodger Combs
--- doc/muxers.texi | 5 + libavformat/segment.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index f2ad7fe..700ec88 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1224,6 +1224,11 @@ muxers/codecs. It is set to @co

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
--- libavutil/Makefile | 1 + libavutil/hash.c | 45 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 + 4 files changed, 95 insertions(+) create mode 100644 tests/ref/fate/ha

[FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread NagaChaitanya Vellanki
Made changes as suggested by James Almer. NagaChaitanya Vellanki (1): Add tests for functions in hash.c libavutil/Makefile | 1 + libavutil/hash.c | 45 + tests/fate/libavutil.mak | 4 tests/ref/fate/hash | 45 ++

[FFmpeg-devel] [PATCH] web/contact: add IRC web-client link

2016-03-06 Thread Ganesh Ajjanagadde
Ran into some glitches when I initially tried accessing IRC through my browser; in particular the Firefox default of "mibbit" does not work: https://blog.freenode.net/2009/06/new-freenode-webchat-and-why-to-use-it/. Signed-off-by: Ganesh Ajjanagadde --- src/contact | 2 ++ 1 file changed, 2 inse

Re: [FFmpeg-devel] [PATCH] web/contact: add IRC web-client link

2016-03-06 Thread Lou Logan
On Sun, 6 Mar 2016 22:33:30 -0500, Ganesh Ajjanagadde wrote: > Ran into some glitches when I initially tried accessing IRC through my > browser; in particular the Firefox default of "mibbit" does not work: > https://blog.freenode.net/2009/06/new-freenode-webchat-and-why-to-use-it/. > > Signed-of

[FFmpeg-devel] [PATCH] Opus in MP4 support

2016-03-06 Thread Matthew Gregan
Hi, The attached patch adds basic mux/demux support for the Opus audio codec in MP4. Mozilla have expressed interest in shipping support for this in: https://groups.google.com/d/msg/mozilla.dev.platform/mdDZ-nBr_jM/MaLi2BDOAgAJ Comments welcome! Basic Opus in MP4 mux/demux support based on the d

Re: [FFmpeg-devel] [PATCH] Add tests for functions in hash.c

2016-03-06 Thread James Almer
On 3/7/2016 12:26 AM, NagaChaitanya Vellanki wrote: > --- > libavutil/Makefile | 1 + > libavutil/hash.c | 45 + > tests/fate/libavutil.mak | 4 > tests/ref/fate/hash | 45 + > 4 files

Re: [FFmpeg-devel] [PATCH] aacenc_utils: unroll loops to allow compiler to use SIMD.

2016-03-06 Thread Reimar Döffinger
On 07.03.2016, at 04:04, Ganesh Ajjanagadde wrote: > On Sun, Mar 6, 2016 at 1:43 PM, Reimar Döffinger > wrote: >> On Sun, Mar 06, 2016 at 07:35:58PM +0100, Reimar Döffinger wrote: >>> Approximately 10% faster transcode from mp3 to aac >>> with default settings. >> >> Note to anyone wanting to op