Re: [FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

2015-12-26 Thread Michael Niedermayer
On Fri, Dec 25, 2015 at 08:10:16PM -0800, Ganesh Ajjanagadde wrote: > On Fri, Dec 25, 2015 at 9:11 AM, Ganesh Ajjanagadde > wrote: > > This tightens the errors by doing a first order Taylor approximation of > > one obvious source of error. This results in negligible runtime > > slowdown, but impro

Re: [FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

2015-12-26 Thread Ronald S. Bultje
Hi, On Sat, Dec 26, 2015 at 6:37 AM, Michael Niedermayer wrote: > On Fri, Dec 25, 2015 at 08:10:16PM -0800, Ganesh Ajjanagadde wrote: > > On Fri, Dec 25, 2015 at 9:11 AM, Ganesh Ajjanagadde > > wrote: > > > This tightens the errors by doing a first order Taylor approximation of > > > one obviou

[FFmpeg-devel] [PATCHv2] lavf/srtdec: rewrite parsing logic

2015-12-26 Thread Clément Bœsch
Fixes Ticket #5032 The samples in Ticket #5032 is using \r\r\n as line breaks. Since we already are handling \r, or \n, or \r\n as line breaks, \r\n\n will be considered as a double line breaks. This is an issue because ff_subtitles_read_text_chunk() will as a result stop extracting a chunk after

[FFmpeg-devel] Added support for http_proxy

2015-12-26 Thread Joel Holdsworth
Previously, avformat/http only supported http proxy servers via the http_proxy environment variable. This patch series add support for an "http_proxy" option in avformat/http, which enables per-stream tunnelling through an HTTP proxy server. This has applications within Kodi, where per-stream p

[FFmpeg-devel] [PATCH 1/3] avformat/http: Added http_proxy option

2015-12-26 Thread Joel Holdsworth
--- libavformat/http.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 2230442..ad8358e 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -67,6 +67,7 @@ typedef struct HTTPContext { char *location; HTTPAuthSta

[FFmpeg-devel] [PATCH 2/3] avformat/hls: Remember to free HLSContext::headers

2015-12-26 Thread Joel Holdsworth
--- libavformat/hls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 2d4ee13..82d5410 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -256,6 +256,7 @@ static void free_playlist_list(HLSContext *c) av_freep(&c->playlists); av_free

[FFmpeg-devel] [PATCH 3/3] avformat/hls: Added http_proxy support

2015-12-26 Thread Joel Holdsworth
--- libavformat/hls.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 82d5410..9ced13b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -196,6 +196,7 @@ typedef struct HLSContext { char *user_agent;

Re: [FFmpeg-devel] [PATCH 1/3] avformat/http: Added http_proxy option

2015-12-26 Thread Nicolas George
Le sextidi 6 nivôse, an CCXXIV, Joel Holdsworth a écrit : > { "seekable", "control seekability of connection", OFFSET(seekable), > AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, D }, > { "chunked_post", "use chunked transfer-encoding for posts", > OFFSET(chunked_post), AV_OPT_TYPE_BOOL, { .i64

Re: [FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

2015-12-26 Thread Ganesh Ajjanagadde
On Sat, Dec 26, 2015 at 3:37 AM, Michael Niedermayer wrote: [...] > > i dont know if the speed difference of exp10 really matters for any > speed relevant code (probably not) and i dont know if the accuracy > increase really matters for any code either Accuracy increases rarely matter for anythin

Re: [FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

2015-12-26 Thread Nicolas George
Le sextidi 6 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : > Point taken though: the only clear changes are ones which are Pareto > improvements for speed and accuracy ... AND code complexity. For example, the pow(10, x) call in testsrc is neither speed-critical nor accuracy-critical. Regards,

Re: [FFmpeg-devel] [PATCH 3/3] lavu/internal: tighten errors for avpriv_exp10

2015-12-26 Thread Ganesh Ajjanagadde
On Sat, Dec 26, 2015 at 2:44 PM, Nicolas George wrote: > Le sextidi 6 nivôse, an CCXXIV, Ganesh Ajjanagadde a écrit : >> Point taken though: the only clear changes are ones which are Pareto >> improvements for speed and accuracy > > ... AND code complexity. For example, the pow(10, x) call in test

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

2015-12-26 Thread James Almer
On 12/23/2015 3:47 PM, Ganesh Ajjanagadde wrote: > exp10, introduced recently, is superior for the purpose. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/on2avc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/on2avc.c b/libavcodec/on2avc.c >

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

2015-12-26 Thread Ganesh Ajjanagadde
On Sat, Dec 26, 2015 at 4:08 PM, James Almer wrote: > On 12/23/2015 3:47 PM, Ganesh Ajjanagadde wrote: >> exp10, introduced recently, is superior for the purpose. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavcodec/on2avc.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

2015-12-26 Thread Ganesh Ajjanagadde
On Sat, Dec 26, 2015 at 4:20 PM, Ganesh Ajjanagadde wrote: > On Sat, Dec 26, 2015 at 4:08 PM, James Almer wrote: >> On 12/23/2015 3:47 PM, Ganesh Ajjanagadde wrote: >>> exp10, introduced recently, is superior for the purpose. >>> >>> Signed-off-by: Ganesh Ajjanagadde >>> --- >>> libavcodec/on2a

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Michael Niedermayer
On Wed, Dec 23, 2015 at 03:37:18PM +0100, Mats Peterson wrote: > I mistakenly used 'extradata' rather than 'st->codec->extradata', > naturally leading to a segfault. Here's an updated patch. > > An explanation of the patch follows: > > Palettized QuickTime video in Matroska has hitherto not been

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

2015-12-26 Thread Michael Niedermayer
On Sat, Dec 26, 2015 at 05:23:55PM -0800, Ganesh Ajjanagadde wrote: > On Sat, Dec 26, 2015 at 4:20 PM, Ganesh Ajjanagadde wrote: > > On Sat, Dec 26, 2015 at 4:08 PM, James Almer wrote: > >> On 12/23/2015 3:47 PM, Ganesh Ajjanagadde wrote: > >>> exp10, introduced recently, is superior for the purp

Re: [FFmpeg-devel] [PATCH 11/15] lavc/on2avc: replace pow(10, x) by exp10(x)

2015-12-26 Thread Ganesh Ajjanagadde
On Sat, Dec 26, 2015 at 6:19 PM, Michael Niedermayer wrote: > On Sat, Dec 26, 2015 at 05:23:55PM -0800, Ganesh Ajjanagadde wrote: >> On Sat, Dec 26, 2015 at 4:20 PM, Ganesh Ajjanagadde wrote: >> > On Sat, Dec 26, 2015 at 4:08 PM, James Almer wrote: >> >> On 12/23/2015 3:47 PM, Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Mats Peterson
On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); the malloc is unneeded, an array on the stack could be used (its just a fixed 70 bytes) this would also simplify the error handling Yes, I thought so. I tried to be "a good

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Mats Peterson
On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); the malloc is unneeded, an array on the stack could be used (its just a fixed 70 bytes) this would also simplify the error handli

Re: [FFmpeg-devel] [PATCH v6] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Mats Peterson
On 12/27/2015 04:42 AM, Mats Peterson wrote: On 12/27/2015 03:57 AM, Mats Peterson wrote: On 12/27/2015 03:03 AM, Michael Niedermayer wrote: + +if (!(stsd = av_malloc(70))) +return AVERROR(ENOMEM); the malloc is unneeded, an array on the stack could be used (its just a fixed 70 by

Re: [FFmpeg-devel] [PATCH 5/5] lavc/snowenc: replace rint by lrint

2015-12-26 Thread Ganesh Ajjanagadde
On Fri, Dec 25, 2015 at 5:48 PM, Ganesh Ajjanagadde wrote: > On Fri, Dec 25, 2015 at 5:38 PM, Michael Niedermayer > wrote: >> On Fri, Dec 25, 2015 at 04:00:20PM -0800, Ganesh Ajjanagadde wrote: >>> avoids float to int cast, and is >> >> >>> slightly superior in terms of rounding >>> ("Dutch/Gauss

Re: [FFmpeg-devel] [PATCH] ffprobe: avoid unnecessary pow and exp2 calls

2015-12-26 Thread Ganesh Ajjanagadde
On Wed, Dec 23, 2015 at 9:56 AM, Ganesh Ajjanagadde wrote: > These are just for prefixes and may be hardcoded easily; see lavu/eval > for this approach. > > Signed-off-by: Ganesh Ajjanagadde > --- > ffprobe.c | 27 +++ > 1 file changed, 19 insertions(+), 8 deletions(-) >

[FFmpeg-devel] [PATCH] lavfi/af_anequalizer: remove cabs, cexp dependencies

2015-12-26 Thread Ganesh Ajjanagadde
Replaces by real arithmetic. Tested the validity of these transformations separately. Signed-off-by: Ganesh Ajjanagadde --- configure| 1 - libavfilter/af_anequalizer.c | 25 + 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/configure

[FFmpeg-devel] [PATCH v7] lavf: palettized QuickTime video in Matroska

2015-12-26 Thread Mats Peterson
Palettized QuickTime video in Matroska has hitherto not been recognized whatsoever, and the "palette" used has been completely random. The patch for matroskadec.c fixes this issue by adding a palette side data packet in matroska_deliver_packet(), much in the same way as it's done in mov.c. T