Re: [FFmpeg-devel] [PATCH] Revert "Merge commit '741b494fa8cd28a7d096349bac183893c236e3f9'"

2015-12-18 Thread Hendrik Leppkes
On Thu, Dec 17, 2015 at 2:46 PM, Hendrik Leppkes wrote: > On Thu, Dec 17, 2015 at 2:06 PM, Michael Niedermayer wrote: >> From: Michael Niedermayer >> >> This fixes a regression of the sample from Ticket 2371 >> >> This reverts commit bc66451e5e903698ee0500faf04c1214f3dd157f, reversing >> changes

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So you probably did use gcc. Anyway since it is already merged I guess take my reply as a hint for next time :)

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Kacper Michajlow
18 gru 2015 10:06 AM "Kacper Michajlow" napisał(a): > > One minor nitpick about commit message. You could mention which compiler was used to generate code for benchmark. For example Clang 3.7 replaces pow(2,...) with exp2(...) call by itself. So you probably did use gcc. Anyway since it is already

Re: [FFmpeg-devel] [PATCH] ffplay: remove existing AVPicture usage

2015-12-18 Thread Paul B Mahol
On 12/18/15, Marton Balint wrote: > It is deprecated. > > Signed-off-by: Marton Balint > --- > ffplay.c | 51 +++ > 1 file changed, 27 insertions(+), 24 deletions(-) > lgtm ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/1] arm64: fix inverted register order in transpose_4x4H

2015-12-18 Thread Janne Grunau
Fix related register order issue in ff_h264_idct_add_neon. Found-by: zjh8890 <243186...@qq.com> --- libavcodec/aarch64/h264idct_neon.S | 4 ++-- libavcodec/aarch64/neon.S | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/aarch64/h264idct_neon.S b/libavc

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-18 Thread Matthieu Bouron
On Thu, Dec 17, 2015 at 07:47:08PM +0100, Michael Niedermayer wrote: > On Thu, Dec 17, 2015 at 04:54:31PM +0100, Matthieu Bouron wrote: > > On Tue, Dec 15, 2015 at 06:22:43PM +0100, Michael Niedermayer wrote: > > > On Tue, Dec 15, 2015 at 05:46:09PM +0100, Matthieu Bouron wrote: > > > > From: Matth

Re: [FFmpeg-devel] [PATCH 1/1] arm64: fix inverted register order in transpose_4x4H

2015-12-18 Thread Carl Eugen Hoyos
Janne Grunau jannau.net> writes: > Fix related register order issue in ff_h264_idct_add_neon. Is there a public sample that allows to reproduce? Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Mats Peterson
On 12/18/2015 05:32 AM, Mats Peterson wrote: On 12/18/2015 05:12 AM, Mats Peterson wrote: On 12/18/2015 04:13 AM, Mats Peterson wrote: Samples: https://drive.google.com/open?id=0B3_pEBoLs0faei1Sd1h6SG11QlE Mats The clips are sample clips from Video for Windows, in case anyone wonders. I hav

[FFmpeg-devel] [PATCH] aacenc: remove depricated avctx->frame_bits use

2015-12-18 Thread Rostislav Pehlivanov
The type of last_frame_pb_count was chosen to be an int since overflow is impossible (the spec says the maximum bits per frame is 6144 per channel and the encoder checks for that). Signed-off-by: Rostislav Pehlivanov --- libavcodec/aacenc.c | 9 +++-- libavcodec/aacenc.h | 1 + 2 files chang

Re: [FFmpeg-devel] [PATCH] aacenc: remove depricated avctx->frame_bits use

2015-12-18 Thread Paul B Mahol
On 12/18/15, Rostislav Pehlivanov wrote: > The type of last_frame_pb_count was chosen to be an int since overflow > is impossible (the spec says the maximum bits per frame is 6144 per > channel and the encoder checks for that). > > Signed-off-by: Rostislav Pehlivanov > --- > libavcodec/aacenc.c

Re: [FFmpeg-devel] [libav-devel] [PATCH] nuv: reject negative fps rate

2015-12-18 Thread Andreas Cadhalpun
On 18.12.2015 12:00, Luca Barbato wrote: > On 17/12/15 23:01, Andreas Cadhalpun wrote: >> On 16.12.2015 22:18, Luca Barbato wrote: >>> On 16/12/15 20:56, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavformat/nuv.c | 4 1 file changed, 4 insertions(+) >

Re: [FFmpeg-devel] [PATCH] nuv: reject negative fps rate

2015-12-18 Thread Andreas Cadhalpun
On 18.12.2015 01:12, Michael Niedermayer wrote: > On Thu, Dec 17, 2015 at 11:03:15PM +0100, Andreas Cadhalpun wrote: >> On 16.12.2015 23:53, Michael Niedermayer wrote: >>> On Wed, Dec 16, 2015 at 08:56:55PM +0100, Andreas Cadhalpun wrote: Signed-off-by: Andreas Cadhalpun --- libavf

Re: [FFmpeg-devel] [PATCH] on2avc: limit number of bits to 30 in get_egolomb

2015-12-18 Thread Andreas Cadhalpun
On 18.12.2015 01:44, Michael Niedermayer wrote: > On Thu, Dec 17, 2015 at 11:30:01PM +0100, Andreas Cadhalpun wrote: >> On 17.12.2015 13:28, Michael Niedermayer wrote: >>> On Wed, Dec 16, 2015 at 08:20:18PM +0100, Andreas Cadhalpun wrote: More don't fit into the integer output. Also

Re: [FFmpeg-devel] [PATCH] exr: fix out of bounds read in get_code

2015-12-18 Thread Andreas Cadhalpun
On 13.12.2015 23:37, Andreas Cadhalpun wrote: > This macro unconditionally used out[-1], which causes an out of bounds > read, if out is the very beginning of the buffer. > > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/exr.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions

[FFmpeg-devel] [PATCH 1/2] swscale/arm/yuv2rgb: disable neon if accurate_rnd is enabled

2015-12-18 Thread Matthieu Bouron
From: Matthieu Bouron This disables the 32bit precision neon code path in favor of the default C one and avoids breaking fate if accurate_rnd is enabled. --- libswscale/arm/swscale_unscaled.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libswscale/arm/swscale_unscal

[FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-18 Thread Matthieu Bouron
From: Matthieu Bouron --- libswscale/arm/swscale_unscaled.c | 52 +++--- libswscale/arm/yuv2rgb_neon.S | 77 --- 2 files changed, 118 insertions(+), 11 deletions(-) diff --git a/libswscale/arm/swscale_unscaled.c b/libswscale/arm/swsca

[FFmpeg-devel] [PATCH] avfilter/vf_delogo: change the definition of logo_x2 and logo_y2

2015-12-18 Thread Jean Delvare
In the code we keep using logo_x2-1 and logo_y2-1 rather than logo_x2 and logo_y2 themselves. Define them to be what we need instead, to avoid the repeated subtractions. Signed-off-by: Jean Delvare --- libavfilter/vf_delogo.c | 26 +- 1 file changed, 13 insertions(+), 1

[FFmpeg-devel] [PATCH] lavfi/scale: add nb_slices debug option

2015-12-18 Thread Clément Bœsch
From: Clément Bœsch --- libavfilter/vf_scale.c | 8 1 file changed, 8 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index f2f475e..d8f5f77 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -110,6 +110,8 @@ typedef struct ScaleContext {

Re: [FFmpeg-devel] [PATCH] lavfi/scale: add nb_slices debug option

2015-12-18 Thread Nicolas George
L'octidi 28 frimaire, an CCXXIV, Clement Boesch a écrit : > +const int slice_h = FFMAX(1, link->h / scale->nb_slices); > +for (i = 0; i < scale->nb_slices; i++) > +scale_slice(link, out, in, scale->sws, i*slice_h, slice_h, 1, 0); What happens if link->h is not a multipl

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-18 Thread Matthieu Bouron
On Fri, Dec 18, 2015 at 3:59 PM, Matthieu Bouron wrote: > From: Matthieu Bouron > > --- > libswscale/arm/swscale_unscaled.c | 52 +++--- > libswscale/arm/yuv2rgb_neon.S | 77 > --- > 2 files changed, 118 insertions(+), 11 deletions(-)

Re: [FFmpeg-devel] [libav-devel] [PATCH] nuv: reject negative fps rate

2015-12-18 Thread Andreas Cadhalpun
On 18.12.2015 15:46, Anton Khirnov wrote: > Quoting Luca Barbato (2015-12-18 15:36:33) >> On 18/12/15 15:25, Andreas Cadhalpun wrote: >>> On 18.12.2015 12:00, Luca Barbato wrote: b- mark the framerate as invalid >>> >>> How does one do that? >>> and let the user decide what to do, e.

Re: [FFmpeg-devel] [PATCH] avcodec/nellymoserenc: avoid wasteful pow

2015-12-18 Thread Ganesh Ajjanagadde
On Fri, Dec 18, 2015 at 1:11 AM, Kacper Michajlow wrote: > 18 gru 2015 10:06 AM "Kacper Michajlow" napisał(a): >> >> One minor nitpick about commit message. You could mention which compiler > was used to generate code for benchmark. For example Clang 3.7 replaces > pow(2,...) with exp2(...) call

Re: [FFmpeg-devel] [PATCH 2/2] lavc/aacsbr: sbr_dequant optimization

2015-12-18 Thread Ganesh Ajjanagadde
On Tue, Dec 15, 2015 at 9:53 PM, Ganesh Ajjanagadde wrote: > This uses ff_exp2fi to get a speedup (~ 6x). > > sample benchmark (Haswell, GNU/Linux): > old: > 19102 decicycles in sbr_dequant,1023 runs, 1 skips > 19002 decicycles in sbr_dequant,2045 runs, 3 skips > 17638 deci

Re: [FFmpeg-devel] [PATCH] aacenc: remove depricated avctx->frame_bits use

2015-12-18 Thread Claudio Freire
On Fri, Dec 18, 2015 at 10:59 AM, Rostislav Pehlivanov wrote: > The type of last_frame_pb_count was chosen to be an int since overflow > is impossible (the spec says the maximum bits per frame is 6144 per > channel and the encoder checks for that). LGTM __

[FFmpeg-devel] [PATCH] nutdec: reject negative sm_size

2015-12-18 Thread Andreas Cadhalpun
If it is negative, it makes size larger than the size of the packet buffer, causing invalid writes in avio_read. Signed-off-by: Andreas Cadhalpun --- libavformat/nutdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 286d1ee..47ae7a7 1

[FFmpeg-devel] [PATCH] nutdec: only copy the header if it exists

2015-12-18 Thread Andreas Cadhalpun
Fixes runtime error: null pointer passed as argument 2, which is declared to never be null Signed-off-by: Andreas Cadhalpun --- libavformat/nutdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 47ae7a7..3aa7a88 100644 ---

Re: [FFmpeg-devel] [PATCH] lavfi/scale: add nb_slices debug option

2015-12-18 Thread Clément Bœsch
On Fri, Dec 18, 2015 at 04:33:18PM +0100, Nicolas George wrote: > L'octidi 28 frimaire, an CCXXIV, Clement Boesch a écrit : > > +const int slice_h = FFMAX(1, link->h / scale->nb_slices); > > +for (i = 0; i < scale->nb_slices; i++) > > +scale_slice(link, out, in, scale->s

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Paul B Mahol
On 12/18/15, Mats Peterson wrote: > On 12/18/2015 05:32 AM, Mats Peterson wrote: >> On 12/18/2015 05:12 AM, Mats Peterson wrote: >>> On 12/18/2015 04:13 AM, Mats Peterson wrote: Samples: https://drive.google.com/open?id=0B3_pEBoLs0faei1Sd1h6SG11QlE Mats >>> >>> The clips are sa

Re: [FFmpeg-devel] [libav-devel] [PATCH] nutdec: only copy the header if it exists

2015-12-18 Thread Andreas Cadhalpun
On 18.12.2015 18:53, Luca Barbato wrote: > On 18/12/15 17:24, Andreas Cadhalpun wrote: >> Fixes runtime error: null pointer passed as argument 2, which is >> declared to never be null >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/nutdec.c | 3 ++- >> 1 file changed, 2 insertions(+)

[FFmpeg-devel] [PATCH] xwddec: prevent overflow of lsize * avctx->height

2015-12-18 Thread Andreas Cadhalpun
This is used to check if the input buffer is larger enough, so if this overflows it can cause a false negative leading to a segmentation fault in bytestream2_get_bufferu. Signed-off-by: Andreas Cadhalpun --- libavcodec/xwddec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec

Re: [FFmpeg-devel] [libav-devel] [PATCH] nutdec: only copy the header if it exists

2015-12-18 Thread Andreas Cadhalpun
On 18.12.2015 20:06, Luca Barbato wrote: > On 18/12/15 19:05, Andreas Cadhalpun wrote: >> On 18.12.2015 18:53, Luca Barbato wrote: >>> On 18/12/15 17:24, Andreas Cadhalpun wrote: Fixes runtime error: null pointer passed as argument 2, which is declared to never be null Signed-of

Re: [FFmpeg-devel] [libav-devel] [PATCH] xwddec: prevent overflow of lsize * avctx->height

2015-12-18 Thread Andreas Cadhalpun
On 18.12.2015 20:08, Luca Barbato wrote: > On 18/12/15 20:04, Andreas Cadhalpun wrote: >> This is used to check if the input buffer is larger enough, so if this >> overflows it can cause a false negative leading to a segmentation fault >> in bytestream2_get_bufferu. >> >> Signed-off-by: Andreas Cad

[FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-18 Thread Ganesh Ajjanagadde
For systems with broken libms. Tested with NAN, -NAN, INFINITY, -INFINITY, +/-x for regular double x and combinations of these. Signed-off-by: Ganesh Ajjanagadde --- configure| 2 +- libavutil/libm.h | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/configure

[FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-18 Thread Matthias Hunstock
As it is already written in the documentation, BMD DeckLink cards are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). Currently the value is hardcoded to 2. Introduces new option. Signed-off-by: Matthias Hunstock --- doc/indevs.texi | 13 - libavdevic

[FFmpeg-devel] Patch for libavcodec dvdec.c

2015-12-18 Thread Dan Haddix
This is a patch for the bug filed here... https://trac.ffmpeg.org/ticket/5092 as described in the bug report the current code is designed against the SMPTE 314M spec, which only applies to SD content. In the SMPTE 370M spec they have flipped the meaning of "field 1" and "field 2" so the bits i

Re: [FFmpeg-devel] Patch for libavcodec dvdec.c

2015-12-18 Thread Carl Eugen Hoyos
Dan Haddix hotmail.com> writes: > This is my first patch so hopefully I did it correctly. > If not let me know and I will fix it. Please try the following, what you attached cannot be used. Checkout current FFmpeg: $ git checkout git://source.ffmpeg.org/ffmpeg.git ffmpeg Make your change(s) in

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-18 Thread Ronald S. Bultje
Hi, On Fri, Dec 18, 2015 at 2:18 PM, Ganesh Ajjanagadde wrote: > For systems with broken libms. > Tested with NAN, -NAN, INFINITY, -INFINITY, +/-x for regular double x and > combinations of these. > > Signed-off-by: Ganesh Ajjanagadde > --- > configure| 2 +- > libavutil/libm.h | 9 +++

Re: [FFmpeg-devel] [PATCH] lavu/libm: add copysign hack

2015-12-18 Thread Ganesh Ajjanagadde
On Fri, Dec 18, 2015 at 12:41 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Dec 18, 2015 at 2:18 PM, Ganesh Ajjanagadde > wrote: >> >> For systems with broken libms. >> Tested with NAN, -NAN, INFINITY, -INFINITY, +/-x for regular double x and >> combinations of these. >> >> Signed-off-by: Ganesh

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video2.1) codec

2015-12-18 Thread Piotr Bandurski
Dnia 18 grudnia 2015 18:54 Paul B Mahol napisał(a): > > > On 12/18/15, Mats Peterson wrote: > > On 12/18/2015 05:32 AM, Mats Peterson wrote: > >> On 12/18/2015 05:12 AM, Mats Peterson wrote: > >>> On 12/18/2015 04:13 AM, Mats Peterson wrote: > Samples: https://drive.google.com/open?id

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video2.1) codec

2015-12-18 Thread Paul B Mahol
On 12/18/15, Piotr Bandurski wrote: > > > > Dnia 18 grudnia 2015 18:54 Paul B Mahol napisal/(a): > > > >> >> > On 12/18/15, Mats Peterson wrote: >> > On 12/18/2015 05:32 AM, Mats Peterson wrote: >> >> On 12/18/2015 05:12 AM, Mats Peterson wrote: >> >>> On 12/18/2015 04:13 AM, Mats Peterson wrote

Re: [FFmpeg-devel] [libav-devel] [PATCH] xwddec: prevent overflow of lsize * avctx->height

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 08:13:06PM +0100, Andreas Cadhalpun wrote: > On 18.12.2015 20:08, Luca Barbato wrote: > > On 18/12/15 20:04, Andreas Cadhalpun wrote: > >> This is used to check if the input buffer is larger enough, so if this > >> overflows it can cause a false negative leading to a segment

Re: [FFmpeg-devel] [PATCH] lavfi/scale: add nb_slices debug option

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 05:31:32PM +0100, Clément Bœsch wrote: > On Fri, Dec 18, 2015 at 04:33:18PM +0100, Nicolas George wrote: > > L'octidi 28 frimaire, an CCXXIV, Clement Boesch a écrit : > > > +const int slice_h = FFMAX(1, link->h / scale->nb_slices); > > > +for (i = 0; i < scal

Re: [FFmpeg-devel] [PATCH] nutdec: reject negative sm_size

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 05:22:31PM +0100, Andreas Cadhalpun wrote: > If it is negative, it makes size larger than the size of the packet > buffer, causing invalid writes in avio_read. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/nutdec.c | 5 + > 1 file changed, 5 insertions(+) >

Re: [FFmpeg-devel] [PATCH] nutdec: only copy the header if it exists

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 05:24:09PM +0100, Andreas Cadhalpun wrote: > Fixes runtime error: null pointer passed as argument 2, which is > declared to never be null > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/nutdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM tha

Re: [FFmpeg-devel] [PATCH] avfilter/vf_delogo: change the definition of logo_x2 and logo_y2

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 04:16:38PM +0100, Jean Delvare wrote: > In the code we keep using logo_x2-1 and logo_y2-1 rather than logo_x2 > and logo_y2 themselves. Define them to be what we need instead, to avoid > the repeated subtractions. > > Signed-off-by: Jean Delvare > --- > libavfilter/vf_del

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 04:33:37PM +0100, Matthieu Bouron wrote: > On Fri, Dec 18, 2015 at 3:59 PM, Matthieu Bouron > wrote: > > > From: Matthieu Bouron > > > > --- > > libswscale/arm/swscale_unscaled.c | 52 +++--- > > libswscale/arm/yuv2rgb_neon.S | 77 > >

Re: [FFmpeg-devel] [PATCH 2/2] swscale/arm/yuv2rgb: add ff_yuv420p_to_{argb, rgba, abgr, bgra}_neon_{16, 32}

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 11:44:27AM +0100, Matthieu Bouron wrote: > On Thu, Dec 17, 2015 at 07:47:08PM +0100, Michael Niedermayer wrote: > > On Thu, Dec 17, 2015 at 04:54:31PM +0100, Matthieu Bouron wrote: > > > On Tue, Dec 15, 2015 at 06:22:43PM +0100, Michael Niedermayer wrote: > > > > On Tue, Dec

Re: [FFmpeg-devel] [PATCH 1/1] arm64: fix inverted register order in transpose_4x4H

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 11:27:05AM +0100, Janne Grunau wrote: > Fix related register order issue in ff_h264_idct_add_neon. > > Found-by: zjh8890 <243186...@qq.com> > --- > libavcodec/aarch64/h264idct_neon.S | 4 ++-- > libavcodec/aarch64/neon.S | 4 ++-- > 2 files changed, 4 insertions(+

Re: [FFmpeg-devel] [PATCH 1/1] arm64: fix inverted register order in transpose_4x4H

2015-12-18 Thread Michael Niedermayer
On Fri, Dec 18, 2015 at 11:07:56AM +, Carl Eugen Hoyos wrote: > Janne Grunau jannau.net> writes: > > > Fix related register order issue in ff_h264_idct_add_neon. > > Is there a public sample that allows to reproduce? i dont think this fixes a sample, its more a cosmetic/internal API fix IIU

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Mats Peterson
On 12/18/2015 01:22 PM, Mats Peterson wrote: On 12/18/2015 05:32 AM, Mats Peterson wrote: On 12/18/2015 05:12 AM, Mats Peterson wrote: On 12/18/2015 04:13 AM, Mats Peterson wrote: Samples: https://drive.google.com/open?id=0B3_pEBoLs0faei1Sd1h6SG11QlE Mats The clips are sample clips from Vi

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Mats Peterson
On 12/19/2015 04:01 AM, Mats Peterson wrote: On 12/18/2015 01:22 PM, Mats Peterson wrote: On 12/18/2015 05:32 AM, Mats Peterson wrote: On 12/18/2015 05:12 AM, Mats Peterson wrote: On 12/18/2015 04:13 AM, Mats Peterson wrote: Samples: https://drive.google.com/open?id=0B3_pEBoLs0faei1Sd1h6SG11Q

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Mats Peterson
On 12/19/2015 04:03 AM, Mats Peterson wrote: On 12/19/2015 04:01 AM, Mats Peterson wrote: On 12/18/2015 01:22 PM, Mats Peterson wrote: On 12/18/2015 05:32 AM, Mats Peterson wrote: On 12/18/2015 05:12 AM, Mats Peterson wrote: On 12/18/2015 04:13 AM, Mats Peterson wrote: Samples: https://drive

[FFmpeg-devel] [PATCH 01/12] lavfi/vf_idet: replace round and cast by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is faster and conveys the intent better here. It is safe as long int has at least 32 bits. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_idet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_idet.c b/libavfilter/vf_idet.c index e4fe6cb..60ec23a 10

[FFmpeg-devel] [PATCH 03/12] lavfi/vf_colorlevels: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is more accurate, and is not slower on non-broken libm's. Thus this represents a Pareto improvement. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_colorlevels.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavfilter/vf_colorlevels.c b/libavf

[FFmpeg-devel] [PATCH 00/12] replace round by lrint/llrint

2015-12-18 Thread Ganesh Ajjanagadde
The chief difference between round and lrint/llrint lies in somewhat nuanced semantics: 1. (minor) round inherently returns a double precision value, so this is then implicitly cast to an integer afterwards. Nothing inherently wrong with this, but the implicit cast may be easily missed. 2. l(l)rin

[FFmpeg-devel] [PATCH 02/12] lavfi/vf_colorchannelmixer: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is faster here on -ftree-vectorize with GCC. This is likely simply an artifact of GCC's rather terrible auto-vectorizer, since as per the instruction set manuals cvtsd2si and cvttsd2si (or their vector equivalents) have identical cycle timings. Anyway, regardless of above, lrint is superior

[FFmpeg-devel] [PATCH 05/12] lavfi/vsrc_mandelbrot: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is at least as fast, and is more accurate. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vsrc_mandelbrot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vsrc_mandelbrot.c b/libavfilter/vsrc_mandelbrot.c index 063b7d1..2f6944f 100644 --- a/libavfilter/v

[FFmpeg-devel] [PATCH 06/12] lavf/hlsenc: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
Mainly cosmetic here. Signed-off-by: Ganesh Ajjanagadde --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index adcf7df..f2d7a52 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -430,7 +430,7 @@

[FFmpeg-devel] [PATCH 04/12] lavfi/vf_drawtext: replace round by llrint

2015-12-18 Thread Ganesh Ajjanagadde
llrint is at least as fast, and better accuracy wise. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_drawtext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_drawtext.c b/libavfilter/vf_drawtext.c index fc77be4..d5770ad 100644 --- a/libavfilter/vf_drawt

[FFmpeg-devel] [PATCH 08/12] lavfi/vf_crop: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is at least as fast, and more accurate. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_crop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c index 93a58da..01773fa 100644 --- a/libavfilter/vf_crop.c +++ b/libavfilter/

[FFmpeg-devel] [PATCH 07/12] lavc/libvpxenc: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
Mostly cosmetic here. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/libvpxenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 96b1ac6..585c218 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -4

[FFmpeg-devel] [PATCH 09/12] lavfi/af_dynaudnorm: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is at least as fast, and is more accurate. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/af_dynaudnorm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_dynaudnorm.c b/libavfilter/af_dynaudnorm.c index 5f412f5..6401595 100644 --- a/libavfilter/af_dyna

[FFmpeg-devel] [PATCH 10/12] lavfi/vf_cropdetect: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is at least as fast, and more accurate. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_cropdetect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_cropdetect.c b/libavfilter/vf_cropdetect.c index d456377..4a89875 100644 --- a/libavfilter/vf_cropdet

[FFmpeg-devel] [PATCH 11/12] lavfi/vf_histogram: replace round by lrint

2015-12-18 Thread Ganesh Ajjanagadde
lrint is at least as fast, and more accurate. Signed-off-by: Ganesh Ajjanagadde --- libavfilter/vf_histogram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_histogram.c b/libavfilter/vf_histogram.c index 8e6f531..3f50f12 100644 --- a/libavfilter/vf_histogram.

[FFmpeg-devel] [PATCH 12/12] lavd/pulse_audio_enc: replace lround by lrint

2015-12-18 Thread Ganesh Ajjanagadde
Here it is mostly a cosmetic change, but there might be benefits in that there are no compat hacks for lround, while there are for lrint. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/pulse_audio_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/pulse_audi

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Dave Yeo
On 12/18/15 09:54 AM, Paul B Mahol wrote: On 12/18/15, Mats Peterson wrote: >On 12/18/2015 05:32 AM, Mats Peterson wrote: >>On 12/18/2015 05:12 AM, Mats Peterson wrote: >>>On 12/18/2015 04:13 AM, Mats Peterson wrote: Samples:https://drive.google.com/open?id=0B3_pEBoLs0faei1Sd1h6SG11QlE >

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Mats Peterson
On 12/19/2015 07:20 AM, Dave Yeo wrote: On 12/18/15 09:54 AM, Paul B Mahol wrote: On 12/18/15, Mats Peterson wrote: >On 12/18/2015 05:32 AM, Mats Peterson wrote: >>On 12/18/2015 05:12 AM, Mats Peterson wrote: >>>On 12/18/2015 04:13 AM, Mats Peterson wrote: Samples:https://drive.google.c

Re: [FFmpeg-devel] Vertical bands with RT21 (Intel Real Time Video 2.1) codec

2015-12-18 Thread Mats Peterson
On 12/19/2015 07:52 AM, Mats Peterson wrote: On 12/19/2015 07:20 AM, Dave Yeo wrote: On 12/18/15 09:54 AM, Paul B Mahol wrote: On 12/18/15, Mats Peterson wrote: >On 12/18/2015 05:32 AM, Mats Peterson wrote: >>On 12/18/2015 05:12 AM, Mats Peterson wrote: >>>On 12/18/2015 04:13 AM, Mats Peter