Re: [FFmpeg-devel] [PATCH] x86/vp9: add avx2 subpel MC SIMD for 10/12bpp

2015-09-18 Thread Ronald S. Bultje
Hi, On Sep 18, 2015 3:55 AM, "James Almer" wrote: > > Signed-off-by: James Almer > --- > Unbenched as i lack the hardware to do so. > > libavcodec/x86/vp9dsp_init_16bpp_template.c | 22 ++ > libavcodec/x86/vp9mc_16bpp.asm | 6 ++ > 2 files changed, 28 insert

Re: [FFmpeg-devel] [PATCHv2] avcodec: use HAVE_THREADS header guards to silence -Wunused-function

2015-09-18 Thread wm4
On 17.09.2015 15:07, Ganesh Ajjanagadde wrote: When compiled with --disable-pthreads, e.g http://fate.ffmpeg.org/report.cgi?time=20150917015044&slot=alpha-debian-qemu-gcc-4.7, a bunch of -Wunused-functions are reported. This patch should silence such warnings. Signed-off-by: Ganesh Ajjanagadde

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: use frequency domain windowing

2015-09-18 Thread Muhammad Faiz
On Thu, Sep 17, 2015 at 1:58 AM, Ganesh Ajjanagadde wrote: > Have not checked what the filter is doing, but have a minor comment: > int sign computation - please use FFSIGN. > > the code doesn't extract sign of number, but decide for even index use positive sign and for odd index use negative sig

Re: [FFmpeg-devel] Voting committee

2015-09-18 Thread wm4
On 16.09.2015 07:32, Yayoi Ukai wrote: I also thought that it was wrong that how some of the FFmpeg developer treated/regarded this Outreachy organization. For example, it seemed that Outreachy was regarded more like a source of cheap talented labor to accomplish FFmpeg agenda further rather tha

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread wm4
On 09.09.2015 18:23, Paul B Mahol wrote: On 9/9/15, Carl Eugen Hoyos wrote: Paul B Mahol gmail.com> writes: +av_log(ctx, AV_LOG_INFO, "%s\n", result); Can't this output a subtitle stream as it is currently done for Closed Captions? Imo, this would be helpful even without any formatting

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread Nicolas George
Le jour du Génie, an CCXXIII, wm4 a écrit : > He means the really terrible hack for the movie src filter, which shouldn't > have been done at all. We have verified users who use the feature. If you are not prepared to propose another solution for the same use, then either keep that kind of remark

Re: [FFmpeg-devel] [PATCH] avutil/attributes: add AV_GCC_VERSION_AT_MOST

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 01:04:52AM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > doc/Doxyfile | 1 + > libavutil/arm/bswap.h| 4 ++-- > libavutil/arm/intreadwrite.h | 4 ++-- > libavutil/attributes.h | 2 ++ > libavutil/x86/bswap.h| 8 ---

[FFmpeg-devel] [PATCH] avfilter/vf_chromakey: Add chromakey video filter

2015-09-18 Thread Timo Rothenpieler
--- Changelog | 1 + MAINTAINERS| 1 + doc/filters.texi | 45 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_chromakey.c | 211 +++

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: Add chromakey video filter

2015-09-18 Thread Paul B Mahol
On 9/18/15, Timo Rothenpieler wrote: > --- > Changelog | 1 + > MAINTAINERS| 1 + > doc/filters.texi | 45 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/version.h | 2 +- > libavfilter/vf

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: use frequency domain windowing

2015-09-18 Thread Ganesh Ajjanagadde
On Fri, Sep 18, 2015 at 4:43 AM, Muhammad Faiz wrote: > On Thu, Sep 17, 2015 at 1:58 AM, Ganesh Ajjanagadde > wrote: > >> Have not checked what the filter is doing, but have a minor comment: >> int sign computation - please use FFSIGN. >> >> > the code doesn't extract sign of number, but decide f

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: Add chromakey video filter

2015-09-18 Thread Paul B Mahol
On 9/18/15, Paul B Mahol wrote: > On 9/18/15, Timo Rothenpieler wrote: >> --- >> Changelog | 1 + >> MAINTAINERS| 1 + >> doc/filters.texi | 45 ++ >> libavfilter/Makefile | 1 + >> libavfilter/allfilters.c | 1 + >> libavfilter

[FFmpeg-devel] [PATCHv2] avfilter/vf_chromakey: Add chromakey video filter

2015-09-18 Thread Timo Rothenpieler
--- Changelog | 1 + MAINTAINERS| 1 + doc/filters.texi | 45 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_chromakey.c | 199 +++

Re: [FFmpeg-devel] [PATCHv2] avcodec: use HAVE_THREADS header guards to silence -Wunused-function

2015-09-18 Thread Ganesh Ajjanagadde
On Fri, Sep 18, 2015 at 4:40 AM, wm4 wrote: > On 17.09.2015 15:07, Ganesh Ajjanagadde wrote: >> >> When compiled with --disable-pthreads, e.g >> >> http://fate.ffmpeg.org/report.cgi?time=20150917015044&slot=alpha-debian-qemu-gcc-4.7, >> a bunch of -Wunused-functions are reported. >> This patch sho

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: Add chromakey video filter

2015-09-18 Thread Timo Rothenpieler
Have you explored way how to handle borders? You mean the outmost pixels, where the calculation is slightly inaccurate? Or the greenscreen spilling into the object because of light reflections? The first could be addressed by adjusting the value for the out-of-bounds pixels. The later is ha

Re: [FFmpeg-devel] [PATCH] avformat/hls: remove unused function

2015-09-18 Thread Ganesh Ajjanagadde
On Wed, Sep 16, 2015 at 8:26 PM, Ganesh Ajjanagadde wrote: > Fixes -Wunused-function from > http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/hls.c | 13 - > 1 file changed, 13 deletions(-

Re: [FFmpeg-devel] [PATCHv2] all: do standards compliant absdiff computation

2015-09-18 Thread Ganesh Ajjanagadde
On Wed, Sep 16, 2015 at 2:48 PM, Ganesh Ajjanagadde wrote: > This resolves implementation defined behavior, and also silences > -Wabsolute-value in clang 3.5+. > Moreover, the generated asm is identical to before modulo nop padding. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavcodec/flash

Re: [FFmpeg-devel] [PATCH] avfilter/vf_chromakey: Add chromakey video filter

2015-09-18 Thread Paul B Mahol
On 9/18/15, Timo Rothenpieler wrote: >> >> Have you explored way how to handle borders? > > You mean the outmost pixels, where the calculation is slightly inaccurate? > Or the greenscreen spilling into the object because of light reflections? Yes, the first one. > > The first could be addressed

[FFmpeg-devel] undefined left shift of negative number (clang 3.7+ warnings)

2015-09-18 Thread Ganesh Ajjanagadde
Hi all, Would like to bring to attention the undefined left shift of negative numbers that are found by latest clang 3.7.0 (-Wshift-negative-value). I send this because I have no idea important they are, but clearly they are of the type that interests static analyzers/fuzzers: e5aa6f702130f1afd53c

[FFmpeg-devel] [PATCHv3] avfilter/vf_chromakey: Add chromakey video filter

2015-09-18 Thread Timo Rothenpieler
--- Changelog | 1 + MAINTAINERS| 1 + doc/filters.texi | 45 +++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h | 2 +- libavfilter/vf_chromakey.c | 198 ++

[FFmpeg-devel] [PATCH] avcodec/imgconvert: Support non-planar colorspaces while padding

2015-09-18 Thread Przemysław Sobala
--- libavcodec/imgconvert.c | 99 - 1 file changed, 65 insertions(+), 34 deletions(-) diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c index dc67560..a523bd5 100644 --- a/libavcodec/imgconvert.c +++ b/libavcodec/imgconvert.c @@ -236,54

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread wm4
On 18.09.2015 13:03, Nicolas George wrote: Le jour du Génie, an CCXXIII, wm4 a écrit : He means the really terrible hack for the movie src filter, which shouldn't have been done at all. We have verified users who use the feature. If you are not prepared to propose another solution for the same

Re: [FFmpeg-devel] [PATCH]lavf/mp3dec: Silence a warning if it makes no sense

2015-09-18 Thread wm4
On 16.09.2015 12:16, Carl Eugen Hoyos wrote: Hi! Attached patch silences the following warning: Skipping 0 bytes of junk at 5772990. NACK. It logs the byte position, and also you can know if the ffmpeg version includes this code. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hls: remove unused function

2015-09-18 Thread wm4
On 18.09.2015 15:09, Ganesh Ajjanagadde wrote: On Wed, Sep 16, 2015 at 8:26 PM, Ganesh Ajjanagadde wrote: Fixes -Wunused-function from http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 Signed-off-by: Ganesh Ajjanagadde --- libavformat/hls.c | 13 ---

[FFmpeg-devel] [PATCH] avfilter: slightly improve filters descriptions

2015-09-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/f_reverse.c | 2 +- libavfilter/src_movie.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_reverse.c b/libavfilter/f_reverse.c index 37c25e9..890be54 100644 --- a/libavfilter/f_reverse.c +++ b/libavfilter/f_reverse.

Re: [FFmpeg-devel] [PATCH] avformat/hls: remove unused function

2015-09-18 Thread Ganesh Ajjanagadde
On Fri, Sep 18, 2015 at 11:08 AM, wm4 wrote: > On 18.09.2015 15:09, Ganesh Ajjanagadde wrote: >> >> On Wed, Sep 16, 2015 at 8:26 PM, Ganesh Ajjanagadde >> wrote: >>> >>> Fixes -Wunused-function from >>> >>> http://fate.ffmpeg.org/report.cgi?time=20150820031140&slot=arm64-darwin-clang-apple-5.1 >>

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread Nicolas George
wm4: > Nice snarky, content-free remark. But you know that just because a hack got > "blessed" because it has "verified users", this is not a reason to implement > things in the right way, so that they are also maintainable and orthogonal. Do you intend to propose a patch that implements things "t

Re: [FFmpeg-devel] [PATCH] avfilter: slightly improve filters descriptions

2015-09-18 Thread Nicolas George
Le jour du Génie, an CCXXIII, Paul B Mahol a écrit : > .name = "movie", > -.description = NULL_IF_CONFIG_SMALL("Read from a movie source."), > +.description = NULL_IF_CONFIG_SMALL("Read video from a movie source."), movie can read audio too. Regards, -- Nicolas Georg

Re: [FFmpeg-devel] [PATCH] x86/vp9: add avx2 subpel MC SIMD for 10/12bpp

2015-09-18 Thread James Almer
On 9/18/2015 5:10 AM, Ronald S. Bultje wrote: > Cool, I was hoping that would work but don't have Intel's emulator; thanks > for testing && lgtm. > > Ronald Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo

Re: [FFmpeg-devel] [PATCH] avfilter: slightly improve filters descriptions

2015-09-18 Thread Paul B Mahol
On 9/18/15, Nicolas George wrote: > Le jour du Genie, an CCXXIII, Paul B Mahol a ecrit : >> .name = "movie", >> -.description = NULL_IF_CONFIG_SMALL("Read from a movie source."), >> +.description = NULL_IF_CONFIG_SMALL("Read video from a movie >> source."), > > movie can

Re: [FFmpeg-devel] [PATCH] avfilter: slightly improve filters descriptions

2015-09-18 Thread Nicolas George
Le jour du Génie, an CCXXIII, Paul B Mahol a écrit : > Yes, but that filter is called amovie, this one is called movie. > > I failed to use movie filter with audio only file, please enlight me. movie=${file}:s=v+a The difference between movie and amovie lies only in the default value for the s

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread Paul B Mahol
I'm not interested in this inflammatory conversation, to be hones it should never started. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avutil/attributes: add AV_GCC_VERSION_AT_MOST

2015-09-18 Thread James Almer
On 9/18/2015 8:46 AM, Michael Niedermayer wrote: > On Fri, Sep 18, 2015 at 01:04:52AM -0300, James Almer wrote: >> Signed-off-by: James Almer >> --- >> doc/Doxyfile | 1 + >> libavutil/arm/bswap.h| 4 ++-- >> libavutil/arm/intreadwrite.h | 4 ++-- >> libavutil/attributes.h

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread wm4
On 18.09.2015 17:19, Nicolas George wrote: wm4: Nice snarky, content-free remark. But you know that just because a hack got "blessed" because it has "verified users", this is not a reason to implement things in the right way, so that they are also maintainable and orthogonal. Do you intend to

Re: [FFmpeg-devel] [PATCH] avfilter: slightly improve filters descriptions

2015-09-18 Thread Paul B Mahol
On 9/18/15, Nicolas George wrote: > Le jour du Genie, an CCXXIII, Paul B Mahol a ecrit : >> Yes, but that filter is called amovie, this one is called movie. >> >> I failed to use movie filter with audio only file, please enlight me. > > movie=${file}:s=v+a > > The difference between movie and am

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread Nicolas George
Le jour du Génie, an CCXXIII, wm4 a écrit : > And just for the protocol, yes, I called it a terrible hack, but you agree > that it's an "ugly hack", so I'm not sure what I did wrong here. Read Cyrano: Je me les sers à moi-même avec assez de verve Mais je ne permets pas qu'un autre

Re: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: use frequency domain windowing

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 08:55:51AM -0400, Ganesh Ajjanagadde wrote: > On Fri, Sep 18, 2015 at 4:43 AM, Muhammad Faiz wrote: > > On Thu, Sep 17, 2015 at 1:58 AM, Ganesh Ajjanagadde > > wrote: > > > >> Have not checked what the filter is doing, but have a minor comment: > >> int sign computation -

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-18 Thread James Almer
On 9/15/2015 4:24 AM, Claudio Freire wrote: > This patch refactors the AAC coders to reuse code > between the MIPS port and the regular, portable C code. > There were two main functions that had to use > hand-optimized versions of quantization code: > - search_for_quantizers_twoloop > - codebook_

[FFmpeg-devel] [PATCH][RFC] configure: silence preprocessor noise from dependency generation

2015-09-18 Thread Ganesh Ajjanagadde
Currently, errors are thrown for various macros while building that are completely bogus. They occur during the dependency (.d) generation phase, and have no bearing on the compiled output, since only the stdout is piped into the sed command to generate the .d files. They basically occur as the r

Re: [FFmpeg-devel] [PATCHv2] all: do standards compliant absdiff computation

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 09:10:49AM -0400, Ganesh Ajjanagadde wrote: > On Wed, Sep 16, 2015 at 2:48 PM, Ganesh Ajjanagadde > wrote: > > This resolves implementation defined behavior, and also silences > > -Wabsolute-value in clang 3.5+. > > Moreover, the generated asm is identical to before modulo

[FFmpeg-devel] [PATCH] avformat/rtmpcrypt: fix discarded const warning

2015-09-18 Thread Ganesh Ajjanagadde
This patch silences a -Wdiscarded-qualifiers observed with GCC 5.2. Signed-off-by: Ganesh Ajjanagadde --- libavformat/rtmpcrypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpcrypt.c b/libavformat/rtmpcrypt.c index 2065ec6..447dbc2 100644 --- a/libavformat/

Re: [FFmpeg-devel] [PATCH] avformat/rtmpcrypt: fix discarded const warning

2015-09-18 Thread Nicolas George
Le jour du Génie, an CCXXIII, Ganesh Ajjanagadde a écrit : > This patch silences a -Wdiscarded-qualifiers observed with GCC 5.2. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavformat/rtmpcrypt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I am not sure this is correct: the buffe

Re: [FFmpeg-devel] [PATCH] avformat/rtmpcrypt: fix discarded const warning

2015-09-18 Thread Ganesh Ajjanagadde
On Fri, Sep 18, 2015 at 3:50 PM, Nicolas George wrote: > Le jour du Génie, an CCXXIII, Ganesh Ajjanagadde a écrit : >> This patch silences a -Wdiscarded-qualifiers observed with GCC 5.2. >> >> Signed-off-by: Ganesh Ajjanagadde >> --- >> libavformat/rtmpcrypt.c | 2 +- >> 1 file changed, 1 insert

[FFmpeg-devel] [PATCH] avfilter: add rubberband wrapper

2015-09-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- configure | 5 + libavfilter/Makefile| 1 + libavfilter/af_rubberband.c | 225 libavfilter/allfilters.c| 1 + 4 files changed, 232 insertions(+) create mode 100644 libavfilter/af_rubb

[FFmpeg-devel] [PATCH] libswscale/swscale: fix -Wunused-function

2015-09-18 Thread Ganesh Ajjanagadde
hyscale, hcscale are only used in old filter code, hence place header guard to silence -Wunused-function. Signed-off-by: Ganesh Ajjanagadde --- libswscale/swscale.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index 120bba1..f4aa41b 100644 ---

Re: [FFmpeg-devel] [PATCH] avfilter: add rubberband wrapper

2015-09-18 Thread James Almer
On 9/18/2015 5:22 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure | 5 + > libavfilter/Makefile| 1 + > libavfilter/af_rubberband.c | 225 > > libavfilter/allfilters.c| 1 + > 4 files changed

[FFmpeg-devel] FFMPEG build

2015-09-18 Thread Rajesh Mahalingam
Hi, How to build a single module or file in ffmpeg? currently I am using "make" and it trigger a full build. Thanks, Rajesh.M ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add ocr filter

2015-09-18 Thread Anshul
On September 18, 2015 9:12:46 PM IST, wm4 wrote: >On 18.09.2015 17:19, Nicolas George wrote: >> wm4: >>> Nice snarky, content-free remark. But you know that just because a >hack got >>> "blessed" because it has "verified users", this is not a reason to >implement >>> things in the right way, so th

Re: [FFmpeg-devel] [PATCH] avformat/rtmpcrypt: fix discarded const warning

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 09:50:29PM +0200, Nicolas George wrote: > Le jour du Génie, an CCXXIII, Ganesh Ajjanagadde a écrit : > > This patch silences a -Wdiscarded-qualifiers observed with GCC 5.2. > > > > Signed-off-by: Ganesh Ajjanagadde > > --- > > libavformat/rtmpcrypt.c | 2 +- > > 1 file ch

[FFmpeg-devel] [PATCH] avformat/movenc: suppress -Wstrict-overflow warnings

2015-09-18 Thread Ganesh Ajjanagadde
This patch results in identical behavior of movenc, and suppresses -Wstrict-overflow warnings observed in GCC 5.2. I have manually checked that all usages are safe, and overflow possibility does not exist with this expression rewrite. Signed-off-by: Ganesh Ajjanagadde --- libavformat/movenc.c |

Re: [FFmpeg-devel] [PATCH] AAC encoder: refactor to resynchronize MIPS port

2015-09-18 Thread Claudio Freire
On Fri, Sep 18, 2015 at 3:10 PM, James Almer wrote: > On 9/15/2015 4:24 AM, Claudio Freire wrote: >> This patch refactors the AAC coders to reuse code >> between the MIPS port and the regular, portable C code. >> There were two main functions that had to use >> hand-optimized versions of quantizat

Re: [FFmpeg-devel] [PATCH] avcodec/ac3enc: use long long after switch to 64 bit bitrate

2015-09-18 Thread James Almer
On 9/17/2015 9:46 AM, Ganesh Ajjanagadde wrote: > Commit 7404f3bdb switched bitrate to 64 bits. > This triggers -Wabsolute-value on clang, e.g > http://fate.ffmpeg.org/log.cgi?time=20150917122742&log=compile&slot=x86_64-darwin-clang-3.7-O3. > Therefore, usage of abs is changed to llabs, which is av

[FFmpeg-devel] [PATCH] avcodec/xface: suppress -Wstrict-overflow warnings

2015-09-18 Thread Ganesh Ajjanagadde
This patch results in identical behavior of xface, and suppresses -Wstrict-overflow warnings observed in GCC 5.2. I have manually checked that this usage is safe, and overflow possibility does not exist with this expression rewrite. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/xface.c | 2 +

Re: [FFmpeg-devel] [PATCH] avcodec/ac3enc: use long long after switch to 64 bit bitrate

2015-09-18 Thread Ganesh Ajjanagadde
On Fri, Sep 18, 2015 at 5:30 PM, James Almer wrote: > On 9/17/2015 9:46 AM, Ganesh Ajjanagadde wrote: >> Commit 7404f3bdb switched bitrate to 64 bits. >> This triggers -Wabsolute-value on clang, e.g >> http://fate.ffmpeg.org/log.cgi?time=20150917122742&log=compile&slot=x86_64-darwin-clang-3.7-O3.

Re: [FFmpeg-devel] [PATCH] libswscale/swscale: fix -Wunused-function

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 04:35:33PM -0400, Ganesh Ajjanagadde wrote: > hyscale, hcscale are only used in old filter code, hence place > header guard to silence -Wunused-function. > > Signed-off-by: Ganesh Ajjanagadde > --- > libswscale/swscale.c | 2 ++ > 1 file changed, 2 insertions(+) applied

Re: [FFmpeg-devel] [PATCH] avcodec/ac3enc: use long long after switch to 64 bit bitrate

2015-09-18 Thread James Almer
On 9/18/2015 6:35 PM, Ganesh Ajjanagadde wrote: > On Fri, Sep 18, 2015 at 5:30 PM, James Almer wrote: >> On 9/17/2015 9:46 AM, Ganesh Ajjanagadde wrote: >>> Commit 7404f3bdb switched bitrate to 64 bits. >>> This triggers -Wabsolute-value on clang, e.g >>> http://fate.ffmpeg.org/log.cgi?time=201509

[FFmpeg-devel] [PATCH 1/2] avcodec/vda_h264: use multichar literal portably

2015-09-18 Thread Ganesh Ajjanagadde
Multichar literals are implementation defined, and thus trigger -Wmultichar: http://fate.ffmpeg.org/log.cgi?time=20150918202532&log=compile&slot=x86_64-darwin-gcc-5. http://www.zipcon.net/~swhite/docs/computers/languages/c_multi-char_const.html gives a good summary of how to deal with them; in part

[FFmpeg-devel] [PATCH 2/2] avcodec/vda_h264_dec: use multichar literal portably

2015-09-18 Thread Ganesh Ajjanagadde
Multichar literals are implementation defined, and thus trigger -Wmultichar: http://fate.ffmpeg.org/log.cgi?time=20150918202532&log=compile&slot=x86_64-darwin-gcc-5. http://www.zipcon.net/~swhite/docs/computers/languages/c_multi-char_const.html gives a good summary of how to deal with them; in part

[FFmpeg-devel] [PATCH] avdevice/xcbgrab: fix -Wunused-variable

2015-09-18 Thread Ganesh Ajjanagadde
This patch fixes a -Wunused-variable reported in e.g http://fate.ffmpeg.org/log.cgi?time=20150918194649&log=compile&slot=x86_64-debian-asan-144800. av_unused is used as opposed to a header guard for readability. Signed-off-by: Ganesh Ajjanagadde --- libavdevice/xcbgrab.c | 2 +- 1 file changed,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vda_h264: use multichar literal portably

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 06:16:18PM -0400, Ganesh Ajjanagadde wrote: > Multichar literals are implementation defined, and thus trigger -Wmultichar: > http://fate.ffmpeg.org/log.cgi?time=20150918202532&log=compile&slot=x86_64-darwin-gcc-5. > http://www.zipcon.net/~swhite/docs/computers/languages/c_mu

[FFmpeg-devel] [PATCHv2 1/2] avcodec/vda_h264: use multichar literal portably

2015-09-18 Thread Ganesh Ajjanagadde
Multichar literals are implementation defined, and thus trigger -Wmultichar: http://fate.ffmpeg.org/log.cgi?time=20150918202532&log=compile&slot=x86_64-darwin-gcc-5. This patch replaces them with AV_RB32. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/vda_h264.c | 2 +- 1 file changed, 1 inser

[FFmpeg-devel] [PATCHv2 2/2] avcodec/vda_h264_dec: use multichar literal portably

2015-09-18 Thread Ganesh Ajjanagadde
Multichar literals are implementation defined, and thus trigger -Wmultichar: http://fate.ffmpeg.org/log.cgi?time=20150918202532&log=compile&slot=x86_64-darwin-gcc-5. This patch uses AV_RB32 to silence such warnings. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/vda_h264_dec.c | 10 +-

Re: [FFmpeg-devel] [PATCHv2 2/2] avcodec/vda_h264_dec: use multichar literal portably

2015-09-18 Thread Ganesh Ajjanagadde
On Fri, Sep 18, 2015 at 7:28 PM, Ganesh Ajjanagadde wrote: > Multichar literals are implementation defined, and thus trigger -Wmultichar: > http://fate.ffmpeg.org/log.cgi?time=20150918202532&log=compile&slot=x86_64-darwin-gcc-5. > This patch uses AV_RB32 to silence such warnings. > > Signed-off-by

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: fix -Wunused-variable

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 06:17:42PM -0400, Ganesh Ajjanagadde wrote: > This patch fixes a -Wunused-variable reported in e.g > http://fate.ffmpeg.org/log.cgi?time=20150918194649&log=compile&slot=x86_64-debian-asan-144800. > av_unused is used as opposed to a header guard for readability. applied tha

Re: [FFmpeg-devel] [PATCH] avcodec/imgconvert: Support non-planar colorspaces while padding

2015-09-18 Thread Michael Niedermayer
On Fri, Sep 18, 2015 at 04:31:16PM +0200, Przemysław Sobala wrote: > --- > libavcodec/imgconvert.c | 99 > - > 1 file changed, 65 insertions(+), 34 deletions(-) > > diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c > index dc67560..a52

[FFmpeg-devel] [PATCH] avcodec/indeo3data: fix undefined left shift of negative number

2015-09-18 Thread Ganesh Ajjanagadde
This fixes a whole sea of -Wshift-negative-value reported with clang 3.7+, e.g http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. Any half decent compiler should anyway optimize away the multiplication. Signed-off-by: Ganesh Ajjan

[FFmpeg-devel] [PATCH] avcodec/internal: silence -Wempty-body on clang

2015-09-18 Thread Ganesh Ajjanagadde
This silences a -Wempty-body warning on clang 3.7+, e.g http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[FFmpeg-devel] [PATCH] avcodec/g723_1: fix a undefined left shift of negative number

2015-09-18 Thread Ganesh Ajjanagadde
This fixes a -Wshift-negative-value reported with clang 3.7+, e.g http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/g723_1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCH 1/2] avutil/attributes: extend av_uninit to clang

2015-09-18 Thread Ganesh Ajjanagadde
Commit 6dac8c8327 disabled av_uninit for clang, due to some useless warnings. The concept of av_uninit is inherently useful though. This patch silences a bunch of warnings on clang e.g http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-

[FFmpeg-devel] [PATCH 2/2] avcodec/dcadec: fix a -Wsometimes-unitialized on clang

2015-09-18 Thread Ganesh Ajjanagadde
This fixes a genuine -Wsometimes-unitialized reported on clang, e.g http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/dcadec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [FFmpeg-devel] [PATCH] avcodec/indeo3data: fix undefined left shift of negative number

2015-09-18 Thread James Almer
On 9/19/2015 1:53 AM, Ganesh Ajjanagadde wrote: > This fixes a whole sea of -Wshift-negative-value reported with clang 3.7+, e.g > http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. > Any half decent compiler should anyway optimize

[FFmpeg-devel] [PATCH] avcodec/mlpdec: fix a undefined left shift of negative number

2015-09-18 Thread Ganesh Ajjanagadde
This fixes a -Wshift-negative-value reported with clang 3.7+, e.g http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. Signed-off-by: Ganesh Ajjanagadde --- libavcodec/mlpdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[FFmpeg-devel] [PATCHv2] avcodec/indeo3data: fix undefined left shift of negative number

2015-09-18 Thread Ganesh Ajjanagadde
This fixes a whole sea of -Wshift-negative-value reported with clang 3.7+, e.g http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. Any half decent compiler should anyway optimize away the multiplication. Signed-off-by: Ganesh Ajjan

Re: [FFmpeg-devel] [PATCH] avcodec/indeo3data: fix undefined left shift of negative number

2015-09-18 Thread Ganesh Ajjanagadde
On Sat, Sep 19, 2015 at 1:02 AM, James Almer wrote: > On 9/19/2015 1:53 AM, Ganesh Ajjanagadde wrote: >> This fixes a whole sea of -Wshift-negative-value reported with clang 3.7+, >> e.g >> http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-str

Re: [FFmpeg-devel] [PATCHv2] avcodec/indeo3data: fix undefined left shift of negative number

2015-09-18 Thread James Almer
On 9/19/2015 2:21 AM, Ganesh Ajjanagadde wrote: > This fixes a whole sea of -Wshift-negative-value reported with clang 3.7+, e.g > http://fate.ffmpeg.org/log.cgi?time=20150918181527&log=compile&slot=x86_64-darwin-clang-polly-vectorize-stripmine-3.7. > Any half decent compiler should anyway optimize

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vda_h264: use multichar literal portably

2015-09-18 Thread Hendrik Leppkes
On Sat, Sep 19, 2015 at 12:35 AM, Michael Niedermayer wrote: > On Fri, Sep 18, 2015 at 06:16:18PM -0400, Ganesh Ajjanagadde wrote: >> Multichar literals are implementation defined, and thus trigger -Wmultichar: >> http://fate.ffmpeg.org/log.cgi?time=20150918202532&log=compile&slot=x86_64-darwin-gc