Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Detect jpeg2000 through codec_ul too

2015-06-15 Thread tim nicholson
On 12/06/15 18:05, Michael Niedermayer wrote: > Fixes Ticket2345 > > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfdec.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > index 78e2393..7389555 100644 > --- a/liba

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-15 Thread Stefano Sabatini
On date Saturday 2015-06-13 14:20:07 +0200, Hendrik Leppkes encoded: > On Thu, Jun 11, 2015 at 8:54 PM, wm4 wrote: > > On Thu, 11 Jun 2015 17:24:45 +0200 > > Stefano Sabatini wrote: > > > >> Next step would be the use of YASM, but I only want to test if the > >> general approach is fine (and if t

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: check frame properties for consistency before copying

2015-06-15 Thread Vittorio Giovara
On Sun, Jun 14, 2015 at 11:40 AM, Andreas Cadhalpun wrote: > Also use the frame pixel format instead of the one from the codec > context, which is more robust. Does this fix anything in particular or is just as precaution? > Signed-off-by: Andreas Cadhalpun > --- > libavcodec/h264_slice.c | 6

[FFmpeg-devel] [PATCH] avformat/mxfdec: Change version byte for JPEG2000 to match mxf.c and RP224v12

2015-06-15 Thread Michael Niedermayer
This should make no difference as the byte is ignored Found-by: tim nicholson Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 7389555..b3c25b7 100644 --- a/libavf

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Detect jpeg2000 through codec_ul too

2015-06-15 Thread Michael Niedermayer
On Mon, Jun 15, 2015 at 09:57:17AM +0100, tim nicholson wrote: > On 12/06/15 18:05, Michael Niedermayer wrote: > > > Fixes Ticket2345 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/mxfdec.c | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/libav

[FFmpeg-devel] [GSOC][Outreachy] midterm evaluations 2015

2015-06-15 Thread Michael Niedermayer
Hi everyone in june (26th) there will be midterm evaluations in GSoC and similarly a few days later in Outreachy That means your mentor must decide if you pass or not then To pass midterm evaluations, make sure you show some activity, submit patches well before the deadline. also independant of t

Re: [FFmpeg-devel] [RFC] DXVA2 decoding and FFmpeg

2015-06-15 Thread Stefano Sabatini
On date Monday 2015-06-15 11:56:13 +0200, Stefano Sabatini encoded: [...] > From 3a75ef1e86360cd6f30b8e550307404d0d1c1dba Mon Sep 17 00:00:00 2001 > From: Stefano Sabatini > Date: Mon, 15 Jun 2015 11:02:50 +0200 > Subject: [PATCH] lavu/mem: add av_memcpynt() function with x86 optimizations > > As

Re: [FFmpeg-devel] [PATCH] doc: avoid incorrect phrase 'allows to'

2015-06-15 Thread Andreas Cadhalpun
On 14.06.2015 23:32, Lou Logan wrote: > On Sun, Jun 14, 2015, at 10:49 AM, Andreas Cadhalpun wrote: >> --- a/libavcodec/ppc/me_cmp.c >> +++ b/libavcodec/ppc/me_cmp.c >> @@ -504,7 +504,7 @@ static int hadamard8_diff8x8_altivec(MpegEncContext >> *s, uint8_t *dst, >> } >> >> /* >> - * 16x8 works w

Re: [FFmpeg-devel] [libav-devel] [PATCH] h264: check frame properties for consistency before copying

2015-06-15 Thread Andreas Cadhalpun
On 15.06.2015 12:57, Vittorio Giovara wrote: > On Sun, Jun 14, 2015 at 11:40 AM, Andreas Cadhalpun > wrote: >> Also use the frame pixel format instead of the one from the codec >> context, which is more robust. > > Does this fix anything in particular or is just as precaution? This fixes SIGABRT

Re: [FFmpeg-devel] [PATCH] examples/demuxing_decoding: use properties from frame instead of video_dec_ctx

2015-06-15 Thread Andreas Cadhalpun
On 15.06.2015 04:43, Michael Niedermayer wrote: > On Sun, Jun 14, 2015 at 08:40:50PM +0200, Andreas Cadhalpun wrote: >> This is more robust. >> >> And only check if there is actually a frame returned. > > LGTM Pushed. Best regards, Andreas ___ ffmpeg-

Re: [FFmpeg-devel] [PATCH] h264: check frame properties for consistency before copying

2015-06-15 Thread Andreas Cadhalpun
On 15.06.2015 03:54, Michael Niedermayer wrote: > On Sun, Jun 14, 2015 at 12:40:18PM +0200, Andreas Cadhalpun wrote: >> Also use the frame pixel format instead of the one from the codec >> context, which is more robust. > > the checks cant hurt ... > LGTM Pushed. Best regards, Andreas _

Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: add couple of more curves

2015-06-15 Thread Michael Niedermayer
On Sun, Jun 14, 2015 at 08:26:42PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 12 +++- > libavfilter/af_afade.c | 30 +- > 2 files changed, 36 insertions(+), 6 deletions(-) LGTM thanks [...] -- Michael GnuP

[FFmpeg-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2015-06-15 Thread Andreas Cadhalpun
The values are written with avio_wl16 and if they don't fit into uint16_t, this triggers an av_assert2 in avio_w8. Signed-off-by: Andreas Cadhalpun --- libavformat/matroskadec.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c inde

[FFmpeg-devel] [PATCH 1/2] matroskadec: check audio sample rate

2015-06-15 Thread Andreas Cadhalpun
And default to 8000 if it is invalid. An invalid sample rate can trigger av_assert2 in av_rescale_rnd. Signed-off-by: Andreas Cadhalpun --- libavformat/matroskadec.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 3512f0f..

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: added HLS encryption

2015-06-15 Thread Dan Dennedy
On Wed, Feb 11, 2015 at 12:20 PM Michael Niedermayer wrote: > > please provide a example which works > this is not an example its a description of how to create an example > I mean example in the sense that its bytes when given to the right > program like /bin/sh will do something not a descripti

[FFmpeg-devel] [PATCH] avformat/qcp: s/unsigned int/uint32_t

2015-06-15 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavformat/qcp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/qcp.c b/libavformat/qcp.c index 9e2eedf..e2fd5ff 100644 --- a/libavformat/qcp.c +++ b/libavformat/qcp.c @@ -139,7 +139,7 @@ static int qcp_read_packet(AVFormatContext

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2015-06-15 Thread Hendrik Leppkes
On Mon, Jun 15, 2015 at 9:17 PM, Andreas Cadhalpun wrote: > The values are written with avio_wl16 and if they don't fit into > uint16_t, this triggers an av_assert2 in avio_w8. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/matroskadec.c | 8 > 1 file changed, 8 insertions(+)

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2015-06-15 Thread Andreas Cadhalpun
On 15.06.2015 21:46, Luca Barbato wrote: > On 15/06/15 21:17, Andreas Cadhalpun wrote: >> The values are written with avio_wl16 and if they don't fit into >> uint16_t, this triggers an av_assert2 in avio_w8. > > No does not. As with the other patch. Feel free to suggest different problem descript

Re: [FFmpeg-devel] [PATCH] avformat/qcp: s/unsigned int/uint32_t

2015-06-15 Thread Ronald S. Bultje
Hi, On Mon, Jun 15, 2015 at 12:38 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/qcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/qcp.c b/libavformat/qcp.c > index 9e2eedf..e2fd5ff 100644 > --- a/libavformat/qcp.c > +++ b/lib

Re: [FFmpeg-devel] [PATCH] avformat/qcp: s/unsigned int/uint32_t

2015-06-15 Thread Michael Niedermayer
On Mon, Jun 15, 2015 at 07:38:28PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/qcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The greatest way to live

Re: [FFmpeg-devel] [libav-devel] [PATCH 1/2] matroskadec: check audio sample rate

2015-06-15 Thread Andreas Cadhalpun
On 15.06.2015 21:42, Luca Barbato wrote: > On 15/06/15 21:17, Andreas Cadhalpun wrote: >> And default to 8000 if it is invalid. >> >> An invalid sample rate can trigger av_assert2 in av_rescale_rnd. > > No, it cannot. That depends. >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/matr

Re: [FFmpeg-devel] [PATCH] swresample: make swr_get_out_samples() work with all resamplers

2015-06-15 Thread Michael Niedermayer
On Thu, Jun 04, 2015 at 07:19:25PM +0200, wm4 wrote: > Making it fail if e.g. soxr is used makes the function completely > useless. > --- > libswresample/swresample.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) this together with the other commit results in an insufficent n

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2015-06-15 Thread Andreas Cadhalpun
On 15.06.2015 21:40, Hendrik Leppkes wrote: > On Mon, Jun 15, 2015 at 9:17 PM, Andreas Cadhalpun > wrote: >> The values are written with avio_wl16 and if they don't fit into >> uint16_t, this triggers an av_assert2 in avio_w8. >> >> Signed-off-by: Andreas Cadhalpun >> --- >> libavformat/matroska

Re: [FFmpeg-devel] [PATCH 1/2] matroskadec: check audio sample rate

2015-06-15 Thread Michael Niedermayer
On Mon, Jun 15, 2015 at 09:17:36PM +0200, Andreas Cadhalpun wrote: > And default to 8000 if it is invalid. > > An invalid sample rate can trigger av_assert2 in av_rescale_rnd. > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/matroskadec.c | 8 > 1 file changed, 8 insertions(+)

Re: [FFmpeg-devel] [PATCH] avformat/qcp: s/unsigned int/uint32_t

2015-06-15 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 01:59:22AM +0200, Michael Niedermayer wrote: > On Mon, Jun 15, 2015 at 07:38:28PM +, Paul B Mahol wrote: > > Signed-off-by: Paul B Mahol > > --- > > libavformat/qcp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > LGTM didnt see ronalds reply as it was

Re: [FFmpeg-devel] [PATCH] configure: make makeinfo_html check more robust

2015-06-15 Thread Timothy Gu
On Sun, Jun 14, 2015 at 2:32 AM Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > The current check is too strict for newer makeinfo versions. > Existing version strings are: > makeinfo (GNU texinfo) 4.13 > makeinfo (GNU texinfo) 5.2 > texi2any (GNU texinfo) 5.9.93 > > Probably versio

Re: [FFmpeg-devel] [libav-devel] [PATCH 2/2] matroskadec: validate audio channels and bitdepth

2015-06-15 Thread Michael Niedermayer
On Tue, Jun 16, 2015 at 12:09:37AM +0200, Andreas Cadhalpun wrote: > On 15.06.2015 21:40, Hendrik Leppkes wrote: > > On Mon, Jun 15, 2015 at 9:17 PM, Andreas Cadhalpun > > wrote: > >> The values are written with avio_wl16 and if they don't fit into > >> uint16_t, this triggers an av_assert2 in avi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: added HLS encryption

2015-06-15 Thread Michael Niedermayer
On Mon, Jun 15, 2015 at 12:18:51PM -0700, Dan Dennedy wrote: > On Wed, Feb 11, 2015 at 12:20 PM Michael Niedermayer > wrote: > > > > > please provide a example which works > > this is not an example its a description of how to create an example > > I mean example in the sense that its bytes when

Re: [FFmpeg-devel] [PATCH] doc: avoid incorrect phrase 'allows to'

2015-06-15 Thread Lou Logan
On Mon, Jun 15, 2015, at 08:24 AM, Andreas Cadhalpun wrote: > > OK, I reworded the changes in avformat.h. New patch attached. Patch looks good to me. Thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-

[FFmpeg-devel] [PATCH] doc/muxers.texi: properly insert {}s in example

2015-06-15 Thread James Zern
use '@{' / '@}', fixes compile errors: *** '{' without macro. Before: 1:-'.'} *** '}' without opening '{' before: since: 907ac20 avformat/hlsenc: added HLS encryption Signed-off-by: James Zern --- doc/muxers.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/muxers.tex

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: Change version byte for JPEG2000 to match mxf.c and RP224v12

2015-06-15 Thread tim nicholson
On 15/06/15 13:13, Michael Niedermayer wrote: > This should make no difference as the byte is ignored > > Found-by: tim nicholson > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfdec.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/mxfdec.c b

Re: [FFmpeg-devel] [PATCH] avformat/qcp: s/unsigned int/uint32_t

2015-06-15 Thread Paul B Mahol
Dana 16. 6. 2015. 02:30 osoba "Ronald S. Bultje" napisala je: > > Hi, > > On Mon, Jun 15, 2015 at 12:38 PM, Paul B Mahol wrote: > > > Signed-off-by: Paul B Mahol > > --- > > libavformat/qcp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/qcp.c b/liba