[FFmpeg-devel] [PATCH] lavfi: drop mp=eq and mp=eq2

2015-01-26 Thread Stefano Sabatini
mp=eq2 was ported to a native libavfilter filter in commit 4c38e960d0ca81b78dec1589275a5274dde21c8e. --- doc/filters.texi | 12 - libavfilter/Makefile | 2 - libavfilter/libmpcodecs/vf_eq.c | 240 -- libavfilter/libmpcodecs/vf_eq2.c | 519 ---

Re: [FFmpeg-devel] dshow crossbar support PATCH es

2015-01-26 Thread Roger Pack
On 1/23/15, Michael Niedermayer wrote: > On Fri, Jan 23, 2015 at 07:06:39AM -0700, Roger Pack wrote: >> OK I have made modifications to the dshow source so that it adds the >> ability to specify capture device by "more unique" name, capture pin >> by name, crossbar device support [this is basicall

Re: [FFmpeg-devel] [PATCH] lavfi: drop mp=eq and mp=eq2

2015-01-26 Thread Paul B Mahol
On 1/26/15, Stefano Sabatini wrote: > mp=eq2 was ported to a native libavfilter filter in commit > 4c38e960d0ca81b78dec1589275a5274dde21c8e. > --- > doc/filters.texi | 12 - > libavfilter/Makefile | 2 - > libavfilter/libmpcodecs/vf_eq.c | 240 -- >

Re: [FFmpeg-devel] [PATCH] lavfi: drop mp=eq and mp=eq2

2015-01-26 Thread Stefano Sabatini
On date Monday 2015-01-26 09:43:46 +, Paul B Mahol encoded: > On 1/26/15, Stefano Sabatini wrote: > > mp=eq2 was ported to a native libavfilter filter in commit > > 4c38e960d0ca81b78dec1589275a5274dde21c8e. > > --- > > doc/filters.texi | 12 - > > libavfilter/Makefile

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread Christophe Gisquet
Hi, so my comments are not aimed at that specific patch at all, but when looking at: 2015-01-24 22:06 GMT+01:00 Paul B Mahol : > +static void process_c(EQParameters *param, uint8_t *dst, int dst_stride, > + uint8_t *src, int src_stride, int w, int h) > +{ > +int x, y, pel

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread wm4
On Mon, 26 Jan 2015 11:31:49 +0100 Christophe Gisquet wrote: > Hi, > > so my comments are not aimed at that specific patch at all, but when looking > at: > > 2015-01-24 22:06 GMT+01:00 Paul B Mahol : > > +static void process_c(EQParameters *param, uint8_t *dst, int dst_stride, > > +

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread Christophe Gisquet
Hi, 2015-01-26 12:33 GMT+01:00 wm4 : > But it's faster! I'm not trying to bash nor troll anyone here, or to debate whether the filter and/or the asm should go, so please don't drag me into that particular crusade. I'd just like the filter and/or the asm to be fixed. And as I'

Re: [FFmpeg-devel] [PATCH] Port mp=eq/eq2 to lavfi

2015-01-26 Thread Michael Niedermayer
On Mon, Jan 26, 2015 at 11:31:49AM +0100, Christophe Gisquet wrote: > Hi, > > so my comments are not aimed at that specific patch at all, but when looking > at: > > 2015-01-24 22:06 GMT+01:00 Paul B Mahol : > > +static void process_c(EQParameters *param, uint8_t *dst, int dst_stride, > > +

[FFmpeg-devel] [PATCH 2/2] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-26 Thread timo
From: Timo Rothenpieler --- libavcodec/nvenc.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 2431c09..2cfc06a 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -472,6 +472,7 @@ static av_cold int nve

[FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Fix b-frame parameter handling

2015-01-26 Thread timo
From: Timo Rothenpieler --- libavcodec/nvenc.c | 28 +++- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c index 16ef93f..2431c09 100644 --- a/libavcodec/nvenc.c +++ b/libavcodec/nvenc.c @@ -157,7 +157,6 @@ typedef st

Re: [FFmpeg-devel] [PATCH] tools/crypto_bench: add Camellia support

2015-01-26 Thread Nicolas George
Le sextidi 6 pluviôse, an CCXXIII, James Almer a écrit : > Signed-off-by: James Almer > --- > tools/crypto_bench.c | 47 +++ > 1 file changed, 47 insertions(+) Looks ok to me. Regards, -- Nicolas George signature.asc Description: Digital signatu

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Fix b-frame parameter handling

2015-01-26 Thread Timo Rothenpieler
This should behave similar to x264 and other encoders, as it handles a gop_size of 0 as Intra-Only, while it's still possible to control how many B-Frames it inserts. signature.asc Description: OpenPGP digital signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-26 Thread Timo Rothenpieler
This is still not 100% correct, because of the weird behaviour on certain DVD resolutions and aspect ratios. But fixing that will be done in a diffrent patch, if it will be fixed in ffmpeg at all. For now, this makes it behave correctly in most cases. signature.asc Description: OpenPGP digita

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/nvenc: Handle non-square pixel aspect ratios

2015-01-26 Thread Timo Rothenpieler
This is still not 100% correct, because of the weird behaviour on certain DVD resolutions and aspect ratios. But fixing that will be done in a diffrent patch, if it will be fixed in ffmpeg at all. For now, this makes it behave correctly in most cases. signature.asc Description: OpenPGP digita

Re: [FFmpeg-devel] [PATCH] tests/fate: added mxf tests for essencegroups and missing index

2015-01-26 Thread Michael Niedermayer
On Sun, Jan 25, 2015 at 04:38:00PM -0800, Mark Reid wrote: > hi, > This patch addes 2 mxf tests for formats that I've been working > on. Opatom mxf files with missing index segments and ones with essence groups. > > the 2 fate can be downloaded here: > > https://dl.dropboxusercontent.com/u/17095

[FFmpeg-devel] [PATCH] avfitler/vf_fieldmatch: fix typo

2015-01-26 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/vf_fieldmatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_fieldmatch.c b/libavfilter/vf_fieldmatch.c index e2aa60b..358bd9e 100644 --- a/libavfilter/vf_fieldmatch.c +++ b/libavfilter/vf_fieldmatch.c @@ -21,7 +21,

Re: [FFmpeg-devel] [PATCH] avfitler/vf_fieldmatch: fix typo

2015-01-26 Thread Clément Bœsch
On Mon, Jan 26, 2015 at 01:06:18PM +, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_fieldmatch.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_fieldmatch.c b/libavfilter/vf_fieldmatch.c > index e2aa60b..358bd9e 100644 > ---

Re: [FFmpeg-devel] dshow crossbar support PATCH es

2015-01-26 Thread Michael Niedermayer
On Mon, Jan 26, 2015 at 02:38:33AM -0700, Roger Pack wrote: > On 1/23/15, Michael Niedermayer wrote: > > On Fri, Jan 23, 2015 at 07:06:39AM -0700, Roger Pack wrote: > >> OK I have made modifications to the dshow source so that it adds the > >> ability to specify capture device by "more unique" nam

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/nvenc: Fix b-frame parameter handling

2015-01-26 Thread Michael Niedermayer
On Mon, Jan 26, 2015 at 01:28:21PM +0100, t...@rothenpieler.org wrote: > From: Timo Rothenpieler > > --- > libavcodec/nvenc.c | 28 +++- > 1 file changed, 15 insertions(+), 13 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133

Re: [FFmpeg-devel] [PATCH] tools/crypto_bench: add Camellia support

2015-01-26 Thread James Almer
On 26/01/15 9:29 AM, Nicolas George wrote: > Le sextidi 6 pluviôse, an CCXXIII, James Almer a écrit : >> Signed-off-by: James Almer >> --- >> tools/crypto_bench.c | 47 +++ >> 1 file changed, 47 insertions(+) > > Looks ok to me. > > Regards, Pushed,

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: remove mp=softpulldown

2015-01-26 Thread Paul B Mahol
On 5/5/13, Paul B Mahol wrote: > On 5/4/13, Ivan Kalvachev wrote: >> On 4/29/13, Paul B Mahol wrote: >>> The filter funcionality is same as interlace/tinterlace. >>> Required flag: MP_IMGFIELD_REPEAT_FIRST is never set, >>> and can not be set as its not exported from lavf/lavc. >> >> That flag i

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg_dxva2: add hevc support

2015-01-26 Thread compn
On Sun, 25 Jan 2015 13:01:12 +0100 Hendrik Leppkes wrote: > --- > ffmpeg_dxva2.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) lgtm -compn ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ff

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: remove mp=softpulldown

2015-01-26 Thread compn
On Mon, 26 Jan 2015 17:06:55 + Paul B Mahol wrote: > On 5/5/13, Paul B Mahol wrote: > I will remove this filter and libmpcodecs with it in next 24 hours. OK with me. thanks to all who ported filters and trolled for the 4 years we had mplayer code in ffmpeg :) -compn _

[FFmpeg-devel] [PATCH] Support BMP files that do not properly align lines.

2015-01-26 Thread Reimar Döffinger
Quite a few programs missed that detail of the spec (including old versions of FFmpeg I believe) and when we would otherwise fail anyway it seems worth a try to us a simple byte-aligned stride instead. Signed-off-by: Reimar Döffinger --- libavcodec/bmp.c | 10 +++--- 1 file changed, 7 insert

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Michael Niedermayer
On Wed, Jan 21, 2015 at 11:14:06PM +0100, Andreas Cadhalpun wrote: > Hi, > > ar and ranlib add timestamp and uid/gid for the object files in > static libraries. > If used in deterministic mode, these are set to zero, making the > binaries reproducible. > Attached patch achieves that. > > Best reg

Re: [FFmpeg-devel] [PATCH] Support BMP files that do not properly align lines.

2015-01-26 Thread Michael Niedermayer
On Mon, Jan 26, 2015 at 08:21:16PM +0100, Reimar Döffinger wrote: > Quite a few programs missed that detail of the spec > (including old versions of FFmpeg I believe) and when > we would otherwise fail anyway it seems worth a try > to us a simple byte-aligned stride instead. > > Signed-off-by: Rei

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-26 Thread Giorgio Vazzana
Hi, 2015-01-25 20:00 GMT+01:00 supraja reddy : > Sorry. I forgot to make a small change. Updated the patch. > +for (i = 0; i < cs->ksize; i++) { > +Me[i] = Key[2 * i]; > +Mo[i] = Key[2 * i + 1]; > +} > +for (i = 0; i < cs->ksize; i++) > +cs->S[cs->ksize - i - 1

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Michael Niedermayer
On Mon, Jan 26, 2015 at 09:56:03PM +0100, Michael Niedermayer wrote: > On Wed, Jan 21, 2015 at 11:14:06PM +0100, Andreas Cadhalpun wrote: > > Hi, > > > > ar and ranlib add timestamp and uid/gid for the object files in > > static libraries. > > If used in deterministic mode, these are set to zero,

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread James Almer
On 26/01/15 7:04 PM, Michael Niedermayer wrote: > On Mon, Jan 26, 2015 at 09:56:03PM +0100, Michael Niedermayer wrote: >> On Wed, Jan 21, 2015 at 11:14:06PM +0100, Andreas Cadhalpun wrote: >>> Hi, >>> >>> ar and ranlib add timestamp and uid/gid for the object files in >>> static libraries. >>> If u

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Michael Niedermayer
On Mon, Jan 26, 2015 at 07:08:42PM -0300, James Almer wrote: > On 26/01/15 7:04 PM, Michael Niedermayer wrote: > > On Mon, Jan 26, 2015 at 09:56:03PM +0100, Michael Niedermayer wrote: > >> On Wed, Jan 21, 2015 at 11:14:06PM +0100, Andreas Cadhalpun wrote: > >>> Hi, > >>> > >>> ar and ranlib add tim

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Andreas Cadhalpun
Hi, On 26.01.2015 23:11, Michael Niedermayer wrote: On Mon, Jan 26, 2015 at 07:08:42PM -0300, James Almer wrote: On 26/01/15 7:04 PM, Michael Niedermayer wrote: reverted, breaks on BSDs ar: illegal option -- D [...] Maybe a configure check for "ranlib -D" could be added. yes Attached pa

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Michael Niedermayer
On Tue, Jan 27, 2015 at 12:31:18AM +0100, Andreas Cadhalpun wrote: > Hi, > > On 26.01.2015 23:11, Michael Niedermayer wrote: > >On Mon, Jan 26, 2015 at 07:08:42PM -0300, James Almer wrote: > >>On 26/01/15 7:04 PM, Michael Niedermayer wrote: > >>>reverted, breaks on BSDs > >>> > >>>ar: illegal opti

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: remove mp=softpulldown

2015-01-26 Thread Stefano Sabatini
On date Monday 2015-01-26 17:06:55 +, Paul B Mahol encoded: [...] > The filter have even bigger problems than setting flags, and as is > present in lavfi does not work properly. > > I will remove this filter and libmpcodecs with it in next 24 hours. Not OK with me. Send a patch for mp remova

Re: [FFmpeg-devel] [PATCH] Support BMP files that do not properly align lines.

2015-01-26 Thread Reimar Döffinger
On 26.01.2015, at 22:49, Michael Niedermayer wrote: > On Mon, Jan 26, 2015 at 08:21:16PM +0100, Reimar Döffinger wrote: >> Quite a few programs missed that detail of the spec >> (including old versions of FFmpeg I believe) and when >> we would otherwise fail anyway it seems worth a try >> to us a

Re: [FFmpeg-devel] libavutil: Added twofish block cipher

2015-01-26 Thread Reimar Döffinger
On 25 January 2015 20:00:07 CET, supraja reddy wrote: >Sorry. I forgot to make a small change. Updated the patch. > Not specifically related to this patch, but with this many implementations I think it is high time we warn about the security implications of using them. My original implementation

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Clément Bœsch
On Tue, Jan 27, 2015 at 12:31:18AM +0100, Andreas Cadhalpun wrote: > Hi, > > On 26.01.2015 23:11, Michael Niedermayer wrote: > >On Mon, Jan 26, 2015 at 07:08:42PM -0300, James Almer wrote: > >>On 26/01/15 7:04 PM, Michael Niedermayer wrote: > >>>reverted, breaks on BSDs > >>> > >>>ar: illegal opti

Re: [FFmpeg-devel] [PATCH] configure: use ar and ranlib in deterministic mode

2015-01-26 Thread Hendrik Leppkes
On Tue, Jan 27, 2015 at 12:31 AM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > Hi, > > On 26.01.2015 23:11, Michael Niedermayer wrote: > >> On Mon, Jan 26, 2015 at 07:08:42PM -0300, James Almer wrote: >> >>> On 26/01/15 7:04 PM, Michael Niedermayer wrote: >>> reverted, break