Hi, 2015-01-25 20:00 GMT+01:00 supraja reddy <supraja0...@gmail.com>: > Sorry. I forgot to make a small change. Updated the patch.
> + for (i = 0; i < cs->ksize; i++) { > + Me[i] = Key[2 * i]; > + Mo[i] = Key[2 * i + 1]; > + } > + for (i = 0; i < cs->ksize; i++) > + cs->S[cs->ksize - i - 1] = tf_RS(Me[i], Mo[i]); Can't the previous two for loops be merged together? > +/** > + * Initialize an AVTWOFISH context. > + * > + * @param ctx an AVTWOFISH context > + * @param key a key of size ranging from 1 to 32 bytes used for > encryption/decryption > + * @param key_bits number of keybits: 128, 192, 256 If less than the > required, padded with zeroes to nearest valid value > + */ You need to document the return values of this function. > +int av_twofish_init(struct AVTWOFISH *ctx, const uint8_t *key, int key_bits); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel