Re: [FFmpeg-devel] ffmpeg nvenc

2014-12-17 Thread Agatha Hu
Repost -Original Message- From: Agatha Hu Sent: 2014年12月17日 15:49 To: 'Philip Langdale'; 'ffmpeg-devel@ffmpeg.org' Cc: Abhijit Patait; Eric Young; Jaime Ieong; Andrew Fear; Stephen Warren; Andy Ritger Subject: RE: ffmpeg nvenc Hi Phil, We've almost finished the license part in our patc

Re: [FFmpeg-devel] ffmpeg nvenc

2014-12-17 Thread Philip Langdale
On 2014-12-17 01:34, Agatha Hu wrote: Repost -Original Message- From: Agatha Hu Sent: 2014年12月17日 15:49 To: 'Philip Langdale'; 'ffmpeg-devel@ffmpeg.org' Cc: Abhijit Patait; Eric Young; Jaime Ieong; Andrew Fear; Stephen Warren; Andy Ritger Subject: RE: ffmpeg nvenc Hi Phil, We've almost

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-17 Thread Carl Eugen Hoyos
supraja reddy gmail.com> writes: > -- CAST128 symmetric block cipher, ECB mode > +- CAST128 symmetric block cipher This line is part of the "2.5" paragraph, please do not change this paragraph as 2.5 was already released. > -void av_cast5_crypt(struct AVCAST5 *ctx, uint8_t *dst, > const uint

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Carl Eugen Hoyos
Thomas Volkert gmx.net> writes: > if (size >= 18) { /* We're obviously dealing with WAVEFORMATEX */ > -int cbSize = avio_rl16(pb); /* cbSize */ > +int cbSize = (!big_endian ? avio_rl16(pb) : > avio_rb16(pb)); /* cbSize */ This change looks useless to me given that you erro

[FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Thomas Volkert
From: Thomas Volkert --- Changelog | 1 + libavformat/act.c | 2 +- libavformat/asfdec.c | 2 +- libavformat/avidec.c | 2 +- libavformat/dxa.c | 2 +- libavformat/matroskadec.c | 2 +- libavformat/mlvdec.c | 2 +- libavformat/mov.c |

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Carl Eugen Hoyos
Thomas Volkert gmx.net> writes: > -id = avio_rl16(pb); > codec->codec_type = AVMEDIA_TYPE_AUDIO; > -codec->channels= avio_rl16(pb); > -codec->sample_rate = avio_rl32(pb); > -codec->bit_rate= avio_rl32(pb) * 8; > -codec->block_align = avio_rl16(pb)

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Thomas Volkert
On 12/16/2014 08:36 AM, Reimar Döffinger wrote: On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote: codec->sample_rate = avio_rl32(pb); codec->bit_rate= avio_rl32(pb) * 8; codec->block_align = avio_rl16(pb); +if (big_endian) { +id

[FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Thomas Volkert
From: Thomas Volkert --- Changelog | 1 + libavformat/act.c | 2 +- libavformat/asfdec.c | 2 +- libavformat/avidec.c | 2 +- libavformat/dxa.c | 2 +- libavformat/matroskadec.c | 2 +- libavformat/mlvdec.c | 2 +- libavformat/mov.c |

Re: [FFmpeg-devel] ffmpeg nvenc

2014-12-17 Thread compn
On Wed, 17 Dec 2014 09:34:56 + Agatha Hu wrote: > We've almost finished the license part in our patch and plan to > commit to ffmpeg community, but we found ffmpeg add Timo's nvenc > patch days ago, so our patch is incompatible with the TOT version. > Should we (1)Add libnvenc on TOT branch bu

Re: [FFmpeg-devel] ffmpeg nvenc

2014-12-17 Thread Carl Eugen Hoyos
compn mi.rr.com> writes: > > Should we (1)Add libnvenc on TOT branch but without > > changing Timo's work or (2)Change nvenc on TOT > > branch like an incremental patch on Timo's work. In > > fact I would prefer (1), as it requires less work. > > probably (1) for now. Isn't that the worst-ca

Re: [FFmpeg-devel] ffmpeg nvenc

2014-12-17 Thread Anshul
On 12/17/2014 10:11 PM, Carl Eugen Hoyos wrote: > compn mi.rr.com> writes: > >>> Should we (1)Add libnvenc on TOT branch but without >>> changing Timo's work or (2)Change nvenc on TOT >>> branch like an incremental patch on Timo's work. In >>> fact I would prefer (1), as it requires less work.

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-17 Thread Giorgio Vazzana
Hello, 2014-12-17 10:27 GMT+01:00 Carl Eugen Hoyos : > supraja reddy gmail.com> writes: > >> -- CAST128 symmetric block cipher, ECB mode >> +- CAST128 symmetric block cipher > > This line is part of the "2.5" paragraph, please > do not change this paragraph as 2.5 was already > released. > >> -vo

[FFmpeg-devel] [PATCH] added slicing yuv, rgb

2014-12-17 Thread Yayoi
--- libavfilter/allfilters.c | 2 +- libavfilter/vf_lut.c | 119 ++- 2 files changed, 88 insertions(+), 33 deletions(-) diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index adb86be..76341bd 100644 --- a/libavfilter/allfilters.c +

[FFmpeg-devel] SCTE-35 development

2014-12-17 Thread Anshul
Hi I was doing development of scte-35 message cue in ffmpeg. I have attached a draft patch. I would like to have some comments of this community. -Anshul >From 2ff4edfdeae131df72ea19005eb6ad85d5332f7c Mon Sep 17 00:00:00 2001 From: Anshul Maheshwari Date: Wed, 17 Dec 2014 22:13:10 +0530 Subjec

Re: [FFmpeg-devel] libavutil: Added cbc mode to cast5.c

2014-12-17 Thread supraja reddy
I hope this fixes all the issues . Supraja On Wed, Dec 17, 2014 at 10:54 PM, Giorgio Vazzana wrote: > > Hello, > > 2014-12-17 10:27 GMT+01:00 Carl Eugen Hoyos : > > supraja reddy gmail.com> writes: > > > >> -- CAST128 symmetric block cipher, ECB mode > >> +- CAST128 symmetric block cipher > > >

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Reimar Döffinger
On Wed, Dec 17, 2014 at 11:55:17AM +0100, Thomas Volkert wrote: > On 12/16/2014 08:36 AM, Reimar Döffinger wrote: > >On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote: > >>> codec->sample_rate = avio_rl32(pb); > >>> codec->bit_rate= avio_rl32(pb) * 8; > >>> code

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Benoit Fouet
Hi, Le 17/12/2014 22:15, Reimar Döffinger a écrit : On Wed, Dec 17, 2014 at 11:55:17AM +0100, Thomas Volkert wrote: On 12/16/2014 08:36 AM, Reimar Döffinger wrote: On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote: codec->sample_rate = avio_rl32(pb); codec->bit_ra

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-17 Thread Lukasz Marek
On 15.12.2014 14:18, Michael Niedermayer wrote: cmdutils.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) 8d012a5193b0440717f89d920661913ef160e674 0001-cmdutils-dont-call-read_header-before-listing-device.patch From 332bb7456c498518ea72dfdaa0e8c3e76d383f21 Mon Sep 17 00:00

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Thomas Volkert
On 12/17/2014 10:57 PM, Benoit Fouet wrote: Hi, Le 17/12/2014 22:15, Reimar Döffinger a écrit : On Wed, Dec 17, 2014 at 11:55:17AM +0100, Thomas Volkert wrote: On 12/16/2014 08:36 AM, Reimar Döffinger wrote: On Mon, Dec 15, 2014 at 10:24:55AM +, Carl Eugen Hoyos wrote: codec->samp

Re: [FFmpeg-devel] [PATCH] aacps.c: Move large arrays to context to reduce stack usage.

2014-12-17 Thread Michael Niedermayer
On Wed, Dec 17, 2014 at 04:31:48AM +0100, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/aacps.c | 4 ++-- > libavcodec/aacps.h | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611

Re: [FFmpeg-devel] [PATCH] rematrix DPLII fix for channel downmixing. Surround now adds to front rather than taking away.

2014-12-17 Thread Oton Mahnič
I tested this patch as described here: https://trac.ffmpeg.org/ticket/4175 It works well with DPLII, I cannot test it for Dolby but it should be ok. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-17 Thread Stefano Sabatini
On date Wednesday 2014-12-17 12:16:12 +0530, arwa arif encoded: > Updated the patch. > Since, norm_qsclae uses "libavcodec/avcodec.h", can't remove it. > From c168321361c99ccb8cea13de0091f112e401614e Mon Sep 17 00:00:00 2001 > From: Arwa Arif > Date: Sun, 14 Dec 2014 12:03:31 +0530 > Subject: [PA

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-17 Thread Carl Eugen Hoyos
Stefano Sabatini gmail.com> writes: > > -DECLARE_ALIGNED(8, uint64_t, ff_MM_FIX_0_541196100)= > > FIX64(0.541196100, 14); > > -DECLARE_ALIGNED(8, uint64_t, ff_MM_FIX_0_707106781)= > > FIX64(0.707106781, 14); > > +extern uint64_t ff_MM_FIX_0_707106781; > > +extern uint64_t ff_MM_FIX_0_541196100; >

Re: [FFmpeg-devel] [PATCH] wavdec: RIFX file format support

2014-12-17 Thread Michael Niedermayer
On Wed, Dec 17, 2014 at 12:04:37PM +0100, Thomas Volkert wrote: > From: Thomas Volkert > > --- > Changelog | 1 + > libavformat/act.c | 2 +- > libavformat/asfdec.c | 2 +- > libavformat/avidec.c | 2 +- > libavformat/dxa.c | 2 +- > libavformat/mat

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-17 Thread Carl Eugen Hoyos
Stefano Sabatini gmail.com> writes: > > +extern uint64_t ff_MM_FIX_0_707106781; > > +extern uint64_t ff_MM_FIX_0_541196100; > > why do you need to change this? > > Can you just drop the ff_ prefix from the > constant and put it in the x86 file? The reason is apparently llvm, see fa35ade8 My

Re: [FFmpeg-devel] [PATCH] added slicing yuv, rgb

2014-12-17 Thread Carl Eugen Hoyos
Yayoi gmail.com> writes: > +++ b/libavfilter/allfilters.c > - > + This change cannot be committed to our repository (trailing whitespace), please remove it. Your commit message should contain a hint to vf_lut, most people here seem to believe in "lavfi/vf_lut: Added..." Did you consid

Re: [FFmpeg-devel] [PATCH] added slicing yuv, rgb

2014-12-17 Thread Michael Niedermayer
On Tue, Dec 16, 2014 at 10:44:27PM -0800, Yayoi wrote: > --- > libavfilter/allfilters.c | 2 +- > libavfilter/vf_lut.c | 119 > ++- > 2 files changed, 88 insertions(+), 33 deletions(-) ./ffplay -i matrixbench_mpeg2.mpg -vf "lutrgb=c0=1/val" show

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-17 Thread Michael Niedermayer
On Wed, Dec 17, 2014 at 10:59:37PM +0100, Lukasz Marek wrote: > On 15.12.2014 14:18, Michael Niedermayer wrote: > >> cmdutils.c |8 ++-- > >> 1 file changed, 6 insertions(+), 2 deletions(-) > >>8d012a5193b0440717f89d920661913ef160e674 > >>0001-cmdutils-dont-call-read_header-before-listin

Re: [FFmpeg-devel] [PATCH] added slicing yuv, rgb

2014-12-17 Thread Clément Bœsch
> Subject: Re: [FFmpeg-devel] [PATCH] added slicing yuv, rgb You probably want to say what part it affects, as well as mentioning threading. So probably something like "avfilter/lut: support rgb and yuv slice threading" You might also want to mention in the commit description what performance boo

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-17 Thread Lukasz Marek
On 18.12.2014 01:09, Michael Niedermayer wrote: On Wed, Dec 17, 2014 at 10:59:37PM +0100, Lukasz Marek wrote: On 15.12.2014 14:18, Michael Niedermayer wrote: cmdutils.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) 8d012a5193b0440717f89d920661913ef160e674 0001-cmdutils-d

Re: [FFmpeg-devel] ffmpeg nvenc

2014-12-17 Thread ahu
On 12/17/2014 10:20 PM, compn wrote:> On Wed, 17 Dec 2014 09:34:56 + > Agatha Hu wrote: >> We've almost finished the license part in our patch and plan to >> commit to ffmpeg community, but we found ffmpeg add Timo's nvenc >> patch days ago, so our patch is incompatible with the TOT version.

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-17 Thread arwa arif
> > AVFILTER_DEFINE_CLASS(fspp) Why do we need this? Is it not defined already? > > +static int config_input(AVFilterLink *inlink) > > +{ > > + > > +AVFilterContext *ctx = inlink->dst; > > +FSPPContext *fspp = ctx->priv; > > +const int h = FFALIGN(inlink->h + 16, 16); > > +const

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-17 Thread Clément Bœsch
On Thu, Dec 18, 2014 at 12:06:04PM +0530, arwa arif wrote: > > > > AVFILTER_DEFINE_CLASS(fspp) > > > Why do we need this? Is it not defined already? > See e93abe1f406964e6e59f2bf86b0763f3a90f5acf [...] -- Clément B. pgpCzcqq5KwWm.pgp Description: PGP signature _

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-17 Thread arwa arif
From af45d0edb243a0948581d48e1794e0e496d2204f Mon Sep 17 00:00:00 2001 From: Arwa Arif Date: Sun, 14 Dec 2014 12:03:31 +0530 Subject: [PATCH] lavfi: port mp=uspp to a native libavfilter filter --- LICENSE.md|1 + configure |1 + doc/filter

Re: [FFmpeg-devel] [PATCH] lavfi: Port fspp to FFmpeg

2014-12-17 Thread Stefano Sabatini
On date Thursday 2014-12-18 12:06:04 +0530, arwa arif encoded: > > > > AVFILTER_DEFINE_CLASS(fspp) > > > Why do we need this? Is it not defined already? > > > > > +static int config_input(AVFilterLink *inlink) > > > +{ > > > + > > > +AVFilterContext *ctx = inlink->dst; > > > +FSPPContex