Re: [FFmpeg-devel] [PATCH]Do not add palette size to the bitmapheader size

2014-09-29 Thread Carl Eugen Hoyos
On Monday 29 September 2014 01:22:38 am Carl Eugen Hoyos wrote: > Attached patch is the first part of the fix for ticket #1304. New, tested patch attached. Please comment, Carl Eugen diff --git a/libavformat/riffenc.c b/libavformat/riffenc.c index 2eb2ae1..723e802 100644 --- a/libavformat/riffenc

Re: [FFmpeg-devel] [PATCH]Set the rawvideo image size to 0 in the bitmapinfoheader

2014-09-29 Thread Carl Eugen Hoyos
On Monday 29 September 2014 01:30:44 am Carl Eugen Hoyos wrote: > Attached patch fixes ticket #1304: biSizeImage may be 0 for images with > codec tag 0, if the size is set too small, WMP refuses to play the file. Patch with changes to fate attached. Please comment, Carl Eugen diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH]Do not add palette size to the bitmapheader size

2014-09-29 Thread Benoit Fouet
Hi, - Mail original - > On Monday 29 September 2014 01:22:38 am Carl Eugen Hoyos wrote: > > Attached patch is the first part of the fix for ticket #1304. > > New, tested patch attached. > > Please comment, Carl Eugen > LGTM, -- Ben ___ ffmp

Re: [FFmpeg-devel] [PATCH]Set the rawvideo image size to 0 in the bitmapinfoheader

2014-09-29 Thread Benoit Fouet
Hi, - Mail original - > On Monday 29 September 2014 01:30:44 am Carl Eugen Hoyos wrote: > > Attached patch fixes ticket #1304: biSizeImage may be 0 for images > > with > > codec tag 0, if the size is set too small, WMP refuses to play the > > file. > > Patch with changes to fate attached.

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/utils: Fix off by 1 error causing unneeded allocation in ff_fast_malloc()

2014-09-29 Thread Benoit Fouet
Hi, - Mail original - > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index b27f918..9eb2b5b 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/put_bits: Add rebase_put_bits()

2014-09-29 Thread Benoit Fouet
Hi, - Mail original - > Signed-off-by: Michael Niedermayer > --- > libavcodec/put_bits.h | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/libavcodec/put_bits.h b/libavcodec/put_bits.h > index 8081fb9..f16d04a 100644 > --- a/libavcodec/put_bits.h > +++ b/liba

Re: [FFmpeg-devel] More specific error codes

2014-09-29 Thread Andrey Utkin
At last I got back to this issue. First I thought of adding such new error codes: #define AVERROR_BAD_REQUESTFFERRTAG(0xF8,'4','0','0') ///< Remote server returns 400 Bad Request reply #define AVERROR_AUTH_FAILEDFFERRTAG(0xF8,'4','0','1') ///< Unauthorized by remote server #define

Re: [FFmpeg-devel] [PATCH]Do not add palette size to the bitmapheader size

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 09:33:16AM +0200, Carl Eugen Hoyos wrote: > On Monday 29 September 2014 01:22:38 am Carl Eugen Hoyos wrote: > > Attached patch is the first part of the fix for ticket #1304. > > New, tested patch attached. > > Please comment, Carl Eugen > riffenc.c |5 - > 1 file

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/utils: Fix off by 1 error causing unneeded allocation in ff_fast_malloc()

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 09:59:21AM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/utils.c |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > > i

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/put_bits: Add rebase_put_bits()

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 10:04:04AM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/put_bits.h | 17 + > > 1 file changed, 17 insertions(+) > > > > diff --git a/libavcodec/put_bits.h b/libavcodec/put_b

Re: [FFmpeg-devel] [PATCH 2/3] configure: Set large address aware.

2014-09-29 Thread Tobias Rapp
On 28.09.2014 10:49, Reimar Döffinger wrote: Note the documentation for that option: The /LARGEADDRESSAWARE option tells the linker that the application can handle addresses larger than 2 gigabytes. This flag is _only_ used to signal that an application can deal with addresses that use more tha

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-29 Thread Benoit Fouet
Hi, - Mail original - > Hi, > > Le 26/09/2014 18:38, Michael Niedermayer a écrit : > > On Fri, Sep 26, 2014 at 09:27:01AM +0200, Benoit Fouet wrote: > >> Hi, > >> > >> - Mail original - > >>> Michael Niedermayer gmx.at> writes: > >>> > > On Fri, Aug 01, 2014 at 01:54:14

Re: [FFmpeg-devel] Please help update tasks and mentor/backups for OPW

2014-09-29 Thread Nicolas George
Le quartidi 4 vendémiaire, an CCXXIII, Reynaldo H. Verdejo Pinochet a écrit : > As you might already know, Samsung has decided to back up our > initiative with the required 6K USD (Thanks!) and as result, > we have got at least one mentee covered for this round of the > Outreach Program for Women (

Re: [FFmpeg-devel] [PATCH] avcodec/srtdec: use AVBPrint API

2014-09-29 Thread Nicolas George
Le septidi 7 vendémiaire, an CCXXIII, Clément Bœsch a écrit : > --- > Can only be applied after timed SRT is dropped. > --- > libavcodec/srtdec.c | 78 > - > 1 file changed, 35 insertions(+), 43 deletions(-) The changes look right to me. Regar

Re: [FFmpeg-devel] [PATCH 1/2] Kill timed SRT

2014-09-29 Thread Nicolas George
L'octidi 28 fructidor, an CCXXII, Clément Bœsch a écrit : > --- > libavcodec/srtdec.c | 33 +++ > libavcodec/srtenc.c | 49 > ++- > libavformat/matroska.c| 1 - > libavformat/matroskaenc.c | 45 +-

[FFmpeg-devel] IRC meeting

2014-09-29 Thread Stefano Sabatini
Hi, I want to propose to have an FFmpeg IRC meeting the next Saturday, 4th October, UTC 16. Alternatively, I propose the Saturday of the next week, Saturday October 11, same time. Candidate topics of the day: - VDD 2014 report and discussion, in particular with regards to relationships with lib

Re: [FFmpeg-devel] IRC meeting

2014-09-29 Thread Clément Bœsch
On Mon, Sep 29, 2014 at 05:39:23PM +0200, Stefano Sabatini wrote: > Hi, > > I want to propose to have an FFmpeg IRC meeting the next Saturday, 4th > October, UTC 16. Alternatively, I propose the Saturday of the next > week, Saturday October 11, same time. > > Candidate topics of the day: > - VDD

Re: [FFmpeg-devel] [PATCH]Fix 32bit pcm audio in mov

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 02:01:25AM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes decoding 32bit pcm audio in mov as written by the > Convergent Design's Odyssey 7Q recorder. > > Please comment, Carl Eugen > mov.c |4 > 1 file changed, 4 insertions(+) > 32e08e9fde8c368a

Re: [FFmpeg-devel] More specific error codes

2014-09-29 Thread Nicolas George
L'octidi 8 vendémiaire, an CCXXIII, Andrey Utkin a écrit : > At last I got back to this issue. > First I thought of adding such new error codes: > What do you think about it? Which would you prefer? I am sorry to have to say your proposal has the taste of "add whatever I need for my specific use

Re: [FFmpeg-devel] More specific error codes

2014-09-29 Thread wm4
On Mon, 29 Sep 2014 19:06:09 +0200 Nicolas George wrote: > I quite like the GError system devised in GLib for the Gtk+ toolkit. It > solves A, B and C in a rather elegant way IMHO. *panic* (GLib is full of utter shit design, I doubt "GError" is sane.) __

Re: [FFmpeg-devel] More specific error codes

2014-09-29 Thread Nicolas George
L'octidi 8 vendémiaire, an CCXXIII, wm4 a écrit : > (GLib is full of utter shit design, I doubt "GError" is sane.) By your wording, I guess you did not actually look. I did. Regards, -- Nicolas George signature.asc Description: Digital signature _

Re: [FFmpeg-devel] More specific error codes

2014-09-29 Thread wm4
On Mon, 29 Sep 2014 19:17:04 +0200 Nicolas George wrote: > L'octidi 8 vendémiaire, an CCXXIII, wm4 a écrit : > > (GLib is full of utter shit design, I doubt "GError" is sane.) > > By your wording, I guess you did not actually look. I did. Well, I've read the rest of your description, but it alr

Re: [FFmpeg-devel] [PATCH 1/2] Kill timed SRT

2014-09-29 Thread Clément Bœsch
On Mon, Sep 29, 2014 at 05:42:09PM +0200, Nicolas George wrote: > L'octidi 28 fructidor, an CCXXII, Clément Bœsch a écrit : > > --- > > libavcodec/srtdec.c | 33 +++ > > libavcodec/srtenc.c | 49 > > ++- > > libav

[FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: fix avio_flush() for read streams

2014-09-29 Thread wm4
avio_flush() did nothing useful for read streams. Fix it to behave as expected, and discard the currently read buffer properly. --- Since avio_flush() was just broken for read streams, I don't think this needs to be treated as an API-change. --- libavformat/avio.h| 8 ++-- libavformat/avio

[FFmpeg-devel] [PATCH 2/2] avformat: add avformat_flush()

2014-09-29 Thread wm4
Useful for Bluray and DVD, since the libraries used to read them just change the byte stream under your feet on seeking. Maybe there should be a AVInputFormat callback for this. But the mpeg-ps (DVD) and the mpeg-ts (Bluray) demuxers don't change much state during seeking - they just try to find a

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add avformat_flush()

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 07:41:28PM +0200, wm4 wrote: > Useful for Bluray and DVD, since the libraries used to read them just > change the byte stream under your feet on seeking. > > Maybe there should be a AVInputFormat callback for this. But the > mpeg-ps (DVD) and the mpeg-ts (Bluray) demuxers d

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add avformat_flush()

2014-09-29 Thread wm4
On Mon, 29 Sep 2014 20:25:47 +0200 Michael Niedermayer wrote: > On Mon, Sep 29, 2014 at 07:41:28PM +0200, wm4 wrote: > > Useful for Bluray and DVD, since the libraries used to read them just > > change the byte stream under your feet on seeking. > > > > Maybe there should be a AVInputFormat call

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add avformat_flush()

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 08:34:44PM +0200, wm4 wrote: > On Mon, 29 Sep 2014 20:25:47 +0200 > Michael Niedermayer wrote: > > > On Mon, Sep 29, 2014 at 07:41:28PM +0200, wm4 wrote: > > > Useful for Bluray and DVD, since the libraries used to read them just > > > change the byte stream under your fee

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpegvideo_enc: Allocate only a small buffer and reallocate as needed

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 05:56:01AM +0200, Michael Niedermayer wrote: > This should reduce the memory requirement > > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpegvideo_enc.c | 36 ++-- > 1 file changed, 34 insertions(+), 2 deletions(-) applied [..

Re: [FFmpeg-devel] [PATCH] h264_mp4toannexb_bsf: always set idr_sps_pps_seen when SPS/PPS is seen.

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 03:31:36PM +0200, Benoit Fouet wrote: > Hi, > > - Mail original - > > Hi, > > > > Le 26/09/2014 18:38, Michael Niedermayer a écrit : > > > On Fri, Sep 26, 2014 at 09:27:01AM +0200, Benoit Fouet wrote: > > >> Hi, > > >> > > >> - Mail original - > > >>> Micha

Re: [FFmpeg-devel] [PATCH 1/2] avformat/aviobuf: fix avio_flush() for read streams

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 07:41:27PM +0200, wm4 wrote: > avio_flush() did nothing useful for read streams. Fix it to behave as > expected, and discard the currently read buffer properly. > --- > Since avio_flush() was just broken for read streams, I don't think this > needs to be treated as an API-ch

[FFmpeg-devel] [PATCH] Reset mutex to NULL after mutex destruction.

2014-09-29 Thread Manfred Georg
A badly behaving user provided mutex manager (such as that in OpenCV) may not reset the mutex to NULL on destruction. This can cause a problem for a later mutex manager (which may assert that the mutex is NULL before creating). --- libavcodec/utils.c | 15 +-- 1 file changed, 9 inse

[FFmpeg-devel] [PATCH 1/2] avcodec: add avcodec_register_one() to register one codec/parser/bsf/hwaccel by its char* name

2014-09-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/allcodecs.c | 51 +--- libavcodec/avcodec.h |5 + 2 files changed, 40 insertions(+), 16 deletions(-) diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c index 7650543..019d5ea 10064

[FFmpeg-devel] [PATCH 2/2] avformat: add av_register_one() to register one codec/parser/bsf/hwaccel/muxer/demuxer by its char* name

2014-09-29 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/allformats.c | 44 +++- libavformat/avformat.h |5 + 2 files changed, 36 insertions(+), 13 deletions(-) diff --git a/libavformat/allformats.c b/libavformat/allformats.c index d54ed9b..b613bed 1

Re: [FFmpeg-devel] [PATCH] Reset mutex to NULL after mutex destruction.

2014-09-29 Thread Michael Niedermayer
On Mon, Sep 29, 2014 at 02:41:38PM -0700, Manfred Georg wrote: > A badly behaving user provided mutex manager (such as that in OpenCV) may not > reset the mutex to NULL on destruction. This can cause a problem for a later > mutex manager (which may assert that the mutex is NULL before creating).

Re: [FFmpeg-devel] [PATCH 2/2] avformat: add avformat_flush()

2014-09-29 Thread Reimar Döffinger
On 29.09.2014, at 22:02, Michael Niedermayer wrote: > On Mon, Sep 29, 2014 at 08:34:44PM +0200, wm4 wrote: >> On Mon, 29 Sep 2014 20:25:47 +0200 >> Michael Niedermayer wrote: >> >>> On Mon, Sep 29, 2014 at 07:41:28PM +0200, wm4 wrote: Useful for Bluray and DVD, since the libraries used to r