Re: [FFmpeg-devel] [PATCH]Clean up if filter initialisation failed

2014-08-30 Thread Nicolas George
Le tridi 13 fructidor, an CCXXII, Carl Eugen Hoyos a écrit : > Attached patch fixes a memleak with ffmpeg if the filter initialisation > fails, > fixes ticket #3858 for me. > > Please review, Carl Eugen > diff --git a/ffmpeg_filter.c b/ffmpeg_filter.c > index b6dc42f..7acff28 100644 > --- a/ffm

Re: [FFmpeg-devel] Symbian port

2014-08-30 Thread Clément Bœsch
On Fri, Aug 29, 2014 at 01:21:32PM -0800, Lou Logan wrote: [...] > ffmpeg-user is not for help involving forks, scripts, counterfeits, or > other third-party tools. Only FFmpeg tools are supported. Please refrain from such comment. gas-pp is a project mostly (entirely?) maintained by the people fr

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-08-30 Thread wm4
On Fri, 29 Aug 2014 15:52:25 -0700 Peter Kasting wrote: > On Fri, Aug 29, 2014 at 3:48 PM, Carl Eugen Hoyos wrote: > > > Peter Kasting google.com> writes: > > > > > The attached patch fixes instances of MSVC warning > > > C4244 about possible value truncation (e.g. when > > > assigning double

Re: [FFmpeg-devel] [PATCH] delete the old segment file from hls list

2014-08-30 Thread Anshul
On August 30, 2014 8:57:12 AM IST, Steven Liu wrote: > >On Aug 28, 2014, at 4:52 AM, Anshul wrote: > >> On August 22, 2014 8:01:20 AM IST, Steven Liu > wrote: >>> repost new patch: >>> >>> when update the hls m3u8 list, the old file is not unlinked >>> this patch can do this operation >>> delete

[FFmpeg-devel] [PATCH] avformat/rtpdec_qt: add cast to silence "discards const qualifier from pointer target type" warning

2014-08-30 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavformat/rtpdec_qt.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtpdec_qt.c b/libavformat/rtpdec_qt.c index ee8a48a..58253b6 100644 --- a/libavformat/rtpdec_qt.c +++ b/libavformat/rtpdec_qt.c @@ -71,7 +71,7 @@ stati

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-30 Thread Christophe Gisquet
Hi, 2014-08-24 18:56 GMT+02:00 Michael Niedermayer : > aggree, a PRORES_PROFILE_AUTO seems like a good idea > with it mismatching profile and pixel format can be errors while > by default the profile can be selected based on the pixel format The attached patch makes it selects either or HQ p

Re: [FFmpeg-devel] [PATCH] avcodec/vp3data: use more compact data types

2014-08-30 Thread Paul B Mahol
On 8/30/14, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp3data.h | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/libavcodec/vp3data.h b/libavcodec/vp3data.h > index 427827b..da31f6d 100644 > --- a/libavcode

Re: [FFmpeg-devel] [PATCH] avcodec/vp3data: use more compact data types

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 01:31:04PM +0200, Paul B Mahol wrote: > On 8/30/14, Michael Niedermayer wrote: > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/vp3data.h | 20 ++-- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > > > diff --git a/libavcodec/vp3dat

Re: [FFmpeg-devel] [RFC] [PATCH] proresenc_kostya: warn/reject on incorrect profile

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 01:13:56PM +0200, Christophe Gisquet wrote: > Hi, > > 2014-08-24 18:56 GMT+02:00 Michael Niedermayer : > > aggree, a PRORES_PROFILE_AUTO seems like a good idea > > with it mismatching profile and pixel format can be errors while > > by default the profile can be selected ba

Re: [FFmpeg-devel] [PATCH] lavu/avstring: check for overlong encodings

2014-08-30 Thread Stefano Sabatini
On date Friday 2014-08-29 15:57:32 +0200, wm4 encoded: > On Thu, 28 Aug 2014 17:39:27 +0200 > Stefano Sabatini wrote: > > > Fix reopened trac ticket #1163. > > --- > > libavutil/avstring.c | 13 - > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/libavutil/avs

Re: [FFmpeg-devel] [PATCH] lavu/avstring: check for overlong encodings

2014-08-30 Thread Nicolas George
Le tridi 13 fructidor, an CCXXII, Stefano Sabatini a écrit : > It is mathematically impossible that the length will be larger than 5. > Added an assert for that though, alternatively I could add a check. In ffprobe, the function is used with values coming directly from the file's metadata: an asse

Re: [FFmpeg-devel] [PATCH] lavu/avstring: check for overlong encodings

2014-08-30 Thread Stefano Sabatini
On date Saturday 2014-08-30 15:06:14 +0200, Nicolas George encoded: > Le tridi 13 fructidor, an CCXXII, Stefano Sabatini a écrit : > > It is mathematically impossible that the length will be larger than 5. > > Added an assert for that though, alternatively I could add a check. > > In ffprobe, the

Re: [FFmpeg-devel] [PATCH] lavu/avstring: check for overlong encodings

2014-08-30 Thread Nicolas George
Le tridi 13 fructidor, an CCXXII, Stefano Sabatini a écrit : > Unless there is an error in the code, a tail length of 6 bytes should > never be reached. > > > Furthermore, the function is capable of decoding the full UTF-8 range, up to > > (1<<31)-1, and that takes 6 octets. > > There is a separa

[FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-30 Thread wm4
--- Reverse engineered by looking at Petri Hintukainen's muxer patch, and also the mkvmerge sources. Tested with files extracted by mkvextract only (does someone have better samples?). No idea if a parser would be required for correct remuxing, but at least for decoding with lavc it probably isn't

[FFmpeg-devel] [PATCH] oggdec: fix invalid free on error

2014-08-30 Thread wm4
The read_packet callback passes a pointer to a stack-allocated AVPacket. Attempting to free it with av_free() makes no sense. --- Found by looking at the code; there's no sample file. --- libavformat/oggdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/oggdec.c b/libavformat/ogg

Re: [FFmpeg-devel] [PATCH] added synchronous KLV codec ID and mpegts PAT and PMT descriptors as specified in stanag4609 annex C

2014-08-30 Thread Peter Ross
On Fri, Aug 29, 2014 at 02:24:21PM +0200, paolovergori wrote: > --- > libavcodec/avcodec.h| 17 + > libavcodec/codec_desc.c | 6 ++ > libavformat/mpegts.c| 2 ++ > libavformat/mpegts.h| 1 + > libavformat/mpegtsenc.c | 27 +++ > 5 files ch

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Reimar Döffinger
On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: > On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: > > Signed-off-by: Reimar Döffinger > > --- > > libavutil/hash.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavutil/hash.c b/li

[FFmpeg-devel] [PATCH 2/6] fft_template: Move variables to where they are used.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/fft_template.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/fft_template.c b/libavcodec/fft_template.c index 3abf948..23ea453 100644 --- a/libavcodec/fft_template.c +++ b/libavcodec/fft_template.c @@ -228

[FFmpeg-devel] [PATCH 5/6] xv.c: Add missing const to lookup table.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavdevice/xv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavdevice/xv.c b/libavdevice/xv.c index aeb3e41..c19c15c 100644 --- a/libavdevice/xv.c +++ b/libavdevice/xv.c @@ -67,7 +67,7 @@ typedef struct XVTagFormatMap enum AV

[FFmpeg-devel] [PATCH 4/6] lavf: add const/static const to pix_fmts arrays.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavfilter/vf_blackdetect.c| 2 +- libavfilter/vf_lenscorrection.c | 2 +- libavfilter/vf_signalstats.c| 2 +- libavfilter/vf_tinterlace.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_blackdetect.c b/libavfi

[FFmpeg-devel] [PATCH 3/6] sipr16kdata.h: add forgotten const.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/sipr16kdata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sipr16kdata.h b/libavcodec/sipr16kdata.h index 96bf0e9..16a653d 100644 --- a/libavcodec/sipr16kdata.h +++ b/libavcodec/sipr16kdata.h @@ -525,7 +525,7 @@ stat

[FFmpeg-devel] [PATCH 1/6] fft: add ff_ prefix to some global arrays.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/fft_init_table.c | 4 ++-- libavcodec/fft_table.h | 4 ++-- libavcodec/fft_template.c | 12 ++-- libavcodec/mips/fft_mips.c | 8 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libavcodec/fft_init_table.c

[FFmpeg-devel] [PATCH 6/6] ac3dec_fixed: add missing "static const".

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/ac3dec_fixed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ac3dec_fixed.c b/libavcodec/ac3dec_fixed.c index f36e7b0..4c09de5 100644 --- a/libavcodec/ac3dec_fixed.c +++ b/libavcodec/ac3dec_fixed.c @@ -65,7 +65,7 @@ s

Re: [FFmpeg-devel] [PATCH] oggdec: fix invalid free on error

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 03:39:15PM +0200, wm4 wrote: > The read_packet callback passes a pointer to a stack-allocated AVPacket. > Attempting to free it with av_free() makes no sense. > --- > Found by looking at the code; there's no sample file. > --- > libavformat/oggdec.c | 1 - > 1 file changed,

Re: [FFmpeg-devel] [PATCH 4/6] lavf: add const/static const to pix_fmts arrays.

2014-08-30 Thread Timothy Gu
On Aug 30, 2014 7:44 AM, "Reimar Döffinger" wrote: It's lavfi, not lavf. Timothy ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 2/6] fft_template: Move variables to where they are used.

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 04:43:40PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/fft_template.c | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB In a

[FFmpeg-devel] [PATCH] aacsbr: support hardcoding tables.

2014-08-30 Thread Reimar Döffinger
For sbr_qmf_window_us there is even a question if it maybe should be fully hardcoded all the time. Since half of it is coded, it ends up in .data and not .bss. Signed-off-by: Reimar Döffinger --- libavcodec/Makefile | 4 +- libavcodec/aacsbr.c | 10 +--- libavcodec/aacsbr_ta

[FFmpeg-devel] [PATCH] Add av_cold to table generation functions.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/aac_tablegen.h | 2 +- libavcodec/aacps_tablegen.h| 4 ++-- libavcodec/aacsbr_tablegen.h | 2 +- libavcodec/cbrt_tablegen.h | 2 +- libavcodec/dv_tablegen.h | 2 +- libavcodec/motionpixels_tablegen.h | 6 +++--

Re: [FFmpeg-devel] [PATCH] Add av_cold to table generation functions.

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 05:35:55PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger Sorry, I sent this by accident. It does not yet compile, will send a fixed version. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.o

Re: [FFmpeg-devel] [PATCH 4/6] lavf: add const/static const to pix_fmts arrays.

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 08:07:29AM -0700, Timothy Gu wrote: > On Aug 30, 2014 7:44 AM, "Reimar Döffinger" > wrote: > > It's lavfi, not lavf. Fixed locally. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH 5/6] xv.c: Add missing const to lookup table.

2014-08-30 Thread Paul B Mahol
On 8/30/14, Reimar Doeffinger wrote: > Signed-off-by: Reimar Doeffinger > --- > libavdevice/xv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavdevice/xv.c b/libavdevice/xv.c > index aeb3e41..c19c15c 100644 > --- a/libavdevice/xv.c > +++ b/libavdevice/xv.c > @@

[FFmpeg-devel] [PATCH] WMA: add "const" to avoid warnings with hardcoded tables.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/wma.h | 2 +- libavcodec/wmaprodec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/wma.h b/libavcodec/wma.h index c4056ec..01244a0 100644 --- a/libavcodec/wma.h +++ b/libavcodec/wma.h @@ -115,7 +115,7 @@ ty

[FFmpeg-devel] [PATCH] Add av_cold to table generation functions.

2014-08-30 Thread Reimar Döffinger
Signed-off-by: Reimar Döffinger --- libavcodec/aac_tablegen.h | 2 +- libavcodec/aacps_tablegen.h| 4 ++-- libavcodec/aacsbr_tablegen.h | 2 +- libavcodec/cbrt_tablegen.h | 3 ++- libavcodec/dv_tablegen.h | 3 ++- libavcodec/motionpixels_tablegen.h | 7 +++

Re: [FFmpeg-devel] [PATCH 5/6] xv.c: Add missing const to lookup table.

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 05:55:39PM +0200, Paul B Mahol wrote: > On 8/30/14, Reimar Doeffinger wrote: > > Signed-off-by: Reimar Doeffinger > > --- > > libavdevice/xv.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > lgtm Thanks, pushed.

Re: [FFmpeg-devel] [PATCH] WMA: add "const" to avoid warnings with hardcoded tables.

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 06:00:20PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/wma.h | 2 +- > libavcodec/wmaprodec.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) LGTM thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF673

Re: [FFmpeg-devel] [PATCH] Add av_cold to table generation functions.

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 06:00:43PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/aac_tablegen.h | 2 +- > libavcodec/aacps_tablegen.h| 4 ++-- > libavcodec/aacsbr_tablegen.h | 2 +- > libavcodec/cbrt_tablegen.h | 3 ++- > libavc

[FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread Reimar Döffinger
Moves it from .data to .bss, slightly reducing binary size. Signed-off-by: Reimar Döffinger --- libavcodec/cabac.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/libavcodec/cabac.c b/libavcodec/cabac.c index 65579d8..803c81c 100644 --- a/libavcode

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-08-30 Thread Dmitry Volyntsev
To understand the problem one needs to see the original code around and to think what would happen if from time to time while capturing condition (s->frame_size > 0 && buf.bytesused != s->frame_size) happens to be true (this is not critical error so capturing would continue). It is obvious that eve

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread wm4
On Sat, 30 Aug 2014 18:18:41 +0200 Reimar Döffinger wrote: > Moves it from .data to .bss, slightly reducing binary size. > > Signed-off-by: Reimar Döffinger > --- > libavcodec/cabac.c | 26 -- > 1 file changed, 4 insertions(+), 22 deletions(-) > > diff --git a/libavcod

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 06:20:56PM +0200, wm4 wrote: > On Sat, 30 Aug 2014 18:18:41 +0200 > Reimar Döffinger wrote: > > > Moves it from .data to .bss, slightly reducing binary size. > > > > Signed-off-by: Reimar Döffinger > > --- > > libavcodec/cabac.c | 26 -- > > 1 fi

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread Reimar Döffinger
On 30.08.2014, at 18:29, Reimar Döffinger wrote: > On Sat, Aug 30, 2014 at 06:20:56PM +0200, wm4 wrote: >> On Sat, 30 Aug 2014 18:18:41 +0200 >> Reimar Döffinger wrote: >> >>> Moves it from .data to .bss, slightly reducing binary size. >>> >>> Signed-off-by: Reimar Döffinger >>> --- >>> libavc

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread wm4
On Sat, 30 Aug 2014 18:41:52 +0200 Reimar Döffinger wrote: > On 30.08.2014, at 18:29, Reimar Döffinger wrote: > > On Sat, Aug 30, 2014 at 06:20:56PM +0200, wm4 wrote: > >> On Sat, 30 Aug 2014 18:18:41 +0200 > >> Reimar Döffinger wrote: > >> > >>> Moves it from .data to .bss, slightly reducing

Re: [FFmpeg-devel] [PATCH] libavdevice/v4l2: fix of crash caused by assert

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 08:19:37PM +0400, Dmitry Volyntsev wrote: > To understand the problem one needs to see the original code around > and to think what would happen if from time to time while capturing > condition (s->frame_size > 0 && buf.bytesused != s->frame_size) > happens to be true (this

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread Reimar Döffinger
On 30.08.2014, at 19:01, wm4 wrote: > On Sat, 30 Aug 2014 18:41:52 +0200 > Reimar Döffinger wrote: > >> On 30.08.2014, at 18:29, Reimar Döffinger wrote: >>> On Sat, Aug 30, 2014 at 06:20:56PM +0200, wm4 wrote: On Sat, 30 Aug 2014 18:18:41 +0200 Reimar Döffinger wrote: > Mov

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread Reimar Döffinger
On 30.08.2014, at 19:46, Reimar Döffinger wrote: > On 30.08.2014, at 19:01, wm4 wrote: >> >> but still I wonder why you'd optimize >> for binary size, in exchange for higher RAM usage. What is your >> motivation for doing this? > > The only higher RAM usage would be when you actually use H.264,

Re: [FFmpeg-devel] [PATCH] cabac: initialize all of ff_h264_cabac_tables programmatically.

2014-08-30 Thread wm4
On Sat, 30 Aug 2014 19:58:11 +0200 Reimar Döffinger wrote: > On 30.08.2014, at 19:46, Reimar Döffinger wrote: > > On 30.08.2014, at 19:01, wm4 wrote: > >> > >> but still I wonder why you'd optimize > >> for binary size, in exchange for higher RAM usage. What is your > >> motivation for doing t

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Clément Bœsch
On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: > On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: > > On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: > > > Signed-off-by: Reimar Döffinger > > > --- > > > libavutil/hash.c | 2 +- > > > 1 file chan

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Timothy Gu
On Aug 30, 2014 7:37 AM, "Reimar Döffinger" wrote: > But mostly I care about having it in .rodata, everything else > I'm willing to adapt to what others prefer. What are the gains for using .rodata instead of .data? Timothy ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] Include content of the news article in the website RSS

2014-08-30 Thread Alexander Strasser
On 2014-08-28 07:23 -0700, Timothy Gu wrote: > On Thu, Aug 28, 2014 at 7:26 AM, Alexander Strasser wrote: > > Hi! > > > > On 2014-05-23 00:28 +0200, Alexander Strasser wrote: > >> On 2014-05-11 01:37 +0200, Gerion Entrup wrote: > >> > Am Donnerstag 01 Mai 2014, 23:48:29 schrieb Alexander Strasser:

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Reimar Döffinger
On Sat, Aug 30, 2014 at 12:58:35PM -0700, Timothy Gu wrote: > On Aug 30, 2014 7:37 AM, "Reimar Döffinger" > wrote: > > > But mostly I care about having it in .rodata, everything else > > I'm willing to adapt to what others prefer. > > What are the gains for using .rodata instead of .data? It is

Re: [FFmpeg-devel] [PATCH] lavu/hash.c: Add missing "static const".

2014-08-30 Thread Reimar Döffinger
On 30.08.2014, at 21:50, Clément Bœsch wrote: > On Sat, Aug 30, 2014 at 04:36:57PM +0200, Reimar Döffinger wrote: >> On Fri, Aug 29, 2014 at 09:29:46PM +0200, Clément Bœsch wrote: >>> On Fri, Aug 29, 2014 at 06:34:52PM +0200, Reimar Döffinger wrote: Signed-off-by: Reimar Döffinger --- >

Re: [FFmpeg-devel] [PATCH 4/6] lavf: add const/static const to pix_fmts arrays.

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 04:43:42PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavfilter/vf_blackdetect.c| 2 +- > libavfilter/vf_lenscorrection.c | 2 +- > libavfilter/vf_signalstats.c| 2 +- > libavfilter/vf_tinterlace.c | 2 +- > 4 files changed, 4 in

Re: [FFmpeg-devel] [PATCH 3/6] sipr16kdata.h: add forgotten const.

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 04:43:41PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/sipr16kdata.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are too

Re: [FFmpeg-devel] [PATCH 6/6] ac3dec_fixed: add missing "static const".

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 04:43:44PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/ac3dec_fixed.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Opposition brings

Re: [FFmpeg-devel] [PATCH 1/6] fft: add ff_ prefix to some global arrays.

2014-08-30 Thread Michael Niedermayer
On Sat, Aug 30, 2014 at 04:43:39PM +0200, Reimar Döffinger wrote: > Signed-off-by: Reimar Döffinger > --- > libavcodec/fft_init_table.c | 4 ++-- > libavcodec/fft_table.h | 4 ++-- > libavcodec/fft_template.c | 12 ++-- > libavcodec/mips/fft_mips.c | 8 > 4 files chang

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-30 Thread Marcus Johnson
Here's a PGS subtitle sample from Eac3to: https://dl.dropboxusercontent.com/u/52358991/English.zip On Sat, Aug 30, 2014 at 9:38 AM, wm4 wrote: > --- > Reverse engineered by looking at Petri Hintukainen's muxer patch, and > also the mkvmerge sources. Tested with files extracted by mkvextract > o

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-30 Thread wm4
On Sat, 30 Aug 2014 18:16:27 -0400 Marcus Johnson wrote: > Here's a PGS subtitle sample from Eac3to: > https://dl.dropboxusercontent.com/u/52358991/English.zip > Thanks! The DTS fields in this one are all 0 too. ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-30 Thread Marcus Johnson
If you don't mind me asking, what is DTS? because when I hear it I think of the DTS audio codec, but I know it's obviously not that, and googling DTS in the codec context won't get me anywhere. On Sat, Aug 30, 2014 at 6:33 PM, wm4 wrote: > On Sat, 30 Aug 2014 18:16:27 -0400 > Marcus Johnson wr

Re: [FFmpeg-devel] [PATCH] Add SUP/PGS subtitle demuxer

2014-08-30 Thread Timothy Gu
On Sat, Aug 30, 2014 at 9:41 PM, Marcus Johnson wrote: > If you don't mind me asking, what is DTS? because when I hear it I think of > the DTS audio codec, but I know it's obviously not that, and googling DTS > in the codec context won't get me anywhere. DTS = decoding time stamp PTS = presentati