On 2014-07-29 16:15, Michael Niedermayer wrote:
> On Fri, Jul 18, 2014 at 10:57:42AM +0200, Nicolas Martyanoff wrote:
> > Before adding new features, I read the code and cleaned it. The main issue
> > was
> > abstruse identifier names.
> >
> > The behaviour of the muxer is *not* modified, by this
On 2014-07-29 15:59, Michael Niedermayer wrote:
> On Fri, Jul 18, 2014 at 10:57:44AM +0200, Nicolas Martyanoff wrote:
> > Since we need all segments to find out the target duration, we can only
> > generate the playlist after writing all segments.
> >
> > There is no need to rewrite the segment li
On Wed, Jul 30, 2014 at 02:18:48AM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> ffprobe.c | 22 +-
> 1 file changed, 21 insertions(+), 1 deletion(-)
>
I believe this is missing doc/ffprobe.xsd updates.
> diff --git a/ffprobe.c b/ffprobe.c
Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
>The libavfilter API
> for EOF is ok,
No, it is not.
> So if you're not actually fixing anything
I am.
> What wrong result?
See my first answer when you started this bikeshedding.
Reg
Michael Niedermayer gmx.at> writes:
> LGTM
Ping.
Please add a comment about ticket #3779 to the commit message.
Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Le duodi 12 thermidor, an CCXXII, Carl Eugen Hoyos a écrit :
> Ping.
>
> Please add a comment about ticket #3779 to the commit message.
Done and pushed to my tree for anyone to merge.
(It did not seem urgent, I was waiting to bundle it with other patches to
save time to the merger. Or are there
Signed-off-by: Michael Niedermayer
---
doc/ffprobe.xsd | 11 +++
ffprobe.c | 21 -
2 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
index 9ef9ecb..e0e9179 100644
--- a/doc/ffprobe.xsd
+++ b/doc/ffprobe.xsd
@@ -5
On Wed, Jul 30, 2014 at 10:30:29AM +0200, Nicolas Martyanoff wrote:
> On 2014-07-29 15:59, Michael Niedermayer wrote:
> > On Fri, Jul 18, 2014 at 10:57:44AM +0200, Nicolas Martyanoff wrote:
> > > Since we need all segments to find out the target duration, we can only
> > > generate the playlist aft
Hi,
Here's a patch adding ASM transform_add functions for HEVC.
Regards,
Pierre-Edouard Leperecommit 1db36e2f5bae3a34d1a5db4520234b52afb51bbb
Author: plepere
Date: Wed Jul 30 10:31:49 2014 +0200
adding ASM transform_add functions for HEVC
diff --git a/libavcodec/x86/Makefile b/libavcodec
Le sextidi 6 thermidor, an CCXXII, Nicolas George a écrit :
> Le sextidi 6 thermidor, an CCXXII, Michael Niedermayer a écrit :
> > the 4 patch set seems to break fate
> > TESTswr-resample-s16p-48000-2626
> > stddev:3.88 PSNR: 84.54 MAXDIFF: 15 bytes:96000/20416
> > Test swr-resamp
On Wed, Jul 30, 2014 at 03:12:19PM +0200, Nicolas George wrote:
> Le duodi 12 thermidor, an CCXXII, Carl Eugen Hoyos a écrit :
> > Ping.
> >
> > Please add a comment about ticket #3779 to the commit message.
>
> Done and pushed to my tree for anyone to merge.
merged
>
> (It did not seem urgen
Hi!
On Wed, Jul 30, 2014 at 9:33 AM, Pierre Edouard Lepere <
pierre-edouard.lep...@insa-rennes.fr> wrote:
> Here's a patch adding ASM transform_add functions for HEVC.
Yay! I'll try to review soon. Do you have rough performance metrics? I know
it's faster :-p but it's nice to document by how mu
On Wed, Jul 30, 2014 at 03:52:34PM +0200, Nicolas George wrote:
> Le sextidi 6 thermidor, an CCXXII, Nicolas George a écrit :
> > Le sextidi 6 thermidor, an CCXXII, Michael Niedermayer a écrit :
> > > the 4 patch set seems to break fate
> > > TESTswr-resample-s16p-48000-2626
> > > stddev:3.
On Wed, Jul 30, 2014 at 05:14:07PM +0200, Michael Niedermayer wrote:
> On Wed, Jul 30, 2014 at 03:52:34PM +0200, Nicolas George wrote:
> > Le sextidi 6 thermidor, an CCXXII, Nicolas George a écrit :
> > > Le sextidi 6 thermidor, an CCXXII, Michael Niedermayer a écrit :
> > > > the 4 patch set seems
On date Wednesday 2014-07-30 15:21:06 +0200, Michael Niedermayer encoded:
> Signed-off-by: Michael Niedermayer
> ---
> doc/ffprobe.xsd | 11 +++
> ffprobe.c | 21 -
> 2 files changed, 31 insertions(+), 1 deletion(-)
>
> diff --git a/doc/ffprobe.xsd b/doc/ffp
On Wed, 30 Jul 2014 10:37:12 +0200
Nicolas George wrote:
> Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> > The libavfilter API
> > for EOF is ok,
>
> No, it is not.
You never explained what's wrong with it.
> > So if you're not actua
Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> You never explained what's wrong with it.
This is tiring. Everyone knows it already and it has been explained numerous
times.
THERE IS NO TIMESTAMP FOR THE END OF STREAM.
Is it enough, or do I have to waste more time explaining how that makes the
On Wed, 30 Jul 2014 19:10:04 +0200
Nicolas George wrote:
> Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> > You never explained what's wrong with it.
>
> This is tiring. Everyone knows it already and it has been explained numerous
> times.
>
> THERE IS NO TIMESTAMP FOR THE END OF STREAM.
Yo
On Wed, Jul 30, 2014 at 02:18:47AM +0200, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer
> ---
> libavutil/frame.c | 14 ++
> libavutil/frame.h |5 +
> 2 files changed, 19 insertions(+)
patch applied with APIChages & version bump
[...]
--
Michael GnuP
On Wed, Jul 30, 2014 at 05:21:15PM +0200, Stefano Sabatini wrote:
> On date Wednesday 2014-07-30 15:21:06 +0200, Michael Niedermayer encoded:
> > Signed-off-by: Michael Niedermayer
> > ---
> > doc/ffprobe.xsd | 11 +++
> > ffprobe.c | 21 -
> > 2 files change
Le duodi 12 thermidor, an CCXXII, wm4 a écrit :
> Demuxers and decoding don't return such an end PTS, so why should
> filters? Demuxers apparently use the frame duration to time the last
> frame, so why not use that in lavfi too? (Demuxers also report the
> total length, but that is probably not us
Signed-off-by: Reimar Döffinger
---
libavutil/dict.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavutil/dict.c b/libavutil/dict.c
index 358958c..aea8910 100644
--- a/libavutil/dict.c
+++ b/libavutil/dict.c
@@ -90,10 +90,9 @@ int av_dict_set(AVDictionary **pm, const
This allows getting rid of the many, slightly differing, implementations
of basically the same thing.
Signed-off-by: Reimar Döffinger
---
doc/APIchanges | 3 +++
ffmpeg_opt.c | 12 +++-
ffplay.c | 2 +-
libavfilter/vf_bbox.c
Unfortunately this was not explicitly documented and thus
might be very risky.
But basically all uses I saw in FFmpeg had a memleak in these
cases.
Signed-off-by: Reimar Döffinger
---
libavutil/dict.c | 9 +++--
libavutil/dict.h | 2 ++
2 files changed, 9 insertions(+), 2 deletions(-)
diff
Ensure this is even the case if they are empty because
we failed adding the first entry.
Signed-off-by: Reimar Döffinger
---
libavutil/dict.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavutil/dict.c b/libavutil/dict.c
index 2cd67e8..9063a57 100644
--- a/libavutil/dict.c
+++ b/lib
On Tue, Jul 29, 2014 at 10:13:39PM +0200, Michael Niedermayer wrote:
> On Tue, Jul 29, 2014 at 09:26:48PM +0200, Reimar Döffinger wrote:
> > Unfortunately this was not explicitly documented and thus
> > might be very risky.
> > But basically all uses I saw in FFmpeg had a memleak in these
> > cases
On 30/07/14 10:33 AM, Pierre Edouard Lepere wrote:
> Hi,
>
> Here's a patch adding ASM transform_add functions for HEVC.
>
> Regards,
> Pierre-Edouard Lepere
Some remarks below.
> diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
> index 7469293..658ad5e 100644
> --- a/libavcodec/x
---
doc/indevs.texi | 15 +++
1 file changed, 15 insertions(+)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index 4ca12ff..e0e7e67 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -483,6 +483,21 @@ ffplay -f lavfi
"movie=test.avi[out0];amovie=test.wav[out1]"
@end itemize
On Wed, Jul 30, 2014 at 08:38:06PM +0200, Reimar Döffinger wrote:
> This allows getting rid of the many, slightly differing, implementations
> of basically the same thing.
This one really can need a few extra eyes.
It's likely I missed a few places, and there's a risk I messed up one
or the other
On 7/30/2014 6:10 PM, Nicolas George wrote:
> This is tiring. Everyone knows it already and it has been explained numerous
> times.
Yeah, why should you have to explain the reason for a change in
a review of that change? How silly. I should just divine the reason
why. I guess we don't count as "ev
On Wed, 30 Jul 2014 20:38:06 +0200
Reimar Döffinger wrote:
> This allows getting rid of the many, slightly differing, implementations
> of basically the same thing.
>
> Signed-off-by: Reimar Döffinger
> ---
> doc/APIchanges | 3 +++
> ffmpeg_opt.c | 12 ++
Le 30 juil. 2014 à 16:35, Ronald S. Bultje a écrit :
> Hi!
>
> On Wed, Jul 30, 2014 at 9:33 AM, Pierre Edouard Lepere <
> pierre-edouard.lep...@insa-rennes.fr> wrote:
>
>> Here's a patch adding ASM transform_add functions for HEVC.
>
>
> Yay! I'll try to review soon. Do you have rough perfor
On Wed, Jul 30, 2014 at 09:22:27PM +0200, wm4 wrote:
> > /**
> > @@ -123,6 +125,12 @@ int av_dict_count(const AVDictionary *m);
> > int av_dict_set(AVDictionary **pm, const char *key, const char *value, int
> > flags);
> >
> > /**
> > + * Convenience wrapper for av_dict_set that converts the
On 30/07/14 10:33 AM, Pierre Edouard Lepere wrote:
> +%macro TR_ADD_INIT_SSE_8 2
> +movu m4, [r1]
> +movu m6, [r1+16]
> +movu m8, [r1+32]
> +movu m10, [r1+48]
You can use mova here, and probably in every other movu as well.
> +
Hi,
On Wed, Jul 30, 2014 at 5:04 PM, James Almer wrote:
> On 30/07/14 10:33 AM, Pierre Edouard Lepere wrote:
>
> > +%macro TR_ADD_INIT_SSE_8 2
> > +movu m4, [r1]
> > +movu m6, [r1+16]
> > +movu m8, [r1+32]
> > +movu m10, [r1+48]
+int av_dict_set_int(AVDictionary **pm, const char *key, int64_t value,
+int flags)
+{
+char valuestr[22];
+snprintf(valuestr, sizeof(valuestr), "%"PRId64, value);
+return av_dict_set_int(pm, key, valuestr, flags);
+}
I guess it's infinite recurrence. ffplay crashes
On 30.07.2014 23:16, Lukasz Marek wrote:
+int av_dict_set_int(AVDictionary **pm, const char *key, int64_t value,
+int flags)
+{
+char valuestr[22];
+snprintf(valuestr, sizeof(valuestr), "%"PRId64, value);
+return av_dict_set_int(pm, key, valuestr, flags);
+}
I gues
On 30/07/14 6:12 PM, Ronald S. Bultje wrote:
> Why all these memory round-trips?
>
> Ronald
What do you suggest? I only simplified the function without trying to
refactor it much.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/
Metaframes are frames without data, identified by a negative
format code, used to carry special conditions.
They are sent only to filter that declare supporting them.
The only metaframe for now is EOF; this mechanism augments
the current mechanism based on request_frame() returning
AVERROR_EOF, wit
Also deprecate adding a NULL frame to mark EOF.
TODO APIchanges entry, version bump.
Signed-off-by: Nicolas George
---
libavfilter/buffersrc.c | 40 ++--
libavfilter/buffersrc.h | 15 +++
2 files changed, 45 insertions(+), 10 deletions(-)
diff --
Signed-off-by: Nicolas George
---
ffmpeg.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/ffmpeg.c b/ffmpeg.c
index 1c1a559..3ac6620 100644
--- a/ffmpeg.c
+++ b/ffmpeg.c
@@ -1741,12 +1741,9 @@ static int decode_audio(InputStream *ist, AVPacket *pkt,
int *got_
This makes the FPS filter duplicate the last frame to take
its duration into account, exactly like the other ones.
TODO find corresponding trac ticket(s).
Signed-off-by: Nicolas George
---
libavfilter/vf_fps.c | 58 +++-
1 file changed, 39 inserti
Le duodi 12 thermidor, an CCXXII, Derek Buitenhuis a écrit :
> Yeah, why should you have to explain the reason for a change in
> a review of that change? How silly. I should just divine the reason
> why. I guess we don't count as "everyone".
To review a change, the minimum is to read it. The answe
Le duodi 12 thermidor, an CCXXII, Michael Niedermayer a écrit :
> heres some valgrind output:
Thanks for the precisions. I was unable to reproduce any of it, despite
running FATE through valgrind. Either the bug went away when I changed the
allocation of the frame or there is something very strang
Signed-off-by: Timothy Gu
---
FATE.pm | 130 --
fate.css| 154 ++--
history.cgi | 32 +++--
index.cgi | 117 -
report.cgi | 46 +
On Wed, Jul 30, 2014 at 10:25:45AM +0200, Nicolas Martyanoff wrote:
> On 2014-07-29 16:15, Michael Niedermayer wrote:
> > On Fri, Jul 18, 2014 at 10:57:42AM +0200, Nicolas Martyanoff wrote:
> > > Before adding new features, I read the code and cleaned it. The main
> > > issue was
> > > abstruse id
Am Mittwoch 30 Juli 2014, 01:53:32 schrieb Gerion Entrup:
> ---
> doc/indevs.texi | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/doc/indevs.texi b/doc/indevs.texi
> index 4ca12ff..e0e7e67 100644
> --- a/doc/indevs.texi
> +++ b/doc/indevs.texi
> @@ -483,6 +483,21 @@ ffpl
On Mon, 28 Jul 2014 17:46:33 -0400, Reynaldo H. Verdejo Pinochet wrote:
> Once posted, it would be great if you can set aside 2 minutes to
> tweet/blogpost/whatever about it so it gets noticed. We need all the
> $ help we can get.
I mentioned this at https://twitter.com/FFmpeg
Lou
__
On Thu, Jul 31, 2014 at 01:14:30AM +0200, Gerion Entrup wrote:
> Am Mittwoch 30 Juli 2014, 01:53:32 schrieb Gerion Entrup:
> > ---
> > doc/indevs.texi | 15 +++
> > 1 file changed, 15 insertions(+)
> >
> > diff --git a/doc/indevs.texi b/doc/indevs.texi
> > index 4ca12ff..e0e7e67 10064
On Wed, Jul 30, 2014 at 08:38:05PM +0200, Reimar Döffinger wrote:
> Signed-off-by: Reimar Döffinger
> ---
> libavutil/dict.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
LGTM
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Asymptotically faster
On Wed, Jul 30, 2014 at 11:44:46PM +0200, Nicolas George wrote:
> Metaframes are frames without data, identified by a negative
> format code, used to carry special conditions.
> They are sent only to filter that declare supporting them.
> The only metaframe for now is EOF; this mechanism augments
>
51 matches
Mail list logo
