Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-10 Thread John Stebbins
On Fri, 2020-04-10 at 09:50 -0700, Philip Langdale wrote: > On Thu, 9 Apr 2020 23:28:49 + > John Stebbins wrote: > > > > Essentially yes. We've had our own mov text encoder and decoder in > > HandBrake for years. I added support for using ffmpeg for decoding > > subtitles last year but the

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-10 Thread Philip Langdale
On Thu, 9 Apr 2020 23:28:49 + John Stebbins wrote: > Essentially yes. We've had our own mov text encoder and decoder in > HandBrake for years. I added support for using ffmpeg for decoding > subtitles last year but the movtext decoder wasn't up to the same > level as ours, so we weren't us

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-09 Thread John Stebbins
On Thu, 2020-04-09 at 14:00 -0700, Philip Langdale wrote: > On Thu, 9 Apr 2020 19:30:53 + > John Stebbins wrote: > > Pushed to https://github.com/jstebbins/FFmpeg/commits/movtext > > > > There's one additional patch on the top implementing what we > > discussed > > about highlight alpha updat

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-09 Thread Philip Langdale
On Thu, 9 Apr 2020 19:30:53 + John Stebbins wrote: > > Pushed to https://github.com/jstebbins/FFmpeg/commits/movtext > > There's one additional patch on the top implementing what we discussed > about highlight alpha updates. Should I send that to the ml as well? > The new one looks good t

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-09 Thread John Stebbins
On Thu, 2020-04-09 at 11:17 -0700, Philip Langdale wrote: > On Thu, 9 Apr 2020 15:51:23 + > John Stebbins wrote: > > > On Wed, 2020-04-08 at 12:24 -0700, Philip Langdale wrote: > > > On Tue, 7 Apr 2020 14:38:52 + > > > John Stebbins wrote: > > > > > > > After checking carefully, patch

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-09 Thread Philip Langdale
On Thu, 9 Apr 2020 15:51:23 + John Stebbins wrote: > On Wed, 2020-04-08 at 12:24 -0700, Philip Langdale wrote: > > On Tue, 7 Apr 2020 14:38:52 + > > John Stebbins wrote: > > > > > After checking carefully, patches 10 and 23 are as I want them. > > > Sizes > > > are relative to 288 whe

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-09 Thread John Stebbins
On Wed, 2020-04-08 at 12:24 -0700, Philip Langdale wrote: > On Tue, 7 Apr 2020 14:38:52 + > John Stebbins wrote: > > > After checking carefully, patches 10 and 23 are as I want them. > > Sizes > > are relative to 288 when using override APIs, but are relative to > > PlayResY when processing t

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-08 Thread Philip Langdale
On Tue, 7 Apr 2020 14:38:52 + John Stebbins wrote: > > After checking carefully, patches 10 and 23 are as I want them. Sizes > are relative to 288 when using override APIs, but are relative to > PlayResY when processing the script. > > On the other hand, patch 20 needs a fix. If the cancel

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-07 Thread John Stebbins
On Mon, 2020-04-06 at 15:03 -0700, John Stebbins wrote: > On Mon, 2020-04-06 at 13:16 -0700, Philip Langdale wrote: > > On Mon, 6 Apr 2020 11:51:55 -0600 > > John Stebbins wrote: > > > > > Patch series adds more complete decoding and encoding of color, > > > alpha, > > > font size, font name, and

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-06 Thread John Stebbins
On Mon, 2020-04-06 at 13:16 -0700, Philip Langdale wrote: > On Mon, 6 Apr 2020 11:51:55 -0600 > John Stebbins wrote: > > > Patch series adds more complete decoding and encoding of color, > > alpha, > > font size, font name, and style tags for movtext. It also fixes a > > number of bugs. > > >

Re: [FFmpeg-devel] movtext decode/encode improvements

2020-04-06 Thread Philip Langdale
On Mon, 6 Apr 2020 11:51:55 -0600 John Stebbins wrote: > Patch series adds more complete decoding and encoding of color, alpha, > font size, font name, and style tags for movtext. It also fixes a > number of bugs. > Hi John, Thanks for doing all of this! I'll try and take a look at these over