On Wed, 2020-04-08 at 12:24 -0700, Philip Langdale wrote: > On Tue, 7 Apr 2020 14:38:52 +0000 > John Stebbins <jstebb...@jetheaddev.com> wrote: > > > After checking carefully, patches 10 and 23 are as I want them. > > Sizes > > are relative to 288 when using override APIs, but are relative to > > PlayResY when processing the script. > > > > On the other hand, patch 20 needs a fix. If the cancel overrides > > does > > not specify a style, it *should* restore the ASS style of the > > current > > dialog, but instead it is returning to the mp4 default style. > > Thanks. I've gone through them all, and I've only had a few minor > comments. Will you need me to push these once they are finalised? > >
Thanks to you as well. Yes, when we're all finished with reviews please commit. I don't have commit access. I have a few comments by you to resolve (patches 18 and 22) and one by Nicolas regarding indentation in patch 1. If I have to change the indentation in patch 1, it'll percolate through a few other patches that touch the same code. So I'll have to resend those, or I can just fix the indentation as a final patch on top? _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
