Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-29 Thread Paul B Mahol
On 3/18/17, Martin Vignali wrote: >> >> Just a nitpick: >> >> > +} else { >> > +//UINT 32 >> >> The comment indicates this should be "else if (pixel_type == UINT)" >> >> Not sure it's necessary to replace else by else if, because OpenExr > "planar" can only have half, float or

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-29 Thread Martin Vignali
2017-03-27 10:10 GMT+02:00 Carl Eugen Hoyos : > 2017-03-25 13:09 GMT+01:00 Martin Vignali : > > Ping for apply > > Please send your public key to Michael and ask him to add you > as committer, you have many commits in FFmpeg. > > Hello, I'm not enough familiar with git, to be a commiter. Martin

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-27 Thread Carl Eugen Hoyos
2017-03-25 13:09 GMT+01:00 Martin Vignali : > Ping for apply Please send your public key to Michael and ask him to add you as committer, you have many commits in FFmpeg. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-25 Thread Martin Vignali
Ping for apply Martin ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-18 Thread Martin Vignali
> > Just a nitpick: > > > +} else { > > +//UINT 32 > > The comment indicates this should be "else if (pixel_type == UINT)" > > Not sure it's necessary to replace else by else if, because OpenExr "planar" can only have half, float or uint32 data But new patch attach. Martin 0

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-18 Thread Carl Eugen Hoyos
2017-03-07 23:05 GMT+01:00 Martin Vignali : > Hello, > > In attach patch for decoding uint32 channels in exr files. > > Following previous comments, i doesn't use float/color transformation for > this kind of pixel data > in this new version. > > Comments welcome Just a nitpick: > +} else

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-18 Thread Paul B Mahol
On 3/18/17, Martin Vignali wrote: > 2017-03-07 23:05 GMT+01:00 Martin Vignali : > >> Hello, >> >> In attach patch for decoding uint32 channels in exr files. >> >> Following previous comments, i doesn't use float/color transformation for >> this kind of pixel data >> in this new version. >> >> Comm

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32

2017-03-18 Thread Martin Vignali
2017-03-07 23:05 GMT+01:00 Martin Vignali : > Hello, > > In attach patch for decoding uint32 channels in exr files. > > Following previous comments, i doesn't use float/color transformation for > this kind of pixel data > in this new version. > > Comments welcome > > Martin Vignali > Jokyo Images

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32 channel decoding with pxr24

2016-11-24 Thread Andreas Cadhalpun
On 17.11.2016 21:30, Martin Vignali wrote: > From c70a83c38cd9a9434e6434d60dadf0a1c809e074 Mon Sep 17 00:00:00 2001 > From: Martin Vignali > Date: Thu, 17 Nov 2016 21:24:42 +0100 > Subject: [PATCH 2/3] libavcodec/exr : add support for uint32 channel decoding > with pxr24 > > Doesn't decode the u

Re: [FFmpeg-devel] libavcodec/exr : add support for uint32 channel decoding with pxr24

2016-11-24 Thread Martin Vignali
2016-11-17 21:30 GMT+01:00 Martin Vignali : > Hello, > > In attach a patch, who fix the decoding of half (or float) layer with > pxr24 compression, when there is also an uint32 layer. > > The uint32 layer is still not decodable. > > Found by Andreas Cadhalpun > > sample can be found here : > https

Re: [FFmpeg-devel] libavcodec/exr : Add support for UINT32

2016-04-04 Thread Martin Vignali
2016-04-03 21:11 GMT+02:00 Martin Vignali : > > > 2016-04-03 21:03 GMT+02:00 Paul B Mahol : > >> On 4/3/16, Martin Vignali wrote: >> > 2016-04-03 19:31 GMT+02:00 wm4 : >> > >> >> On Sun, 3 Apr 2016 19:19:25 +0200 >> >> Paul B Mahol wrote: >> >> >> >> > On 4/3/16, Martin Vignali wrote: >> >> > >

Re: [FFmpeg-devel] libavcodec/exr : Add support for UINT32

2016-04-03 Thread Martin Vignali
2016-04-03 21:03 GMT+02:00 Paul B Mahol : > On 4/3/16, Martin Vignali wrote: > > 2016-04-03 19:31 GMT+02:00 wm4 : > > > >> On Sun, 3 Apr 2016 19:19:25 +0200 > >> Paul B Mahol wrote: > >> > >> > On 4/3/16, Martin Vignali wrote: > >> > > Hello, > >> > > > >> > > In attach a patch to add support f

Re: [FFmpeg-devel] libavcodec/exr : Add support for UINT32

2016-04-03 Thread Paul B Mahol
On 4/3/16, Martin Vignali wrote: > 2016-04-03 19:31 GMT+02:00 wm4 : > >> On Sun, 3 Apr 2016 19:19:25 +0200 >> Paul B Mahol wrote: >> >> > On 4/3/16, Martin Vignali wrote: >> > > Hello, >> > > >> > > In attach a patch to add support for UINT32 pixel type. >> > > >> > > Sample of UINT 32 file (sca

Re: [FFmpeg-devel] libavcodec/exr : Add support for UINT32

2016-04-03 Thread Martin Vignali
2016-04-03 19:31 GMT+02:00 wm4 : > On Sun, 3 Apr 2016 19:19:25 +0200 > Paul B Mahol wrote: > > > On 4/3/16, Martin Vignali wrote: > > > Hello, > > > > > > In attach a patch to add support for UINT32 pixel type. > > > > > > Sample of UINT 32 file (scanline only in that case) can be found here : >

Re: [FFmpeg-devel] libavcodec/exr : Add support for UINT32

2016-04-03 Thread wm4
On Sun, 3 Apr 2016 19:19:25 +0200 Paul B Mahol wrote: > On 4/3/16, Martin Vignali wrote: > > Hello, > > > > In attach a patch to add support for UINT32 pixel type. > > > > Sample of UINT 32 file (scanline only in that case) can be found here : > > https://we.tl/sFB0NYlQVW > > > > For colorproces

Re: [FFmpeg-devel] libavcodec/exr : Add support for UINT32

2016-04-03 Thread Paul B Mahol
On 4/3/16, Martin Vignali wrote: > Hello, > > In attach a patch to add support for UINT32 pixel type. > > Sample of UINT 32 file (scanline only in that case) can be found here : > https://we.tl/sFB0NYlQVW > > For colorprocessing, UINT32, are converted to float, and follow a similar > way for color

Re: [FFmpeg-devel] libavcodec/exr : Add support for UINT32

2016-04-03 Thread Derek Buitenhuis
On 4/3/2016 5:58 PM, Martin Vignali wrote: > Hello, > > In attach a patch to add support for UINT32 pixel type. [...] > +#ifndef UINT32_MAX > +#define UINT32_MAX (0x) > +#endif Don't do this, we already require this header be present and working. - Derek __