On Mon, Nov 24, 2014 at 11:20:25AM -0500, Vadim Kalinsky wrote:
>
> > Nit: space after commas.
>
> > Is it necessary to typedef the structure on top of declaring it? In C,
> > this: {...} is legal, no need to typedef it.
>
>
> > Apart from that, I think the helper structure should be scoped in
> Nit: space after commas.
> Is it necessary to typedef the structure on top of declaring it? In C, this:
> {...} is legal, no need to typedef it.
> Apart from that, I think the helper structure should be scoped in the
> ff_namespace
> Nit: no empty line between doxy and declaration.
Patch
On Fri, 21 Nov 2014 13:43:20 -0500
Vadim Kalinsky wrote:
> C++ does not support anonymous struct.
>
Proposed an alternative patch ([PATCH] avutil/bprint: make header work
with C++, simplify).
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http:
Le tridi 3 frimaire, an CCXXIII, Vadim Kalinsky a écrit :
> Yep, my bad.
Thanks for the updated patch.
> Maybe I'm little contaminated with modern PLs, but I don't see huge
> difference in readability between the old and the new versions. Both are
> terrible :-)
At least, this one, I can actuall
> identifiers starting with a double
> underscode are reserved for the implementation, and therefore can not be
> used.
Yep, my bad.
> Apart from the fact that it makes the macro hackery vastly less readable
> (maybe some indentation would help),
Maybe I'm little contaminated with modern PLs,
On Fri, 21 Nov 2014 21:42:35 +0100
Nicolas George wrote:
> Le primidi 1er frimaire, an CCXXIII, Vadim Kalinsky a écrit :
> > bprint.h can't be included in C++ code
> > C++ does not support anonymous struct.
>
> Thanks for the patch.
>
> Basically, bprint.h is not meant to be included in c++ cod
On Fri, 21 Nov 2014 21:42:35 +0100
Nicolas George wrote:
> Le primidi 1er frimaire, an CCXXIII, Vadim Kalinsky a écrit :
> > bprint.h can't be included in C++ code
> > C++ does not support anonymous struct.
>
> Thanks for the patch.
>
> Basically, bprint.h is not meant to be included in c++ cod
Le primidi 1er frimaire, an CCXXIII, Vadim Kalinsky a écrit :
> bprint.h can't be included in C++ code
> C++ does not support anonymous struct.
Thanks for the patch.
Basically, bprint.h is not meant to be included in c++ code.
> From a45cc83a807e7eabf158ddff52751171e80874f8 Mon Sep 17 00:00:00 2
