On Mon, Nov 24, 2014 at 11:20:25AM -0500, Vadim Kalinsky wrote:
>
> > Nit: space after commas.
>
> > Is it necessary to typedef the structure on top of declaring it? In C,
> > this: {...} is legal, no need to typedef it.
>
>
> > Apart from that, I think the helper structure should be scoped in the
> > ff_namespace
>
> > Nit: no empty line between doxy and declaration.
>
>
> Patch attached.
> > bprint.h | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > 67c639aed01a92890730c7b2cfd85d87baaf4fb4 0001-Squashed-commits.patch > From 36e9b54ca13038d739618d6321006e09a5b83415 Mon Sep 17 00:00:00 2001 > From: Vadim Kalinsky <va...@kalinsky.ru> > Date: Mon, 24 Nov 2014 10:38:05 -0500 > Subject: [PATCH] Squashed commits applied thanks [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB If a bugfix only changes things apparently unrelated to the bug with no further explanation, that is a good sign that the bugfix is wrong.
signature.asc
Description: Digital signature
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
