On Wed, Nov 01, 2017 at 05:49:48PM +, Breeden, Joshua wrote:
> > No but I wonder if the variables "y" and "t" can have more useful names
> > (that may or may not make the comment unneeded),
>
> I've made the variable names more self-explanatory and condensed the comments
>
> > Please do not r
> No but I wonder if the variables "y" and "t" can have more useful names
> (that may or may not make the comment unneeded),
I've made the variable names more self-explanatory and condensed the comments
> Please do not remove the empty line.
And fixed this as well.
Thanks,
Joshua BreedenFrom 6
2017-11-01 16:18 GMT+01:00 Breeden, Joshua :
>> Your patches contain a lot of trailing whitespace (afaict...)
>> that cannot be committed to our repository, please remove it.
>
> Thanks for pointing this out. I've attached new patches to fix this problem.
> patcheck complains about my non-doxy com
> Your patches contain a lot of trailing whitespace (afaict...)
> that cannot be committed to our repository, please remove it.
Thanks for pointing this out. I've attached new patches to fix this problem.
patcheck complains about my non-doxy comments, and about possible unused
variables. Variabl
2017-10-31 19:53 GMT+01:00 Breeden, Joshua :
> Hello,
>
> First patch submission... hopefully I do all of this correctly.?
Your patches contain a lot of trailing whitespace (afaict...)
that cannot be committed to our repository, please remove it.
To find it you can use the script "tools/patcheck"
