On Wed, Nov 01, 2017 at 05:49:48PM +0000, Breeden, Joshua wrote:
> > No but I wonder if the variables "y" and "t" can have more useful names
> > (that may or may not make the comment unneeded),
> 
> I've made the variable names more self-explanatory and condensed the comments
> 
> > Please do not remove the empty line.
> 
> And fixed this as well.
> 
> Thanks,
> 
> Joshua Breeden

>  h264.h       |    1 +
>  h264_parse.c |    6 ++++++
>  2 files changed, 7 insertions(+)
> b92e905eedab047e752f8e539f9bafff0e0dba09  
> 0001-Parse-NAL-type-15-subset-SPS-in-H.264-extradata.patch
> From 65b33b5ed716712118d6cc9a9a0b3b6c260daa03 Mon Sep 17 00:00:00 2001
> From: Joshua Breeden <jbree...@me.com>
> Date: Wed, 1 Nov 2017 13:27:20 -0400
> Subject: [PATCH 1/2] Parse NAL type 15 (subset SPS) in H.264 extradata

can you add a fate test for this ?

(i assume a test for rtp would be hard but if not, that would be
 welcome too)

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf

Attachment: signature.asc
Description: Digital signature

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Reply via email to