Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 5:22 PM, Ronald S. Bultje wrote: > Hello, > [...] > >> +#define DAALA_QM_SCALE (1 << 15) >> +#define DAALA_QM_SCALE_MAX (DAALA_QM_SCALE - 1) >> +#define DAALA_QM_SCALE_UNIT (1.0f/DAALA_QM_SCALE_MAX) >> +#define DAALA_QM_INV_SCALE (1 << 12) >> +#define DAALA_QM_INV_SCALE_UNIT

Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-06 Thread Ronald S. Bultje
Hello, On Sat, Jan 2, 2016 at 12:56 PM, Rostislav Pehlivanov wrote: > @@ -864,6 +865,7 @@ OBJS-$(CONFIG_BMP_PARSER) += bmp_parser.o > OBJS-$(CONFIG_CAVSVIDEO_PARSER)+= cavs_parser.o > OBJS-$(CONFIG_COOK_PARSER) += cook_parser.o > OBJS-$(CONFIG_DCA_PARSER)

Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-04 Thread Rostislav Pehlivanov
>This can still overflow to -256 causing the following line to crash. >A first step towards fixing this would be to replace '2*(*ex) >> 8' >with '*ex >> 7'. That has the same result whenever the first expression >is not undefined and should be faster, as well. ;) >This prevents most of these crashe

Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-03 Thread Andreas Cadhalpun
On 02.01.2016 18:56, Rostislav Pehlivanov wrote: > --- /dev/null > +++ b/libavcodec/daala_entropy.h > @@ -0,0 +1,464 @@ [...] > +/* Expectation value is in Q16 */ > +static inline int daalaent_decode_generic(DaalaEntropy *e, DaalaCDF *c, int > *ex, > + int

Re: [FFmpeg-devel] [RFC v5] libavcodec: add a native Daala decoder

2016-01-02 Thread James Almer
On 1/2/2016 2:56 PM, Rostislav Pehlivanov wrote: > diff --git a/libavcodec/daala_pvq.h b/libavcodec/daala_pvq.h > new file mode 100644 > index 000..23c833e > --- /dev/null > +++ b/libavcodec/daala_pvq.h [...] > +/* q: quantizer, qm = bitstream_header->pvq_qm[p] */ > +static void daalapvq_deco