Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-08 Thread wm4
On Sat, 9 Aug 2014 01:28:05 -0400 compn wrote: > On Mon, 04 Aug 2014 19:58:52 +0200 > Gisle Sælensminde wrote: > > > I'm trying to add support for closed captions in ffmpeg, namely > > cea608 and cea708. > > mythtv fork of ffmpeg has this support already. maybe we can port it > (along with som

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-08 Thread compn
On Mon, 04 Aug 2014 19:58:52 +0200 Gisle Sælensminde wrote: > I'm trying to add support for closed captions in ffmpeg, namely > cea608 and cea708. mythtv fork of ffmpeg has this support already. maybe we can port it (along with some other changes)? https://code.mythtv.org/trac/browser http://s

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 10:16:25PM +0200, Gisle Sælensminde wrote: > Den 04. aug. 2014 21:58, skrev Reimar Döffinger: > >*scratches head* I wonder now if you misunderstood or if you discarded the > >variant I pointed out due to effort/complexity? > > Or because I don't know all the parts of the ff

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Gisle Sælensminde
Den 04. aug. 2014 21:58, skrev Reimar Döffinger: *scratches head* I wonder now if you misunderstood or if you discarded the variant I pointed out due to effort/complexity? Or because I don't know all the parts of the ffmpeg code well enough. Since both you and others has suggested that this is

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 09:35:02PM +0200, Gisle Sælensminde wrote: > Bitstream filter: > > Pro: > > - Modular, the CC code can be kept separate. > - Less complex code > > Cons: > > Need for features that I can't see is present in the bitstream filters: > - As far as I can see -no support for ti

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Kieran Kunhya
> into the decoders. The decoder approch would also not work for insertion of > closed captions (for h.264 that would be x264, and I can't see that CC has a > place there really). I'm uncertain enough that I would prefere to here the > opinion here before submitting a patch. As far as I can see it

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Gisle Sælensminde
Den 04. aug. 2014 21:11, skrev Reimar Döffinger: On Mon, Aug 04, 2014 at 08:04:39PM +0100, Kieran Kunhya wrote: And as far as I can tell if you want to remux but with separate subtitle stream that would even mean that you have to re-encode the video for no good reason. You can just swap out the

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Kieran Kunhya
> Uh, no. > The point is to get the CC data out you need to decode. > Now that you have the video decoded, if you want to mux it you have > to encode it again. Whether you decode the video or not is unrelated to your ability to replace the SEI and replace the captions. You'd still need to know the

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 08:51:57PM +0200, wm4 wrote: > On Mon, 4 Aug 2014 20:47:37 +0200 > Reimar Döffinger wrote: > > > On Mon, Aug 04, 2014 at 08:19:38PM +0200, Hendrik Leppkes wrote: > > > Am 04.08.2014 19:59 schrieb "Gisle Sælensminde" : > > > > > > > > I'm trying to add support for closed ca

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 08:04:39PM +0100, Kieran Kunhya wrote: > > And as far as I can tell if you want to remux > > but with separate subtitle stream that would even mean that you have to > > re-encode the video for no good reason. > > You can just swap out the caption data. It's guaranteed to be

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Kieran Kunhya
> And as far as I can tell if you want to remux > but with separate subtitle stream that would even mean that you have to > re-encode the video for no good reason. You can just swap out the caption data. It's guaranteed to be CBR anyway. ___ ffmpeg-devel

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread wm4
On Mon, 4 Aug 2014 20:47:37 +0200 Reimar Döffinger wrote: > On Mon, Aug 04, 2014 at 08:19:38PM +0200, Hendrik Leppkes wrote: > > Am 04.08.2014 19:59 schrieb "Gisle Sælensminde" : > > > > > > I'm trying to add support for closed captions in ffmpeg, namely cea608 and > > > cea708. Unlike normal sub

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Reimar Döffinger
On Mon, Aug 04, 2014 at 08:19:38PM +0200, Hendrik Leppkes wrote: > Am 04.08.2014 19:59 schrieb "Gisle Sælensminde" : > > > > I'm trying to add support for closed captions in ffmpeg, namely cea608 and > > cea708. Unlike normal subtitles, these are embedded in the video frames > > themselves rather t

Re: [FFmpeg-devel] [RFC] Implementation of closed caption support

2014-08-04 Thread Hendrik Leppkes
Am 04.08.2014 19:59 schrieb "Gisle Sælensminde" : > > I'm trying to add support for closed captions in ffmpeg, namely cea608 and > cea708. Unlike normal subtitles, these are embedded in the video frames > themselves rather than a separate track or file. As a first step I try to write > bitstreams f