Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-19 Thread James Almer
On 5/19/2019 4:22 AM, Peter Ross wrote: > On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote: >> On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: >>> ah, i see what you did there! it works perfectly, just missing >>> UPDATE_CACHE at the start and in the loop. >>> >>> test r

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-19 Thread Peter Ross
On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote: > On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: > > ah, i see what you did there! it works perfectly, just missing > > UPDATE_CACHE at the start and in the loop. > > > > test results on i7 decoding 3 minute long 4k vide

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-17 Thread Reimar Döffinger
On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: > ah, i see what you did there! it works perfectly, just missing > UPDATE_CACHE at the start and in the loop. > > test results on i7 decoding 3 minute long 4k video with vp4. Looks fairly close to noise to me, though for me it seemed a bi

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-17 Thread Peter Ross
On Thu, May 16, 2019 at 10:49:41AM -0300, James Almer wrote: > On 5/16/2019 8:35 AM, Peter Ross wrote: > > --- > > > > what's changed: > > * reordered AV_CODEC_ID_VP4 > > * minor read_mb_values improvement (reproducible 0.5% speedup) > > * configure/Makefile fix > > * squished data tables to fill

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-17 Thread Peter Ross
On Thu, May 16, 2019 at 08:52:39PM +0200, Reimar Döffinger wrote: > On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > > On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > > > +static int read_mb_value(GetBitContext *gb) > > > +{ > > > +int v = 1; > > > +int size

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > > +static int read_mb_value(GetBitContext *gb) > > +{ > > +int v = 1; > > +int size; > > +OPEN_READER(re, gb); > > + > > +do { > > +int bit; > >

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 08:00:55PM +0200, Reimar Döffinger wrote: > v = 127 + SHOW_UBITS(re, gb, 7); Sorry typo, must be 129 instead of 127. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread Reimar Döffinger
On Thu, May 16, 2019 at 09:35:00PM +1000, Peter Ross wrote: > +static int read_mb_value(GetBitContext *gb) > +{ > +int v = 1; > +int size; > +OPEN_READER(re, gb); > + > +do { > +int bit; > +size = 0; > + > +UPDATE_CACHE(re, gb); > +bit = SHOW_UBITS(re

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread James Almer
On 5/16/2019 8:35 AM, Peter Ross wrote: > --- > > what's changed: > * reordered AV_CODEC_ID_VP4 > * minor read_mb_values improvement (reproducible 0.5% speedup) > * configure/Makefile fix > * squished data tables to fill 80 columns. > > UNCHECKED_BITSTREAM_READER doesn't give any performance impr