Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-17 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-16 22:02 -0500, Leo Izen wrote: > On 12/16/24 5:50 PM, Michael Niedermayer wrote: [...] > > > (e): Find a input that encodes to max 2 variants and store 2 checksums > > Doesn't fix the problem, which is that need to be aware of all the known > variants and create hacks to work with them

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Ramiro Polla
On Tue, Dec 17, 2024 at 4:02 AM Leo Izen wrote: > On 12/16/24 5:50 PM, Michael Niedermayer wrote: > > > > (c): implement enough of zlib ourselfs, so it can encode to a valid output > > A reimplementation of zlib that does nothing except for fixing FATE > failures that shouldn't be failing anyway s

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Leo Izen
On 12/16/24 5:50 PM, Michael Niedermayer wrote: (c): implement enough of zlib ourselfs, so it can encode to a valid output A reimplementation of zlib that does nothing except for fixing FATE failures that shouldn't be failing anyway sounds like a security vulnerability waiting to happen. Sto

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Ramiro Polla
On Sat, Dec 14, 2024 at 6:39 PM Alexander Strasser via ffmpeg-devel wrote: > On 2024-12-14 11:09 +0100, Anton Khirnov wrote: > > Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56) > > > This is a fixed up version of the series I sent before. IMO there would be no need to revert and

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Michael Niedermayer
Hi On Mon, Dec 16, 2024 at 05:39:22PM -0500, Leo Izen wrote: [...] > Essentially, we shouldn't be having FATE failures agree > depend on the specific > behavior of whatever zlib we link to, provided it's correct. > DEFLATE > promises certain things about its encodes, but one of the things DEFL

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Leo Izen
On 12/16/24 7:20 AM, Michael Niedermayer wrote: Hi On Sat, Dec 14, 2024 at 11:09:00AM +0100, Anton Khirnov wrote: Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56) This is a fixed up version of the series I sent before. This worked for me on Ubuntu 20.04 but probably will b

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-16 Thread Michael Niedermayer
Hi On Sat, Dec 14, 2024 at 11:09:00AM +0100, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56) > > This is a fixed up version of the series I sent before. > > > > This worked for me on Ubuntu 20.04 but probably will break > > with older zlib versions as Hend

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-14 Thread Alexander Strasser via ffmpeg-devel
On 2024-12-14 11:09 +0100, Anton Khirnov wrote: > Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56) > > This is a fixed up version of the series I sent before. > > > > This worked for me on Ubuntu 20.04 but probably will break > > with older zlib versions as Hendrik pointed out in t

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-14 Thread James Almer
On 12/14/2024 7:09 AM, Anton Khirnov wrote: Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56) This is a fixed up version of the series I sent before. This worked for me on Ubuntu 20.04 but probably will break with older zlib versions as Hendrik pointed out in the previous thread

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-14 Thread Anton Khirnov
Quoting Alexander Strasser via ffmpeg-devel (2024-12-01 21:13:56) > This is a fixed up version of the series I sent before. > > This worked for me on Ubuntu 20.04 but probably will break > with older zlib versions as Hendrik pointed out in the > previous thread. Either we must update zlib on affec

Re: [FFmpeg-devel] [PATCH v2 0/3] Make fate tests succeed with zlib-ng

2024-12-06 Thread Michael Niedermayer
Hi On Sun, Dec 01, 2024 at 09:13:56PM +0100, Alexander Strasser via ffmpeg-devel wrote: > This is a fixed up version of the series I sent before. > > This worked for me on Ubuntu 20.04 but probably will break > with older zlib versions as Hendrik pointed out in the > previous thread. Either we m