Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-13 Thread Sun Zhenliang
在 2021年9月8日 +0800 21:48，Sun Zhenliang ，写道： > 在 2021年9月8日 +0800 17:55，Hendrik Leppkes ，写道： > > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > > wrote: > > > > > > Thanks for reviewing. > > > > > > Probing is expecting to find “correct” frames, which includes those kinds > > > of comfort noise and

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-13 Thread Sun Zhenliang
在 2021年9月8日 +0800 22:12，Sun Zhenliang ，写道： > 在 2021年9月8日 +0800 17:10，Paul B Mahol ，写道： > > On Wed, Sep 8, 2021 at 10:56 AM Sun Zhenliang > > wrote: > > > > > 在 2021年9月8日 +0800 16:37，Paul B Mahol ，写道： > > > > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang > > > > > > > wrote: > > > > > > > > > 在 202

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Sun Zhenliang
在 2021年9月8日 +0800 17:10，Paul B Mahol ，写道： > On Wed, Sep 8, 2021 at 10:56 AM Sun Zhenliang > wrote: > > > 在 2021年9月8日 +0800 16:37，Paul B Mahol ，写道： > > > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang > > > > > wrote: > > > > > > > 在 2021年9月8日 +0800 00:14，Paul B Mahol ，写道： > > > > > On Tue, Sep 7, 2

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Sun Zhenliang
在 2021年9月8日 +0800 17:55，Hendrik Leppkes ，写道： > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > wrote: > > > > Thanks for reviewing. > > > > Probing is expecting to find “correct” frames, which includes those kinds > > of comfort noise and NO_DATA frames mentioned in 3GPP Specifications. > > > > B

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Hendrik Leppkes
On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang wrote: > > Thanks for reviewing. > > Probing is expecting to find “correct” frames, which includes those kinds of > comfort noise and NO_DATA frames mentioned in 3GPP Specifications. > > Besides, those frames are considered as normal frames while readi

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Paul B Mahol
On Wed, Sep 8, 2021 at 10:56 AM Sun Zhenliang wrote: > 在 2021年9月8日 +0800 16:37，Paul B Mahol ，写道： > > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang > > > wrote: > > > > > 在 2021年9月8日 +0800 00:14，Paul B Mahol ，写道： > > > > On Tue, Sep 7, 2021 at 4:48 PM Sun Zhenliang < > hisunzhenli...@outlook.com >

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Sun Zhenliang
在 2021年9月8日 +0800 16:37，Paul B Mahol ，写道： > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang > wrote: > > > 在 2021年9月8日 +0800 00:14，Paul B Mahol ，写道： > > > On Tue, Sep 7, 2021 at 4:48 PM Sun Zhenliang > > > > > wrote: > > > > > > > 在 2021年9月7日 +0800 19:13，Paul B Mahol ，写道： > > > > > On Tue, Sep 7, 20

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Paul B Mahol
On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang wrote: > 在 2021年9月8日 +0800 00:14，Paul B Mahol ，写道： > > On Tue, Sep 7, 2021 at 4:48 PM Sun Zhenliang > > > wrote: > > > > > 在 2021年9月7日 +0800 19:13，Paul B Mahol ，写道： > > > > On Tue, Sep 7, 2021 at 11:36 AM Sun Zhenliang < > > > hisunzhenli...@outlook.c

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Sun Zhenliang
在 2021年9月8日 +0800 00:14，Paul B Mahol ，写道： > On Tue, Sep 7, 2021 at 4:48 PM Sun Zhenliang > wrote: > > > 在 2021年9月7日 +0800 19:13，Paul B Mahol ，写道： > > > On Tue, Sep 7, 2021 at 11:36 AM Sun Zhenliang < > > hisunzhenli...@outlook.com> > > > wrote: > > > > > > > 在 2021年9月7日 +0800 14:16，Paul B Mahol ，写

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Paul B Mahol
On Tue, Sep 7, 2021 at 4:48 PM Sun Zhenliang wrote: > 在 2021年9月7日 +0800 19:13，Paul B Mahol ，写道： > > On Tue, Sep 7, 2021 at 11:36 AM Sun Zhenliang < > hisunzhenli...@outlook.com> > > wrote: > > > > > 在 2021年9月7日 +0800 14:16，Paul B Mahol ，写道： > > > > On Tue, Sep 7, 2021 at 7:34 AM Sun Zhenliang < >

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Sun Zhenliang
在 2021年9月7日 +0800 19:13，Paul B Mahol ，写道： > On Tue, Sep 7, 2021 at 11:36 AM Sun Zhenliang > wrote: > > > 在 2021年9月7日 +0800 14:16，Paul B Mahol ，写道： > > > On Tue, Sep 7, 2021 at 7:34 AM Sun Zhenliang > > > > > wrote: > > > > > > > 在 2021年9月7日 +0800 00:55，Paul B Mahol ，写道： > > > > > On Sat, Sep 4, 2

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Paul B Mahol
On Tue, Sep 7, 2021 at 11:36 AM Sun Zhenliang wrote: > 在 2021年9月7日 +0800 14:16，Paul B Mahol ，写道： > > On Tue, Sep 7, 2021 at 7:34 AM Sun Zhenliang > > > wrote: > > > > > 在 2021年9月7日 +0800 00:55，Paul B Mahol ，写道： > > > > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang < > hisunzhenli...@outlook.com >

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Sun Zhenliang
在 2021年9月7日 +0800 14:16，Paul B Mahol ，写道： > On Tue, Sep 7, 2021 at 7:34 AM Sun Zhenliang > wrote: > > > 在 2021年9月7日 +0800 00:55，Paul B Mahol ，写道： > > > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > > > > > wrote: > > > > > > > > > > > > > > > > > On Sep 4, 2021, at 16:01, Hendrik Leppkes > > wr

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-06 Thread Paul B Mahol
On Tue, Sep 7, 2021 at 7:34 AM Sun Zhenliang wrote: > 在 2021年9月7日 +0800 00:55，Paul B Mahol ，写道： > > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > > > wrote: > > > > > > > > > > > > > On Sep 4, 2021, at 16:01, Hendrik Leppkes > wrote: > > > > > > > > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-06 Thread Sun Zhenliang
在 2021年9月7日 +0800 00:55，Paul B Mahol ，写道： > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > wrote: > > > > > > > > > On Sep 4, 2021, at 16:01, Hendrik Leppkes wrote: > > > > > > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang > > wrote: > > > > > > > > Those comfort noise frames and empty frames shou

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-06 Thread Paul B Mahol
On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang wrote: > > > > > On Sep 4, 2021, at 16:01, Hendrik Leppkes wrote: > > > > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang > wrote: > >> > >> Those comfort noise frames and empty frames should be > >> considered the correct frame. And amr.c/amr_read_pack

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-04 Thread Sun Zhenliang
> > On Sep 4, 2021, at 16:01, Hendrik Leppkes wrote: > > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang > wrote: >> >> Those comfort noise frames and empty frames should be >> considered the correct frame. And amr.c/amr_read_packet() >> also takes them as correct frames too. >> >> Signed-off-

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-04 Thread Hendrik Leppkes
On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang wrote: > > Those comfort noise frames and empty frames should be > considered the correct frame. And amr.c/amr_read_packet() > also takes them as correct frames too. > > Signed-off-by: sunzhenliang > --- > libavformat/amr.c | 4 ++-- > 1 file changed,